[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-1916) param values in generator element should be trimmed during HbmBinding
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-1916?page=c...
]
Renaud Bruyeron commented on HHH-1916:
--------------------------------------
Hello,
I was wondering if this issue fell through the gaps? 3.2.1GA still has this issue. The
patch is a trivial one-liner, I can't see any reason not to apply it.
param values in generator element should be trimmed during
HbmBinding
---------------------------------------------------------------------
Key: HHH-1916
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-1916
Project: Hibernate3
Type: Bug
Components: metamodel
Versions: 3.1.3, 3.2.0.cr3
Environment: Oracle 10g, JDK 1.5.0_06, linux, hibernate 3.1.3
Reporter: Renaud Bruyeron
Attachments: patch-Branch_3_1.txt, patch-Branch_3_2.txt
When using IDEs or tools like xdoclet to generate HBM files, it is easy to get XML like
this:
<generator class="sequence">
<param
name="sequence"
>
SEQ_SOME_SEQUENCE
</param>
</generator>
However the SchemaValidator barfs on this because the HbmBinder does not trim the
sequence name.
The fix is similar to the fix for HBX-423 I believe, i.e. in HbmBinder.java in method
makeIdentifier(...), use getTextTrim() instead of getText().
In 3.1 branch, this is at line 1902. On trunk this is line 1990.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira