[Hibernate-JIRA] Created: (HHH-5543) JEE bootstrapping should only parse and validate mapping files once
9:40 p.m.
JEE bootstrapping should only parse and validate mapping files once
-------------------------------------------------------------------
Key: HHH-5543
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5543
Project: Hibernate Core
Issue Type: Improvement
Components: entity-manager
Affects Versions: 3.6.0.Beta4, 3.5.5
Reporter: Steve Ebersole
Assignee: Steve Ebersole
Fix For: 3.5.6, 3.6.0.CR1
Currently mapping files get parsed and validated twice during JEE bootstrapping:
# once in {{org.hibernate.ejb.Ejb3Configuration#addXMLEntities}} (from
{{org.hibernate.ejb.Ejb3Configuration#configure}}, from
{{org.hibernate.ejb.HibernatePersistence#createContainerEntityManagerFactory}})
# again to actually add it to the configuration from
{{org.hibernate.ejb.Ejb3Configuration#addClassesToSessionFactory}} (from
{{org.hibernate.ejb.Ejb3Configuration#configure}}, from
{{org.hibernate.ejb.HibernatePersistence#createContainerEntityManagerFactory}})
AFAICT, the first occurrence is used to identify classes for potential enhancement.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:47 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5543) JEE bootstrapping should only parse and validate mapping files once
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5543?page=c...
]
Steve Ebersole commented on HHH-5543:
-------------------------------------
If I understand correctly, after the call to {{addXMLEntities}} we no longer really need
the local {{List<String> xmlFiles}} variable for anything other than to pass it to
(eventually) {{addClassesToSessionFactory}} so that they get added to the configuration.
Seems to me the solution here is to save the parsed and validated DOM tree, once that code
is fixed up ( see HHH-5310 ), and pass that DOM tree into the config via a method that
indicates it has already been validated.
JEE bootstrapping should only parse and validate mapping files once
-------------------------------------------------------------------
Key: HHH-5543
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5543
Project: Hibernate Core
Issue Type: Improvement
Components: entity-manager
Affects Versions: 3.5.5, 3.6.0.Beta4
Reporter: Steve Ebersole
Assignee: Steve Ebersole
Fix For: 3.5.6, 3.6.0.CR1
Currently mapping files get parsed and validated twice during JEE bootstrapping:
# once in {{org.hibernate.ejb.Ejb3Configuration#addXMLEntities}} (from
{{org.hibernate.ejb.Ejb3Configuration#configure}}, from
{{org.hibernate.ejb.HibernatePersistence#createContainerEntityManagerFactory}})
# again to actually add it to the configuration from
{{org.hibernate.ejb.Ejb3Configuration#addClassesToSessionFactory}} (from
{{org.hibernate.ejb.Ejb3Configuration#configure}}, from
{{org.hibernate.ejb.HibernatePersistence#createContainerEntityManagerFactory}})
AFAICT, the first occurrence is used to identify classes for potential enhancement.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:52 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5543) JEE bootstrapping should only parse and validate mapping files once
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5543?page=c...
]
Steve Ebersole commented on HHH-5543:
-------------------------------------
Note : {{org.hibernate.cfg.AnnotationConfiguration#add(org.dom4j.Document)}} (3.5) /
{{org.hibernate.cfg.Configuration#add(XmlDocument)}} (3.6) would be the right place I
guess.
JEE bootstrapping should only parse and validate mapping files once
-------------------------------------------------------------------
Key: HHH-5543
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5543
Project: Hibernate Core
Issue Type: Improvement
Components: entity-manager
Affects Versions: 3.5.5, 3.6.0.Beta4
Reporter: Steve Ebersole
Assignee: Steve Ebersole
Fix For: 3.5.6, 3.6.0.CR1
Currently mapping files get parsed and validated twice during JEE bootstrapping:
# once in {{org.hibernate.ejb.Ejb3Configuration#addXMLEntities}} (from
{{org.hibernate.ejb.Ejb3Configuration#configure}}, from
{{org.hibernate.ejb.HibernatePersistence#createContainerEntityManagerFactory}})
# again to actually add it to the configuration from
{{org.hibernate.ejb.Ejb3Configuration#addClassesToSessionFactory}} (from
{{org.hibernate.ejb.Ejb3Configuration#configure}}, from
{{org.hibernate.ejb.HibernatePersistence#createContainerEntityManagerFactory}})
AFAICT, the first occurrence is used to identify classes for potential enhancement.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:37 a.m.
New subject: [Hibernate-JIRA] Resolved: (HHH-5543) JEE bootstrapping should only parse and validate mapping files once
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5543?page=c...
]
Steve Ebersole resolved HHH-5543.
---------------------------------
Resolution: Fixed
JEE bootstrapping should only parse and validate mapping files once
-------------------------------------------------------------------
Key: HHH-5543
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5543
Project: Hibernate Core
Issue Type: Improvement
Components: entity-manager
Affects Versions: 3.5.5, 3.6.0.Beta4
Reporter: Steve Ebersole
Assignee: Steve Ebersole
Fix For: 3.6.0.CR1, 3.5.6
Time Spent: 1.8h
Remaining Estimate: 0h
Currently mapping files get parsed and validated twice during JEE bootstrapping:
# once in {{org.hibernate.ejb.Ejb3Configuration#addXMLEntities}} (from
{{org.hibernate.ejb.Ejb3Configuration#configure}}, from
{{org.hibernate.ejb.HibernatePersistence#createContainerEntityManagerFactory}})
# again to actually add it to the configuration from
{{org.hibernate.ejb.Ejb3Configuration#addClassesToSessionFactory}} (from
{{org.hibernate.ejb.Ejb3Configuration#configure}}, from
{{org.hibernate.ejb.HibernatePersistence#createContainerEntityManagerFactory}})
AFAICT, the first occurrence is used to identify classes for potential enhancement.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:11 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5543) JEE bootstrapping should only parse and validate mapping files once
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5543?page=c...
]
Emmanuel Bernard commented on HHH-5543:
---------------------------------------
The only thing that rings a bell is that the code might use the file name for better error
handling down the road but if you ahve not encountered that in the code path, that should
be fine.
JEE bootstrapping should only parse and validate mapping files once
-------------------------------------------------------------------
Key: HHH-5543
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5543
Project: Hibernate Core
Issue Type: Improvement
Components: entity-manager
Affects Versions: 3.5.5, 3.6.0.Beta4
Reporter: Steve Ebersole
Assignee: Steve Ebersole
Fix For: 3.5.6, 3.6.0.CR1
Time Spent: 1.8h
Remaining Estimate: 0h
Currently mapping files get parsed and validated twice during JEE bootstrapping:
# once in {{org.hibernate.ejb.Ejb3Configuration#addXMLEntities}} (from
{{org.hibernate.ejb.Ejb3Configuration#configure}}, from
{{org.hibernate.ejb.HibernatePersistence#createContainerEntityManagerFactory}})
# again to actually add it to the configuration from
{{org.hibernate.ejb.Ejb3Configuration#addClassesToSessionFactory}} (from
{{org.hibernate.ejb.Ejb3Configuration#configure}}, from
{{org.hibernate.ejb.HibernatePersistence#createContainerEntityManagerFactory}})
AFAICT, the first occurrence is used to identify classes for potential enhancement.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:24 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5543) JEE bootstrapping should only parse and validate mapping files once
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5543?page=c...
]
Steve Ebersole commented on HHH-5543:
-------------------------------------
This is handled much differently on trunk. In 3.5 and prior eventually you always added a
{{Document}} to the {{Configuration}}, which of course lost the ability to report on
source file names. I improved that in 3.6 to use a custom {{XmlDocument}} instead that
wraps the {{Document}} with some other information called an {{Origin}}.
So I'll roll this change back on the 3.5 branch.
JEE bootstrapping should only parse and validate mapping files once
-------------------------------------------------------------------
Key: HHH-5543
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5543
Project: Hibernate Core
Issue Type: Improvement
Components: entity-manager
Affects Versions: 3.5.5, 3.6.0.Beta4
Reporter: Steve Ebersole
Assignee: Steve Ebersole
Fix For: 3.5.6, 3.6.0.CR1
Time Spent: 1.8h
Remaining Estimate: 0h
Currently mapping files get parsed and validated twice during JEE bootstrapping:
# once in {{org.hibernate.ejb.Ejb3Configuration#addXMLEntities}} (from
{{org.hibernate.ejb.Ejb3Configuration#configure}}, from
{{org.hibernate.ejb.HibernatePersistence#createContainerEntityManagerFactory}})
# again to actually add it to the configuration from
{{org.hibernate.ejb.Ejb3Configuration#addClassesToSessionFactory}} (from
{{org.hibernate.ejb.Ejb3Configuration#configure}}, from
{{org.hibernate.ejb.HibernatePersistence#createContainerEntityManagerFactory}})
AFAICT, the first occurrence is used to identify classes for potential enhancement.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:54 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5543) JEE bootstrapping should only parse and validate mapping files once
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5543?page=c...
]
Steve Ebersole commented on HHH-5543:
-------------------------------------
rolling this back on 3.5 branch for error reporting concern
JEE bootstrapping should only parse and validate mapping files once
-------------------------------------------------------------------
Key: HHH-5543
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5543
Project: Hibernate Core
Issue Type: Improvement
Components: entity-manager
Affects Versions: 3.5.5, 3.6.0.Beta4
Reporter: Steve Ebersole
Assignee: Steve Ebersole
Fix For: 3.5.6, 3.6.0.CR1
Time Spent: 1.8h
Remaining Estimate: 0h
Currently mapping files get parsed and validated twice during JEE bootstrapping:
# once in {{org.hibernate.ejb.Ejb3Configuration#addXMLEntities}} (from
{{org.hibernate.ejb.Ejb3Configuration#configure}}, from
{{org.hibernate.ejb.HibernatePersistence#createContainerEntityManagerFactory}})
# again to actually add it to the configuration from
{{org.hibernate.ejb.Ejb3Configuration#addClassesToSessionFactory}} (from
{{org.hibernate.ejb.Ejb3Configuration#configure}}, from
{{org.hibernate.ejb.HibernatePersistence#createContainerEntityManagerFactory}})
AFAICT, the first occurrence is used to identify classes for potential enhancement.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:54 p.m.
New subject: [Hibernate-JIRA] Reopened: (HHH-5543) JEE bootstrapping should only parse and validate mapping files once
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5543?page=c...
]
Steve Ebersole reopened HHH-5543:
---------------------------------
JEE bootstrapping should only parse and validate mapping files once
-------------------------------------------------------------------
Key: HHH-5543
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5543
Project: Hibernate Core
Issue Type: Improvement
Components: entity-manager
Affects Versions: 3.5.5, 3.6.0.Beta4
Reporter: Steve Ebersole
Assignee: Steve Ebersole
Fix For: 3.5.6, 3.6.0.CR1
Time Spent: 1.8h
Remaining Estimate: 0h
Currently mapping files get parsed and validated twice during JEE bootstrapping:
# once in {{org.hibernate.ejb.Ejb3Configuration#addXMLEntities}} (from
{{org.hibernate.ejb.Ejb3Configuration#configure}}, from
{{org.hibernate.ejb.HibernatePersistence#createContainerEntityManagerFactory}})
# again to actually add it to the configuration from
{{org.hibernate.ejb.Ejb3Configuration#addClassesToSessionFactory}} (from
{{org.hibernate.ejb.Ejb3Configuration#configure}}, from
{{org.hibernate.ejb.HibernatePersistence#createContainerEntityManagerFactory}})
AFAICT, the first occurrence is used to identify classes for potential enhancement.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:19 p.m.
New subject: [Hibernate-JIRA] Closed: (HHH-5543) JEE bootstrapping should only parse and validate mapping files once
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5543?page=c...
]
Steve Ebersole closed HHH-5543.
-------------------------------
Resolution: Fixed
Fix Version/s: (was: 3.5.6)
JEE bootstrapping should only parse and validate mapping files once
-------------------------------------------------------------------
Key: HHH-5543
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5543
Project: Hibernate Core
Issue Type: Improvement
Components: entity-manager
Affects Versions: 3.5.5, 3.6.0.Beta4
Reporter: Steve Ebersole
Assignee: Steve Ebersole
Fix For: 3.6.0.CR1
Time Spent: 2h 4m
Remaining Estimate: 0h
Currently mapping files get parsed and validated twice during JEE bootstrapping:
# once in {{org.hibernate.ejb.Ejb3Configuration#addXMLEntities}} (from
{{org.hibernate.ejb.Ejb3Configuration#configure}}, from
{{org.hibernate.ejb.HibernatePersistence#createContainerEntityManagerFactory}})
# again to actually add it to the configuration from
{{org.hibernate.ejb.Ejb3Configuration#addClassesToSessionFactory}} (from
{{org.hibernate.ejb.Ejb3Configuration#configure}}, from
{{org.hibernate.ejb.HibernatePersistence#createContainerEntityManagerFactory}})
AFAICT, the first occurrence is used to identify classes for potential enhancement.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4986
days inactive
4987
days old
hibernate-issues@lists.jboss.org
8 comments
2 participants
participants (2)
-
Emmanuel Bernard (JIRA) -
Steve Ebersole (JIRA)