[Hibernate-JIRA] Created: (HHH-3220) Patch to prevent "org.hibernate.AssertionFailure: possible non-threadsafe access to the session" error caused by stateless sessions
4:54 p.m.
Patch to prevent "org.hibernate.AssertionFailure: possible non-threadsafe access to
the session" error caused by stateless sessions
-----------------------------------------------------------------------------------------------------------------------------------
Key: HHH-3220
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3220
Project: Hibernate3
Issue Type: Patch
Components: core
Affects Versions: 3.2.6
Environment: Hibernate 3.2.6, Apache Derby on Mac OSX & PC
Reporter: Dan Bisalputra
Priority: Minor
When performing a query in a stateless session, the query loads objects in a two-phase
process in which a temporary persistence context is populated with empty objects in the
first phase, then the objects' member data are read from the database in the second
phase. If one of the objects contains an association or a collection, it performs a
recursive call to the session's get() method. The get() method clears the temporary
persistence context, so if the parent object contains any other associations to be read in
the second phase, Hibernate throws an assertion because they are not found in the
persistence context.
This patch solves the problem by only clearing the persistence context when the recursion
ends. It passes all the unit tests for our application, but I have not tested it with any
of the Hibernate unit tests.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:29 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3220) Patch to prevent "org.hibernate.AssertionFailure: possible non-threadsafe access to the session" error caused by stateless sessions
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3220?page=c...
]
Gail Badner commented on HHH-3220:
----------------------------------
Hi Dan, I don't see a patch attached to this issue. Could you attach it when you get a
chance?
Also, please attach a runnable test case (Java + mapping) to reproduce this issue.
Patch to prevent "org.hibernate.AssertionFailure: possible
non-threadsafe access to the session" error caused by stateless sessions
-----------------------------------------------------------------------------------------------------------------------------------
Key: HHH-3220
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3220
Project: Hibernate3
Issue Type: Patch
Components: core
Affects Versions: 3.2.6
Environment: Hibernate 3.2.6, Apache Derby on Mac OSX & PC
Reporter: Dan Bisalputra
Priority: Minor
When performing a query in a stateless session, the query loads objects in a two-phase
process in which a temporary persistence context is populated with empty objects in the
first phase, then the objects' member data are read from the database in the second
phase. If one of the objects contains an association or a collection, it performs a
recursive call to the session's get() method. The get() method clears the temporary
persistence context, so if the parent object contains any other associations to be read in
the second phase, Hibernate throws an assertion because they are not found in the
persistence context.
This patch solves the problem by only clearing the persistence context when the recursion
ends. It passes all the unit tests for our application, but I have not tested it with any
of the Hibernate unit tests.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:10 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-3220) Patch to prevent "org.hibernate.AssertionFailure: possible non-threadsafe access to the session" error caused by stateless sessions
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3220?page=c...
]
Dan Bisalputra updated HHH-3220:
--------------------------------
Attachment: StatelessSession-patch
Patch to prevent "org.hibernate.AssertionFailure: possible
non-threadsafe access to the session" error caused by stateless sessions
-----------------------------------------------------------------------------------------------------------------------------------
Key: HHH-3220
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3220
Project: Hibernate3
Issue Type: Patch
Components: core
Affects Versions: 3.2.6
Environment: Hibernate 3.2.6, Apache Derby on Mac OSX & PC
Reporter: Dan Bisalputra
Priority: Minor
Attachments: StatelessSession-patch
When performing a query in a stateless session, the query loads objects in a two-phase
process in which a temporary persistence context is populated with empty objects in the
first phase, then the objects' member data are read from the database in the second
phase. If one of the objects contains an association or a collection, it performs a
recursive call to the session's get() method. The get() method clears the temporary
persistence context, so if the parent object contains any other associations to be read in
the second phase, Hibernate throws an assertion because they are not found in the
persistence context.
This patch solves the problem by only clearing the persistence context when the recursion
ends. It passes all the unit tests for our application, but I have not tested it with any
of the Hibernate unit tests.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:22 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3220) Patch to prevent "org.hibernate.AssertionFailure: possible non-threadsafe access to the session" error caused by stateless sessions
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3220?page=c...
]
Dan Bisalputra commented on HHH-3220:
-------------------------------------
Okay, I think the patch got attached this time. As for a test case, it will probably take
me about half a day to write a minimal test that doesn't use our framework or domain
objects, so I can't promise anything until the end of our current iteration (April
21).
Patch to prevent "org.hibernate.AssertionFailure: possible
non-threadsafe access to the session" error caused by stateless sessions
-----------------------------------------------------------------------------------------------------------------------------------
Key: HHH-3220
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3220
Project: Hibernate3
Issue Type: Patch
Components: core
Affects Versions: 3.2.6
Environment: Hibernate 3.2.6, Apache Derby on Mac OSX & PC
Reporter: Dan Bisalputra
Priority: Minor
Attachments: StatelessSession-patch
When performing a query in a stateless session, the query loads objects in a two-phase
process in which a temporary persistence context is populated with empty objects in the
first phase, then the objects' member data are read from the database in the second
phase. If one of the objects contains an association or a collection, it performs a
recursive call to the session's get() method. The get() method clears the temporary
persistence context, so if the parent object contains any other associations to be read in
the second phase, Hibernate throws an assertion because they are not found in the
persistence context.
This patch solves the problem by only clearing the persistence context when the recursion
ends. It passes all the unit tests for our application, but I have not tested it with any
of the Hibernate unit tests.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:37 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3220) Patch to prevent "org.hibernate.AssertionFailure: possible non-threadsafe access to the session" error caused by stateless sessions
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3220?page=c...
]
Paul Andrews commented on HHH-3220:
-----------------------------------
Is there an ETA for including this fix?
Patch to prevent "org.hibernate.AssertionFailure: possible
non-threadsafe access to the session" error caused by stateless sessions
-----------------------------------------------------------------------------------------------------------------------------------
Key: HHH-3220
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3220
Project: Hibernate Core
Issue Type: Patch
Components: core
Affects Versions: 3.2.6
Environment: Hibernate 3.2.6, Apache Derby on Mac OSX & PC
Reporter: Dan Bisalputra
Priority: Minor
Attachments: StatelessSession-patch
When performing a query in a stateless session, the query loads objects in a two-phase
process in which a temporary persistence context is populated with empty objects in the
first phase, then the objects' member data are read from the database in the second
phase. If one of the objects contains an association or a collection, it performs a
recursive call to the session's get() method. The get() method clears the temporary
persistence context, so if the parent object contains any other associations to be read in
the second phase, Hibernate throws an assertion because they are not found in the
persistence context.
This patch solves the problem by only clearing the persistence context when the recursion
ends. It passes all the unit tests for our application, but I have not tested it with any
of the Hibernate unit tests.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:22 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3220) Patch to prevent "org.hibernate.AssertionFailure: possible non-threadsafe access to the session" error caused by stateless sessions
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3220?page=c...
]
Dan Bisalputra commented on HHH-3220:
-------------------------------------
I'm sorry I didn't get back to you earlier, but I spent a day or so trying to
create a simple test case, but was unable to create one without including a large chunk of
my domain model. Since then, I've implemented a different approach to solving my
problem which does not require a Stateless Session. Therefore, I don't see much value
in keeping this issue open unless there are others who have encountered the same problem.
Patch to prevent "org.hibernate.AssertionFailure: possible
non-threadsafe access to the session" error caused by stateless sessions
-----------------------------------------------------------------------------------------------------------------------------------
Key: HHH-3220
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3220
Project: Hibernate Core
Issue Type: Patch
Components: core
Affects Versions: 3.2.6
Environment: Hibernate 3.2.6, Apache Derby on Mac OSX & PC
Reporter: Dan Bisalputra
Priority: Minor
Attachments: StatelessSession-patch
When performing a query in a stateless session, the query loads objects in a two-phase
process in which a temporary persistence context is populated with empty objects in the
first phase, then the objects' member data are read from the database in the second
phase. If one of the objects contains an association or a collection, it performs a
recursive call to the session's get() method. The get() method clears the temporary
persistence context, so if the parent object contains any other associations to be read in
the second phase, Hibernate throws an assertion because they are not found in the
persistence context.
This patch solves the problem by only clearing the persistence context when the recursion
ends. It passes all the unit tests for our application, but I have not tested it with any
of the Hibernate unit tests.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:19 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3220) Patch to prevent "org.hibernate.AssertionFailure: possible non-threadsafe access to the session" error caused by stateless sessions
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3220?page=c...
]
Alex Basile commented on HHH-3220:
----------------------------------
Hi Dan, can you please share your alternate solution?
Patch to prevent "org.hibernate.AssertionFailure: possible
non-threadsafe access to the session" error caused by stateless sessions
-----------------------------------------------------------------------------------------------------------------------------------
Key: HHH-3220
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3220
Project: Hibernate Core
Issue Type: Patch
Components: core
Affects Versions: 3.2.6
Environment: Hibernate 3.2.6, Apache Derby on Mac OSX & PC
Reporter: Dan Bisalputra
Priority: Minor
Attachments: StatelessSession-patch
When performing a query in a stateless session, the query loads objects in a two-phase
process in which a temporary persistence context is populated with empty objects in the
first phase, then the objects' member data are read from the database in the second
phase. If one of the objects contains an association or a collection, it performs a
recursive call to the session's get() method. The get() method clears the temporary
persistence context, so if the parent object contains any other associations to be read in
the second phase, Hibernate throws an assertion because they are not found in the
persistence context.
This patch solves the problem by only clearing the persistence context when the recursion
ends. It passes all the unit tests for our application, but I have not tested it with any
of the Hibernate unit tests.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:16 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3220) Patch to prevent "org.hibernate.AssertionFailure: possible non-threadsafe access to the session" error caused by stateless sessions
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3220?page=c...
]
Dan Bisalputra commented on HHH-3220:
-------------------------------------
I was originally trying to implement a history/undo function in which a Hibernate
interceptor would save the previous state of dirty objects so that any change made to the
database could be undone. Stateless sessions were handy for saving the previous state of
a given object without triggering cascaded saves of its associations. I wrote the patch
because I was getting the assertion error even though I was accessing the database using a
single thread.
I abandoned this approach for two reasons: 1) it was too slow because every transaction
effectively had twice as much work to do, and 2) there was only a single history trail,
which meant that it might be necessary to undo a more recent change in a different part of
the database before undoing the desired change.
The solution I finally used was to restrict undoability to a small list of objects whose
editing operations were tricky to undo by hand. Each undoable object is associated with a
persistent list of history entries (designed along the lines of the Swing UndoableEdit
class). This approach does not give a comprehensive history like the first approach, but
it is faster and allows undos to occur without affecting unrelated objects.
So in the end, I did not do anything clever with stateless sessions, I just avoided the
problem by re-scoping my design to use Hibernate in a less exotic way.
Patch to prevent "org.hibernate.AssertionFailure: possible
non-threadsafe access to the session" error caused by stateless sessions
-----------------------------------------------------------------------------------------------------------------------------------
Key: HHH-3220
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3220
Project: Hibernate Core
Issue Type: Patch
Components: core
Affects Versions: 3.2.6
Environment: Hibernate 3.2.6, Apache Derby on Mac OSX & PC
Reporter: Dan Bisalputra
Priority: Minor
Attachments: StatelessSession-patch
When performing a query in a stateless session, the query loads objects in a two-phase
process in which a temporary persistence context is populated with empty objects in the
first phase, then the objects' member data are read from the database in the second
phase. If one of the objects contains an association or a collection, it performs a
recursive call to the session's get() method. The get() method clears the temporary
persistence context, so if the parent object contains any other associations to be read in
the second phase, Hibernate throws an assertion because they are not found in the
persistence context.
This patch solves the problem by only clearing the persistence context when the recursion
ends. It passes all the unit tests for our application, but I have not tested it with any
of the Hibernate unit tests.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:55 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3220) Patch to prevent "org.hibernate.AssertionFailure: possible non-threadsafe access to the session" error caused by stateless sessions
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3220?page=c...
]
Alex Basile commented on HHH-3220:
----------------------------------
Thanks for the insight. We've realized that we are working w/ a more smaller data set
than expected and we open a session (and thus session cache) for each query. So we can do
w/o Stateless Session for now. I hope they fix it soon any way.
Patch to prevent "org.hibernate.AssertionFailure: possible
non-threadsafe access to the session" error caused by stateless sessions
-----------------------------------------------------------------------------------------------------------------------------------
Key: HHH-3220
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3220
Project: Hibernate Core
Issue Type: Patch
Components: core
Affects Versions: 3.2.6
Environment: Hibernate 3.2.6, Apache Derby on Mac OSX & PC
Reporter: Dan Bisalputra
Priority: Minor
Attachments: StatelessSession-patch
When performing a query in a stateless session, the query loads objects in a two-phase
process in which a temporary persistence context is populated with empty objects in the
first phase, then the objects' member data are read from the database in the second
phase. If one of the objects contains an association or a collection, it performs a
recursive call to the session's get() method. The get() method clears the temporary
persistence context, so if the parent object contains any other associations to be read in
the second phase, Hibernate throws an assertion because they are not found in the
persistence context.
This patch solves the problem by only clearing the persistence context when the recursion
ends. It passes all the unit tests for our application, but I have not tested it with any
of the Hibernate unit tests.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:48 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3220) Patch to prevent "org.hibernate.AssertionFailure: possible non-threadsafe access to the session" error caused by stateless sessions
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3220?page=c...
]
Xavier Poinsard commented on HHH-3220:
--------------------------------------
For reference here are two threads that are referencing the same problem :
http://forum.hibernate.org/viewtopic.php?t=957223
http://forum.hibernate.org/viewtopic.php?t=953857
Patch to prevent "org.hibernate.AssertionFailure: possible
non-threadsafe access to the session" error caused by stateless sessions
-----------------------------------------------------------------------------------------------------------------------------------
Key: HHH-3220
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3220
Project: Hibernate Core
Issue Type: Patch
Components: core
Affects Versions: 3.2.6
Environment: Hibernate 3.2.6, Apache Derby on Mac OSX & PC
Reporter: Dan Bisalputra
Priority: Minor
Attachments: StatelessSession-patch
When performing a query in a stateless session, the query loads objects in a two-phase
process in which a temporary persistence context is populated with empty objects in the
first phase, then the objects' member data are read from the database in the second
phase. If one of the objects contains an association or a collection, it performs a
recursive call to the session's get() method. The get() method clears the temporary
persistence context, so if the parent object contains any other associations to be read in
the second phase, Hibernate throws an assertion because they are not found in the
persistence context.
This patch solves the problem by only clearing the persistence context when the recursion
ends. It passes all the unit tests for our application, but I have not tested it with any
of the Hibernate unit tests.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:20 a.m.
New subject: [Hibernate-JIRA] Updated: (HHH-3220) Patch to prevent "org.hibernate.AssertionFailure: possible non-threadsafe access to the session" error caused by stateless sessions
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3220?page=c...
]
Chris Wilson updated HHH-3220:
------------------------------
Attachment: HibernateStatelessSessionCriteriaAssertionFailureTest.java
This is a test for HHH-3220, which currently prevents us from using StatelessSession to
retrieve large numbers of objects for synchronization without loading them into the
Hibernate cache, which would eventually clog the cache and exhaust the available memory.
The problem is more-or-less as described in the ticket, but it's difficult to
reproduce because it only occurs when the SQL generated for the (criteria or HQL) query
omits a join to an associated table, because that join exceeds the maximum query depth.
Therefore it normally requires a deep structure of classes to reproduce. This test forces
the maximum query depth down to 1, to make it easier to reproduce.
TwoPhaseLoad.initializeEntity tries to resolve the identifier of the associated object of
a ManyToOneType association:
{code}
Type[] types = persister.getPropertyTypes();
for ( int i = 0; i < hydratedState.length; i++ ) {
final Object value = hydratedState[i];
if ( value!=LazyPropertyInitializer.UNFETCHED_PROPERTY &&
value!=BackrefPropertyAccessor.UNKNOWN ) {
hydratedState[i] = types[i].resolve( value, session, entity );
}
}
{code}
ManyToOneType's resolve() method calls resolveIdentifier(), which calls the
Session's internalLoad() method.
The identified object does not exist in the cache, because it was not loaded because its
depth exceeded the maximum join depth. Therefore StatelessSessionImpl tries to load it by
calling get():
{code}
EntityPersister persister = getFactory().getEntityPersister( entityName );
// first, try to load it from the temp PC associated to this SS
Object loaded = temporaryPersistenceContext.getEntity( new EntityKey( id, persister,
getEntityMode() ) );
if ( loaded != null ) {
// we found it in the temp PC. Should indicate we are in the midst of processing a
result set
// containing eager fetches via join fetch
return loaded;
}
if ( !eager && persister.hasProxy() ) {
// if the metadata allowed proxy creation and caller did not request forceful eager
loading,
// generate a proxy
return persister.createProxy( id, this );
}
// otherwise immediately materialize it
return get( entityName, id );
{code}
Which clears the entire persistence context:
{code}
public Object get(String entityName, Serializable id, LockMode lockMode) {
errorIfClosed();
Object result = getFactory().getEntityPersister(entityName)
.load(id, null, lockMode, this);
temporaryPersistenceContext.clear();
return result;
}
{code}
Which means that the next attempt to initialize a hydrated object does not find the
(parent) object in the persistence cache:
{code}
for ( int i = 0; i < hydratedObjectsSize; i++ ) {
TwoPhaseLoad.initializeEntity( hydratedObjects.get(i), readOnly, session, pre, post );
}
{code}
which results in the assertion failure:
{code}
org.hibernate.AssertionFailure: possible non-threadsafe access to the session
at org.hibernate.engine.TwoPhaseLoad.initializeEntity(TwoPhaseLoad.java:123)
at org.hibernate.loader.Loader.initializeEntitiesAndCollections(Loader.java:877)
at org.hibernate.loader.Loader.doQuery(Loader.java:752)
at org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:259)
at org.hibernate.loader.Loader.doList(Loader.java:2232)
at org.hibernate.loader.Loader.listIgnoreQueryCache(Loader.java:2129)
at org.hibernate.loader.Loader.list(Loader.java:2124)
at org.hibernate.loader.criteria.CriteriaLoader.list(CriteriaLoader.java:118)
at org.hibernate.impl.StatelessSessionImpl.list(StatelessSessionImpl.java:565)
at org.hibernate.impl.CriteriaImpl.list(CriteriaImpl.java:306)
at
org.wfp.rita.test.hibernate.HibernateStatelessSessionCriteriaAssertionFailureTest.assertList(HibernateStatelessSessionCriteriaAssertionFailureTest.java:721)
at
org.wfp.rita.test.hibernate.HibernateStatelessSessionCriteriaAssertionFailureTest.testFailing(HibernateStatelessSessionCriteriaAssertionFailureTest.java:743)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.wfp.rita.test.base.HibernateTestBase.runTestMethod(HibernateTestBase.java:204)
at org.wfp.rita.test.base.HibernateTestBase.runTest(HibernateTestBase.java:117)
at junit.framework.TestCase.runBare(TestCase.java:130)
at junit.framework.TestResult$1.protect(TestResult.java:106)
at junit.framework.TestResult.runProtected(TestResult.java:124)
at junit.framework.TestResult.run(TestResult.java:109)
at junit.framework.TestCase.run(TestCase.java:120)
at junit.framework.TestSuite.runTest(TestSuite.java:230)
at junit.framework.TestSuite.run(TestSuite.java:225)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:478)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:344)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:196)
{code}
One workaround is to increase the maximum fetch depth until the error no longer occurs, by
setting the hibernate.max_fetch_depth property to a large value. However, this may have
side-effects if you have badly-behaved queries. So I recommend modifying
StatelessSessionImpl.internalLoad(), so that rather than call the public get() method
which has the side-effect of clearing the cache, it simply retrieves the object directly
without clearing the cache:
{code}
// otherwise immediately materialize it
return getFactory().getEntityPersister(entityName).load(id,
null, LockMode.NONE, this);
{code}
Anyone who needs a solution to this problem and can't run a patched version of
Hibernate can wrap the SessionWrapper class from the attached test case around their
StatelessSession to easily apply this workaround.
Patch to prevent "org.hibernate.AssertionFailure: possible
non-threadsafe access to the session" error caused by stateless sessions
-----------------------------------------------------------------------------------------------------------------------------------
Key: HHH-3220
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3220
Project: Hibernate Core
Issue Type: Patch
Components: core
Affects Versions: 3.2.6
Environment: Hibernate 3.2.6, Apache Derby on Mac OSX & PC
Reporter: Dan Bisalputra
Priority: Minor
Attachments: HibernateStatelessSessionCriteriaAssertionFailureTest.java,
StatelessSession-patch
When performing a query in a stateless session, the query loads objects in a two-phase
process in which a temporary persistence context is populated with empty objects in the
first phase, then the objects' member data are read from the database in the second
phase. If one of the objects contains an association or a collection, it performs a
recursive call to the session's get() method. The get() method clears the temporary
persistence context, so if the parent object contains any other associations to be read in
the second phase, Hibernate throws an assertion because they are not found in the
persistence context.
This patch solves the problem by only clearing the persistence context when the recursion
ends. It passes all the unit tests for our application, but I have not tested it with any
of the Hibernate unit tests.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:34 a.m.
New subject: [Hibernate-JIRA] Updated: (HHH-3220) Patch to prevent "org.hibernate.AssertionFailure: possible non-threadsafe access to the session" error caused by stateless sessions
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3220?page=c...
]
Chris Wilson updated HHH-3220:
------------------------------
Attachment: HibernateStatelessSessionCriteriaAssertionFailureTest.java
New version of the test without external dependencies.
Patch to prevent "org.hibernate.AssertionFailure: possible
non-threadsafe access to the session" error caused by stateless sessions
-----------------------------------------------------------------------------------------------------------------------------------
Key: HHH-3220
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3220
Project: Hibernate Core
Issue Type: Patch
Components: core
Affects Versions: 3.2.6
Environment: Hibernate 3.2.6, Apache Derby on Mac OSX & PC
Reporter: Dan Bisalputra
Priority: Minor
Attachments: HibernateStatelessSessionCriteriaAssertionFailureTest.java,
HibernateStatelessSessionCriteriaAssertionFailureTest.java, StatelessSession-patch
When performing a query in a stateless session, the query loads objects in a two-phase
process in which a temporary persistence context is populated with empty objects in the
first phase, then the objects' member data are read from the database in the second
phase. If one of the objects contains an association or a collection, it performs a
recursive call to the session's get() method. The get() method clears the temporary
persistence context, so if the parent object contains any other associations to be read in
the second phase, Hibernate throws an assertion because they are not found in the
persistence context.
This patch solves the problem by only clearing the persistence context when the recursion
ends. It passes all the unit tests for our application, but I have not tested it with any
of the Hibernate unit tests.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:27 a.m.
New subject: [Hibernate-JIRA] Assigned: (HHH-3220) Patch to prevent "org.hibernate.AssertionFailure: possible non-threadsafe access to the session" error caused by stateless sessions
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3220?page=c...
]
Strong Liu reassigned HHH-3220:
-------------------------------
Assignee: Strong Liu
Patch to prevent "org.hibernate.AssertionFailure: possible
non-threadsafe access to the session" error caused by stateless sessions
-----------------------------------------------------------------------------------------------------------------------------------
Key: HHH-3220
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3220
Project: Hibernate Core
Issue Type: Patch
Components: core
Affects Versions: 3.2.6
Environment: Hibernate 3.2.6, Apache Derby on Mac OSX & PC
Reporter: Dan Bisalputra
Assignee: Strong Liu
Priority: Minor
Attachments: HibernateStatelessSessionCriteriaAssertionFailureTest.java,
HibernateStatelessSessionCriteriaAssertionFailureTest.java, StatelessSession-patch
When performing a query in a stateless session, the query loads objects in a two-phase
process in which a temporary persistence context is populated with empty objects in the
first phase, then the objects' member data are read from the database in the second
phase. If one of the objects contains an association or a collection, it performs a
recursive call to the session's get() method. The get() method clears the temporary
persistence context, so if the parent object contains any other associations to be read in
the second phase, Hibernate throws an assertion because they are not found in the
persistence context.
This patch solves the problem by only clearing the persistence context when the recursion
ends. It passes all the unit tests for our application, but I have not tested it with any
of the Hibernate unit tests.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:19 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3220) Patch to prevent "org.hibernate.AssertionFailure: possible non-threadsafe access to the session" error caused by stateless sessions
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3220?page=c...
]
Strong Liu commented on HHH-3220:
---------------------------------
https://jira.jboss.org/jira/browse/JBPAPP-3737
Patch to prevent "org.hibernate.AssertionFailure: possible
non-threadsafe access to the session" error caused by stateless sessions
-----------------------------------------------------------------------------------------------------------------------------------
Key: HHH-3220
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3220
Project: Hibernate Core
Issue Type: Patch
Components: core
Affects Versions: 3.2.6
Environment: Hibernate 3.2.6, Apache Derby on Mac OSX & PC
Reporter: Dan Bisalputra
Assignee: Strong Liu
Priority: Minor
Attachments: HibernateStatelessSessionCriteriaAssertionFailureTest.java,
HibernateStatelessSessionCriteriaAssertionFailureTest.java, StatelessSession-patch
When performing a query in a stateless session, the query loads objects in a two-phase
process in which a temporary persistence context is populated with empty objects in the
first phase, then the objects' member data are read from the database in the second
phase. If one of the objects contains an association or a collection, it performs a
recursive call to the session's get() method. The get() method clears the temporary
persistence context, so if the parent object contains any other associations to be read in
the second phase, Hibernate throws an assertion because they are not found in the
persistence context.
This patch solves the problem by only clearing the persistence context when the recursion
ends. It passes all the unit tests for our application, but I have not tested it with any
of the Hibernate unit tests.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:38 a.m.
New subject: [Hibernate-JIRA] Resolved: (HHH-3220) Patch to prevent "org.hibernate.AssertionFailure: possible non-threadsafe access to the session" error caused by stateless sessions
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3220?page=c...
]
Strong Liu resolved HHH-3220.
-----------------------------
Resolution: Fixed
Fix Version/s: 3.6
3.5.x
Patch to prevent "org.hibernate.AssertionFailure: possible
non-threadsafe access to the session" error caused by stateless sessions
-----------------------------------------------------------------------------------------------------------------------------------
Key: HHH-3220
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3220
Project: Hibernate Core
Issue Type: Patch
Components: core
Affects Versions: 3.2.6
Environment: Hibernate 3.2.6, Apache Derby on Mac OSX & PC
Reporter: Dan Bisalputra
Assignee: Strong Liu
Priority: Minor
Fix For: 3.5.x, 3.6
Attachments: HibernateStatelessSessionCriteriaAssertionFailureTest.java,
HibernateStatelessSessionCriteriaAssertionFailureTest.java, StatelessSession-patch
When performing a query in a stateless session, the query loads objects in a two-phase
process in which a temporary persistence context is populated with empty objects in the
first phase, then the objects' member data are read from the database in the second
phase. If one of the objects contains an association or a collection, it performs a
recursive call to the session's get() method. The get() method clears the temporary
persistence context, so if the parent object contains any other associations to be read in
the second phase, Hibernate throws an assertion because they are not found in the
persistence context.
This patch solves the problem by only clearing the persistence context when the recursion
ends. It passes all the unit tests for our application, but I have not tested it with any
of the Hibernate unit tests.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:09 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3220) Patch to prevent "org.hibernate.AssertionFailure: possible non-threadsafe access to the session" error caused by stateless sessions
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3220?page=c...
]
Paul Smith commented on HHH-3220:
---------------------------------
I know this is marked as closed in 3.6.0+ however I'm hitting this _exact_ same
problem with 3.6.8.Final with a InheritanceType.TABLE_PER_CLASS setup, _only_ when I issue
a:
{noformat}
Criteria criteria = statelessSession.createCriteria(com.aconex.tasks.domain.Task);
...
criteria.scroll(ScrollMode.SCROLL_INSENSITIVE);
{noformat}
Which scrolls through the entire result-set, the above fails with the
"non-threadsafe" error. However issuing an effectively-the-same-query using
the createQuery method with:
{noformat}
Query query = statelessSession.createQuery("from
com.aconex.tasks.domain.Task");
....
query.scroll(ScrollMode.SCROLL_INSENSITIVE);
{noformat}
actually works fine.
We originally had this Query-based execution failing with the non-threadsafe error under
hibernate-core 3.3.0.GA, upgraded to 3.6.8.Final to fix the problem (as is documented
here), and then have needed to switch to using Criteria for more flexible partitioning of
the query (parallelise the row retrievals) now to find us back with the same problem.
Switching to/from Criteria-based scrolling through the entire tablespace fails/succeeds
respectively.
Is there anyone out there with advice? I'm a bit confused as to whether the
SessionWrapper class will help or not, I don't understand why a Criteria-based
"select *" is executing any different than an explicit "select *"
(which is what 'from <entity>' with no other criteria is right?)
Any help really appreciated, I have 130 million records I need to scroll through that I
don't really want to use a stateful session.
Patch to prevent "org.hibernate.AssertionFailure: possible
non-threadsafe access to the session" error caused by stateless sessions
-----------------------------------------------------------------------------------------------------------------------------------
Key: HHH-3220
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3220
Project: Hibernate Core
Issue Type: Patch
Components: core
Affects Versions: 3.2.6
Environment: Hibernate 3.2.6, Apache Derby on Mac OSX & PC
Reporter: Dan Bisalputra
Assignee: Strong Liu
Priority: Minor
Fix For: 3.5.3, 3.6.0.Beta1
Attachments: HibernateStatelessSessionCriteriaAssertionFailureTest.java,
HibernateStatelessSessionCriteriaAssertionFailureTest.java, StatelessSession-patch
When performing a query in a stateless session, the query loads objects in a two-phase
process in which a temporary persistence context is populated with empty objects in the
first phase, then the objects' member data are read from the database in the second
phase. If one of the objects contains an association or a collection, it performs a
recursive call to the session's get() method. The get() method clears the temporary
persistence context, so if the parent object contains any other associations to be read in
the second phase, Hibernate throws an assertion because they are not found in the
persistence context.
This patch solves the problem by only clearing the persistence context when the recursion
ends. It passes all the unit tests for our application, but I have not tested it with any
of the Hibernate unit tests.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:21 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3220) Patch to prevent "org.hibernate.AssertionFailure: possible non-threadsafe access to the session" error caused by stateless sessions
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3220?page=c...
]
Strong Liu commented on HHH-3220:
---------------------------------
please open a new jira, and link it with this one, thanks
Patch to prevent "org.hibernate.AssertionFailure: possible
non-threadsafe access to the session" error caused by stateless sessions
-----------------------------------------------------------------------------------------------------------------------------------
Key: HHH-3220
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3220
Project: Hibernate Core
Issue Type: Patch
Components: core
Affects Versions: 3.2.6
Environment: Hibernate 3.2.6, Apache Derby on Mac OSX & PC
Reporter: Dan Bisalputra
Assignee: Strong Liu
Priority: Minor
Fix For: 3.5.3, 3.6.0.Beta1
Attachments: HibernateStatelessSessionCriteriaAssertionFailureTest.java,
HibernateStatelessSessionCriteriaAssertionFailureTest.java, StatelessSession-patch
When performing a query in a stateless session, the query loads objects in a two-phase
process in which a temporary persistence context is populated with empty objects in the
first phase, then the objects' member data are read from the database in the second
phase. If one of the objects contains an association or a collection, it performs a
recursive call to the session's get() method. The get() method clears the temporary
persistence context, so if the parent object contains any other associations to be read in
the second phase, Hibernate throws an assertion because they are not found in the
persistence context.
This patch solves the problem by only clearing the persistence context when the recursion
ends. It passes all the unit tests for our application, but I have not tested it with any
of the Hibernate unit tests.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:43 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3220) Patch to prevent "org.hibernate.AssertionFailure: possible non-threadsafe access to the session" error caused by stateless sessions
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3220?page=c...
]
Paul Smith commented on HHH-3220:
---------------------------------
ok done, HHH-6857 created, for anyone else who comes here looking for the same solution.
thanks all.
Patch to prevent "org.hibernate.AssertionFailure: possible
non-threadsafe access to the session" error caused by stateless sessions
-----------------------------------------------------------------------------------------------------------------------------------
Key: HHH-3220
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3220
Project: Hibernate Core
Issue Type: Patch
Components: core
Affects Versions: 3.2.6
Environment: Hibernate 3.2.6, Apache Derby on Mac OSX & PC
Reporter: Dan Bisalputra
Assignee: Strong Liu
Priority: Minor
Fix For: 3.5.3, 3.6.0.Beta1
Attachments: HibernateStatelessSessionCriteriaAssertionFailureTest.java,
HibernateStatelessSessionCriteriaAssertionFailureTest.java, StatelessSession-patch
When performing a query in a stateless session, the query loads objects in a two-phase
process in which a temporary persistence context is populated with empty objects in the
first phase, then the objects' member data are read from the database in the second
phase. If one of the objects contains an association or a collection, it performs a
recursive call to the session's get() method. The get() method clears the temporary
persistence context, so if the parent object contains any other associations to be read in
the second phase, Hibernate throws an assertion because they are not found in the
persistence context.
This patch solves the problem by only clearing the persistence context when the recursion
ends. It passes all the unit tests for our application, but I have not tested it with any
of the Hibernate unit tests.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4558
days inactive
5891
days old
hibernate-issues@lists.jboss.org
17 comments
8 participants
participants (8)
-
Alex Basile (JIRA) -
Chris Wilson (JIRA)
-
Dan Bisalputra (JIRA)
-
Gail Badner (JIRA)
-
Paul Andrews (JIRA)
-
Paul Smith (JIRA)
-
Strong Liu (JIRA)
-
Xavier Poinsard (JIRA)