[ http://opensource.atlassian.com/projects/hibernate/browse/ANN-572?page=co... ] Emmanuel Bernard commented on ANN-572: -------------------------------------- It's basically implementing what is available in hbm.xml files. ie port the HbmBinder code back to AnnotationBinder -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/ANN-572?page=co... ] Emmanuel Bernard commented on ANN-572: -------------------------------------- The XML entity mode to AnnotationBinder, yes. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/ANN-572?page=co... ] Emmanuel Bernard commented on ANN-572: -------------------------------------- I tend to agree Peter, but nobody (in or out of) the hibernate team had the ability/willingness to spend time working on it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/ANN-572?page=co... ] Stephane Epardaud commented on ANN-572: --------------------------------------- I've made a patch to allow for this, since we do need it. I'm using @Node.value instead of name so that it works without specifying the embedXML attribute: @Node("Foo"). I suspect the hbm.xml overriding is missing in the EJB3OverridenAnnotationReader, but this file is so overwhelming I didn't dare touch it. In order to be able to specify the element name for a collection I've also added @ElementNode which is the same as @Node, but can be set for collections: @Node("Foos") @ElementNode("Foo") List<Foo> foos; There may be some mappings missing for certain types of properties, since we do not use every possible property type in our project, but I've verified it works for at least SimpleValue, Component, Collection, ManyToOne, and simple ids. When I say it works, I haven't tried to run code with it since I'd like to have some feedback from people with more insight on the code before I trust it with my data. But what we do now is I've patched hibernate-tools to print the node and embed-xml attributes with the hbm2hbmxml ant task, so that we generate our entities' hbm.xml files from the annotations using the patched hibernate-annotations and hibernate-tools, and use these hbm.xml files in our production environment. That way they are easy to check for defects, and they are actually correct: they get the correct embed-xml and node attributes from the annotations, so in all likelyhood it should be possible to do away with hbm.xml files and only use annotations to generate XML. When I tried to do this though I noticed a few strange things: - a @Lob String would have type="org.hibernate.type.StringClobType" instead of type="text", which should be the same. - most other primitive types would have class names instead of hbm names: java.lang.String instead of string, java.util.TimeZone instead of timezone, java.util.Date instead of date, java.lang.Long instead of long... I don't know if these are an issue, but the StringClobType was an issue for me, since hibernate tried to cast it to an ExtendedUserType, which it was not. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/ANN-572?page=co... ] Emmanuel Bernard updated ANN-572: --------------------------------- Fix Version/s: 3.4 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/ANN-572?page=co... ] Arturo Frappé updated ANN-572: ------------------------------ Attachment: ANN-572-patch-by-afm.patch This is my own version of Node annotation. I tested against Many ToOne, OneToMany, Property, Class -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/ANN-572?page=co... ] Arturo Frappé commented on ANN-572: ----------------------------------- Did I forget something? - Tanks to Stephane Epardaud for his initial patch. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/ANN-572?page=co... ] Arturo Frappé commented on ANN-572: ----------------------------------- ¿What does javax.persistence.Embedded mean? I was wondering if Embedded annotation interfers with Node annotation in any sense. This line is found inside org.hibernate.cfg.AnnotationBinder::processElementAnnotations( .. ) { ... near 1544 line of code: //potential element property.isAnnotationPresent( Embedded.class ) ; ... I think that this line overrides the @Node(embedXML=true|false) What if the same line is rewritten: //potential element collectionBinder.setEmbedded( BinderHelper.isElementNodeEmbeddedXML( property ) || property.isAnnotationPresent( Embedded.class ) ); Considering that a @Node is also present and is predominant ? What if the prescence of @Embedded annotation is ignored, what will be the effect? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/ANN-572?page=co... ] Emmanuel Bernard commented on ANN-572: -------------------------------------- @Embedded is about the notion of component in Hibernate -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira