12:43 p.m.
Expand CustomEntityDirtinessStrategy to define findDirty
--------------------------------------------------------
Key: HHH-6998
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-6998
Project: Hibernate ORM
Issue Type: Improvement
Reporter: Steve Ebersole
Assignee: Steve Ebersole
Fix For: 4.1.0
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:47 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-6998) Expand CustomEntityDirtinessStrategy to define findDirty
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-6998?page=c...
]
Steve Ebersole updated HHH-6998:
--------------------------------
Description:
{{CustomEntityDirtinessStrategy}} allows applications to bypass dirty checking in cases
when they know an entity is not dirty.
In some of these application, they also carry along the initial ("loaded")
state. In those cases it might be more performant to allow them to tell us which fields
changed. If we go this route though I'd like to take it as an opportunity to explore
options for not exposing all these arrays to user code. So partially this issue will be a
discussion of possible approaches to that.
Expand CustomEntityDirtinessStrategy to define findDirty
--------------------------------------------------------
Key: HHH-6998
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-6998
Project: Hibernate ORM
Issue Type: Improvement
Reporter: Steve Ebersole
Assignee: Steve Ebersole
Fix For: 4.1.0
{{CustomEntityDirtinessStrategy}} allows applications to bypass dirty checking in cases
when they know an entity is not dirty.
In some of these application, they also carry along the initial ("loaded")
state. In those cases it might be more performant to allow them to tell us which fields
changed. If we go this route though I'd like to take it as an opportunity to explore
options for not exposing all these arrays to user code. So partially this issue will be a
discussion of possible approaches to that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:02 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-6998) Expand CustomEntityDirtinessStrategy to define findDirty
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-6998?page=c...
]
Steve Ebersole commented on HHH-6998:
-------------------------------------
Here is an initial swag...
{code:title=CustomEntityDirtinessStrategy.java|borderStyle=solid}
public interface CustomEntityDirtinessStrategy {
...
public void findDirty(DirtyCheckContext context, Object entity, Session session);
}
{code}
{code:title=DirtyCheckContext.java|borderStyle=solid}
public interface DirtyCheckContext {
public static interface AttributeContext {
public String getName();
public Type getType();
public Object getCurrentValue();
public Object getLoadedValue();
}
public static interface AttributeChecker {
public boolean isDirty(AttributeContext attributeContext);
}
public void doDirtyChecking(AttributeChecker attributeChecker);
}
{code}
Application code is already implementing {{CustomEntityDirtinessStrategy}}. The only new
requirement here is to implement {{AttributeChecker}}. As an example consider a case
where we hold a map of changed values on the entity itself:
{code:borderStyle=solid}
public class MyCustomEntityDirtinessStrategy implements CustomEntityDirtinessStrategy {
...
public void findDirty(DirtyCheckContext context, final Object entity, final Session
session) {
context.doDirtyChecking(
new AttributeChecker() {
public boolean isDirty(AttributeContext attributeContext) {
return ( (DirtyTrackingEntity) entity
).getChangedValueMap().containsKey( attributeContext.getName();
}
}
);
}
}
{code}
Expand CustomEntityDirtinessStrategy to define findDirty
--------------------------------------------------------
Key: HHH-6998
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-6998
Project: Hibernate ORM
Issue Type: Improvement
Reporter: Steve Ebersole
Assignee: Steve Ebersole
Fix For: 4.1.0
{{CustomEntityDirtinessStrategy}} allows applications to bypass dirty checking in cases
when they know an entity is not dirty.
In some of these application, they also carry along the initial ("loaded")
state. In those cases it might be more performant to allow them to tell us which fields
changed. If we go this route though I'd like to take it as an opportunity to explore
options for not exposing all these arrays to user code. So partially this issue will be a
discussion of possible approaches to that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:34 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-6998) Expand CustomEntityDirtinessStrategy to define findDirty
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-6998?page=c...
]
Steve Ebersole commented on HHH-6998:
-------------------------------------
{{DirtyCheckContext}} would need access to {{Session}}, so:
{code:title=CustomEntityDirtinessStrategy.java|borderStyle=solid}
public interface CustomEntityDirtinessStrategy {
...
public void findDirty(DirtyCheckContext context, Object entity);
}
{code}
plus a {{getSession}} method on {{DirtyCheckContext}}
Expand CustomEntityDirtinessStrategy to define findDirty
--------------------------------------------------------
Key: HHH-6998
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-6998
Project: Hibernate ORM
Issue Type: Improvement
Reporter: Steve Ebersole
Assignee: Steve Ebersole
Fix For: 4.1.0
{{CustomEntityDirtinessStrategy}} allows applications to bypass dirty checking in cases
when they know an entity is not dirty.
In some of these application, they also carry along the initial ("loaded")
state. In those cases it might be more performant to allow them to tell us which fields
changed. If we go this route though I'd like to take it as an opportunity to explore
options for not exposing all these arrays to user code. So partially this issue will be a
discussion of possible approaches to that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:51 p.m.
New subject: [Hibernate-JIRA] Resolved: (HHH-6998) Expand CustomEntityDirtinessStrategy to define findDirty
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-6998?page=c...
]
Steve Ebersole resolved HHH-6998.
---------------------------------
Resolution: Fixed
Expand CustomEntityDirtinessStrategy to define findDirty
--------------------------------------------------------
Key: HHH-6998
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-6998
Project: Hibernate ORM
Issue Type: Improvement
Reporter: Steve Ebersole
Assignee: Steve Ebersole
Fix For: 4.1.0
Time Spent: 3h 22m
{{CustomEntityDirtinessStrategy}} allows applications to bypass dirty checking in cases
when they know an entity is not dirty.
In some of these application, they also carry along the initial ("loaded")
state. In those cases it might be more performant to allow them to tell us which fields
changed. If we go this route though I'd like to take it as an opportunity to explore
options for not exposing all these arrays to user code. So partially this issue will be a
discussion of possible approaches to that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:04 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-6998) Expand CustomEntityDirtinessStrategy to define findDirty
[
https://hibernate.onjira.com/browse/HHH-6998?page=com.atlassian.jira.plug...
]
Shawn Clowater commented on HHH-6998:
-------------------------------------
Steve,
You don't waste any time at all when you get an idea in your head. Took a peek at the
code and it looks very slick and I can't wait to kick the tires on it. From a cursory
glance it looks like it should fit the bill nicely.
The one scenario i'll have to go back and hammer to see if it even still exists is
where the core was trying to update a fk reference on a many to one to null on a delete.
In that case it was modifying the current values array w/o calling the setter on my entity
so I wasn't trapping the change. This may no longer apply as this was 2 or 3 years
ago at least when I was looking at that.
Expand CustomEntityDirtinessStrategy to define findDirty
--------------------------------------------------------
Key: HHH-6998
URL: https://hibernate.onjira.com/browse/HHH-6998
Project: Hibernate ORM
Issue Type: Improvement
Reporter: Steve Ebersole
Assignee: Steve Ebersole
Fix For: 4.1.0
Time Spent: 3h 22m
{{CustomEntityDirtinessStrategy}} allows applications to bypass dirty checking in cases
when they know an entity is not dirty.
In some of these application, they also carry along the initial ("loaded")
state. In those cases it might be more performant to allow them to tell us which fields
changed. If we go this route though I'd like to take it as an opportunity to explore
options for not exposing all these arrays to user code. So partially this issue will be a
discussion of possible approaches to that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:56 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-6998) Expand CustomEntityDirtinessStrategy to define findDirty
[
https://hibernate.onjira.com/browse/HHH-6998?page=com.atlassian.jira.plug...
]
Steve Ebersole commented on HHH-6998:
-------------------------------------
Definitely, lol
Expand CustomEntityDirtinessStrategy to define findDirty
--------------------------------------------------------
Key: HHH-6998
URL: https://hibernate.onjira.com/browse/HHH-6998
Project: Hibernate ORM
Issue Type: Improvement
Reporter: Steve Ebersole
Assignee: Steve Ebersole
Fix For: 4.1.0
Time Spent: 3h 22m
{{CustomEntityDirtinessStrategy}} allows applications to bypass dirty checking in cases
when they know an entity is not dirty.
In some of these application, they also carry along the initial ("loaded")
state. In those cases it might be more performant to allow them to tell us which fields
changed. If we go this route though I'd like to take it as an opportunity to explore
options for not exposing all these arrays to user code. So partially this issue will be a
discussion of possible approaches to that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:22 p.m.
New subject: [Hibernate-JIRA] Closed: (HHH-6998) Expand CustomEntityDirtinessStrategy to define findDirty
[
https://hibernate.onjira.com/browse/HHH-6998?page=com.atlassian.jira.plug...
]
Steve Ebersole closed HHH-6998.
-------------------------------
Closing for 4.1 release
Expand CustomEntityDirtinessStrategy to define findDirty
--------------------------------------------------------
Key: HHH-6998
URL: https://hibernate.onjira.com/browse/HHH-6998
Project: Hibernate ORM
Issue Type: Improvement
Reporter: Steve Ebersole
Assignee: Steve Ebersole
Fix For: 4.1.0
Time Spent: 3h 22m
{{CustomEntityDirtinessStrategy}} allows applications to bypass dirty checking in cases
when they know an entity is not dirty.
In some of these application, they also carry along the initial ("loaded")
state. In those cases it might be more performant to allow them to tell us which fields
changed. If we go this route though I'd like to take it as an opportunity to explore
options for not exposing all these arrays to user code. So partially this issue will be a
discussion of possible approaches to that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5172
days inactive
5187
days old
hibernate-issues@lists.jboss.org
7 comments
2 participants
participants (2)
-
Shawn Clowater (JIRA) -
Steve Ebersole (JIRA)