[ http://opensource.atlassian.com/projects/hibernate/browse/ANN-862?page=co... ] Albert Kurucz commented on ANN-862: ----------------------------------- http://www.gmarwaha.com/blog/2009/08/26/hibernate-why-should-i-force-disc... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4358?page=c... ] Steve Ebersole updated HHH-4358: -------------------------------- Fix Version/s: (was: 4.0.0.CR2) 4.0.0.next Still awaiting response, moving to next release -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4358?page=c... ] Gail Badner updated HHH-4358: ----------------------------- Fix Version/s: (was: 4.0.0.CR5) 4.0.0.next -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4358?page=c... ] Karsten Wutzke edited comment on HHH-4358 at 11/3/11 12:21 PM: --------------------------------------------------------------- OMG another Hibernate head-shaker: @ForceDiscriminator ... please support discriminators *by default* in the next version. It's critical as otherwise the discriminator column is never set to its correct value. This leads to inconsistent data. was (Author: kwutzke): OMG another Hibernate head-shaker: @ForceDiscriminator ... please support discriminators *by default* in the next version. It's critical as otherwise the discriminator column is never set to its correct value. Ugh. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4358?page=c... ] Steve Ebersole updated HHH-4358: -------------------------------- Fix Version/s: (was: 4.0.0.CR6) 4.0.0.next -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4358?page=c... ] Steve Ebersole updated HHH-4358: -------------------------------- Fix Version/s: (was: 4.0.0.Final) 4.0.1 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4358?page=c... ] Steve Ebersole commented on HHH-4358: ------------------------------------- Sorry Karsten, must have missed your pull request. Mind linking that again? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4358?page=c... ] Karsten Wutzke commented on HHH-4358: ------------------------------------- Why do you require a spec for an issue that's supposed to work by common sense? Just ignore the JPA part in the description then. It kinda breaks common sense compatibility. BTW I didn't attach a pull request. I meant it doesn't make much sense to further defer fixing this bug just because some JPA spec statement is missing. The JPA spec itself isn't perfect, but not persisting the discriminator value is even more pointless than just doing nothing. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4358?page=c... ] Steve Ebersole commented on HHH-4358: ------------------------------------- I *know* you did not attach a pull request. That was in fact my point. You say it is something so important, so why not fix it? The consensus on the relate developer mailing list discussion was that because this would break the way existing applications worked we would only change this *as the default behavior* if this actually violated the spec. As it does not appear to violate the spec, this will not change as the default behavior. Now, we could discuss having this work with a configuration setting (something like {{hibernate.force_discriminators_by_default}}) that (1) keeps the current behavior as default and (2) allows specifying that forcing discriminator should be the default when enabled. I had only initially assigned a fix version because I assumed someone involved in this issue or the person that started the dev list discussion was going to follow up. That never happened. So I'll just un-assign a fix version. That way we dont have to keep "pushing it on and on"... -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4358?page=c... ] Karsten Wutzke edited comment on HHH-4358 at 12/19/11 4:47 PM: --------------------------------------------------------------- Here's what Michael Keith (Author of Pro JPA 2 and member of the JPA expert group) had to say about this: "The spec does not require an implementation to use discriminator columns to implement JOINED inheritance, however, the assumption is that if @DiscriminatorColumn is specified then it would be used, i.e. the values would be written out. We do not explicitly state that if a @DiscriminatorColumn is specified in the code it must be used, just like we don't explicitly state that if a @Column or @JoinColumn is specified the values must be stored in the table, but there is only so much that we can or should specify. At the lowest level, certain laws of physics and reason are just assumed." So implementing an option would be the way to go (even though I still believe Hibernate is wrong). I wonder how existing applications would break if they set the correct discriminator value instead of the wrong one now... (sorry for turning this into a discussion) was (Author: kwutzke): Here's what Michael Keith (Author of Pro JPA 2 and member of the JPA expert group) had to say about this: "The spec does not require an implementation to use discriminator columns to implement JOINED inheritance, however, the assumption is that if @DiscriminatorColumn is specified then it would be used, i.e. the values would be written out. We do not explicitly state that if a @DiscriminatorColumn is specified in the code it must be used, just like we don't explicitly state that if a @Column or @JoinColumn is specified the values must be stored in the table, but there is only so much that we can or should specify. At the lowest level, certain laws of physics and reason are just assumed." So implementing an option would be the way to go (even though I still believe Hibernate is wrong nontheless). I wonder how existing applications would break if they now set the correct discriminator value instead of the wrong one now... (sorry for turning this into a discussion) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4358?page=c... ] Steve Ebersole commented on HHH-4358: ------------------------------------- Karsten, you are completely misunderstanding the issue. "force discriminator" has *nothing* to do with whether the discriminator value is saved or not. Have you even tried any of this? Or at least looked at the documentation? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4358?page=c... ] Karsten Wutzke commented on HHH-4358: ------------------------------------- Uhh please calm down. Not everyone is as involved in this as you are. I will then enter a new bug report as to why the discriminator value isn't stored. Sorry for the inconvenience. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4358?page=c... ] Karsten Wutzke commented on HHH-4358: ------------------------------------- I admit I have no idea how I thought this bug might be the place to discuss my problem, but instead of making fun of me please have a look at my posting in the forum (which is, as ever so often, unanswered) before I go ahead and report something that isn't supposed to be a bug: https://forum.hibernate.org/viewtopic.php?f=1&t=1013221 Thanks -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4358?page=c... ] Karsten Wutzke edited comment on HHH-4358 at 12/19/11 7:51 PM: --------------------------------------------------------------- I admit I have no idea how I thought this bug might be the place to discuss my problem, but instead of making fun of me please have a look at my posting in the forum (which is, as ever so often, unanswered) before I go ahead and report a bug that isn't one: https://forum.hibernate.org/viewtopic.php?f=1&t=1013221 Thanks was (Author: kwutzke): I admit I have no idea how I thought this bug might be the place to discuss my problem, but instead of making fun of me please have a look at my posting in the forum (which is, as ever so often, unanswered) before I go ahead and report a bug that isn't one at all: https://forum.hibernate.org/viewtopic.php?f=1&t=1013221 Thanks -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4358?page=c... ] Steve Ebersole commented on HHH-4358: ------------------------------------- Not sure where I "made fun of" you. And I dont think you should be talking about tone in comments; just look at yours on this issue. You are the only one getting worked up. Sure, Mike also speaks from the perspective of the particular JPA impl he works on :) Hibernate does not need the discriminator value here (really if you step back and think about it, the discriminator is completely unnecessary) so it does nothing with it. What Mike refers to is the awesomely worded passage {quote} For the SINGLE_TABLE mapping strategy, and typically also for the JOINED strategy, the persistence provider will use a type discriminator column. The DiscriminatorColumn annotation is used to define the discriminator column for the SINGLE_TABLE and JOINED inheritance mapping strategies. {quote} That is the only time DiscriminatorColumn is discussed in conjunction with JOINED. The entire section devoted to the JOINED strategy (2.12.2) does not mention use of DiscriminatorColumn once. Whereas the discussion of DiscriminatorColumn in regards to SINGLE_TABLE comes up in the second sentence of its section (2.12.1). Not to mention that the passage itself goes out of its way to differentiate DiscriminatorColumn as used SINGLE_TABLE versus as used with JOINED. I mean to me, as a person whose primary language is English, the phrase "typically also for the JOINED strategy" says that not all providers use a DiscriminatorColumn with JOINED and that it is not mandated that they do. Not sure what "laws of physics" Mike is referring to, but the laws of physics I always learned were never that obtuse nor wishy-washy. Yeah, in retrospect, for the sake of portability I can see how Hibernate still writing the discriminator value to the database is useful. But I am sure Mike and his crew often think deeply about portability to Hibernate as well ;) Open a RFE if you wish. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4358?page=c... ] Karsten Wutzke edited comment on HHH-4358 at 12/20/11 2:38 PM: --------------------------------------------------------------- OK I probably misunderstood the "making fun of". Winter is not my time honestly. :( Thanks for the insight, but I still don't see why Hibernate doesn't simply persist a discriminator. How would I get Hibernate to do it now as a workaround? If I understand correctly JOINED inheritance simply uses joins on sub entities to determine the actual type (only disjoint inheritance supported). That's all that came to my mind. I'm mostly flooded trying to solve business problems. In the end it's hard to explain to a customer when you recommend Hibernate as a OR mapper and it doesn't simply do the things you'd expect (Michael's "assumed thing" I concur with). My customer first thought I was doing something wrong with Hibernate, then they thought I recommended the wrong tool... not good in any case, y'know... I will open an RFE then. Thanks for your patience. was (Author: kwutzke): OK I probably misunderstood the "making fun of". Winter is not my time honestly. :( Thanks for the insight, but I still don't see why Hibernate doesn't simply persist a discriminator. How would I get Hibernate to do it now as a workaround? I probably have to think about this problem. It just doesn't spring to MY mind. It might be logical for anybody somewhat deeply involved, but I'm mostly flooded trying to solve business problems. Furthermore, it's hard to explain to a customer when you recommend Hibernate as a OR mapper and it doesn't simply do the things you'd expect (Michael's "assumed thing" I concur with). My customer first thought I was doing something wrong with Hibernate, then they thought I recommended the wrong tool... not good in any case, y'know... I will open an RFE then. Thanks for your patience. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4358?page=c... ] Karsten Wutzke edited comment on HHH-4358 at 12/20/11 2:39 PM: --------------------------------------------------------------- OK I probably misunderstood the "making fun of". Winter is not my time honestly. :( Thanks for the insight, but I still don't see why Hibernate doesn't simply persist a discriminator. How would I get Hibernate to do it now as a workaround? If I understand correctly JOINED inheritance simply uses joins on sub entities to determine the actual type (only disjoint inheritance supported), which can't work for SINGLE_TABLE. That's all that came to my mind. I'm mostly flooded trying to solve business problems. In the end it's hard to explain to a customer when you recommend Hibernate as a OR mapper and it doesn't simply do the things you'd expect (Michael's "assumed thing" that I concur with). My customer first thought I was doing something wrong with Hibernate, then they thought I recommended the wrong tool... not good in any case, y'know... I will open an RFE then. Thanks for your patience. was (Author: kwutzke): OK I probably misunderstood the "making fun of". Winter is not my time honestly. :( Thanks for the insight, but I still don't see why Hibernate doesn't simply persist a discriminator. How would I get Hibernate to do it now as a workaround? If I understand correctly JOINED inheritance simply uses joins on sub entities to determine the actual type (only disjoint inheritance supported), which can't work for SINGLE_TABLE. That's all that came to my mind. I'm mostly flooded trying to solve business problems. In the end it's hard to explain to a customer when you recommend Hibernate as a OR mapper and it doesn't simply do the things you'd expect (Michael's "assumed thing" I concur with). My customer first thought I was doing something wrong with Hibernate, then they thought I recommended the wrong tool... not good in any case, y'know... I will open an RFE then. Thanks for your patience. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4358?page=c... ] Steve Ebersole updated HHH-4358: -------------------------------- Fix Version/s: (was: 4.0.1) 4.1.0 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4358?page=c... ] Steve Ebersole resolved HHH-4358. --------------------------------- Resolution: Fixed -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira