[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2146?page=c... ] Ashley Tate commented on HHH-2146: ---------------------------------- I've duplicated this bug in 3.2.1 GA . The stack trace is below. The source of the problem is in org.hibernate.engine.Cascade.deleteOrphans() on this line: << eventSource.delete( entityName, orphan, false, null ); EventSource.delete(String, Object, boolean, Set) should be called with an empty Set parameter rather than null. Hopefully this info will suffice, otherwise let me know if you still need a test case. Regards, Ashley Tate ============================================ SOURCE OF ERROR: private void deleteOrphans(String entityName, PersistentCollection pc) throws HibernateException { //TODO: suck this logic into the collection! final Collection orphans; if ( pc.wasInitialized() ) { CollectionEntry ce = eventSource.getPersistenceContext().getCollectionEntry(pc); orphans = ce==null ? CollectionHelper.EMPTY_COLLECTION : ce.getOrphans(entityName, pc); } else { orphans = pc.getQueuedOrphans(entityName); } final Iterator orphanIter = orphans.iterator(); while ( orphanIter.hasNext() ) { Object orphan = orphanIter.next(); if (orphan!=null) { if ( log.isTraceEnabled() ) { log.trace("deleting orphaned entity instance: " + entityName); } eventSource.delete( entityName, orphan, false, null ); } } } ======================================= ERROR STACK TRACE: java.lang.NullPointerException at org.hibernate.event.def.DefaultDeleteEventListener.deleteTransientEntity(DefaultDeleteEventListener.java:162) at org.hibernate.event.def.DefaultDeleteEventListener.onDelete(DefaultDeleteEventListener.java:70) at org.hibernate.impl.SessionImpl.fireDelete(SessionImpl.java:775) at org.hibernate.impl.SessionImpl.delete(SessionImpl.java:758) at org.hibernate.engine.Cascade.deleteOrphans(Cascade.java:355) at org.hibernate.engine.Cascade.cascadeCollectionElements(Cascade.java:324) at org.hibernate.engine.Cascade.cascadeCollection(Cascade.java:242) at org.hibernate.engine.Cascade.cascadeAssociation(Cascade.java:219) at org.hibernate.engine.Cascade.cascadeProperty(Cascade.java:169) at org.hibernate.engine.Cascade.cascade(Cascade.java:130) at org.hibernate.event.def.DefaultDeleteEventListener.cascadeBeforeDelete(DefaultDeleteEventListener.java:274) at org.hibernate.event.def.DefaultDeleteEventListener.deleteEntity(DefaultDeleteEventListener.java:213) at org.hibernate.event.def.DefaultDeleteEventListener.onDelete(DefaultDeleteEventListener.java:128) at org.hibernate.event.def.DefaultDeleteEventListener.onDelete(DefaultDeleteEventListener.java:49) at org.hibernate.impl.SessionImpl.fireDelete(SessionImpl.java:766) at org.hibernate.impl.SessionImpl.delete(SessionImpl.java:744) at org.springframework.orm.hibernate3.HibernateTemplate$25.doInHibernate(HibernateTemplate.java:785) at org.springframework.orm.hibernate3.HibernateTemplate.execute(HibernateTemplate.java:367) at org.springframework.orm.hibernate3.HibernateTemplate.delete(HibernateTemplate.java:779) at org.springframework.orm.hibernate3.HibernateTemplate.delete(HibernateTemplate.java:775) at com.mckesson.common.orm.hibernate.HibernateDaoSupport.deleteObject(HibernateDaoSupport.java:59) at com.mckesson.common.eo2.eo.CustomerHibernateDao.delete(CustomerHibernateDao.java:22) at com.mckesson.common.eo2.BookstoreHibDaoApiTest.testCreateCustomer1(BookstoreHibDaoApiTest.java:351) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:585) at junit.framework.TestCase.runTest(TestCase.java:164) at com.mckesson.common.junit.TestCase.runTest(TestCase.java:426) at junit.framework.TestCase.runBare(TestCase.java:130) at com.mckesson.common.junit.TestCase.runBare(TestCase.java:415) at junit.framework.TestResult$1.protect(TestResult.java:110) at junit.framework.TestResult.runProtected(TestResult.java:128) at junit.framework.TestResult.run(TestResult.java:113) at junit.framework.TestCase.run(TestCase.java:120) at junit.framework.TestSuite.runTest(TestSuite.java:228) at junit.framework.TestSuite.run(TestSuite.java:223) at junit.framework.TestSuite.runTest(TestSuite.java:228) at junit.framework.TestSuite.run(TestSuite.java:223) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:297) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:672) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:567) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2146?page=c... ] Andrew Timpone commented on HHH-2146: ------------------------------------- Is there anyway to raise the priority on this issue? We recently upgraded from Hibernate 3.0.x to 3.2.2 and are starting to see this error pop up in quite a few issues. At surface level, this appears to be a relatively simple fix (not knowing the deep inner guts of Hibernate), but a null check before comparing to the transientEntities would easily solve the issue. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2146?page=c... ] Nadim Hourani commented on HHH-2146: ------------------------------------ For now I also compiled Hibernate 3.2.2 with Darren's fix and it works fine. Can you please give us an estimate of when this will be fixed and in what version? Thank you -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2146?page=c... ] Donnchadh O Donnabhain updated HHH-2146: ---------------------------------------- Attachment: deletetransientmn.zip Unit Test to reproduce this problem. Let me know if any modifications are required. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2146?page=c... ] shilpa updated HHH-2146: ------------------------ Attachment: Cascade.java Hello, I have attached the modified org.hibernate.engine.Cascade class which contains the fix to this comment. The sugggested change has been done to this file at line no. 356. eventSource.delete( entityName, orphan, false, null ); is replaced with eventSource.delete( entityName, orphan, false, new HashSet()); Could you please commit it to your repository. Thanks shilpa -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2146?page=c... ] Ola Kristoffer Øye commented on HHH-2146: ----------------------------------------- Also affected here. Seems the unit test was uploaded half a year ago (by Donnchadh), so it should be easy to fix? Maybe the reason is that this bug isnt assigned to anyone and marked with minor priority? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2146?page=c... ] Alon Salant commented on HHH-2146: ---------------------------------- We are also experiencing this issue. Another fix that you can use while waiting for the Hibernate core to be patched is to extend DefaultDeleteEventListener and do the null check: public class BugFixDeleteEventListener extends DefaultDeleteEventListener { protected void deleteTransientEntity(EventSource session, Object entity, boolean cascadeDeleteEnabled, EntityPersister persister, Set transientEntities) { super.deleteTransientEntity(session, entity, cascadeDeleteEnabled, persister, transientEntities == null ? new HashSet() : transientEntities); } } Then you can register this listener in place of the default: <hibernate-configuration> <session-factory> <event type="delete"> <listener class="your.package.BugFixDeleteEventListener"/> </event> </session-factory> </hibernate-configuration> -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2146?page=c... ] Frédéric Brouillé commented on HHH-2146: ---------------------------------------- This bug breaks our production system some mouths ago. We had to patch hibernate 3.2.5 and compile it locally. I confirm Darren's fix works fine. This issue is not yet fixed in hibernate 3.2.6, so we have to patch it again. It becomes unpleasant to patch every new version. So please, could you fix this bug? Thanks -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2146?page=c... ] Gail Badner updated HHH-2146: ----------------------------- Assignee: Gail Badner Fix Version/s: 3.3 3.2.x -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2146?page=c... ] Andreas Schildbach commented on HHH-2146: ----------------------------------------- I'm also bitten by this nasty! I think it should be taken seriously. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2146?page=c... ] Gail Badner updated HHH-2146: ----------------------------- Fix Version/s: (was: 3.2.x) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2146?page=c... ] Steve Ebersole updated HHH-2146: -------------------------------- Fix Version/s: (was: 3.3.1) 3.3.x -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2146?page=c... ] Martin Kartumovich commented on HHH-2146: ----------------------------------------- I can still reproduce the problem in 3.3.1. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2146?page=c... ] Feybesse commented on HHH-2146: ------------------------------- I'm too. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2146?page=c... ] Cyril commented on HHH-2146: ---------------------------- I faced the same issue and fixed the Cascade.java source by downloading the hibernate core from SVN. However, when I try to build the core using 'mvn clean install', the build fails with all the entitymanager test-cases reported as failed. Do I need to build entitymanager before I can build the core? Am a newbie to hibernate, any help on this would be greatly appreciated. Thanks, Cyril -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2146?page=c... ] Gail Badner commented on HHH-2146: ---------------------------------- Harsha, 3.2.6 still has the bug. You need to use 3.2.7 or 3.3.2 to get the fix. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira