5:13 p.m.
Make DocHelper robust against failing buildSettings()
-----------------------------------------------------
Key: HBX-1042
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1042
Project: Hibernate Tools
Issue Type: Improvement
Components: hbm2doc
Reporter: Arnout Engelen
Attachments: dochelper.diff.txt
DocHelper calls cfg.buildSettings(). to get the Dialect, default catalog name and default
schema name.
However, cfg.buildSettings() may fail with a HibernateException (example below).
It would be nice to have DocHelper handle this more gracefully. Attached is a simple patch
that does this.
(background: I'd like to use the Configuration I'm getting from a Spring
LocalSessionFactoryBean, which after initial creation leaves its
LocalDataSourceConnectionProvider in a state that yiels a HibernateException when calling
'configure()' on it, which buildSettings() does. Because of this issue, I cannot
use the DocExporter for my Spring-based hibernate configurations)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:23 a.m.
New subject: [Hibernate-JIRA] Commented: (HBX-1042) Make DocHelper robust against failing buildSettings()
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1042?page=c...
]
Max Rydahl Andersen commented on HBX-1042:
------------------------------------------
In what scenario will buildSettings fail !? We can't just ignore the exception since
it might influence the output.
Please give a more concrete example of what fails...
Make DocHelper robust against failing buildSettings()
-----------------------------------------------------
Key: HBX-1042
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1042
Project: Hibernate Tools
Issue Type: Improvement
Components: hbm2doc
Reporter: Arnout Engelen
Attachments: dochelper.diff.txt
DocHelper calls cfg.buildSettings(). to get the Dialect, default catalog name and default
schema name.
However, cfg.buildSettings() may fail with a HibernateException (example below).
It would be nice to have DocHelper handle this more gracefully. Attached is a simple
patch that does this.
(background: I'd like to use the Configuration I'm getting from a Spring
LocalSessionFactoryBean, which after initial creation leaves its
LocalDataSourceConnectionProvider in a state that yiels a HibernateException when calling
'configure()' on it, which buildSettings() does. Because of this issue, I cannot
use the DocExporter for my Spring-based hibernate configurations)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:29 p.m.
New subject: [Hibernate-JIRA] Commented: (HBX-1042) Make DocHelper robust against failing buildSettings()
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1042?page=c...
]
Arnout Engelen commented on HBX-1042:
-------------------------------------
I'm using the Spring AnnotationSessionFactoryBean, which returns an
AnnotationConfiguration with
hibernate.connection.provider_class=org.springframework.orm.hibernate3.LocalDataSourceConnectionProvider.
SettingsFactory.buildSettings() does a createConnectionProvider(), which makes a new
LocalDataSourceConnectionProvider and tries to call .configure() on it, which tries to
look up the datasource in the LocalSessionFactoryBean. A this point, however, the
LocalSessionFactoryBean no longer provides the DataSource, and
LocalDataSourceConnectionProvider.configure() throws a HibernateException.
org.hibernate.HibernateException: No local DataSource found for configuration - dataSource
property must be set on LocalSessionFactoryBean
at
org.springframework.orm.hibernate3.LocalDataSourceConnectionProvider.configure(LocalDataSourceConnectionProvider.java:49)
at
org.hibernate.connection.ConnectionProviderFactory.newConnectionProvider(ConnectionProviderFactory.java:124)
at
org.hibernate.connection.ConnectionProviderFactory.newConnectionProvider(ConnectionProviderFactory.java:56)
at org.hibernate.cfg.SettingsFactory.createConnectionProvider(SettingsFactory.java:414)
at org.hibernate.cfg.SettingsFactory.buildSettings(SettingsFactory.java:62)
at org.hibernate.cfg.Configuration.buildSettings(Configuration.java:2069)
at org.hibernate.tool.hbm2x.doc.DocHelper.<init>(DocHelper.java:135)
I'm not sure if this could be considered a bug in Spring, but in any case it would be
really helpful if DocExporter could recover from this exception gracefully, perhaps
logging a warning?
Make DocHelper robust against failing buildSettings()
-----------------------------------------------------
Key: HBX-1042
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1042
Project: Hibernate Tools
Issue Type: Improvement
Components: hbm2doc
Reporter: Arnout Engelen
Attachments: dochelper.diff.txt
DocHelper calls cfg.buildSettings(). to get the Dialect, default catalog name and default
schema name.
However, cfg.buildSettings() may fail with a HibernateException (example below).
It would be nice to have DocHelper handle this more gracefully. Attached is a simple
patch that does this.
(background: I'd like to use the Configuration I'm getting from a Spring
LocalSessionFactoryBean, which after initial creation leaves its
LocalDataSourceConnectionProvider in a state that yiels a HibernateException when calling
'configure()' on it, which buildSettings() does. Because of this issue, I cannot
use the DocExporter for my Spring-based hibernate configurations)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:57 a.m.
New subject: [Hibernate-JIRA] Commented: (HBX-1042) Make DocHelper robust against failing buildSettings()
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1042?page=c...
]
Max Rydahl Andersen commented on HBX-1042:
------------------------------------------
workaround:
if you set the dialect we don't need to contact the db to detect the database or you
can set the connection properties to not be dataSource bound by setting the relevant
connection properties on the configuration (for all the configurations supported by
hibernate tools we can set a properties file to override these....as far as I remember
that is also possible in spring)
Make DocHelper robust against failing buildSettings()
-----------------------------------------------------
Key: HBX-1042
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1042
Project: Hibernate Tools
Issue Type: Improvement
Components: hbm2doc
Reporter: Arnout Engelen
Attachments: dochelper.diff.txt
DocHelper calls cfg.buildSettings(). to get the Dialect, default catalog name and default
schema name.
However, cfg.buildSettings() may fail with a HibernateException (example below).
It would be nice to have DocHelper handle this more gracefully. Attached is a simple
patch that does this.
(background: I'd like to use the Configuration I'm getting from a Spring
LocalSessionFactoryBean, which after initial creation leaves its
LocalDataSourceConnectionProvider in a state that yiels a HibernateException when calling
'configure()' on it, which buildSettings() does. Because of this issue, I cannot
use the DocExporter for my Spring-based hibernate configurations)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:59 a.m.
New subject: [Hibernate-JIRA] Commented: (HBX-1042) Make DocHelper robust against failing buildSettings()
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1042?page=c...
]
Max Rydahl Andersen commented on HBX-1042:
------------------------------------------
I don't belive this is docexporter specific hence I updated the title.
note: I don't currently see how we can just ignore the exception since it might not
just be valid connection info that is missing.
Make DocHelper robust against failing buildSettings()
-----------------------------------------------------
Key: HBX-1042
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1042
Project: Hibernate Tools
Issue Type: Improvement
Components: hbm2doc
Reporter: Arnout Engelen
Attachments: dochelper.diff.txt
DocHelper calls cfg.buildSettings(). to get the Dialect, default catalog name and default
schema name.
However, cfg.buildSettings() may fail with a HibernateException (example below).
It would be nice to have DocHelper handle this more gracefully. Attached is a simple
patch that does this.
(background: I'd like to use the Configuration I'm getting from a Spring
LocalSessionFactoryBean, which after initial creation leaves its
LocalDataSourceConnectionProvider in a state that yiels a HibernateException when calling
'configure()' on it, which buildSettings() does. Because of this issue, I cannot
use the DocExporter for my Spring-based hibernate configurations)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:55 p.m.
New subject: [Hibernate-JIRA] Commented: (HBX-1042) Make DocHelper robust against failing buildSettings()
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1042?page=c...
]
Arnout Engelen commented on HBX-1042:
-------------------------------------
Indeed, all the relevant information (default schema, default catalog and dialect) is
readily present in the Properties of the Configuration.
However, DocHelper still insists on calling cfg.buildSettings() to get the information
from there - as far as I can see it is not used for anything else.
Couldn't we make DocHelper simply use the information from the Properties, instead of
calling cfg.buildSettings()? Or, alternatively, issue a warning and take the settings from
the Properties in case calling buildSettings() fails?
I'd be happy to provide a patch for either solution.
Make DocHelper robust against failing buildSettings()
-----------------------------------------------------
Key: HBX-1042
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1042
Project: Hibernate Tools
Issue Type: Improvement
Components: hbm2doc
Reporter: Arnout Engelen
Attachments: dochelper.diff.txt
DocHelper calls cfg.buildSettings(). to get the Dialect, default catalog name and default
schema name.
However, cfg.buildSettings() may fail with a HibernateException (example below).
It would be nice to have DocHelper handle this more gracefully. Attached is a simple
patch that does this.
(background: I'd like to use the Configuration I'm getting from a Spring
LocalSessionFactoryBean, which after initial creation leaves its
LocalDataSourceConnectionProvider in a state that yiels a HibernateException when calling
'configure()' on it, which buildSettings() does. Because of this issue, I cannot
use the DocExporter for my Spring-based hibernate configurations)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:55 p.m.
New subject: [Hibernate-JIRA] Commented: (HBX-1042) Make DocHelper robust against failing buildSettings()
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1042?page=c...
]
Max Rydahl Andersen commented on HBX-1042:
------------------------------------------
look into the code...it is trying to get the connection for a reason. Fix that reason ,)
Make DocHelper robust against failing buildSettings()
-----------------------------------------------------
Key: HBX-1042
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1042
Project: Hibernate Tools
Issue Type: Improvement
Components: hbm2doc
Reporter: Arnout Engelen
Attachments: dochelper.diff.txt
DocHelper calls cfg.buildSettings(). to get the Dialect, default catalog name and default
schema name.
However, cfg.buildSettings() may fail with a HibernateException (example below).
It would be nice to have DocHelper handle this more gracefully. Attached is a simple
patch that does this.
(background: I'd like to use the Configuration I'm getting from a Spring
LocalSessionFactoryBean, which after initial creation leaves its
LocalDataSourceConnectionProvider in a state that yiels a HibernateException when calling
'configure()' on it, which buildSettings() does. Because of this issue, I cannot
use the DocExporter for my Spring-based hibernate configurations)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:20 a.m.
New subject: [Hibernate-JIRA] Commented: (HBX-1042) Make DocHelper robust against failing buildSettings()
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1042?page=c...
]
Arnout Engelen commented on HBX-1042:
-------------------------------------
The reason for getting the connection is to find out the default schema, default catalog
and dialect.
Indeed, this information can be found in the Properties. Reading your workaround
suggestion again, you're proposing to take these options from the Properties by
default (and only go to the database if they cannot be found there)? Sounds reasonable to
me.
Make DocHelper robust against failing buildSettings()
-----------------------------------------------------
Key: HBX-1042
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1042
Project: Hibernate Tools
Issue Type: Improvement
Components: hbm2doc
Reporter: Arnout Engelen
Attachments: dochelper.diff.txt
DocHelper calls cfg.buildSettings(). to get the Dialect, default catalog name and default
schema name.
However, cfg.buildSettings() may fail with a HibernateException (example below).
It would be nice to have DocHelper handle this more gracefully. Attached is a simple
patch that does this.
(background: I'd like to use the Configuration I'm getting from a Spring
LocalSessionFactoryBean, which after initial creation leaves its
LocalDataSourceConnectionProvider in a state that yiels a HibernateException when calling
'configure()' on it, which buildSettings() does. Because of this issue, I cannot
use the DocExporter for my Spring-based hibernate configurations)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:04 a.m.
New subject: [Hibernate-JIRA] Commented: (HBX-1042) Make DocHelper robust against failing buildSettings()
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1042?page=c...
]
Max Rydahl Andersen commented on HBX-1042:
------------------------------------------
"The reason for getting the connection is to find out the default schema, default
catalog and dialect."
Dialect yes, catalog and schema no.
build Settings is ok to call. It should not ever go to the db when used from hibernate
tools.
Make DocHelper robust against failing buildSettings()
-----------------------------------------------------
Key: HBX-1042
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1042
Project: Hibernate Tools
Issue Type: Improvement
Components: hbm2doc
Reporter: Arnout Engelen
Attachments: dochelper.diff.txt
DocHelper calls cfg.buildSettings(). to get the Dialect, default catalog name and default
schema name.
However, cfg.buildSettings() may fail with a HibernateException (example below).
It would be nice to have DocHelper handle this more gracefully. Attached is a simple
patch that does this.
(background: I'd like to use the Configuration I'm getting from a Spring
LocalSessionFactoryBean, which after initial creation leaves its
LocalDataSourceConnectionProvider in a state that yiels a HibernateException when calling
'configure()' on it, which buildSettings() does. Because of this issue, I cannot
use the DocExporter for my Spring-based hibernate configurations)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:05 a.m.
New subject: [Hibernate-JIRA] Commented: (HBX-1042) Make DocHelper robust against failing buildSettings()
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1042?page=c...
]
Arnout Engelen commented on HBX-1042:
-------------------------------------
So buildSettings() should be OK to call. However, in my case it is not OK to call (as it
produces the stacktrace pasted at 02/Mar/08).
Is this a bug in Spring (LocalDataSourceConnectionProvider.configure() throwing a
HibernateException), or should Hibernate not be calling
LocalDataSourceConnectionProvider.configure()?
The issue still exists using Spring 3.x.
Make DocHelper robust against failing buildSettings()
-----------------------------------------------------
Key: HBX-1042
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1042
Project: Hibernate Tools
Issue Type: Improvement
Components: hbm2doc
Reporter: Arnout Engelen
Attachments: dochelper.diff.txt
DocHelper calls cfg.buildSettings(). to get the Dialect, default catalog name and default
schema name.
However, cfg.buildSettings() may fail with a HibernateException (example below).
It would be nice to have DocHelper handle this more gracefully. Attached is a simple
patch that does this.
(background: I'd like to use the Configuration I'm getting from a Spring
LocalSessionFactoryBean, which after initial creation leaves its
LocalDataSourceConnectionProvider in a state that yiels a HibernateException when calling
'configure()' on it, which buildSettings() does. Because of this issue, I cannot
use the DocExporter for my Spring-based hibernate configurations)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:44 a.m.
New subject: [Hibernate-JIRA] Commented: (HBX-1042) Make DocHelper robust against failing buildSettings()
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1042?page=c...
]
Max Rydahl Andersen commented on HBX-1042:
------------------------------------------
its a userbug you are running hibernate tools with a configuration that expects its
running in a container.
Override the connection manager via properties and you would not get the exception.
Make DocHelper robust against failing buildSettings()
-----------------------------------------------------
Key: HBX-1042
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1042
Project: Hibernate Tools
Issue Type: Improvement
Components: hbm2doc
Reporter: Arnout Engelen
Attachments: dochelper.diff.txt
DocHelper calls cfg.buildSettings(). to get the Dialect, default catalog name and default
schema name.
However, cfg.buildSettings() may fail with a HibernateException (example below).
It would be nice to have DocHelper handle this more gracefully. Attached is a simple
patch that does this.
(background: I'd like to use the Configuration I'm getting from a Spring
LocalSessionFactoryBean, which after initial creation leaves its
LocalDataSourceConnectionProvider in a state that yiels a HibernateException when calling
'configure()' on it, which buildSettings() does. Because of this issue, I cannot
use the DocExporter for my Spring-based hibernate configurations)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4910
days inactive
5902
days old
hibernate-issues@lists.jboss.org
10 comments
2 participants
participants (2)
-
Arnout Engelen (JIRA) -
Max Rydahl Andersen (JIRA)