2 p.m.
stack overflow when having @Valid on cycle
------------------------------------------
Key: HV-587
URL: https://hibernate.onjira.com/browse/HV-587
Project: Hibernate Validator
Issue Type: Bug
Reporter: Michael G
When I have some entities referencing each other (a cycle), the annotation @Valid is on
the corresponding getters and there is not really something to be validated on these
entities (no @NotNull, ... is present) I end up in a recursion which leads to a stack
overflow.
If there are some @NotNull the detection of cycles does work fine.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:36 p.m.
New subject: [Hibernate-JIRA] Commented: (HV-587) stack overflow when having @Valid on cycle
[
https://hibernate.onjira.com/browse/HV-587?page=com.atlassian.jira.plugin...
]
Hardy Ferentschik commented on HV-587:
--------------------------------------
Can you provide a full test case? It makes it much easier if we get a concrete example.
stack overflow when having @Valid on cycle
------------------------------------------
Key: HV-587
URL: https://hibernate.onjira.com/browse/HV-587
Project: Hibernate Validator
Issue Type: Bug
Reporter: Michael G
When I have some entities referencing each other (a cycle), the annotation @Valid is on
the corresponding getters and there is not really something to be validated on these
entities (no @NotNull, ... is present) I end up in a recursion which leads to a stack
overflow.
If there are some @NotNull the detection of cycles does work fine.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:20 p.m.
New subject: [Hibernate-JIRA] Commented: (HV-587) stack overflow when having @Valid on cycle
[
https://hibernate.onjira.com/browse/HV-587?page=com.atlassian.jira.plugin...
]
Michael G commented on HV-587:
------------------------------
I would assume you have a test suite and create this case at least as quickly as I can
write, zip and attach it.
stack overflow when having @Valid on cycle
------------------------------------------
Key: HV-587
URL: https://hibernate.onjira.com/browse/HV-587
Project: Hibernate Validator
Issue Type: Bug
Reporter: Michael G
When I have some entities referencing each other (a cycle), the annotation @Valid is on
the corresponding getters and there is not really something to be validated on these
entities (no @NotNull, ... is present) I end up in a recursion which leads to a stack
overflow.
If there are some @NotNull the detection of cycles does work fine.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:27 a.m.
New subject: [Hibernate-JIRA] Commented: (HV-587) stack overflow when having @Valid on cycle
[
https://hibernate.onjira.com/browse/HV-587?page=com.atlassian.jira.plugin...
]
Hardy Ferentschik commented on HV-587:
--------------------------------------
{quote}
I would assume you have a test suite and create this case at least as quickly as I can
write, zip and attach it.
{quote}
Sure we have a test harness. In fact a testcase which afaics matches your criteria would
look like this:
{code}
public class CascadedValidationTest {
@Test
@TestForIssue(jiraKey = "HV-587")
public void testNoStackOverflow() {
Validator validator = ValidatorUtil.getValidator();
Foo foo = new Foo();
Set<ConstraintViolation<Foo>> violations = validator.validate( foo );
assertNumberOfViolations( violations, 0 );
}
private static class Foo {
private Bar bar;
private Foo() {
this.bar = new Bar( this );
}
@Valid
public Bar getBar() {
return bar;
}
}
private static class Bar {
private Foo foo;
private Bar(Foo foo) {
this.foo = foo;
}
@Valid
public Foo getFoo() {
return foo;
}
}
}
{code}
This test passes just fine.
The reason I am asking for a test case is so that I can actually reproduce the right
scenario. In your description it is open whether the entities references each other as
part of a one to one relationship or as part of a collection association. It also leaves
open whether there are any other constraints.
Even though a testcase which runs directly in our test harness would be the best, I would
have been happy with some actual example code.
stack overflow when having @Valid on cycle
------------------------------------------
Key: HV-587
URL: https://hibernate.onjira.com/browse/HV-587
Project: Hibernate Validator
Issue Type: Bug
Reporter: Michael G
When I have some entities referencing each other (a cycle), the annotation @Valid is on
the corresponding getters and there is not really something to be validated on these
entities (no @NotNull, ... is present) I end up in a recursion which leads to a stack
overflow.
If there are some @NotNull the detection of cycles does work fine.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:29 a.m.
New subject: [Hibernate-JIRA] Commented: (HV-587) stack overflow when having @Valid on cycle
[
https://hibernate.onjira.com/browse/HV-587?page=com.atlassian.jira.plugin...
]
Hardy Ferentschik commented on HV-587:
--------------------------------------
Btw, which version are you using?
stack overflow when having @Valid on cycle
------------------------------------------
Key: HV-587
URL: https://hibernate.onjira.com/browse/HV-587
Project: Hibernate Validator
Issue Type: Bug
Reporter: Michael G
When I have some entities referencing each other (a cycle), the annotation @Valid is on
the corresponding getters and there is not really something to be validated on these
entities (no @NotNull, ... is present) I end up in a recursion which leads to a stack
overflow.
If there are some @NotNull the detection of cycles does work fine.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:11 a.m.
New subject: [Hibernate-JIRA] Updated: (HV-587) stack overflow when having @Valid on cycle
[
https://hibernate.onjira.com/browse/HV-587?page=com.atlassian.jira.plugin...
]
Michael G updated HV-587:
-------------------------
Attachment: test.zip
Please find attached my test case.
I am using
<groupId>org.hibernate</groupId>
<artifactId>hibernate-validator</artifactId>
<version>4.2.0.Final</version>
The exception is
Exception in thread "main" java.lang.StackOverflowError
at
javax.persistence.spi.PersistenceProviderResolverHolder.getPersistenceProviderResolver(PersistenceProviderResolverHolder.java:39)
at javax.persistence.Persistence.getProviders(Persistence.java:60)
at javax.persistence.Persistence.access$000(Persistence.java:16)
at javax.persistence.Persistence$1.isLoaded(Persistence.java:76)
at
org.hibernate.validator.engine.resolver.JPATraversableResolver.isReachable(JPATraversableResolver.java:61)
at
org.hibernate.validator.engine.resolver.DefaultTraversableResolver.isReachable(DefaultTraversableResolver.java:131)
at
org.hibernate.validator.engine.resolver.SingleThreadCachedTraversableResolver.isReachable(SingleThreadCachedTraversableResolver.java:46)
at
org.hibernate.validator.engine.ValidatorImpl.isCascadeRequired(ValidatorImpl.java:1266)
at
org.hibernate.validator.engine.ValidatorImpl.validateCascadedConstraints(ValidatorImpl.java:472)
at
org.hibernate.validator.engine.ValidatorImpl.validateInContext(ValidatorImpl.java:322)
at
org.hibernate.validator.engine.ValidatorImpl.validateCascadedConstraint(ValidatorImpl.java:613)
at
org.hibernate.validator.engine.ValidatorImpl.validateCascadedConstraints(ValidatorImpl.java:478)
at
org.hibernate.validator.engine.ValidatorImpl.validateInContext(ValidatorImpl.java:322)
at
org.hibernate.validator.engine.ValidatorImpl.validateCascadedConstraint(ValidatorImpl.java:613)
at
org.hibernate.validator.engine.ValidatorImpl.validateCascadedConstraints(ValidatorImpl.java:478)
at
org.hibernate.validator.engine.ValidatorImpl.validateInContext(ValidatorImpl.java:322)
at
org.hibernate.validator.engine.ValidatorImpl.validateCascadedConstraint(ValidatorImpl.java:613)
at
org.hibernate.validator.engine.ValidatorImpl.validateCascadedConstraints(ValidatorImpl.java:478)
at
org.hibernate.validator.engine.ValidatorImpl.validateInContext(ValidatorImpl.java:322)
at
org.hibernate.validator.engine.ValidatorImpl.validateCascadedConstraint(ValidatorImpl.java:613)
at
org.hibernate.validator.engine.ValidatorImpl.validateCascadedConstraints(ValidatorImpl.java:478)
...
stack overflow when having @Valid on cycle
------------------------------------------
Key: HV-587
URL: https://hibernate.onjira.com/browse/HV-587
Project: Hibernate Validator
Issue Type: Bug
Reporter: Michael G
Attachments: test.zip
When I have some entities referencing each other (a cycle), the annotation @Valid is on
the corresponding getters and there is not really something to be validated on these
entities (no @NotNull, ... is present) I end up in a recursion which leads to a stack
overflow.
If there are some @NotNull the detection of cycles does work fine.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:16 a.m.
New subject: [Hibernate-JIRA] Issue Comment Edited: (HV-587) stack overflow when having @Valid on cycle
[
https://hibernate.onjira.com/browse/HV-587?page=com.atlassian.jira.plugin...
]
Hardy Ferentschik edited comment on HV-587 at 5/11/12 9:15 AM:
---------------------------------------------------------------
Please find attached my test case.
I am using:
{noformat}
<groupId>org.hibernate</groupId>
<artifactId>hibernate-validator</artifactId>
<version>4.2.0.Final</version>
{noformat}
The exception is
{noformat}
Exception in thread "main" java.lang.StackOverflowError
at
javax.persistence.spi.PersistenceProviderResolverHolder.getPersistenceProviderResolver(PersistenceProviderResolverHolder.java:39)
at javax.persistence.Persistence.getProviders(Persistence.java:60)
at javax.persistence.Persistence.access$000(Persistence.java:16)
at javax.persistence.Persistence$1.isLoaded(Persistence.java:76)
at
org.hibernate.validator.engine.resolver.JPATraversableResolver.isReachable(JPATraversableResolver.java:61)
at
org.hibernate.validator.engine.resolver.DefaultTraversableResolver.isReachable(DefaultTraversableResolver.java:131)
at
org.hibernate.validator.engine.resolver.SingleThreadCachedTraversableResolver.isReachable(SingleThreadCachedTraversableResolver.java:46)
at
org.hibernate.validator.engine.ValidatorImpl.isCascadeRequired(ValidatorImpl.java:1266)
at
org.hibernate.validator.engine.ValidatorImpl.validateCascadedConstraints(ValidatorImpl.java:472)
at
org.hibernate.validator.engine.ValidatorImpl.validateInContext(ValidatorImpl.java:322)
at
org.hibernate.validator.engine.ValidatorImpl.validateCascadedConstraint(ValidatorImpl.java:613)
at
org.hibernate.validator.engine.ValidatorImpl.validateCascadedConstraints(ValidatorImpl.java:478)
at
org.hibernate.validator.engine.ValidatorImpl.validateInContext(ValidatorImpl.java:322)
at
org.hibernate.validator.engine.ValidatorImpl.validateCascadedConstraint(ValidatorImpl.java:613)
at
org.hibernate.validator.engine.ValidatorImpl.validateCascadedConstraints(ValidatorImpl.java:478)
at
org.hibernate.validator.engine.ValidatorImpl.validateInContext(ValidatorImpl.java:322)
at
org.hibernate.validator.engine.ValidatorImpl.validateCascadedConstraint(ValidatorImpl.java:613)
at
org.hibernate.validator.engine.ValidatorImpl.validateCascadedConstraints(ValidatorImpl.java:478)
at
org.hibernate.validator.engine.ValidatorImpl.validateInContext(ValidatorImpl.java:322)
at
org.hibernate.validator.engine.ValidatorImpl.validateCascadedConstraint(ValidatorImpl.java:613)
at
org.hibernate.validator.engine.ValidatorImpl.validateCascadedConstraints(ValidatorImpl.java:478)
...
{noformat}
was (Author: ztang):
Please find attached my test case.
I am using
<groupId>org.hibernate</groupId>
<artifactId>hibernate-validator</artifactId>
<version>4.2.0.Final</version>
The exception is
Exception in thread "main" java.lang.StackOverflowError
at
javax.persistence.spi.PersistenceProviderResolverHolder.getPersistenceProviderResolver(PersistenceProviderResolverHolder.java:39)
at javax.persistence.Persistence.getProviders(Persistence.java:60)
at javax.persistence.Persistence.access$000(Persistence.java:16)
at javax.persistence.Persistence$1.isLoaded(Persistence.java:76)
at
org.hibernate.validator.engine.resolver.JPATraversableResolver.isReachable(JPATraversableResolver.java:61)
at
org.hibernate.validator.engine.resolver.DefaultTraversableResolver.isReachable(DefaultTraversableResolver.java:131)
at
org.hibernate.validator.engine.resolver.SingleThreadCachedTraversableResolver.isReachable(SingleThreadCachedTraversableResolver.java:46)
at
org.hibernate.validator.engine.ValidatorImpl.isCascadeRequired(ValidatorImpl.java:1266)
at
org.hibernate.validator.engine.ValidatorImpl.validateCascadedConstraints(ValidatorImpl.java:472)
at
org.hibernate.validator.engine.ValidatorImpl.validateInContext(ValidatorImpl.java:322)
at
org.hibernate.validator.engine.ValidatorImpl.validateCascadedConstraint(ValidatorImpl.java:613)
at
org.hibernate.validator.engine.ValidatorImpl.validateCascadedConstraints(ValidatorImpl.java:478)
at
org.hibernate.validator.engine.ValidatorImpl.validateInContext(ValidatorImpl.java:322)
at
org.hibernate.validator.engine.ValidatorImpl.validateCascadedConstraint(ValidatorImpl.java:613)
at
org.hibernate.validator.engine.ValidatorImpl.validateCascadedConstraints(ValidatorImpl.java:478)
at
org.hibernate.validator.engine.ValidatorImpl.validateInContext(ValidatorImpl.java:322)
at
org.hibernate.validator.engine.ValidatorImpl.validateCascadedConstraint(ValidatorImpl.java:613)
at
org.hibernate.validator.engine.ValidatorImpl.validateCascadedConstraints(ValidatorImpl.java:478)
at
org.hibernate.validator.engine.ValidatorImpl.validateInContext(ValidatorImpl.java:322)
at
org.hibernate.validator.engine.ValidatorImpl.validateCascadedConstraint(ValidatorImpl.java:613)
at
org.hibernate.validator.engine.ValidatorImpl.validateCascadedConstraints(ValidatorImpl.java:478)
...
stack overflow when having @Valid on cycle
------------------------------------------
Key: HV-587
URL: https://hibernate.onjira.com/browse/HV-587
Project: Hibernate Validator
Issue Type: Bug
Reporter: Michael G
Attachments: test.zip
When I have some entities referencing each other (a cycle), the annotation @Valid is on
the corresponding getters and there is not really something to be validated on these
entities (no @NotNull, ... is present) I end up in a recursion which leads to a stack
overflow.
If there are some @NotNull the detection of cycles does work fine.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:18 a.m.
New subject: [Hibernate-JIRA] Updated: (HV-587) stack overflow when having @Valid on cycle
[
https://hibernate.onjira.com/browse/HV-587?page=com.atlassian.jira.plugin...
]
Hardy Ferentschik updated HV-587:
---------------------------------
Affects Version/s: 4.2.0.Final
stack overflow when having @Valid on cycle
------------------------------------------
Key: HV-587
URL: https://hibernate.onjira.com/browse/HV-587
Project: Hibernate Validator
Issue Type: Bug
Affects Versions: 4.2.0.Final
Reporter: Michael G
Attachments: test.zip
When I have some entities referencing each other (a cycle), the annotation @Valid is on
the corresponding getters and there is not really something to be validated on these
entities (no @NotNull, ... is present) I end up in a recursion which leads to a stack
overflow.
If there are some @NotNull the detection of cycles does work fine.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:11 a.m.
New subject: [Hibernate-JIRA] Commented: (HV-587) stack overflow when having @Valid on cycle
[
https://hibernate.onjira.com/browse/HV-587?page=com.atlassian.jira.plugin...
]
Hardy Ferentschik commented on HV-587:
--------------------------------------
Ok, I am not able to reproduce the exception using a Arquillian test -
https://github.com/hferentschik/hibernate-validator/tree/HV-587
As you said, adding an actual constraint somewhere makes the test pass. I will look into
it asap. The other question of course is why would add a _@Valid_ annotation without any
actual constraint in the entities?
stack overflow when having @Valid on cycle
------------------------------------------
Key: HV-587
URL: https://hibernate.onjira.com/browse/HV-587
Project: Hibernate Validator
Issue Type: Bug
Affects Versions: 4.2.0.Final
Reporter: Michael G
Attachments: test.zip
When I have some entities referencing each other (a cycle), the annotation @Valid is on
the corresponding getters and there is not really something to be validated on these
entities (no @NotNull, ... is present) I end up in a recursion which leads to a stack
overflow.
If there are some @NotNull the detection of cycles does work fine.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:08 p.m.
New subject: [Hibernate-JIRA] Commented: (HV-587) stack overflow when having @Valid on cycle
[
https://hibernate.onjira.com/browse/HV-587?page=com.atlassian.jira.plugin...
]
Michael G commented on HV-587:
------------------------------
The reason I would like to add @Valid just for every case might be a bit special. All my
entities are generated from a XText DSL and deciding if @Valid is needed or not in the
generation would be a bit tricky.
stack overflow when having @Valid on cycle
------------------------------------------
Key: HV-587
URL: https://hibernate.onjira.com/browse/HV-587
Project: Hibernate Validator
Issue Type: Bug
Affects Versions: 4.2.0.Final
Reporter: Michael G
Attachments: test.zip
When I have some entities referencing each other (a cycle), the annotation @Valid is on
the corresponding getters and there is not really something to be validated on these
entities (no @NotNull, ... is present) I end up in a recursion which leads to a stack
overflow.
If there are some @NotNull the detection of cycles does work fine.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4388
days inactive
4439
days old
hibernate-issues@lists.jboss.org
10 comments
3 participants
participants (3)
-
Gunnar Morling (JIRA) -
Hardy Ferentschik (JIRA)
-
Michael G (JIRA)