[Hibernate-JIRA] Created: (HHH-2971) AbstractFlushingEventListener catches, logs and re-throws HibernateException in performExecutions generating noisy logs

[Hibernate-JIRA] Created:...

craig mcmillan (JIRA)

Monday, 26 November 2007 Mon, 26 Nov '07

7:22 p.m.

AbstractFlushingEventListener catches, logs and re-throws HibernateException in performExecutions generating noisy logs ----------------------------------------------------------------------------------------------------------------------- Key: HHH-2971 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2971 Project: Hibernate3 Issue Type: Bug Components: core Affects Versions: 3.2.5 Environment: v3.2.5 Reporter: craig mcmillan Priority: Minor AbstractFlushingEventListener catches HibernateException, logs an error, and re-throws the same HibernateException... so the Exception gets logged twice, or worse [ in the case i'm looking at, an offline locker ], an expected Exception [ConstraingViolationException] is caught and discarded, but an error is still logged -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

Show replies by date

craig mcmillan (JIRA)

Monday, 26 November Mon, 26 Nov

7:35 p.m.

New subject: [Hibernate-JIRA] Updated: (HHH-2971) AbstractFlushingEventListener catches, logs and re-throws HibernateException in performExecutions generating noisy logs

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2971?page=c... ] craig mcmillan updated HHH-2971: -------------------------------- Attachment: tags.v325.r14204.patch a patch to stop AbstractFlushingEventListener logging excessively

...

AbstractFlushingEventListener catches, logs and re-throws HibernateException in performExecutions generating noisy logs ----------------------------------------------------------------------------------------------------------------------- Key: HHH-2971 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2971 Project: Hibernate3 Issue Type: Bug Components: core Affects Versions: 3.2.5 Environment: v3.2.5 Reporter: craig mcmillan Priority: Minor Attachments: tags.v325.r14204.patch AbstractFlushingEventListener catches HibernateException, logs an error, and re-throws the same HibernateException... so the Exception gets logged twice, or worse [ in the case i'm looking at, an offline locker ], an expected Exception [ConstraingViolationException] is caught and discarded, but an error is still logged

-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

Diego Pires Plentz (JIRA)

Saturday, 8 December Sat, 8 Dec

11:26 p.m.

New subject: [Hibernate-JIRA] Resolved: (HHH-2971) AbstractFlushingEventListener catches, logs and re-throws HibernateException in performExecutions generating noisy logs

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2971?page=c... ] Diego Pires Plentz resolved HHH-2971. ------------------------------------- Assignee: Diego Pires Plentz Resolution: Rejected And what is the problem of logging the exception? It doesn't change the behavior of your application, so, just ignore it ;-)

...

AbstractFlushingEventListener catches, logs and re-throws HibernateException in performExecutions generating noisy logs ----------------------------------------------------------------------------------------------------------------------- Key: HHH-2971 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2971 Project: Hibernate3 Issue Type: Bug Components: core Affects Versions: 3.2.5 Environment: v3.2.5 Reporter: craig mcmillan Assignee: Diego Pires Plentz Priority: Minor Attachments: tags.v325.r14204.patch AbstractFlushingEventListener catches HibernateException, logs an error, and re-throws the same HibernateException... so the Exception gets logged twice, or worse [ in the case i'm looking at, an offline locker ], an expected Exception [ConstraingViolationException] is caught and discarded, but an error is still logged

craig mcmillan (JIRA)

Friday, 21 December Fri, 21 Dec

4:28 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2971) AbstractFlushingEventListener catches, logs and re-throws HibernateException in performExecutions generating noisy logs

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2971?page=c... ] craig mcmillan commented on HHH-2971: ------------------------------------- i disagree logs should be readable. imagine if every framework caught, logged and re-threw exceptions. logging would be a mess i can of course filter out all logging from AbstractFlushingEventListener, but that sucks what is the point of catching, logging and re-throwing the same exception ?

...

AbstractFlushingEventListener catches, logs and re-throws HibernateException in performExecutions generating noisy logs ----------------------------------------------------------------------------------------------------------------------- Key: HHH-2971 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2971 Project: Hibernate3 Issue Type: Bug Components: core Affects Versions: 3.2.5 Environment: v3.2.5 Reporter: craig mcmillan Assignee: Diego Pires Plentz Priority: Minor Attachments: tags.v325.r14204.patch AbstractFlushingEventListener catches HibernateException, logs an error, and re-throws the same HibernateException... so the Exception gets logged twice, or worse [ in the case i'm looking at, an offline locker ], an expected Exception [ConstraingViolationException] is caught and discarded, but an error is still logged

Andreas Bergander (JIRA)

Wednesday, 5 November Wed, 5 Nov

4:10 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2971) AbstractFlushingEventListener catches, logs and re-throws HibernateException in performExecutions generating noisy logs

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2971?page=c... ] Andreas Bergander commented on HHH-2971: ---------------------------------------- I agree with craig. In a production environment it is of importance to have clean logs so no false alarms are triggered in a log monitoring application. To always log this on error-level seems like a bad idea. Let the application catch the re-thrown exception and choose whether or not this should be logged. Anyone else thinks that this issue should be re-opened?

...

AbstractFlushingEventListener catches, logs and re-throws HibernateException in performExecutions generating noisy logs ----------------------------------------------------------------------------------------------------------------------- Key: HHH-2971 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2971 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.2.5 Environment: v3.2.5 Reporter: craig mcmillan Assignee: Diego Plentz Priority: Minor Attachments: tags.v325.r14204.patch AbstractFlushingEventListener catches HibernateException, logs an error, and re-throws the same HibernateException... so the Exception gets logged twice, or worse [ in the case i'm looking at, an offline locker ], an expected Exception [ConstraingViolationException] is caught and discarded, but an error is still logged

Thomas S (JIRA)

Thursday, 13 August Thu, 13 Aug

8:55 a.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2971) AbstractFlushingEventListener catches, logs and re-throws HibernateException in performExecutions generating noisy logs

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2971?page=c... ] Thomas S commented on HHH-2971: -------------------------------

...

And what is the problem of logging the exception?

As Craig suggest you can filter out logging from AbstractFlushingEventListener but this is only treating the symptons and not fixing the problem. In my case we have customers that buy and install out system. I can't rely on all customers not to configure or change the log filter. In case they don't filter out those messages we will have them on the phone, and maybe even accept an error report on the exception, causing everybody to waste their time. Instead I would like Diego to explain why the log statement is needed when you rethrow the exception? Removing the log statement doesn't change the behavior of your application ;-)

...

AbstractFlushingEventListener catches, logs and re-throws HibernateException in performExecutions generating noisy logs ----------------------------------------------------------------------------------------------------------------------- Key: HHH-2971 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2971 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.2.5 Environment: v3.2.5 Reporter: craig mcmillan Assignee: Diego Plentz Priority: Minor Attachments: tags.v325.r14204.patch AbstractFlushingEventListener catches HibernateException, logs an error, and re-throws the same HibernateException... so the Exception gets logged twice, or worse [ in the case i'm looking at, an offline locker ], an expected Exception [ConstraingViolationException] is caught and discarded, but an error is still logged

Geoffrey De Smet (JIRA)

Monday, 7 September Mon, 7 Sep

2:04 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2971) AbstractFlushingEventListener catches, logs and re-throws HibernateException in performExecutions generating noisy logs

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2971?page=c... ] Geoffrey De Smet commented on HHH-2971: --------------------------------------- +1 to reopen Most experts agree that catch-log-rethrow is bad code.

...

AbstractFlushingEventListener catches, logs and re-throws HibernateException in performExecutions generating noisy logs ----------------------------------------------------------------------------------------------------------------------- Key: HHH-2971 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2971 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.2.5 Environment: v3.2.5 Reporter: craig mcmillan Assignee: Diego Plentz Priority: Minor Attachments: tags.v325.r14204.patch AbstractFlushingEventListener catches HibernateException, logs an error, and re-throws the same HibernateException... so the Exception gets logged twice, or worse [ in the case i'm looking at, an offline locker ], an expected Exception [ConstraingViolationException] is caught and discarded, but an error is still logged

John Kristian (JIRA)

Thursday, 22 July Thu, 22 Jul

1:11 a.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2971) AbstractFlushingEventListener catches, logs and re-throws HibernateException in performExecutions generating noisy logs

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2971?page=c... ] John Kristian commented on HHH-2971: ------------------------------------ +1 to reopen

...

AbstractFlushingEventListener catches, logs and re-throws HibernateException in performExecutions generating noisy logs ----------------------------------------------------------------------------------------------------------------------- Key: HHH-2971 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2971 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.2.5 Environment: v3.2.5 Reporter: craig mcmillan Assignee: Diego Plentz Priority: Minor Attachments: tags.v325.r14204.patch AbstractFlushingEventListener catches HibernateException, logs an error, and re-throws the same HibernateException... so the Exception gets logged twice, or worse [ in the case i'm looking at, an offline locker ], an expected Exception [ConstraingViolationException] is caught and discarded, but an error is still logged

Zohar Shay (JIRA)

Wednesday, 28 July Wed, 28 Jul

10:28 a.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2971) AbstractFlushingEventListener catches, logs and re-throws HibernateException in performExecutions generating noisy logs

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2971?page=c... ] Zohar Shay commented on HHH-2971: --------------------------------- +1 to reopen

...

AbstractFlushingEventListener catches, logs and re-throws HibernateException in performExecutions generating noisy logs ----------------------------------------------------------------------------------------------------------------------- Key: HHH-2971 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2971 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.2.5 Environment: v3.2.5 Reporter: craig mcmillan Assignee: Diego Plentz Priority: Minor Attachments: tags.v325.r14204.patch AbstractFlushingEventListener catches HibernateException, logs an error, and re-throws the same HibernateException... so the Exception gets logged twice, or worse [ in the case i'm looking at, an offline locker ], an expected Exception [ConstraingViolationException] is caught and discarded, but an error is still logged

Alex Peters (JIRA)

Friday, 13 August Fri, 13 Aug

6:18 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2971) AbstractFlushingEventListener catches, logs and re-throws HibernateException in performExecutions generating noisy logs

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2971?page=c... ] Alex Peters commented on HHH-2971: ---------------------------------- +1 to reopen

...

AbstractFlushingEventListener catches, logs and re-throws HibernateException in performExecutions generating noisy logs ----------------------------------------------------------------------------------------------------------------------- Key: HHH-2971 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2971 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.2.5 Environment: v3.2.5 Reporter: craig mcmillan Assignee: Diego Plentz Priority: Minor Attachments: tags.v325.r14204.patch AbstractFlushingEventListener catches HibernateException, logs an error, and re-throws the same HibernateException... so the Exception gets logged twice, or worse [ in the case i'm looking at, an offline locker ], an expected Exception [ConstraingViolationException] is caught and discarded, but an error is still logged

Mark Malynn (JIRA)

Thursday, 4 November Thu, 4 Nov

5:22 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2971) AbstractFlushingEventListener catches, logs and re-throws HibernateException in performExecutions generating noisy logs

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2971?page=c... ] Mark Malynn commented on HHH-2971: ---------------------------------- +1 to reopen

...

AbstractFlushingEventListener catches, logs and re-throws HibernateException in performExecutions generating noisy logs ----------------------------------------------------------------------------------------------------------------------- Key: HHH-2971 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2971 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.2.5 Environment: v3.2.5 Reporter: craig mcmillan Assignee: Diego Plentz Priority: Minor Attachments: tags.v325.r14204.patch AbstractFlushingEventListener catches HibernateException, logs an error, and re-throws the same HibernateException... so the Exception gets logged twice, or worse [ in the case i'm looking at, an offline locker ], an expected Exception [ConstraingViolationException] is caught and discarded, but an error is still logged

Diego Plentz (JIRA)

Tuesday, 9 November Tue, 9 Nov

12:40 a.m.

New subject: [Hibernate-JIRA] Reopened: (HHH-2971) AbstractFlushingEventListener catches, logs and re-throws HibernateException in performExecutions generating noisy logs

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2971?page=c... ] Diego Plentz reopened HHH-2971: -------------------------------

...

AbstractFlushingEventListener catches, logs and re-throws HibernateException in performExecutions generating noisy logs ----------------------------------------------------------------------------------------------------------------------- Key: HHH-2971 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2971 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.2.5 Environment: v3.2.5 Reporter: craig mcmillan Assignee: Diego Plentz Priority: Minor Attachments: tags.v325.r14204.patch AbstractFlushingEventListener catches HibernateException, logs an error, and re-throws the same HibernateException... so the Exception gets logged twice, or worse [ in the case i'm looking at, an offline locker ], an expected Exception [ConstraingViolationException] is caught and discarded, but an error is still logged

Markus Merder (JIRA)

Wednesday, 16 February Wed, 16 Feb

7:19 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2971) AbstractFlushingEventListener catches, logs and re-throws HibernateException in performExecutions generating noisy logs

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2971?page=c... ] Markus Merder commented on HHH-2971: ------------------------------------ This issue also affects version 3.3.1. I think the priority should be more than minor, as many production environments are monitored and should not log errors that are no errors. for example you could get a StaleObjectStateException in case you use optimistic locking. This is a common case in multi-user environments and should not cause a log if you catch that exception.

...

AbstractFlushingEventListener catches, logs and re-throws HibernateException in performExecutions generating noisy logs ----------------------------------------------------------------------------------------------------------------------- Key: HHH-2971 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2971 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.2.5 Environment: v3.2.5 Reporter: craig mcmillan Assignee: Diego Plentz Priority: Minor Attachments: tags.v325.r14204.patch AbstractFlushingEventListener catches HibernateException, logs an error, and re-throws the same HibernateException... so the Exception gets logged twice, or worse [ in the case i'm looking at, an offline locker ], an expected Exception [ConstraingViolationException] is caught and discarded, but an error is still logged

Paulo Ricardo Ribeiro (JIRA)

Thursday, 25 August Thu, 25 Aug

12:55 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2971) AbstractFlushingEventListener catches, logs and re-throws HibernateException in performExecutions generating noisy logs

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2971?page=c... ] Paulo Ricardo Ribeiro commented on HHH-2971: -------------------------------------------- As Thomas S said, if we have external costumers, it's a bad thing for them to see those logs, when it is not an actual appication error. Stack traces shouldn't appear on logs, because on most of the times that means that an unexpected exception occured;

...

AbstractFlushingEventListener catches, logs and re-throws HibernateException in performExecutions generating noisy logs ----------------------------------------------------------------------------------------------------------------------- Key: HHH-2971 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2971 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.2.5 Environment: v3.2.5 Reporter: craig mcmillan Assignee: Diego Plentz Priority: Minor Attachments: tags.v325.r14204.patch AbstractFlushingEventListener catches HibernateException, logs an error, and re-throws the same HibernateException... so the Exception gets logged twice, or worse [ in the case i'm looking at, an offline locker ], an expected Exception [ConstraingViolationException] is caught and discarded, but an error is still logged

-- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

Paulo Ricardo Ribeiro (JIRA)

12:57 p.m.

New subject: [Hibernate-JIRA] Issue Comment Edited: (HHH-2971) AbstractFlushingEventListener catches, logs and re-throws HibernateException in performExecutions generating noisy logs

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2971?page=c... ] Paulo Ricardo Ribeiro edited comment on HHH-2971 at 8/25/11 5:55 AM: --------------------------------------------------------------------- As Thomas S said, if we have external costumers, it's a bad thing for them to see those logs, when it is not an actual application error. Stack traces shouldn't appear on logs, because on most of the times that means that an unexpected exception occured; was (Author: pribeiro): As Thomas S said, if we have external costumers, it's a bad thing for them to see those logs, when it is not an actual appication error. Stack traces shouldn't appear on logs, because on most of the times that means that an unexpected exception occured;

...

AbstractFlushingEventListener catches, logs and re-throws HibernateException in performExecutions generating noisy logs ----------------------------------------------------------------------------------------------------------------------- Key: HHH-2971 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2971 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.2.5 Environment: v3.2.5 Reporter: craig mcmillan Assignee: Diego Plentz Priority: Minor Attachments: tags.v325.r14204.patch AbstractFlushingEventListener catches HibernateException, logs an error, and re-throws the same HibernateException... so the Exception gets logged twice, or worse [ in the case i'm looking at, an offline locker ], an expected Exception [ConstraingViolationException] is caught and discarded, but an error is still logged

-- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

Greg Casbolt (JIRA)

Friday, 24 February Fri, 24 Feb

2:45 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2971) AbstractFlushingEventListener catches, logs and re-throws HibernateException in performExecutions generating noisy logs

[ https://hibernate.onjira.com/browse/HHH-2971?page=com.atlassian.jira.plug... ] Greg Casbolt commented on HHH-2971: ----------------------------------- +1 for the suggested change. Our customers have noticed it too.

...

AbstractFlushingEventListener catches, logs and re-throws HibernateException in performExecutions generating noisy logs ----------------------------------------------------------------------------------------------------------------------- Key: HHH-2971 URL: https://hibernate.onjira.com/browse/HHH-2971 Project: Hibernate ORM Issue Type: Bug Components: core Affects Versions: 3.2.5 Environment: v3.2.5 Reporter: craig mcmillan Assignee: Diego Plentz Priority: Minor Attachments: tags.v325.r14204.patch AbstractFlushingEventListener catches HibernateException, logs an error, and re-throws the same HibernateException... so the Exception gets logged twice, or worse [ in the case i'm looking at, an offline locker ], an expected Exception [ConstraingViolationException] is caught and discarded, but an error is still logged

-- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

4450

days inactive

6001

days old

hibernate-issues@lists.jboss.org

Manage subscription

15 comments

13 participants

tags (0)

participants (13)

Alex Peters (JIRA)
Andreas Bergander (JIRA)
craig mcmillan (JIRA)
Diego Pires Plentz (JIRA)
Diego Plentz (JIRA)
Geoffrey De Smet (JIRA)
Greg Casbolt (JIRA)
John Kristian (JIRA)
Mark Malynn (JIRA)
Markus Merder (JIRA)
Paulo Ricardo Ribeiro (JIRA)
Thomas S (JIRA)
Zohar Shay (JIRA)

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

[Hibernate-JIRA] Created: (HHH-2971) AbstractFlushingEventListener catches, logs and re-throws HibernateException in performExecutions generating noisy logs