[Hibernate-JIRA] Created: (HHH-3694) ResultTransformer not used when scroll() is used on a named SQLQuery

[Hibernate-JIRA] Created:...

Oscar Pearce (JIRA)

Wednesday, 7 January 2009 Wed, 7 Jan '09

7:40 p.m.

ResultTransformer not used when scroll() is used on a named SQLQuery -------------------------------------------------------------------- Key: HHH-3694 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3694 Project: Hibernate Core Issue Type: Bug Affects Versions: 3.3.1 Environment: Hibernate Core 3.3.1, PostgreSQL 8.1, HSQLDB 1.8 Reporter: Oscar Pearce Priority: Minor Attachments: sqlqueryrestrans.zip If a ResultTransformer is set on a named SQLQuery, and then scroll() is used on the query, the ResultTransformer is never used. The unit test in the attached Maven project shows this. The fix seems simple - a one-line change in org.hibernate.loader.custom.CustomLoader#getHolderInstantiator(ResultTransformer resultTransformer, String[] queryReturnAliases). The sense of the test of resultTransformer against null should be reversed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

Show replies by date

Shawn Clowater (JIRA)

Wednesday, 5 August Wed, 5 Aug

3:41 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3694) ResultTransformer not used when scroll() is used on a named SQLQuery

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3694?page=c... ] Shawn Clowater commented on HHH-3694: ------------------------------------- The issue I'm currently running into is the fact that the criteria I've supplied to scroll isn't unique and it is ignoring my DistinctRootEntityResultTransformer that I was applying. Even with your suggested change the Distinct Transformer is going to be useless since it would try to distinct on a single tuple basis and just return itself resulting in still having duplicates. I'm not seeing a clear way use a transformer to distinct the results in this case. Path of least resistance for me is to handle it as I'm processing but I'm throwing the distinct out for discussion.

...

-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

Shawn Clowater (JIRA)

3:46 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3694) ResultTransformer not used when scroll() is used on a named SQLQuery

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3694?page=c... ] Shawn Clowater commented on HHH-3694: ------------------------------------- The issue I'm currently running into is duplicates even though my criteria has a DistinctRootEntityResultTransformer set on it. However, even with the supposed fix it would be useless since it would try to distinct based on a single result which would essentially just return the tuple anyways. I would think to do it in the core I'd need some sort of Stateful transformer that could keep track of what it already scrolled over but that gets messy as when the ScrollableResultSet would attempt to get a record it could be a duplicate that you'd want to ignore so it would have to try again. The path of least resistance for me is going to be to keep track of it during my processing (which I have a good point to tie into) but I thought I'd throw out the fact that scroll would return duplicates even if it was properly using a DistinctRootEntityResultTransformer for discussion.

...

Shawn Clowater (JIRA)

3:48 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3694) ResultTransformer not used when scroll() is used on a named SQLQuery

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3694?page=c... ] Shawn Clowater commented on HHH-3694: ------------------------------------- The issue I'm currently running into is duplicates even though my criteria has a DistinctRootEntityResultTransformer set on it. However, even with the supposed fix it would be useless since it would try to distinct based on a single result which would essentially just return the tuple anyways. I would think to do it in the core I'd need some sort of Stateful transformer that could keep track of what it already scrolled over but that gets messy as when the ScrollableResultSet would attempt to get a record it could be a duplicate that you'd want to ignore so it would have to try again. The path of least resistance for me is going to be to keep track of it during my processing (which I have a good point to tie into) but I thought I'd throw out the fact that scroll would return duplicates even if it was properly using a DistinctRootEntityResultTransformer for discussion.

...

Shawn Clowater (JIRA)

3:50 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3694) ResultTransformer not used when scroll() is used on a named SQLQuery

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3694?page=c... ] Shawn Clowater commented on HHH-3694: ------------------------------------- I apologize if my last comment ends up triple posting. I just got an email notification yet it wasn't appearing in the JIRA post.

...

Angel (JIRA)

Thursday, 11 February Thu, 11 Feb

1 a.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3694) ResultTransformer not used when scroll() is used on a named SQLQuery

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3694?page=c... ] Angel commented on HHH-3694: ---------------------------- Why this bug does not appear in the issues summary for 3.3.X: http://opensource.atlassian.com/projects/hibernate/browse/HHH/fixforversi... It would be nice to have this feature. Thanks.

...

Angel (JIRA)

6:36 p.m.

New subject: [Hibernate-JIRA] Updated: (HHH-3694) ResultTransformer not used when scroll() is used on a named SQLQuery

...

ResultTransformer not used when scroll() is used on a named SQLQuery -------------------------------------------------------------------- Key: HHH-3694 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3694 Project: Hibernate Core Issue Type: Bug Affects Versions: 3.3.1 Environment: Hibernate Core 3.3.1, PostgreSQL 8.1, HSQLDB 1.8 Reporter: Oscar Pearce Priority: Minor Attachments: CustomLoader.patch, sqlqueryrestrans.zip If a ResultTransformer is set on a named SQLQuery, and then scroll() is used on the query, the ResultTransformer is never used. The unit test in the attached Maven project shows this. The fix seems simple - a one-line change in org.hibernate.loader.custom.CustomLoader#getHolderInstantiator(ResultTransformer resultTransformer, String[] queryReturnAliases). The sense of the test of resultTransformer against null should be reversed.

Angel (JIRA)

6:36 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3694) ResultTransformer not used when scroll() is used on a named SQLQuery

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3694?page=c... ] Angel commented on HHH-3694: ---------------------------- Hi. I have been having a deeper look through the Hibernate code and finally I was able to make it work. The problem is that the only thing I had to do is to comment a few lines in the org.hibernate.loader.custom.CustomLoader.java and I do not understand why those lines where there in the first place, because if you analyze it, they do not make much sense. Also, this code do not have any comments, so I do not know why this control sentence was made for. Now my fear is if after this change I will get any unexpected behaviour, but my tests are still succesful. I am attaching the patch that I have made to make this work. I am using Hibernate 3.2.6 GA Specifically I have to change the method: static private HolderInstantiator getHolderInstantiator(ResultTransformer resultTransformer, String[] queryReturnAliases); and now it look like this: static private HolderInstantiator getHolderInstantiator(ResultTransformer resultTransformer, String[] queryReturnAliases) { // if ( resultTransformer != null ) { // return HolderInstantiator.NOOP_INSTANTIATOR; // } // else { return new HolderInstantiator(resultTransformer, queryReturnAliases); // } } It would be appreciated if someone could notice any problem after applying this patch and leave feedback here. Cheers.

...

ResultTransformer not used when scroll() is used on a named SQLQuery -------------------------------------------------------------------- Key: HHH-3694 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3694 Project: Hibernate Core Issue Type: Bug Affects Versions: 3.3.1 Environment: Hibernate Core 3.3.1, PostgreSQL 8.1, HSQLDB 1.8 Reporter: Oscar Pearce Priority: Minor Attachments: CustomLoader.patch, sqlqueryrestrans.zip If a ResultTransformer is set on a named SQLQuery, and then scroll() is used on the query, the ResultTransformer is never used. The unit test in the attached Maven project shows this. The fix seems simple - a one-line change in org.hibernate.loader.custom.CustomLoader#getHolderInstantiator(ResultTransformer resultTransformer, String[] queryReturnAliases). The sense of the test of resultTransformer against null should be reversed.

Angel (JIRA)

11:05 p.m.

New subject: [Hibernate-JIRA] Updated: (HHH-3694) ResultTransformer not used when scroll() is used on a named SQLQuery

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3694?page=c... ] Angel updated HHH-3694: ----------------------- Attachment: CustomLoader.patch I have just realized that the reported had already offered a solution which I thin is better that just commenting the lines. Anyway I attaching the patch to apply his solution too.

...

ResultTransformer not used when scroll() is used on a named SQLQuery -------------------------------------------------------------------- Key: HHH-3694 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3694 Project: Hibernate Core Issue Type: Bug Affects Versions: 3.3.1 Environment: Hibernate Core 3.3.1, PostgreSQL 8.1, HSQLDB 1.8 Reporter: Oscar Pearce Priority: Minor Attachments: CustomLoader.patch, CustomLoader.patch, sqlqueryrestrans.zip If a ResultTransformer is set on a named SQLQuery, and then scroll() is used on the query, the ResultTransformer is never used. The unit test in the attached Maven project shows this. The fix seems simple - a one-line change in org.hibernate.loader.custom.CustomLoader#getHolderInstantiator(ResultTransformer resultTransformer, String[] queryReturnAliases). The sense of the test of resultTransformer against null should be reversed.

Sharath Reddy (JIRA)

Monday, 3 May Mon, 3 May

9:45 a.m.

New subject: [Hibernate-JIRA] Assigned: (HHH-3694) ResultTransformer not used when scroll() is used on a named SQLQuery

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3694?page=c... ] Sharath Reddy reassigned HHH-3694: ---------------------------------- Assignee: Sharath Reddy

...

ResultTransformer not used when scroll() is used on a named SQLQuery -------------------------------------------------------------------- Key: HHH-3694 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3694 Project: Hibernate Core Issue Type: Bug Affects Versions: 3.3.1 Environment: Hibernate Core 3.3.1, PostgreSQL 8.1, HSQLDB 1.8 Reporter: Oscar Pearce Assignee: Sharath Reddy Priority: Minor Attachments: CustomLoader.patch, CustomLoader.patch, sqlqueryrestrans.zip If a ResultTransformer is set on a named SQLQuery, and then scroll() is used on the query, the ResultTransformer is never used. The unit test in the attached Maven project shows this. The fix seems simple - a one-line change in org.hibernate.loader.custom.CustomLoader#getHolderInstantiator(ResultTransformer resultTransformer, String[] queryReturnAliases). The sense of the test of resultTransformer against null should be reversed.

Sharath Reddy (JIRA)

9:48 a.m.

New subject: [Hibernate-JIRA] Resolved: (HHH-3694) ResultTransformer not used when scroll() is used on a named SQLQuery

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3694?page=c... ] Sharath Reddy resolved HHH-3694. -------------------------------- Resolution: Fixed Fix Version/s: 3.6

...

ResultTransformer not used when scroll() is used on a named SQLQuery -------------------------------------------------------------------- Key: HHH-3694 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3694 Project: Hibernate Core Issue Type: Bug Affects Versions: 3.3.1 Environment: Hibernate Core 3.3.1, PostgreSQL 8.1, HSQLDB 1.8 Reporter: Oscar Pearce Assignee: Sharath Reddy Priority: Minor Fix For: 3.6 Attachments: CustomLoader.patch, CustomLoader.patch, sqlqueryrestrans.zip If a ResultTransformer is set on a named SQLQuery, and then scroll() is used on the query, the ResultTransformer is never used. The unit test in the attached Maven project shows this. The fix seems simple - a one-line change in org.hibernate.loader.custom.CustomLoader#getHolderInstantiator(ResultTransformer resultTransformer, String[] queryReturnAliases). The sense of the test of resultTransformer against null should be reversed.

Gail Badner (JIRA)

Tuesday, 4 May Tue, 4 May

8:02 p.m.

New subject: [Hibernate-JIRA] Reopened: (HHH-3694) ResultTransformer not used when scroll() is used on a named SQLQuery

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3694?page=c... ] Gail Badner reopened HHH-3694: ------------------------------ Sharath, Please backport your fix to Branch_3_5. Thanks, Gail

...

ResultTransformer not used when scroll() is used on a named SQLQuery -------------------------------------------------------------------- Key: HHH-3694 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3694 Project: Hibernate Core Issue Type: Bug Affects Versions: 3.3.1 Environment: Hibernate Core 3.3.1, PostgreSQL 8.1, HSQLDB 1.8 Reporter: Oscar Pearce Assignee: Sharath Reddy Priority: Minor Fix For: 3.5.x, 3.6 Attachments: CustomLoader.patch, CustomLoader.patch, sqlqueryrestrans.zip If a ResultTransformer is set on a named SQLQuery, and then scroll() is used on the query, the ResultTransformer is never used. The unit test in the attached Maven project shows this. The fix seems simple - a one-line change in org.hibernate.loader.custom.CustomLoader#getHolderInstantiator(ResultTransformer resultTransformer, String[] queryReturnAliases). The sense of the test of resultTransformer against null should be reversed.

Gail Badner (JIRA)

8:02 p.m.

New subject: [Hibernate-JIRA] Updated: (HHH-3694) ResultTransformer not used when scroll() is used on a named SQLQuery

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3694?page=c... ] Gail Badner updated HHH-3694: ----------------------------- Fix Version/s: 3.5.x

...

ResultTransformer not used when scroll() is used on a named SQLQuery -------------------------------------------------------------------- Key: HHH-3694 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3694 Project: Hibernate Core Issue Type: Bug Affects Versions: 3.3.1 Environment: Hibernate Core 3.3.1, PostgreSQL 8.1, HSQLDB 1.8 Reporter: Oscar Pearce Assignee: Sharath Reddy Priority: Minor Fix For: 3.5.x, 3.6 Attachments: CustomLoader.patch, CustomLoader.patch, sqlqueryrestrans.zip If a ResultTransformer is set on a named SQLQuery, and then scroll() is used on the query, the ResultTransformer is never used. The unit test in the attached Maven project shows this. The fix seems simple - a one-line change in org.hibernate.loader.custom.CustomLoader#getHolderInstantiator(ResultTransformer resultTransformer, String[] queryReturnAliases). The sense of the test of resultTransformer against null should be reversed.

Gail Badner (JIRA)

Wednesday, 12 May Wed, 12 May

3:06 p.m.

New subject: [Hibernate-JIRA] Updated: (HHH-3694) ResultTransformer not used when scroll() is used on a named SQLQuery

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3694?page=c... ] Gail Badner updated HHH-3694: ----------------------------- Fix Version/s: 3.6

...

ResultTransformer not used when scroll() is used on a named SQLQuery -------------------------------------------------------------------- Key: HHH-3694 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3694 Project: Hibernate Core Issue Type: Bug Affects Versions: 3.3.1 Environment: Hibernate Core 3.3.1, PostgreSQL 8.1, HSQLDB 1.8 Reporter: Oscar Pearce Assignee: Sharath Reddy Priority: Minor Fix For: 3.5.x, 3.6 Attachments: CustomLoader.patch, CustomLoader.patch, sqlqueryrestrans.zip If a ResultTransformer is set on a named SQLQuery, and then scroll() is used on the query, the ResultTransformer is never used. The unit test in the attached Maven project shows this. The fix seems simple - a one-line change in org.hibernate.loader.custom.CustomLoader#getHolderInstantiator(ResultTransformer resultTransformer, String[] queryReturnAliases). The sense of the test of resultTransformer against null should be reversed.

Gail Badner (JIRA)

Monday, 14 June Mon, 14 Jun

2:19 p.m.

New subject: [Hibernate-JIRA] Updated: (HHH-3694) ResultTransformer not used when scroll() is used on a named SQLQuery

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3694?page=c... ] Gail Badner updated HHH-3694: ----------------------------- Fix Version/s: (was: 3.5.3) 3.5.x

...

ResultTransformer not used when scroll() is used on a named SQLQuery -------------------------------------------------------------------- Key: HHH-3694 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3694 Project: Hibernate Core Issue Type: Bug Affects Versions: 3.3.1 Environment: Hibernate Core 3.3.1, PostgreSQL 8.1, HSQLDB 1.8 Reporter: Oscar Pearce Assignee: Sharath Reddy Priority: Minor Fix For: 3.5.x, 3.6 Attachments: CustomLoader.patch, CustomLoader.patch, sqlqueryrestrans.zip If a ResultTransformer is set on a named SQLQuery, and then scroll() is used on the query, the ResultTransformer is never used. The unit test in the attached Maven project shows this. The fix seems simple - a one-line change in org.hibernate.loader.custom.CustomLoader#getHolderInstantiator(ResultTransformer resultTransformer, String[] queryReturnAliases). The sense of the test of resultTransformer against null should be reversed.

Gail Badner (JIRA)

Tuesday, 15 June Tue, 15 Jun

2:21 a.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3694) ResultTransformer not used when scroll() is used on a named SQLQuery

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3694?page=c... ] Gail Badner commented on HHH-3694: ---------------------------------- Sharath, we are planning to release 3.5.3 Wednesday. Will you be able to backport this to Branch_3_5 before Wednesday (US) morning?

...

ResultTransformer not used when scroll() is used on a named SQLQuery -------------------------------------------------------------------- Key: HHH-3694 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3694 Project: Hibernate Core Issue Type: Bug Affects Versions: 3.3.1 Environment: Hibernate Core 3.3.1, PostgreSQL 8.1, HSQLDB 1.8 Reporter: Oscar Pearce Assignee: Sharath Reddy Priority: Minor Fix For: 3.5.x, 3.6 Attachments: CustomLoader.patch, CustomLoader.patch, sqlqueryrestrans.zip If a ResultTransformer is set on a named SQLQuery, and then scroll() is used on the query, the ResultTransformer is never used. The unit test in the attached Maven project shows this. The fix seems simple - a one-line change in org.hibernate.loader.custom.CustomLoader#getHolderInstantiator(ResultTransformer resultTransformer, String[] queryReturnAliases). The sense of the test of resultTransformer against null should be reversed.

Sharath Reddy (JIRA)

Saturday, 3 July Sat, 3 Jul

11:15 a.m.

New subject: [Hibernate-JIRA] Resolved: (HHH-3694) ResultTransformer not used when scroll() is used on a named SQLQuery

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3694?page=c... ] Sharath Reddy resolved HHH-3694. -------------------------------- Resolution: Fixed

...

ResultTransformer not used when scroll() is used on a named SQLQuery -------------------------------------------------------------------- Key: HHH-3694 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3694 Project: Hibernate Core Issue Type: Bug Affects Versions: 3.3.1 Environment: Hibernate Core 3.3.1, PostgreSQL 8.1, HSQLDB 1.8 Reporter: Oscar Pearce Assignee: Sharath Reddy Priority: Minor Fix For: 3.5.x, 3.6 Attachments: CustomLoader.patch, CustomLoader.patch, sqlqueryrestrans.zip If a ResultTransformer is set on a named SQLQuery, and then scroll() is used on the query, the ResultTransformer is never used. The unit test in the attached Maven project shows this. The fix seems simple - a one-line change in org.hibernate.loader.custom.CustomLoader#getHolderInstantiator(ResultTransformer resultTransformer, String[] queryReturnAliases). The sense of the test of resultTransformer against null should be reversed.

5050

days inactive

5591

days old

hibernate-issues@lists.jboss.org

Manage subscription

16 comments

5 participants

tags (0)

participants (5)

Angel (JIRA)
Gail Badner (JIRA)
Oscar Pearce (JIRA)
Sharath Reddy (JIRA)
Shawn Clowater (JIRA)

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

[Hibernate-JIRA] Created: (HHH-3694) ResultTransformer not used when scroll() is used on a named SQLQuery