[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5372?page=c... ] Matthew B. Jones updated HHH-5372: ---------------------------------- Attachment: revend_queries.txt Provided patch (co-written by Chris Bates) which optionally changes the queries Envers uses if the strategy is enabled, to use the REVEND columns for dramatic performance improvements. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5372?page=c... ] Erik-Berndt Scheper commented on HHH-5372: ------------------------------------------ This issue is related to HHH-5371. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5372?page=c... ] Adam Warski commented on HHH-5372: ---------------------------------- The patch is almost good, I'd only like to see the comments on the methods update too - because they are now out of sync with the code. Also, isn't the code for generating: // e.revision <= _revision and (e.endRevision > _revision or e.endRevision is null) duplicated? (OneAuditEntityQueryGenerator, OneEntityQueryGenerator, QueryGeneratorTools)? Maybe it could be a method on an AuditStrategy, so that an ugly class-check could be avoided? In the before mentioned classes, the "maxERevQb" object is always created, but only used for the default auditing strategy. Luckily, no more tests here are necessary, as all tests run twice now: with the two different audit strategies. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5372?page=c... ] Erik-Berndt Scheper commented on HHH-5372: ------------------------------------------ First of all: great news; thanks for reviewing the initial patch! I have attached a new patch file which resolves the issues mentioned above. In order to achieve this, I have changed the following: 1. The org.hibernate.envers.strategy.AuditStrategy interface has been extended with the following methods: {noformat} void addEntityAtRevisionRestriction(AuditConfiguration auditCfg, QueryBuilder rootQueryBuilder, String revisionProperty, String revisionEndProperty, boolean addAlias, MiddleIdData idData, String revisionPropertyPath, String originalIdPropertyName, String alias1, String alias2); void addAssociationAtRevisionRestriction(QueryBuilder rootQueryBuilder, String revisionProperty, String revisionEndProperty, boolean addAlias, MiddleIdData referencingIdData, String versionsMiddleEntityName, String eeOriginalIdPropertyPath, String revisionPropertyPath, String originalIdPropertyName, MiddleComponentData... componentDatas); {noformat} These have been implemented in the DefaultAuditStrategy and the ValidTimeAuditStrategy using Matthew's code (thanks). The DefaultAuditStrategy uses subqueries, whereas the ValidTimeAuditStrategy uses the new end-revision column which greatly improves performance. 2. The class org.hibernate.envers.entities.mapper.relation.query.QueryGeneratorTools has been removed. This code is now implemented in the two AuditStrategy implementations 3. All code-duplicates of the subquery creation / end-revision where clause have been replaced by calls to the AuditStrategy 4. The 'ugly class check' against ValidTimeAuditStrategy has been removed. This required some minor changes in the initial configuration, including AuditConfiguration, EntitiesConfigurator, AuditMetadataGenerator, CollectionMetadataGenerator, QueryGeneratorBuilder. 5. A subquery builder is only created when it is used (in DefaultAuditStrategy). Hopefully this issue can now be resolved; but as always: further improvements are welcome! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5372?page=c... ] Erik-Berndt Scheper updated HHH-5372: ------------------------------------- Attachment: HHH-5372-revend_queries-revised-20100907-v2.patch Same patch file, but with Unix line endings. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira