[Hibernate-JIRA] Created: (HHH-5944) Refresh of an entity should clear its entries in the action queue
1:29 a.m.
Refresh of an entity should clear its entries in the action queue
-----------------------------------------------------------------
Key: HHH-5944
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5944
Project: Hibernate Core
Issue Type: New Feature
Components: core
Affects Versions: 3.3.2
Environment: JBoss 4.2.3
Spring 2.5.5
Reporter: Jonas Olsson
We're using optimistic locking for some statistics entities and are doing re-tries on
StaleObjectStateException by refreshing the entity and re-applying our update. However,
this fails in the same way every time as the failed update lingers in the action queue and
is flushed before the changed update.
Shouldn't/Couldn't refresh clear the action queue from actions of the given
entity? As it is now it's quite nasty as you think you know what the instance looks
like, but there is a hidden update just waiting for a flush.
Our work-around is to cast Session to EventSource and clear the action queue ourselves (we
pre-flush the session before the optimistic locking update to ensure the failed update is
the only one queued), but that feels a bit like a hack.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:06 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5944) Refresh of an entity should clear its entries in the action queue
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5944?page=c...
]
Lukasz Antoniak commented on HHH-5944:
--------------------------------------
Pull request submitted: https://github.com/hibernate/hibernate-core/pull/177
Refresh of an entity should clear its entries in the action queue
-----------------------------------------------------------------
Key: HHH-5944
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5944
Project: Hibernate Core
Issue Type: New Feature
Components: core
Affects Versions: 3.3.2
Environment: JBoss 4.2.3
Spring 2.5.5
Reporter: Jonas Olsson
We're using optimistic locking for some statistics entities and are doing re-tries on
StaleObjectStateException by refreshing the entity and re-applying our update. However,
this fails in the same way every time as the failed update lingers in the action queue and
is flushed before the changed update.
Shouldn't/Couldn't refresh clear the action queue from actions of the given
entity? As it is now it's quite nasty as you think you know what the instance looks
like, but there is a hidden update just waiting for a flush.
Our work-around is to cast Session to EventSource and clear the action queue ourselves
(we pre-flush the session before the optimistic locking update to ensure the failed update
is the only one queued), but that feels a bit like a hack.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:34 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5944) Refresh of an entity should clear its entries in the action queue
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5944?page=c...
]
Strong Liu commented on HHH-5944:
---------------------------------
this is a bad idea, see
https://forum.hibernate.org/viewtopic.php?t=942461&highlight=retry for details
Refresh of an entity should clear its entries in the action queue
-----------------------------------------------------------------
Key: HHH-5944
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5944
Project: Hibernate Core
Issue Type: New Feature
Components: core
Affects Versions: 3.3.2
Environment: JBoss 4.2.3
Spring 2.5.5
Reporter: Jonas Olsson
We're using optimistic locking for some statistics entities and are doing re-tries on
StaleObjectStateException by refreshing the entity and re-applying our update. However,
this fails in the same way every time as the failed update lingers in the action queue and
is flushed before the changed update.
Shouldn't/Couldn't refresh clear the action queue from actions of the given
entity? As it is now it's quite nasty as you think you know what the instance looks
like, but there is a hidden update just waiting for a flush.
Our work-around is to cast Session to EventSource and clear the action queue ourselves
(we pre-flush the session before the optimistic locking update to ensure the failed update
is the only one queued), but that feels a bit like a hack.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:34 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5944) Refresh of an entity should clear its entries in the action queue
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5944?page=c...
]
Strong Liu commented on HHH-5944:
---------------------------------
I'm leaving this open in case you want to discuss more
Refresh of an entity should clear its entries in the action queue
-----------------------------------------------------------------
Key: HHH-5944
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5944
Project: Hibernate Core
Issue Type: New Feature
Components: core
Affects Versions: 3.3.2
Environment: JBoss 4.2.3
Spring 2.5.5
Reporter: Jonas Olsson
Assignee: Strong Liu
We're using optimistic locking for some statistics entities and are doing re-tries on
StaleObjectStateException by refreshing the entity and re-applying our update. However,
this fails in the same way every time as the failed update lingers in the action queue and
is flushed before the changed update.
Shouldn't/Couldn't refresh clear the action queue from actions of the given
entity? As it is now it's quite nasty as you think you know what the instance looks
like, but there is a hidden update just waiting for a flush.
Our work-around is to cast Session to EventSource and clear the action queue ourselves
(we pre-flush the session before the optimistic locking update to ensure the failed update
is the only one queued), but that feels a bit like a hack.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:34 p.m.
New subject: [Hibernate-JIRA] Assigned: (HHH-5944) Refresh of an entity should clear its entries in the action queue
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5944?page=c...
]
Strong Liu reassigned HHH-5944:
-------------------------------
Assignee: Strong Liu
Refresh of an entity should clear its entries in the action queue
-----------------------------------------------------------------
Key: HHH-5944
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5944
Project: Hibernate Core
Issue Type: New Feature
Components: core
Affects Versions: 3.3.2
Environment: JBoss 4.2.3
Spring 2.5.5
Reporter: Jonas Olsson
Assignee: Strong Liu
We're using optimistic locking for some statistics entities and are doing re-tries on
StaleObjectStateException by refreshing the entity and re-applying our update. However,
this fails in the same way every time as the failed update lingers in the action queue and
is flushed before the changed update.
Shouldn't/Couldn't refresh clear the action queue from actions of the given
entity? As it is now it's quite nasty as you think you know what the instance looks
like, but there is a hidden update just waiting for a flush.
Our work-around is to cast Session to EventSource and clear the action queue ourselves
(we pre-flush the session before the optimistic locking update to ensure the failed update
is the only one queued), but that feels a bit like a hack.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:28 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5944) Refresh of an entity should clear its entries in the action queue
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5944?page=c...
]
Lukasz Antoniak commented on HHH-5944:
--------------------------------------
I don't know if I understood the forum topic in 100% and got the actual idea behind
it. You suggest that after clearing action queue, it would be difficult to automatically
retry saving changes. Am I right? See Rob Jellinghaus message posted on Mon Oct 17, 2005
6:47 pm. Is this the problematic line: {{session.refresh(objectToUpdate,
LockMode.UPGRADE);}} ? If so, maybe we shall introduce a new LockMode/LockOptions that
would clear action queue.
Sorry if I understood the forum topic incorrectly.
Refresh of an entity should clear its entries in the action queue
-----------------------------------------------------------------
Key: HHH-5944
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5944
Project: Hibernate Core
Issue Type: New Feature
Components: core
Affects Versions: 3.3.2
Environment: JBoss 4.2.3
Spring 2.5.5
Reporter: Jonas Olsson
Assignee: Strong Liu
We're using optimistic locking for some statistics entities and are doing re-tries on
StaleObjectStateException by refreshing the entity and re-applying our update. However,
this fails in the same way every time as the failed update lingers in the action queue and
is flushed before the changed update.
Shouldn't/Couldn't refresh clear the action queue from actions of the given
entity? As it is now it's quite nasty as you think you know what the instance looks
like, but there is a hidden update just waiting for a flush.
Our work-around is to cast Session to EventSource and clear the action queue ourselves
(we pre-flush the session before the optimistic locking update to ensure the failed update
is the only one queued), but that feels a bit like a hack.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:09 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5944) Refresh of an entity should clear its entries in the action queue
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5944?page=c...
]
Strong Liu commented on HHH-5944:
---------------------------------
http://docs.jboss.org/hibernate/core/3.6/reference/en-US/html/transaction...
{quote}
If the Session throws an exception, including any SQLException, immediately rollback the
database transaction, call Session.close() and discard the Session instance. Certain
methods of Session will not leave the session in a consistent state. No exception thrown
by Hibernate can be treated as recoverable. Ensure that the Session will be closed by
calling close() in a finally block.
{quote}
Refresh of an entity should clear its entries in the action queue
-----------------------------------------------------------------
Key: HHH-5944
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5944
Project: Hibernate Core
Issue Type: New Feature
Components: core
Affects Versions: 3.3.2
Environment: JBoss 4.2.3
Spring 2.5.5
Reporter: Jonas Olsson
Assignee: Strong Liu
We're using optimistic locking for some statistics entities and are doing re-tries on
StaleObjectStateException by refreshing the entity and re-applying our update. However,
this fails in the same way every time as the failed update lingers in the action queue and
is flushed before the changed update.
Shouldn't/Couldn't refresh clear the action queue from actions of the given
entity? As it is now it's quite nasty as you think you know what the instance looks
like, but there is a hidden update just waiting for a flush.
Our work-around is to cast Session to EventSource and clear the action queue ourselves
(we pre-flush the session before the optimistic locking update to ensure the failed update
is the only one queued), but that feels a bit like a hack.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:17 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5944) Refresh of an entity should clear its entries in the action queue
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5944?page=c...
]
Lukasz Antoniak commented on HHH-5944:
--------------------------------------
Thanks for explanation. Issue can be closed from my point of view.
Refresh of an entity should clear its entries in the action queue
-----------------------------------------------------------------
Key: HHH-5944
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5944
Project: Hibernate Core
Issue Type: New Feature
Components: core
Affects Versions: 3.3.2
Environment: JBoss 4.2.3
Spring 2.5.5
Reporter: Jonas Olsson
Assignee: Strong Liu
We're using optimistic locking for some statistics entities and are doing re-tries on
StaleObjectStateException by refreshing the entity and re-applying our update. However,
this fails in the same way every time as the failed update lingers in the action queue and
is flushed before the changed update.
Shouldn't/Couldn't refresh clear the action queue from actions of the given
entity? As it is now it's quite nasty as you think you know what the instance looks
like, but there is a hidden update just waiting for a flush.
Our work-around is to cast Session to EventSource and clear the action queue ourselves
(we pre-flush the session before the optimistic locking update to ensure the failed update
is the only one queued), but that feels a bit like a hack.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:31 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5944) Refresh of an entity should clear its entries in the action queue
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5944?page=c...
]
Jonas Olsson commented on HHH-5944:
-----------------------------------
I've also read that documentation and I don't accept it as an excuse to not
support this. However, considering that's an "assumption" in Hibernate, what
I'm asking for could very well be considered too much effort/risk (and that's an
excuse I accept).
It just seems a bit weak that optimistic locking automatically pushes all retry mechanisms
to outside the ongoing transaction/session, probably into code that's not necessarily
aware of optimistic locking at all.
Refresh of an entity should clear its entries in the action queue
-----------------------------------------------------------------
Key: HHH-5944
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5944
Project: Hibernate Core
Issue Type: New Feature
Components: core
Affects Versions: 3.3.2
Environment: JBoss 4.2.3
Spring 2.5.5
Reporter: Jonas Olsson
Assignee: Strong Liu
We're using optimistic locking for some statistics entities and are doing re-tries on
StaleObjectStateException by refreshing the entity and re-applying our update. However,
this fails in the same way every time as the failed update lingers in the action queue and
is flushed before the changed update.
Shouldn't/Couldn't refresh clear the action queue from actions of the given
entity? As it is now it's quite nasty as you think you know what the instance looks
like, but there is a hidden update just waiting for a flush.
Our work-around is to cast Session to EventSource and clear the action queue ourselves
(we pre-flush the session before the optimistic locking update to ensure the failed update
is the only one queued), but that feels a bit like a hack.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:58 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5944) Refresh of an entity should clear its entries in the action queue
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5944?page=c...
]
Strong Liu commented on HHH-5944:
---------------------------------
Jonas,
no, that's is not 'too much effort/risk' but design.
that's how we design Session, it is a light weight Object, and should be throw away
once there is a hibernate exception thrown.
Refresh of an entity should clear its entries in the action queue
-----------------------------------------------------------------
Key: HHH-5944
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5944
Project: Hibernate Core
Issue Type: New Feature
Components: core
Affects Versions: 3.3.2
Environment: JBoss 4.2.3
Spring 2.5.5
Reporter: Jonas Olsson
Assignee: Strong Liu
We're using optimistic locking for some statistics entities and are doing re-tries on
StaleObjectStateException by refreshing the entity and re-applying our update. However,
this fails in the same way every time as the failed update lingers in the action queue and
is flushed before the changed update.
Shouldn't/Couldn't refresh clear the action queue from actions of the given
entity? As it is now it's quite nasty as you think you know what the instance looks
like, but there is a hidden update just waiting for a flush.
Our work-around is to cast Session to EventSource and clear the action queue ourselves
(we pre-flush the session before the optimistic locking update to ensure the failed update
is the only one queued), but that feels a bit like a hack.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8 a.m.
New subject: [Hibernate-JIRA] Resolved: (HHH-5944) Refresh of an entity should clear its entries in the action queue
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5944?page=c...
]
Strong Liu resolved HHH-5944.
-----------------------------
Resolution: Rejected
Refresh of an entity should clear its entries in the action queue
-----------------------------------------------------------------
Key: HHH-5944
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5944
Project: Hibernate Core
Issue Type: New Feature
Components: core
Affects Versions: 3.3.2
Environment: JBoss 4.2.3
Spring 2.5.5
Reporter: Jonas Olsson
Assignee: Strong Liu
We're using optimistic locking for some statistics entities and are doing re-tries on
StaleObjectStateException by refreshing the entity and re-applying our update. However,
this fails in the same way every time as the failed update lingers in the action queue and
is flushed before the changed update.
Shouldn't/Couldn't refresh clear the action queue from actions of the given
entity? As it is now it's quite nasty as you think you know what the instance looks
like, but there is a hidden update just waiting for a flush.
Our work-around is to cast Session to EventSource and clear the action queue ourselves
(we pre-flush the session before the optimistic locking update to ensure the failed update
is the only one queued), but that feels a bit like a hack.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4616
days inactive
4849
days old
hibernate-issues@lists.jboss.org
10 comments
3 participants
participants (3)
-
Jonas Olsson (JIRA) -
Lukasz Antoniak (JIRA)
-
Strong Liu (JIRA)