[ http://opensource.atlassian.com/projects/hibernate/browse/ANN-472?page=co... ] Ted Bergeron commented on ANN-472: ---------------------------------- I am using Hibernate Validator. I do understand I can go on my own and create propritary annotations to solve the reflection part of the problem. This will not solve the part about not being able to declare composite unique constraints in abstract base classes. Further, the wish to see what validation restrictions are in place for an object without having to populate the object and run it throught the ClassValidator is a general desire that can many Hibernate users can benefit from. I have not checked to see if the ClassValidator would actually generate Select statements to validate single column and/or composite unique constraints. (I will be very impressed if it does.) I was thinking that it was limited to the checks in section 4.1.2 of the documentation. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/ANN-472?page=co... ] Ted Bergeron commented on ANN-472: ---------------------------------- I am still puzzled about your suggestion. Currently I do have the annotations in place, and my hibernate generated DDL has the unique constraints set in Oracle. If I insert a row that violates the unique constraint I'll get a SQLException. I'd like to go one better and have my view layer inspect the field of the model bean and on finding a single or composite unique constraint, dynamically generate the DWR code to validate this case. Thus, a user enters the name field, and tabs to other fields. DWR fires off an event that tells my app layers to select the one or combination of fields to check if they exist in Oracle. That returns a boolean to the view which alerts the user to the problem before submit. I know this is only 99% effective due to the race condition, but the SQLException will cover the other 1%. If I try to use the validator for this case, I have to populate a whole bean because getPotentialInvalidValues and getInvalidValues only accept one property otherwise (not multiple for a composite constraint). Then I'd have to iterate over InvalidValue[] just looking for the specific combination of fields. This is where I am confused by your suggestion. Without generating a select, how does the validator check that the unique constraint is not violated? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/ANN-472?page=co... ] Ted Bergeron commented on ANN-472: ---------------------------------- API Extension: getInvalidValues could accept the bean and use Java 5's varargs ability to allow for one or more String propertyNames: public InvalidValue[] getInvalidValues(T bean, String... propertyNames) getPotentialInvalidValues would have to accept a Map: public InvalidValue[] getPotentialInvalidValues(Map<String, Object> propertyValueMap) Now you've got me thinking about the details of doing this exactly right. The validations need to honor priorities. IE, if instead of name, I am putting unique constraints on an email property, I'd best make sure the user input passes basic validation first. No sense in hitting the database looking to see if invalid data would violate a unique constraint. My ideal solution is not possible currently, thanks to Java 5's limitations around inheritance and annotation overriding. I'll list the code below in the hopes it gives you an idea, or that java 6/7 makes this possible: in NameableObject ... @Column(name = "name") @Length(min = 1, max = NAME_LENGTH) @NotNull public String getName() { return name; } in LookupObject extends NameableObject ... @Override @Column(name = "name", unique = true) // We add a unique constraint for lookupObjects @Length(min = 1, max = NAME_LENGTH) @NotNull public String getName() { return super.getName(); } in CustomerBoundLookupObject extends LookupObject ... @Override @Unique(composite = true, constraintname = "cust_name") @Column(name = "name") @Length(min = 1, max = NAME_LENGTH) @NotNull public String getName() { return super.getName(); } @Unique(composite = true, constraintname = "cust_name") @NotNull @ManyToOne(cascade = {CascadeType.MERGE, CascadeType.PERSIST}) @JoinColumn(name = "cust_id") public Customer getCustomer() { return customer; } The idea here is that I can query a property via reflection and ask if it needs to be unique, or participates in one or more composite unique constraints. If I find one or more composite constraints, I can iterate over the bean's properties looking for the other properties that belong to the constraint. On finding the 2+ properties, I could generate a select statement with the 2+ columns in the where clause to test if a transient bean would violate my constraint. If the validator would automatically generate the selects when validating, but only if the simple validations all pass, that would be perfect. At the bean level, we could optionally define the constraint much like: @SequenceGenerator We'd give it the meaningless name to match with the @Unique annotation, and the real database name of the constraint. Without the inheritance that is impossible, this would still be useful as is. If you do not agree with any of the above, then at the very least, changing: uniqueConstraints = {@UniqueConstraint(columnNames={"month", "day"})} to use property names vs column names would help with the reflection. (And hibernate can easily derive column names from properties.) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/ANN-472?page=co... ] Diego Pires Plentz updated ANN-472: ----------------------------------- Component/s: binder -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira