11:42 a.m.
Support multi-line import.sql files
-----------------------------------
Key: HHH-2403
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2403
Project: Hibernate3
Type: Improvement
Components: core
Versions: 3.2.2
Reporter: Christian Bauer
I leave this as Major, because it most likely breaks all existing import.sql's.
The statement delimiter in import.sql is currently a newline. We need to change that to:
- delimiter is semicolon, so users can copy/paste stuff from and to SQL consoles
- newline is a real newline, allows users to enter newlines into larger text columns
without a 5000 character wide line
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
3:14 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2403) Support multi-line import.sql files
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2403?page=c...
]
Christian Bauer commented on HHH-2403:
--------------------------------------
Furthermore, popular databases (MySQL...) don't like // as a line comment. We need to
support # and --. This is useful because I want to distribute my import.sql after
development with some initial data for my application - without changing the comments from
Java to SQL.
Support multi-line import.sql files
-----------------------------------
Key: HHH-2403
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2403
Project: Hibernate3
Issue Type: Improvement
Components: core
Affects Versions: 3.2.2
Reporter: Christian Bauer
I leave this as Major, because it most likely breaks all existing import.sql's.
The statement delimiter in import.sql is currently a newline. We need to change that to:
- delimiter is semicolon, so users can copy/paste stuff from and to SQL consoles
- newline is a real newline, allows users to enter newlines into larger text columns
without a 5000 character wide line
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:18 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2403) Support multi-line import.sql files
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2403?page=c...
]
Christian Bauer commented on HHH-2403:
--------------------------------------
OK, disregard this (mostly), I've seen that Max added support for --. Why he
didn't add # I don't know...
Support multi-line import.sql files
-----------------------------------
Key: HHH-2403
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2403
Project: Hibernate3
Issue Type: Improvement
Components: core
Affects Versions: 3.2.2
Reporter: Christian Bauer
I leave this as Major, because it most likely breaks all existing import.sql's.
The statement delimiter in import.sql is currently a newline. We need to change that to:
- delimiter is semicolon, so users can copy/paste stuff from and to SQL consoles
- newline is a real newline, allows users to enter newlines into larger text columns
without a 5000 character wide line
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:11 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2403) Support multi-line import.sql files
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2403?page=c...
]
Max Rydahl Andersen commented on HHH-2403:
------------------------------------------
because -- is in the sql 92 standard, # is not.
Support multi-line import.sql files
-----------------------------------
Key: HHH-2403
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2403
Project: Hibernate3
Issue Type: Improvement
Components: core
Affects Versions: 3.2.2
Reporter: Christian Bauer
I leave this as Major, because it most likely breaks all existing import.sql's.
The statement delimiter in import.sql is currently a newline. We need to change that to:
- delimiter is semicolon, so users can copy/paste stuff from and to SQL consoles
- newline is a real newline, allows users to enter newlines into larger text columns
without a 5000 character wide line
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:16 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2403) Support multi-line import.sql files
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2403?page=c...
]
Yenan Zhou commented on HHH-2403:
---------------------------------
Has this be solved? It seems that this issue has been pending for long time.
I would like to use create statement in import.sql for legacy script, but this issue stuck
me.
Support multi-line import.sql files
-----------------------------------
Key: HHH-2403
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2403
Project: Hibernate3
Issue Type: Improvement
Components: core
Affects Versions: 3.2.2
Reporter: Christian Bauer
I leave this as Major, because it most likely breaks all existing import.sql's.
The statement delimiter in import.sql is currently a newline. We need to change that to:
- delimiter is semicolon, so users can copy/paste stuff from and to SQL consoles
- newline is a real newline, allows users to enter newlines into larger text columns
without a 5000 character wide line
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:59 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-2403) Support multi-line import.sql files
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2403?page=c...
]
vitali yemialyanchyk updated HHH-2403:
--------------------------------------
Attachment: org.hibernate.tool.hbm2ddl.SchemaExport_patch.txt
This simple patch fix the issue - just replace the function -> importScript to version
from org.hibernate.tool.hbm2ddl.SchemaExport_patch.txt
Support multi-line import.sql files
-----------------------------------
Key: HHH-2403
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2403
Project: Hibernate3
Issue Type: Improvement
Components: core
Affects Versions: 3.2.2
Reporter: Christian Bauer
Attachments: org.hibernate.tool.hbm2ddl.SchemaExport_patch.txt
I leave this as Major, because it most likely breaks all existing import.sql's.
The statement delimiter in import.sql is currently a newline. We need to change that to:
- delimiter is semicolon, so users can copy/paste stuff from and to SQL consoles
- newline is a real newline, allows users to enter newlines into larger text columns
without a 5000 character wide line
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:18 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2403) Support multi-line import.sql files
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2403?page=c...
]
Max Rydahl Andersen commented on HHH-2403:
------------------------------------------
how backwards compatible is it ?
Support multi-line import.sql files
-----------------------------------
Key: HHH-2403
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2403
Project: Hibernate3
Issue Type: Improvement
Components: core
Affects Versions: 3.2.2
Reporter: Christian Bauer
Attachments: org.hibernate.tool.hbm2ddl.SchemaExport_patch.txt
I leave this as Major, because it most likely breaks all existing import.sql's.
The statement delimiter in import.sql is currently a newline. We need to change that to:
- delimiter is semicolon, so users can copy/paste stuff from and to SQL consoles
- newline is a real newline, allows users to enter newlines into larger text columns
without a 5000 character wide line
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:29 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2403) Support multi-line import.sql files
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2403?page=c...
]
Vitali Yemialyanchyk commented on HHH-2403:
-------------------------------------------
should be fully backwards compatible. plus I add some support of multiline comments. why
you ask? you see some possible drawbacks?
Support multi-line import.sql files
-----------------------------------
Key: HHH-2403
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2403
Project: Hibernate3
Issue Type: Improvement
Components: core
Affects Versions: 3.2.2
Reporter: Christian Bauer
Attachments: org.hibernate.tool.hbm2ddl.SchemaExport_patch.txt
I leave this as Major, because it most likely breaks all existing import.sql's.
The statement delimiter in import.sql is currently a newline. We need to change that to:
- delimiter is semicolon, so users can copy/paste stuff from and to SQL consoles
- newline is a real newline, allows users to enter newlines into larger text columns
without a 5000 character wide line
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:50 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2403) Support multi-line import.sql files
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2403?page=c...
]
Max Rydahl Andersen commented on HHH-2403:
------------------------------------------
wont current users import.sql's be parsed as one big line of sql instead of multiple
lines with one sql statement ?
Support multi-line import.sql files
-----------------------------------
Key: HHH-2403
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2403
Project: Hibernate3
Issue Type: Improvement
Components: core
Affects Versions: 3.2.2
Reporter: Christian Bauer
Attachments: org.hibernate.tool.hbm2ddl.SchemaExport_patch.txt
I leave this as Major, because it most likely breaks all existing import.sql's.
The statement delimiter in import.sql is currently a newline. We need to change that to:
- delimiter is semicolon, so users can copy/paste stuff from and to SQL consoles
- newline is a real newline, allows users to enter newlines into larger text columns
without a 5000 character wide line
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:31 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2403) Support multi-line import.sql files
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2403?page=c...
]
Vitali Yemialyanchyk commented on HHH-2403:
-------------------------------------------
I cannot answer your question. My thoughts about it -> if it work and perform
functionality that user expect from it - it is not important howto execute it. if the
question concern to transactions or some other possible complexities - I don't
know...
Support multi-line import.sql files
-----------------------------------
Key: HHH-2403
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2403
Project: Hibernate3
Issue Type: Improvement
Components: core
Affects Versions: 3.2.2
Reporter: Christian Bauer
Attachments: org.hibernate.tool.hbm2ddl.SchemaExport_patch.txt
I leave this as Major, because it most likely breaks all existing import.sql's.
The statement delimiter in import.sql is currently a newline. We need to change that to:
- delimiter is semicolon, so users can copy/paste stuff from and to SQL consoles
- newline is a real newline, allows users to enter newlines into larger text columns
without a 5000 character wide line
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:39 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2403) Support multi-line import.sql files
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2403?page=c...
]
Max Rydahl Andersen commented on HHH-2403:
------------------------------------------
if we break every existing hibernate 3.2.x users existing import.sql it is *not* something
we can put in. Then it would wait for 3.3.x.
A thought would be If the parser would be able to just read the whole thing and scan for ;
before newlines and then decide if multiline execution is needed or not then it would work
backwards compatible enough I would think.
Support multi-line import.sql files
-----------------------------------
Key: HHH-2403
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2403
Project: Hibernate3
Issue Type: Improvement
Components: core
Affects Versions: 3.2.2
Reporter: Christian Bauer
Attachments: org.hibernate.tool.hbm2ddl.SchemaExport_patch.txt
I leave this as Major, because it most likely breaks all existing import.sql's.
The statement delimiter in import.sql is currently a newline. We need to change that to:
- delimiter is semicolon, so users can copy/paste stuff from and to SQL consoles
- newline is a real newline, allows users to enter newlines into larger text columns
without a 5000 character wide line
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:51 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2403) Support multi-line import.sql files
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2403?page=c...
]
Vitali Yemialyanchyk commented on HHH-2403:
-------------------------------------------
I expect it should work in 3.2.x as in 3.3.x. it seems dangerous read whole thing cause
potentially it could be too big or rather big.
Support multi-line import.sql files
-----------------------------------
Key: HHH-2403
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2403
Project: Hibernate3
Issue Type: Improvement
Components: core
Affects Versions: 3.2.2
Reporter: Christian Bauer
Attachments: org.hibernate.tool.hbm2ddl.SchemaExport_patch.txt
I leave this as Major, because it most likely breaks all existing import.sql's.
The statement delimiter in import.sql is currently a newline. We need to change that to:
- delimiter is semicolon, so users can copy/paste stuff from and to SQL consoles
- newline is a real newline, allows users to enter newlines into larger text columns
without a 5000 character wide line
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:33 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2403) Support multi-line import.sql files
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2403?page=c...
]
Constantine commented on HHH-2403:
----------------------------------
Please, update "Affects Version" field. Problem still exists for 3.6.x
Support multi-line import.sql files
-----------------------------------
Key: HHH-2403
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2403
Project: Hibernate Core
Issue Type: Improvement
Components: core
Affects Versions: 3.2.2
Reporter: Christian Bauer
Attachments: org.hibernate.tool.hbm2ddl.SchemaExport_patch.txt
I leave this as Major, because it most likely breaks all existing import.sql's.
The statement delimiter in import.sql is currently a newline. We need to change that to:
- delimiter is semicolon, so users can copy/paste stuff from and to SQL consoles
- newline is a real newline, allows users to enter newlines into larger text columns
without a 5000 character wide line
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:06 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2403) Support multi-line import.sql files
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2403?page=c...
]
Lukasz Antoniak commented on HHH-2403:
--------------------------------------
Welcome!
I have developed quite simple ANTLR-based parser for this. It deals much better with
comments and quoted strings then the one attached in the patch.
This script would break Vitali's parser (just a simple example):
{code:sql}
INSERT INTO data(id, text) VALUES(1, 'a very long
/* commented int here */
text'); -- and a comment here :)
{code}
@Max: My solution definitely passes a single SQL statement into
{{Exporter.export(String)}} method at a time.
I will try to introduce it by making a pull request as soon as possible.
Regards,
Lukasz Antoniak
Support multi-line import.sql files
-----------------------------------
Key: HHH-2403
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2403
Project: Hibernate Core
Issue Type: Improvement
Components: core
Affects Versions: 3.2.2
Reporter: Christian Bauer
Attachments: org.hibernate.tool.hbm2ddl.SchemaExport_patch.txt
I leave this as Major, because it most likely breaks all existing import.sql's.
The statement delimiter in import.sql is currently a newline. We need to change that to:
- delimiter is semicolon, so users can copy/paste stuff from and to SQL consoles
- newline is a real newline, allows users to enter newlines into larger text columns
without a 5000 character wide line
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:08 a.m.
New subject: [Hibernate-JIRA] Assigned: (HHH-2403) Support multi-line import.sql files
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2403?page=c...
]
Lukasz Antoniak reassigned HHH-2403:
------------------------------------
Assignee: Lukasz Antoniak
Support multi-line import.sql files
-----------------------------------
Key: HHH-2403
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2403
Project: Hibernate Core
Issue Type: Improvement
Components: core
Affects Versions: 3.2.2
Reporter: Christian Bauer
Assignee: Lukasz Antoniak
Attachments: org.hibernate.tool.hbm2ddl.SchemaExport_patch.txt
I leave this as Major, because it most likely breaks all existing import.sql's.
The statement delimiter in import.sql is currently a newline. We need to change that to:
- delimiter is semicolon, so users can copy/paste stuff from and to SQL consoles
- newline is a real newline, allows users to enter newlines into larger text columns
without a 5000 character wide line
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:47 p.m.
New subject: [Hibernate-JIRA] Resolved: (HHH-2403) Support multi-line import.sql files
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2403?page=c...
]
Lukasz Antoniak resolved HHH-2403.
----------------------------------
Resolution: Fixed
Fix Version/s: 4.0.0.CR6
I haven't noticed that semicolon is not mandatory at the end of each SQL statement.
Since version 4.0.0.CR6 {{hibernate.hbm2ddl.import_files_sql_extractor}} configuration
parameter has been introduced. See Hibernate documentation and JavaDoc of
{{org.hibernate.tool.hbm2ddl.ImportSqlCommandExtractor}} interface and two
implementations: {{org.hibernate.tool.hbm2ddl.SingleLineSqlCommandExtractor}} (default)
and {{org.hibernate.tool.hbm2ddl.MultipleLinesSqlCommandExtractor}}. You can register your
own implementation through configuration parameter or {{ServiceRegistryBuilder}}.
Support multi-line import.sql files
-----------------------------------
Key: HHH-2403
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2403
Project: Hibernate Core
Issue Type: Improvement
Components: core
Affects Versions: 3.2.2
Reporter: Christian Bauer
Assignee: Lukasz Antoniak
Fix For: 4.0.0.CR6
Attachments: org.hibernate.tool.hbm2ddl.SchemaExport_patch.txt
I leave this as Major, because it most likely breaks all existing import.sql's.
The statement delimiter in import.sql is currently a newline. We need to change that to:
- delimiter is semicolon, so users can copy/paste stuff from and to SQL consoles
- newline is a real newline, allows users to enter newlines into larger text columns
without a 5000 character wide line
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4063
days inactive
6286
days old
hibernate-issues@lists.jboss.org
27 comments
11 participants
participants (11)
-
Arnout Engelen (JIRA) -
Christian Bauer (JIRA)
-
Constantine (JIRA)
-
Esen Sagynov (JIRA)
-
Lukasz Antoniak (JIRA)
-
Max Rydahl Andersen (JIRA)
-
Michi (JIRA)
-
Strong Liu (JIRA)
-
Vitali Yemialyanchyk (JIRA)
-
vitali yemialyanchyk (JIRA)
-
Yenan Zhou (JIRA)