11:19 a.m.
CLONE -dropIndex doesn't cound on Dialect
-----------------------------------------
Key: HB-1570
URL: http://opensource.atlassian.com/projects/hibernate/browse/HB-1570
Project: Hibernate2
Type: Bug
Components: core
Versions: 2.1.6
Environment: Hibernate 2.1.6, MySql 4.??
Reporter: Ohad Bruker
In class net.sf.hibernate.mapping.Index method
sqlDropString(Dialect dialect)
doesn't count on dialect, and always makes name of index qualified:
return "drop index " + StringHelper.qualify( table.getQualifiedName(dialect),
name);
This will fail at least in case of MySql DB, because it doesn't understand
{tablename}.{indexname} constructions, but {indexname} only.
I propose next edition:
return "drop index " + (dialect.qualifyIndexName() ? StringHelper.qualify(
table.getQualifiedName(dialect), name) : name);
Is it suitable?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
2:24 a.m.
New subject: [Hibernate-JIRA] Commented: (HB-1570) CLONE -dropIndex doesn't cound on Dialect
[
http://opensource.atlassian.com/projects/hibernate/browse/HB-1570?page=co...
]
Ohad Bruker commented on HB-1570:
---------------------------------
Due to the same reason above the generated SQL for drop index is not correct for Oracle
9i.
drop index {tablename}.{indexname} format is illegal in several databases and should use
the dialect for this statement creation.
Suggested solution:
1) Add to org.hibernate.dialect.Dialect:
public boolean qualifyIndexNameWithTable() {
return true;
}
2) For Oracle9i dialect (and for MySql DB as mentioned above) qualifyIndexNameWithTable
returns false.
3) Update org.hibernate.mapping.Index:
public String sqlDropString(Dialect dialect, String defaultCatalog, String defaultSchema)
{
return "drop index " + dialect.qualifyIndexNameWithTable()
? StringHelper.qualify(table.getQualifiedName(dialect, defaultCatalog, defaultSchema),
name);
: name;
}
CLONE -dropIndex doesn't cound on Dialect
-----------------------------------------
Key: HB-1570
URL: http://opensource.atlassian.com/projects/hibernate/browse/HB-1570
Project: Hibernate2
Type: Bug
Components: core
Versions: 2.1.6
Environment: Hibernate 2.1.6, MySql 4.??
Reporter: Ohad Bruker
In class net.sf.hibernate.mapping.Index method
sqlDropString(Dialect dialect)
doesn't count on dialect, and always makes name of index qualified:
return "drop index " + StringHelper.qualify( table.getQualifiedName(dialect),
name);
This will fail at least in case of MySql DB, because it doesn't understand
{tablename}.{indexname} constructions, but {indexname} only.
I propose next edition:
return "drop index " + (dialect.qualifyIndexName() ? StringHelper.qualify(
table.getQualifiedName(dialect), name) : name);
Is it suitable?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
2:40 a.m.
New subject: [Hibernate-JIRA] Commented: (HB-1570) CLONE -dropIndex doesn't cound on Dialect
[
http://opensource.atlassian.com/projects/hibernate/browse/HB-1570?page=co...
]
Max Rydahl Andersen commented on HB-1570:
-----------------------------------------
2.1.6 is *very* old.
why not submit a patch for Hibernate 3.2 if it is still relevant ?
CLONE -dropIndex doesn't cound on Dialect
-----------------------------------------
Key: HB-1570
URL: http://opensource.atlassian.com/projects/hibernate/browse/HB-1570
Project: Hibernate2
Type: Bug
Components: core
Versions: 2.1.6
Environment: Hibernate 2.1.6, MySql 4.??
Reporter: Ohad Bruker
In class net.sf.hibernate.mapping.Index method
sqlDropString(Dialect dialect)
doesn't count on dialect, and always makes name of index qualified:
return "drop index " + StringHelper.qualify( table.getQualifiedName(dialect),
name);
This will fail at least in case of MySql DB, because it doesn't understand
{tablename}.{indexname} constructions, but {indexname} only.
I propose next edition:
return "drop index " + (dialect.qualifyIndexName() ? StringHelper.qualify(
table.getQualifiedName(dialect), name) : name);
Is it suitable?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
12:28 p.m.
New subject: [Hibernate-JIRA] Commented: (HB-1570) CLONE -dropIndex doesn't cound on Dialect
[
http://opensource.atlassian.com/projects/hibernate/browse/HB-1570?page=co...
]
Diego Pires Plentz commented on HB-1570:
----------------------------------------
Dup. Max, please close this (since I can't :-) )
CLONE -dropIndex doesn't cound on Dialect
-----------------------------------------
Key: HB-1570
URL: http://opensource.atlassian.com/projects/hibernate/browse/HB-1570
Project: Hibernate2
Issue Type: Bug
Components: core
Affects Versions: 2.1.6
Environment: Hibernate 2.1.6, MySql 4.??
Reporter: Ohad Bruker
In class net.sf.hibernate.mapping.Index method
sqlDropString(Dialect dialect)
doesn't count on dialect, and always makes name of index qualified:
return "drop index " + StringHelper.qualify( table.getQualifiedName(dialect),
name);
This will fail at least in case of MySql DB, because it doesn't understand
{tablename}.{indexname} constructions, but {indexname} only.
I propose next edition:
return "drop index " + (dialect.qualifyIndexName() ? StringHelper.qualify(
table.getQualifiedName(dialect), name) : name);
Is it suitable?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:48 p.m.
New subject: [Hibernate-JIRA] Commented: (HB-1570) CLONE -dropIndex doesn't cound on Dialect
[
http://opensource.atlassian.com/projects/hibernate/browse/HB-1570?page=co...
]
Ohad Bruker commented on HB-1570:
---------------------------------
Also different for HSQL database:
drop index <index_name> on <table_name>;
Please don't close this bug, I will provide a patch in a few days.
CLONE -dropIndex doesn't cound on Dialect
-----------------------------------------
Key: HB-1570
URL: http://opensource.atlassian.com/projects/hibernate/browse/HB-1570
Project: Hibernate2
Issue Type: Bug
Components: core
Affects Versions: 2.1.6
Environment: Hibernate 2.1.6, MySql 4.??
Reporter: Ohad Bruker
In class net.sf.hibernate.mapping.Index method
sqlDropString(Dialect dialect)
doesn't count on dialect, and always makes name of index qualified:
return "drop index " + StringHelper.qualify( table.getQualifiedName(dialect),
name);
This will fail at least in case of MySql DB, because it doesn't understand
{tablename}.{indexname} constructions, but {indexname} only.
I propose next edition:
return "drop index " + (dialect.qualifyIndexName() ? StringHelper.qualify(
table.getQualifiedName(dialect), name) : name);
Is it suitable?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:57 p.m.
New subject: [Hibernate-JIRA] Moved: (HHH-3153) CLONE -dropIndex doesn't cound on Dialect
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3153?page=c...
]
Ohad Bruker moved HB-1570 to HHH-3153:
--------------------------------------
Affects Version/s: (was: 2.1.6)
3.2.5
Component/s: (was: core)
core
Workflow: Expanded Workflow (was: jira)
Key: HHH-3153 (was: HB-1570)
Project: Hibernate3 (was: Hibernate2)
CLONE -dropIndex doesn't cound on Dialect
-----------------------------------------
Key: HHH-3153
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3153
Project: Hibernate3
Issue Type: Bug
Components: core
Affects Versions: 3.2.5
Environment: Hibernate 2.1.6, MySql 4.??
Reporter: Ohad Bruker
In class net.sf.hibernate.mapping.Index method
sqlDropString(Dialect dialect)
doesn't count on dialect, and always makes name of index qualified:
return "drop index " + StringHelper.qualify( table.getQualifiedName(dialect),
name);
This will fail at least in case of MySql DB, because it doesn't understand
{tablename}.{indexname} constructions, but {indexname} only.
I propose next edition:
return "drop index " + (dialect.qualifyIndexName() ? StringHelper.qualify(
table.getQualifiedName(dialect), name) : name);
Is it suitable?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:09 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-3153) CLONE -dropIndex doesn't cound on Dialect
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3153?page=c...
]
Ohad Bruker updated HHH-3153:
-----------------------------
Attachment: HHH-3153.patch
This patch produces an appropriate drop index string for each dialect.
It fixes invalid drop index DDL for Oracle, HSQL, MySQL databases.
I have tested it on the following databases:
MS-SQL 2000(and default): DROP INDEX table_name.index_name
Oracle 9i, 10g: DROP INDEX index_name
HSQL: DROP INDEX index_name
MySQL 5.0: DROP INDEX index_name ON table_name
CLONE -dropIndex doesn't cound on Dialect
-----------------------------------------
Key: HHH-3153
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3153
Project: Hibernate3
Issue Type: Bug
Components: core
Affects Versions: 3.2.5
Environment: Hibernate 2.1.6, MySql 4.??
Reporter: Ohad Bruker
Attachments: HHH-3153.patch
In class net.sf.hibernate.mapping.Index method
sqlDropString(Dialect dialect)
doesn't count on dialect, and always makes name of index qualified:
return "drop index " + StringHelper.qualify( table.getQualifiedName(dialect),
name);
This will fail at least in case of MySql DB, because it doesn't understand
{tablename}.{indexname} constructions, but {indexname} only.
I propose next edition:
return "drop index " + (dialect.qualifyIndexName() ? StringHelper.qualify(
table.getQualifiedName(dialect), name) : name);
Is it suitable?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:20 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-3153) DropIndex doesn't cound on Dialect
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3153?page=c...
]
Diego Plentz updated HHH-3153:
------------------------------
Assignee: Diego Plentz
Affects Version/s: (was: 3.2.5)
3.2.6
Summary: DropIndex doesn't cound on Dialect (was: CLONE -dropIndex
doesn't cound on Dialect)
DropIndex doesn't cound on Dialect
----------------------------------
Key: HHH-3153
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3153
Project: Hibernate3
Issue Type: Bug
Components: core
Affects Versions: 3.2.6
Environment: Hibernate 2.1.6, MySql 4.??
Reporter: Ohad Bruker
Assignee: Diego Plentz
Attachments: HHH-3153.patch
In class net.sf.hibernate.mapping.Index method
sqlDropString(Dialect dialect)
doesn't count on dialect, and always makes name of index qualified:
return "drop index " + StringHelper.qualify( table.getQualifiedName(dialect),
name);
This will fail at least in case of MySql DB, because it doesn't understand
{tablename}.{indexname} constructions, but {indexname} only.
I propose next edition:
return "drop index " + (dialect.qualifyIndexName() ? StringHelper.qualify(
table.getQualifiedName(dialect), name) : name);
Is it suitable?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5876
days inactive
6427
days old
hibernate-issues@lists.jboss.org
7 comments
4 participants
participants (4)
-
Diego Pires Plentz (JIRA) -
Diego Plentz (JIRA)
-
Max Rydahl Andersen (JIRA)
-
Ohad Bruker (JIRA)