[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3729?page=c... ] Erik-Berndt Scheper commented on HHH-3729: ------------------------------------------ OK, it took me some time to reproduce this. I think some explanation is required for this testcase, as it is quite elaborate. The main test class to be called is VersionsJoinTableRangeComponentNamingTest.java *The test persists an instance of VersionsJoinTableRangeComponentTestEntity.java (the main entity). *This entity contains two embedded components of type VersionsJoinTableRangeComponent. *The embedded component contains a property 'range' which is a List of Entity-instances. *All properties of these entities are audited. Because of the List inside the component, envers generates two audit join tables. This is correct. Ultimately, what I want to achieve is to rename these audit join tables, using the Envers @AuditJoinTable annotation. This works perfectly fine in simple cases, but not here. Understandably, I cannot add the @AuditJoinTable to the component, because that leads to an "org.hibernate.DuplicateMappingException: Duplicate class/entity mapping", because the component is used twice. For JoinColumns, there is the JPA standard annotation @AssociationOverride(name="range", joinColumns={@JoinColumn(name = "VJTRCTE1_ID", insertable = true, updatable = false, nullable = false)}) which I use in the 'main' entity. My original report meant to say that the following @AuditJoinTable annotation to the entity has no effect (as demonstrated in the testcase). @org.hibernate.envers.AuditJoinTable(name = "JOIN_TABLE_COMPONENT_1_AUD", inverseJoinColumns = @JoinColumn(name = "VJTRTE_ID") However, to maintain consistency with the JPA-spec, I now believe is that we need an extra annotation for the override, like so @AuditJoinTableOverride(name="range", auditJoinTable=(a)org.hibernate.envers.AuditJoinTable(name = "JOIN_TABLE_COMPONENT_1_AUD", inverseJoinColumns = @JoinColumn(name = "VJTRTE_ID")) But I am open to all suggestions. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3729?page=c... ] Erik-Berndt Scheper updated HHH-3729: ------------------------------------- Attachment: envers-HHH-3729-testcases-and-fix.patch Revised integration tests and fix for this issue. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3729?page=c... ] Adam Warski commented on HHH-3729: ---------------------------------- Looks great - I certainly agree that we need @AuditingOverride when there's support for relations in components. One small question though - maybe a better (more consistent) name would be @AuditOverride? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3729?page=c... ] Adam Warski resolved HHH-3729. ------------------------------ Assignee: Adam Warski Resolution: Fixed Fix Version/s: 3.5 Patches applied, using @AuditOverride. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira