Gavin King (
https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%...
) *commented* on HHH-16769 (
https://hibernate.atlassian.net/browse/HHH-16769?atlOrigin=eyJpIjoiMDkyNj...
)
Re: Allow comparing expressions of certain types against a string representation in HQL (
https://hibernate.atlassian.net/browse/HHH-16769?atlOrigin=eyJpIjoiMDkyNj...
)
As Steve says, this is something we need to do in a very careful way. It’s true that
currently we’re much too fussy and reject type conversions that are completely safe.
But we can’t solve this issue by just arbitrarily disabling checks in an undisciplined
way.
Instead we need to write down and properly document which implicit type conversions are
allowed by design and ensure that they work portably across databases. That is we need a
spec and tests.
I see that there is at least one pull request currently opened. I think we should not
integrate any such PRs until we have a proper spec.
Also we need to pay careful attention to what happens when you changed preferred JDBC type
code mappings.
Personally I think we would be better up opening a Discussion about this.
(
https://hibernate.atlassian.net/browse/HHH-16769#add-comment?atlOrigin=ey...
) Add Comment (
https://hibernate.atlassian.net/browse/HHH-16769#add-comment?atlOrigin=ey...
)
Get Jira notifications on your phone! Download the Jira Cloud app for Android (
https://play.google.com/store/apps/details?id=com.atlassian.android.jira....
) or iOS (
https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=Em...
) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:956085d )