[ http://opensource.atlassian.com/projects/hibernate/browse/METAGEN-29?page... ] Hardy Ferentschik commented on METAGEN-29: ------------------------------------------ Here is a "boiled down" version of the problem: {noformat} @MappedSuperclass public abstract class AbstractEntity<T> { @Id @GeneratedValue private Long id; private T foo; public AbstractEntity() { } } {noformat} {noformat} @Entity public class Person extends AbstractEntity<String> { private String name; protected Person() { } public String getName() { return name; } public void setName(String name) { this.name = name; } } {noformat} The problem is that the type visitor in {{AnnotationMetaEntity}} does currently not handle visiting a type variable. The generated meta class {{AbstractEntity_}} should use the upper bound of T for the property. In the example {{SingularAttribute<AbstractEntity, Object>}}. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/METAGEN-29?page... ] Hardy Ferentschik resolved METAGEN-29. -------------------------------------- Resolution: Fixed -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/METAGEN-29?page... ] Hardy Ferentschik commented on METAGEN-29: ------------------------------------------ Right, for some reason the SNAPSHOT was not deployed properly. I uploaded a new SNAPSHOT. I hope it works now. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/METAGEN-29?page... ] Andy Schlaikjer commented on METAGEN-29: ---------------------------------------- bq. The generated meta class AbstractEntity_ should use the upper bound of T for the property. In the example SingularAttribute<AbstractEntity, Object>. I think there's another wrinkle to this bug-- Within {{Person_}}, shouldn't the {{foo}} attribute be redefined to match {{SingularAttribute<Person, String>}} based on {{Person}}'s assignment of {{String}} to {{AbstractEntity}}'s type parameter? Otherwise, in cases where {{foo}} is something more complex, like an Embeddable type, you can't use the generated metamodel to reference components of {{Person_.foo}}. Here's a more complete example: First, we have an Embeddable value type {{Foo}}: {noformat} @Embeddable public class Foo { private String name; } {noformat} Now, a parameterized base class {{Base<T>}}: {noformat} @MappedSuperclass public abstract class Base<T> { private T value; } {noformat} And a refinement of {{Base<T>}}, specifying {{Foo}} as its type parameter: {noformat} @Embeddable public class Fooed extends Base<Foo> { } {noformat} Now, what should our metamodel types be? {{Foo}} is straight-forward: {noformat} @StaticMetamodel(Foo.class) public abstract class Foo_ { public static volatile SingularAttribute<Foo, String> name; } {noformat} {{Base_}} would look something like this: {noformat} @StaticMetamodel(Base.class) public abstract class Base_ { public static volatile SingularAttribute<Base, Object> value; } {noformat} and {{Fooed_}} might look like this: {noformat} @StaticMetamodel(Fooed.class) public abstract class Fooed_ extends Base_ { public static volatile SingularAttribute<Fooed, Foo> value; } {noformat} With {{hibernate-jpamodelgen 1.1.1.Final}}, {{Fooed_}} doesn't get a new definition for {{value}}, which, as far as I can tell, prevents us from creating criteria paths from {{Fooed_.value}} to {{Foo_.name}}. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira