4:02 p.m.
EntityType.deepCopy needs to copy for EntityType.DOM4J
------------------------------------------------------
Key: HHH-2764
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2764
Project: Hibernate3
Issue Type: Bug
Affects Versions: 3.2.2
Environment: Hibernate 3.2.2
Reporter: Alan Krueger
Using DOM4J with a set of composite-elements that contains a many-to-one. When loading
this from the database, the many-to-one piece of the composite-element is disappearing
from the XML. I can see the collection being built and the properties on the elements of
the collection being set, but the many-to-one property disappears after that.
Investigating this, it looks like when PersistentElementHolder.getSnapshot is called and a
deepCopy is performed, the EntityType.deepCopy method returns the value to be copied
rather than copying it. This interacts poorly with the DOM4J tree, since each Element can
only have a single Element parent. When the properties are set on this, a detach is
performed that yanks the original element out of its parent.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:43 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2764) EntityType.deepCopy needs to copy for EntityType.DOM4J
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2764?page=c...
]
John Verhaeg commented on HHH-2764:
-----------------------------------
I've determined the problem, but it looks like the solution might be a bit of a mess.
The problem is when creating a copy of query results to store in the entityEntry, the
portion of the code that deals with copying the property value doesn't take into
consideration when that value is yet another entity, and ends up moving it from the
results to be returned to the user to the copy, leaving the user with null where an entity
reference should have been. It seems like the solution should involve using the
appropriate entity-mode-specific tupilizer in the deepCopy method for the property type
class, but I can't see a good way of making that available without changing the API
fairly significantly or doing something hackish like re-creating a parent component's
metamodel object.
EntityType.deepCopy needs to copy for EntityType.DOM4J
------------------------------------------------------
Key: HHH-2764
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2764
Project: Hibernate Core
Issue Type: Bug
Affects Versions: 3.2.2
Environment: Hibernate 3.2.2
Reporter: Alan Krueger
Using DOM4J with a set of composite-elements that contains a many-to-one. When loading
this from the database, the many-to-one piece of the composite-element is disappearing
from the XML. I can see the collection being built and the properties on the elements of
the collection being set, but the many-to-one property disappears after that.
Investigating this, it looks like when PersistentElementHolder.getSnapshot is called and
a deepCopy is performed, the EntityType.deepCopy method returns the value to be copied
rather than copying it. This interacts poorly with the DOM4J tree, since each Element can
only have a single Element parent. When the properties are set on this, a detach is
performed that yanks the original element out of its parent.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:46 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2764) EntityType.deepCopy needs to copy for EntityType.DOM4J
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2764?page=c...
]
John Verhaeg commented on HHH-2764:
-----------------------------------
I guess to clarify my previous comment, I was looking at potentially doing another deep
copy of the value via the tupilzer, but that would require access to the session as well
as the tupilizer itself.
EntityType.deepCopy needs to copy for EntityType.DOM4J
------------------------------------------------------
Key: HHH-2764
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2764
Project: Hibernate Core
Issue Type: Bug
Affects Versions: 3.2.2
Environment: Hibernate 3.2.2
Reporter: Alan Krueger
Using DOM4J with a set of composite-elements that contains a many-to-one. When loading
this from the database, the many-to-one piece of the composite-element is disappearing
from the XML. I can see the collection being built and the properties on the elements of
the collection being set, but the many-to-one property disappears after that.
Investigating this, it looks like when PersistentElementHolder.getSnapshot is called and
a deepCopy is performed, the EntityType.deepCopy method returns the value to be copied
rather than copying it. This interacts poorly with the DOM4J tree, since each Element can
only have a single Element parent. When the properties are set on this, a detach is
performed that yanks the original element out of its parent.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:56 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-2764) EntityType.deepCopy needs to copy for EntityType.DOM4J
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2764?page=c...
]
John Verhaeg updated HHH-2764:
------------------------------
Fix Version/s: 4.x
Looks like the issue is due to the bidirectional relationship between DOM parent and child
elements. For POJOs, this isn't usually an issue since the component
"value" is just also set as a property on the copied parent class, without being
removed from the parent in the query results (technically violating composition rules, but
the state of these copies is all we really care about). For all modes, property values
are simply returned rather than copied, but in the case of DOM (and I suspect also Map of
Maps) adding the value to the copied parent also detaches that value from its previous
parent, thus "stealing" it from the actual results. The best way to address
this is probably via entity-mode specific code for a deepCopy method introduced to the
tuplizer that would actually create a copy of the value, but since that would introduce a
breaking change to the tuplizer spi, this is being re-targeted for 4.x.
EntityType.deepCopy needs to copy for EntityType.DOM4J
------------------------------------------------------
Key: HHH-2764
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2764
Project: Hibernate Core
Issue Type: Bug
Affects Versions: 3.2.2
Environment: Hibernate 3.2.2
Reporter: Alan Krueger
Fix For: 4.x
Using DOM4J with a set of composite-elements that contains a many-to-one. When loading
this from the database, the many-to-one piece of the composite-element is disappearing
from the XML. I can see the collection being built and the properties on the elements of
the collection being set, but the many-to-one property disappears after that.
Investigating this, it looks like when PersistentElementHolder.getSnapshot is called and
a deepCopy is performed, the EntityType.deepCopy method returns the value to be copied
rather than copying it. This interacts poorly with the DOM4J tree, since each Element can
only have a single Element parent. When the properties are set on this, a detach is
performed that yanks the original element out of its parent.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:33 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-2764) EntityType.deepCopy needs to copy for EntityType.DOM4J
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2764?page=c...
]
Steve Ebersole updated HHH-2764:
--------------------------------
Fix Version/s: (was: 4.x)
EntityType.deepCopy needs to copy for EntityType.DOM4J
------------------------------------------------------
Key: HHH-2764
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2764
Project: Hibernate Core
Issue Type: Bug
Affects Versions: 3.2.2
Environment: Hibernate 3.2.2
Reporter: Alan Krueger
Using DOM4J with a set of composite-elements that contains a many-to-one. When loading
this from the database, the many-to-one piece of the composite-element is disappearing
from the XML. I can see the collection being built and the properties on the elements of
the collection being set, but the many-to-one property disappears after that.
Investigating this, it looks like when PersistentElementHolder.getSnapshot is called and
a deepCopy is performed, the EntityType.deepCopy method returns the value to be copied
rather than copying it. This interacts poorly with the DOM4J tree, since each Element can
only have a single Element parent. When the properties are set on this, a detach is
performed that yanks the original element out of its parent.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4511
days inactive
6119
days old
hibernate-issues@lists.jboss.org
4 comments
3 participants
participants (3)
-
Alan Krueger (JIRA) -
John Verhaeg (JIRA)
-
Steve Ebersole (JIRA)