7:47 a.m.
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: Sub-task
Reporter: Emmanuel Bernard
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:47 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
Emmanuel Bernard commented on HSEARCH-434:
------------------------------------------
This breaks index compatibility and query compatibility. As you need to use
NumericRangeQuery?
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: Sub-task
Components: engine
Reporter: Emmanuel Bernard
Fix For: 3.2.0.Beta3
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:26 a.m.
New subject: [Hibernate-JIRA] Updated: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
Emmanuel Bernard updated HSEARCH-434:
-------------------------------------
Parent Issue: HSEARCH-424 (was: HSEARCH-415)
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: Sub-task
Components: engine
Reporter: Emmanuel Bernard
Fix For: 3.2.0.Beta3
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:34 a.m.
New subject: [Hibernate-JIRA] Updated: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
Emmanuel Bernard updated HSEARCH-434:
-------------------------------------
Fix Version/s: (was: 3.2.0.Beta3)
3.3.0
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: Sub-task
Components: engine
Reporter: Emmanuel Bernard
Fix For: 3.3.0
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:07 p.m.
New subject: [Hibernate-JIRA] Assigned: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
Sanne Grinovero reassigned HSEARCH-434:
---------------------------------------
Assignee: G Fernandes
volunteered :)
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: Sub-task
Components: engine
Reporter: Emmanuel Bernard
Assignee: G Fernandes
Fix For: 3.3.0
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:11 p.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
G Fernandes commented on HSEARCH-434:
-------------------------------------
What about creating a new annotation, some examples:
// with all attributes
@NumericField(name="f",precisionStep=8,type=NumericTypes.LONG)
private String serialNumber;
// assuming all defaults, with precisionStep=4, type would be Integer
@NumericField
private Integer id;
WDYT?
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: Sub-task
Components: engine
Reporter: Emmanuel Bernard
Assignee: G Fernandes
Fix For: 3.3.0
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:27 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
Emmanuel Bernard commented on HSEARCH-434:
------------------------------------------
I am not ruling this out but the problem with this one are:
- it does not work with @Fields so we need a @NumericFields annotation which is a bit
nasty
- it forces to duplicate the @Field attributes
- if we introduce spatial fields, we will have to do it again
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: Sub-task
Components: engine
Reporter: Emmanuel Bernard
Assignee: G Fernandes
Fix For: 3.3.0
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:33 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
G Fernandes commented on HSEARCH-434:
-------------------------------------
Another option is to extend @Field with numeric attributes:
{code}
@Field(type=FieldType.NUMERIC, precisionStep=8)
{code}
FieldType being enum of STRING, NUMERIC for the moment. The drawback is that @Field will
not be always semantically correct (Numeric related attributes could appear in non numeric
Fields types), but this should keep the API closer to the current one.
Regarding spatial fields, are you planning on using Lucene's spatial Cartesian Tier
system? Geohash? Both? None? :) Any open issues for that?
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: Sub-task
Components: engine
Reporter: Emmanuel Bernard
Assignee: G Fernandes
Fix For: 3.3.0
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:48 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
Emmanuel Bernard commented on HSEARCH-434:
------------------------------------------
yes that's the alternative.
The big question is how much *Field specific properties are needed. For example does the
spatial approach require configuration?
About the spatial support, that's still a todo but the Lucene spatial support has been
refreshed/rewritten (Nicolas Helleringer has been helping in this area at least in design
/ review). That's the one I want to get support for.
There is no opened JIRA yet but that will likely need some coordination with Hibernate
Spatial's project so that core supports the JTS types.
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: Sub-task
Components: engine
Reporter: Emmanuel Bernard
Assignee: G Fernandes
Fix For: 3.3.0
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:26 p.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
G Fernandes commented on HSEARCH-434:
-------------------------------------
Regarding NumericFields, only two params are need: precision and type, probably the type
can be taken from the property?
Also, the simple fact of supporting NumericFields provide a simple but efficient geo
search, which covers the use case of searching all documents that are inside a box given
by a pair of (lat,long). I've not used much Spatial Lucene, but AFAIK the cartesian
tier modality need just one (advanced) configuration: the prefix of the name of the new
internal fields that'll be created at index time to store the coordinates of the point
in the several zoom levels. But that is not part of the field definiton itself, it's
rather a global property for the index.
Btw, this issue was created as a task of Lucene 3.0 migration, but NumericFields are
supported in Lucene 2.9 as well
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: Sub-task
Components: engine
Reporter: Emmanuel Bernard
Assignee: G Fernandes
Fix For: 3.3.0
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:51 p.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
Sanne Grinovero commented on HSEARCH-434:
-----------------------------------------
right this is not blocked by the upgrade to 3.0: originally there wasn't a plan for an
intermediate release using Lucene 2.9, we wanted to upgrade to 3 right away, unfortunately
that wasn't possible.
about NumericFields, yes if you can have the type inferred from the property/field that
would be great.
About Spatial, that could be a first implementation, but I assume that it should be
possible to customise the prefixes differently for each field? Maybe not a great feature,
but stresses that there might be other changes needed in future to support more
differences about Field/NumericField/SpatialFields..
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: Sub-task
Components: engine
Reporter: Emmanuel Bernard
Assignee: G Fernandes
Fix For: 3.3.0
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:28 p.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
G Fernandes commented on HSEARCH-434:
-------------------------------------
Prefix will form the name of the "hidden" fields created by Lucene Spatial when
indexing, it's not a per document/field property but a index wide. Those fields I
imagine will be completely invisible to the HS user. Here are some examples: [lucene
spatial|http://osdir.com/ml/java-dev.lucene.apache.org/2010-02/msg00084.html] and
[hibernate search|http://java.dzone.com/articles/spatial-search-hibernate] examples
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: Sub-task
Components: engine
Reporter: Emmanuel Bernard
Assignee: G Fernandes
Fix For: 3.3.0
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:28 p.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
Emmanuel Bernard commented on HSEARCH-434:
------------------------------------------
When do you think you can get this done?
1 week, 3 weeks or 5 weeks?
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: Sub-task
Components: engine
Reporter: Emmanuel Bernard
Assignee: G Fernandes
Fix For: 3.3.0
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:28 p.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
Emmanuel Bernard commented on HSEARCH-434:
------------------------------------------
I am leaning towards a dedicated @NumericField(forField="") or @Numeric that is
a complement of @Field
ie
@Field @Numeric
Integer age;
@Field(name="length_d") @Numeric(forField="length_d")
BigDecimal length;
WDYT?
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: Sub-task
Components: engine
Reporter: Emmanuel Bernard
Assignee: G Fernandes
Fix For: 3.3.0
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:56 p.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
G Fernandes commented on HSEARCH-434:
-------------------------------------
@NumericField(forField="") seems a little more verbose, repeating the field name
twice. Also it gives the impression that you can define a @NumericField for a different
field. I personally prefer the @Field(type=FieldType.NUMERIC, precisionStep=8) option. Any
particular reason for your preference on having two annotations?
Regarding completion time, actually I've starting coding just today, and should have a
patch in the next week or so.
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: Sub-task
Components: engine
Reporter: Emmanuel Bernard
Assignee: G Fernandes
Fix For: 3.3.0
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:35 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
Emmanuel Bernard commented on HSEARCH-434:
------------------------------------------
It's the same discussion we had with one more options basically. But it boils down to
extensibility. I am concerned about flat annotations with many irrelevant options in many
cases. The options on the table are:
- a fully dedicated @NumericField annotation copying some of the @Field types
- put everything on @Field with the risk of confusing people (esp when new types of types
come to the table)
- have an extension annotation ie @Field @NumericField(forField)
- use the same mechanism Bean Validation uses to compose annotations (ie a @NumericField
annotated with @Field, @Boost etc)
The last option is quite elegant but I don't think it provides much benefits to the
user as I don't see extensibility as a primary feature at this time.
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: Sub-task
Components: engine
Reporter: Emmanuel Bernard
Assignee: G Fernandes
Fix For: 3.3.0
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:24 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
Sanne Grinovero commented on HSEARCH-434:
-----------------------------------------
+1 for @Field && @NumericField, I like it.
in future we could add support the composing annotations, seems nice to reuse mapping
definitions, but that's about a different feature which I assume could be built on top
of the couple "@Field @NumericField"
why should @Numeric(forField="length_d") repeat the field name? can't he
assume the reading?
How should @Fields{} be mapped if some are numeric? (is this interesting at all to
implement?)
Final doubt, shouldn't we have a global option to automatically consider all numbers
as NumericFields?
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: Sub-task
Components: engine
Reporter: Emmanuel Bernard
Assignee: G Fernandes
Fix For: 3.3.0
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:31 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
Emmanuel Bernard commented on HSEARCH-434:
------------------------------------------
You're confusing me, what do you mean by "+1 for @Field && @NumericField,
I like it" Which option are you talking about?
The forField is optional as long as there is a single @Field defined.
The plural annotation is needed yes.
As for the option, I don't know. WDYT?
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: Sub-task
Components: engine
Reporter: Emmanuel Bernard
Assignee: G Fernandes
Fix For: 3.3.0
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:09 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
Sanne Grinovero commented on HSEARCH-434:
-----------------------------------------
sorry for the confusion.
I mean I like the third option, the one which Emmanuel labeled "have an extension
annotation ie @Field @NumericField(forField)" in the comment of 11/Oct/10 2:35 AM
About the global options, I'm just suggesting a discussion for future improvements,
enough features to work on for next release :) Also the eventual composite annotations
might work well as an alternative.
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: Sub-task
Components: engine
Reporter: Emmanuel Bernard
Assignee: G Fernandes
Fix For: 3.3.0
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:29 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
G Fernandes commented on HSEARCH-434:
-------------------------------------
Emmanuel: I now see your point about the 'forField' attribute :)
Sanne: Good point, the @Fields{} annotation will have to change to include a optional list
@NumericField attr.
Bear in mind that a new field type will only appear when Lucene decide to create another
class besides Field and NumericField, and AFAIK, that will not happen soon. What other
types of fields do you imagine having beside String and Numeric?
I got the version using @Field(type=FieldType.NUMERIC) working, should we use that as a
first release to get feedback from users?
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: Sub-task
Components: engine
Reporter: Emmanuel Bernard
Assignee: G Fernandes
Fix For: 3.3.0
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:05 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
Emmanuel Bernard commented on HSEARCH-434:
------------------------------------------
If we use @NumericField then it's plural annotation will be @NumericFields, not
@Fields.
I'd be more inclined to try on users the @NumericField.forField approach first as it
is the most visible. If we see complaints, then we can go back to the other scheme which
is more subtle and thus invidious wrt to it's drawbacks ;)
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: Sub-task
Components: engine
Reporter: Emmanuel Bernard
Assignee: G Fernandes
Fix For: 3.3.0
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:35 p.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
G Fernandes commented on HSEARCH-434:
-------------------------------------
Fair enough, I'll patch my patch and see how it goes :)
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: Sub-task
Components: engine
Reporter: Emmanuel Bernard
Assignee: G Fernandes
Fix For: 3.3.0
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:09 a.m.
New subject: [Hibernate-JIRA] Updated: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
Hardy Ferentschik updated HSEARCH-434:
--------------------------------------
Issue Type: New Feature (was: Sub-task)
Parent: (was: HSEARCH-424)
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: New Feature
Components: engine
Reporter: Emmanuel Bernard
Assignee: G Fernandes
Fix For: 3.3.0
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:24 p.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
G Fernandes commented on HSEARCH-434:
-------------------------------------
Hi, how does the @Fields annotation will work with @Numeric(forField="...")
stuff?
Before using the two annotations (@Field + @Numeric), it was
http://pastebin.com/GuuwNE9W
Any suggestions on the new one?
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: New Feature
Components: engine
Reporter: Emmanuel Bernard
Assignee: G Fernandes
Fix For: 3.3.0
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:31 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
Emmanuel Bernard commented on HSEARCH-434:
------------------------------------------
This
http://pastebin.com/Pkd2yx0J
{code}@Fields({
@Field(name = "name", type=FieldType.NUMERIC),
@Field(name = "name2", type=FieldType.NUMERIC)
}
)
@NumericFields({
@NumericFields(forField="name"),
@NumericField(forName="name2")
})
private Integer counter;
{code}
But I wonder what the use case would be to index the same property twice as numeric
field.
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: New Feature
Components: engine
Reporter: Emmanuel Bernard
Assignee: G Fernandes
Fix For: 3.3.0
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:22 p.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
G Fernandes commented on HSEARCH-434:
-------------------------------------
This is how the Programmatic Configuration will look like with NumericFields:
{code}
.entity(Item.class)
.indexed()
.property("productCatalog", ElementType.FIELD)
.containedIn()
.property("price", ElementType.FIELD)
.field()
.numeric().precisionStep(10)
{code}
Is that ok?
Apart from that, the QueryBuilder DSL will also need to be changed in order to do specific
Term and Range queries for Numeric Fields.
Anything else that needs to be changed in order to have full support for Numeric Fields?
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: New Feature
Components: engine
Reporter: Emmanuel Bernard
Assignee: G Fernandes
Fix For: 3.3.0
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:34 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
Emmanuel Bernard commented on HSEARCH-434:
------------------------------------------
That works for me.
About the query dsl, you mean the internals or the API, it seems only the internals will
be affected.
Another area I can think of is the LuceneOptions interface used in FieldBridges.
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: New Feature
Components: engine
Reporter: Emmanuel Bernard
Assignee: G Fernandes
Fix For: 3.3.0
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:26 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
G Fernandes commented on HSEARCH-434:
-------------------------------------
Yes, I had to change LuceneOptions as well. Regarding the DSL, I'm aiming to not
change the API and automatically pick the right query for numeric fields internally.
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: New Feature
Components: engine
Reporter: Emmanuel Bernard
Assignee: G Fernandes
Fix For: 3.3.0
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:23 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
G Fernandes commented on HSEARCH-434:
-------------------------------------
Pls take a look at http://github.com/hibernate/hibernate-search/pulls to see the
implementation of the discussed features.
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: New Feature
Components: engine
Reporter: Emmanuel Bernard
Assignee: G Fernandes
Fix For: 3.3.0
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:10 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
Emmanuel Bernard commented on HSEARCH-434:
------------------------------------------
Hi Gustavo,
Thanks for the hard work. That's a hell of a pull request :)
I've commented using the github facilities as it allows per line comments. Don't
worry about the amount of comments, the review was very comprehensive on purpose (it's
my first pull-request review session).
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: New Feature
Components: engine
Reporter: Emmanuel Bernard
Assignee: G Fernandes
Fix For: 3.3.0
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:16 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
Emmanuel Bernard commented on HSEARCH-434:
------------------------------------------
I forgot one actually
NumericBridge is not a TwoWayFieldBridge, that's a problem as it cannot be used with
projections. Is there a technical reason?
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: New Feature
Components: engine
Reporter: Emmanuel Bernard
Assignee: G Fernandes
Fix For: 3.3.0
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:47 p.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
G Fernandes commented on HSEARCH-434:
-------------------------------------
Thanks for the in-depth review, really usefull!
Regarding TwoWayFieldBridge I believe it can be supported as well, let me add a projection
test to make sure.
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: New Feature
Components: engine
Reporter: Emmanuel Bernard
Assignee: G Fernandes
Fix For: 3.3.0
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:16 a.m.
New subject: [Hibernate-JIRA] Resolved: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
Emmanuel Bernard resolved HSEARCH-434.
--------------------------------------
Resolution: Fixed
Fix Version/s: (was: 3.3.0)
3.3.0.CR1
Many thanks Gustavo.
One last question (maybe ;) ), it seems the @NumericField support won't work for
@DocumentId, is that expected and would it make sense?
From my PoV it would make sense to be many times faster on a numeric
term query to load by id :)
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: New Feature
Components: engine
Reporter: Emmanuel Bernard
Assignee: G Fernandes
Fix For: 3.3.0.CR1
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:37 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
G Fernandes commented on HSEARCH-434:
-------------------------------------
I've added support for this as well, check the example in
[Location.java|http://github.com/gustavonalle/hibernate-search/blob/8cc185...]
and
[NumericFieldTest.java|http://github.com/gustavonalle/hibernate-search/com...]
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: New Feature
Components: engine
Reporter: Emmanuel Bernard
Assignee: G Fernandes
Fix For: 3.3.0.CR1
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:59 p.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
Sanne Grinovero commented on HSEARCH-434:
-----------------------------------------
@Emmanuel I'm not sure it would be many times faster to load by id (and why would we
load by id from the index anyway?), the feature is meant to solve the issue with range
queries.
It might be worth trying, but in case would you be ok in chaning the default encoding for
all ids?
Perhaps making confusion with the discussion we had about FieldCaches? that's cool for
the ids ;)
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: New Feature
Components: engine
Reporter: Emmanuel Bernard
Assignee: G Fernandes
Fix For: 3.3.0.CR1
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:25 p.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
Emmanuel Bernard commented on HSEARCH-434:
------------------------------------------
we do query by id on deletes (and updates by side effect), but year, I'm happy to not
advertise it until we have the FieldCache options which is going to be much better.
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: New Feature
Components: engine
Reporter: Emmanuel Bernard
Assignee: G Fernandes
Fix For: 3.3.0.CR1
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:44 p.m.
New subject: [Hibernate-JIRA] Reopened: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
G Fernandes reopened HSEARCH-434:
---------------------------------
Using @NumericField together with @DocumentId is currently supported for range queries,
but when deleting an entity, the document from the index is not being deleted as well.
Currently the DeleteWorkDelegate does a delete by Term doing a toString() in the id field,
which will not work with numeric fields given its multi-valued encoded nature. I'll
provide a fix shortly.
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: New Feature
Components: engine
Reporter: Emmanuel Bernard
Assignee: G Fernandes
Fix For: 3.3.0.CR1
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:39 p.m.
New subject: [Hibernate-JIRA] Updated: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
Emmanuel Bernard updated HSEARCH-434:
-------------------------------------
Fix Version/s: 3.3.0.Beta3
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: New Feature
Components: engine
Reporter: Emmanuel Bernard
Assignee: G Fernandes
Fix For: 3.3.0.Beta3, 3.3.0.CR1
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:39 p.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
Emmanuel Bernard commented on HSEARCH-434:
------------------------------------------
Hi Gustavo,
We prefer to leave issues resolved on a released version to stay closed. Prefer opening a
new issue with the dedicated issue.
Yes I know I mis-assigned it to CR1 while it was released in beta 3.
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: New Feature
Components: engine
Reporter: Emmanuel Bernard
Assignee: G Fernandes
Fix For: 3.3.0.Beta3, 3.3.0.CR1
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:39 p.m.
New subject: [Hibernate-JIRA] Resolved: (HSEARCH-434) Make use of NumericField
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434?pag...
]
Emmanuel Bernard resolved HSEARCH-434.
--------------------------------------
Resolution: Fixed
Mark it back as resolved
Make use of NumericField
-------------------------
Key: HSEARCH-434
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-434
Project: Hibernate Search
Issue Type: New Feature
Components: engine
Reporter: Emmanuel Bernard
Assignee: G Fernandes
Fix For: 3.3.0.CR1, 3.3.0.Beta3
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4974
days inactive
5299
days old
hibernate-issues@lists.jboss.org
39 comments
4 participants
participants (4)
-
Emmanuel Bernard (JIRA) -
G Fernandes (JIRA)
-
Hardy Ferentschik (JIRA)
-
Sanne Grinovero (JIRA)