[Hibernate-JIRA] Created: (ANN-640) use property names defined in CompositeUserType as default column names
4:26 p.m.
use property names defined in CompositeUserType as default column names
-----------------------------------------------------------------------
Key: ANN-640
URL: http://opensource.atlassian.com/projects/hibernate/browse/ANN-640
Project: Hibernate Annotations
Issue Type: New Feature
Affects Versions: 3.3.0.ga
Reporter: Michael Newcomb
Priority: Minor
Consider:
public class LongitudeLatitude
{
protected double longitude;
protected double latitude;
}
public class LongitudeLatitudeCompositeUserType
implements CompositeUserType
{
public String[] getPropertyNames()
{
return new String[] { "longitude", "latitude" };
}
public Type[] getPropertyTypes()
{
return new Type[] { Hibernate.DOUBLE, Hibernate.DOUBLE };
}
...
}
@Entity
public class Test
{
@Basic(optional = false)
@Type(type = "foo.bar.LongitudeLatitudeCompositeUserType")
@Columns(columns = { @Column(name = "location_longitude"), @Column(name =
"location_latitude") })
protected LongitudeLatitude location;
}
Why does the developer need to specify each column?
I'd really rather let the CompositeUserType take care of that for me. Now, I have to
tie the @Columns to the # of properties in my CompositeUserType AND the order in which
they are defined? This seems to defeat the purpose of having a class (CompositeUserType)
to tell Hibernate how to store it.
Couldn't Hibernate prepend the property name 'location' and '_' to the
front of each property name in the CompositeUserType?
Perhaps (more than likely) I'm doing something wrong, but I get a failure if I do not
specify the columns.
Thanks,
Michael
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:47 p.m.
New subject: [Hibernate-JIRA] Commented: (ANN-640) use property names defined in CompositeUserType as default column names
[
http://opensource.atlassian.com/projects/hibernate/browse/ANN-640?page=co...
]
Emmanuel Bernard commented on ANN-640:
--------------------------------------
public String[] getPropertyNames()
{
return new String[] { "longitude", "latitude" };
}
is optional
use property names defined in CompositeUserType as default column
names
-----------------------------------------------------------------------
Key: ANN-640
URL: http://opensource.atlassian.com/projects/hibernate/browse/ANN-640
Project: Hibernate Annotations
Issue Type: New Feature
Affects Versions: 3.3.0.ga
Reporter: Michael Newcomb
Priority: Minor
Consider:
public class LongitudeLatitude
{
protected double longitude;
protected double latitude;
}
public class LongitudeLatitudeCompositeUserType
implements CompositeUserType
{
public String[] getPropertyNames()
{
return new String[] { "longitude", "latitude" };
}
public Type[] getPropertyTypes()
{
return new Type[] { Hibernate.DOUBLE, Hibernate.DOUBLE };
}
...
}
@Entity
public class Test
{
@Basic(optional = false)
@Type(type = "foo.bar.LongitudeLatitudeCompositeUserType")
@Columns(columns = { @Column(name = "location_longitude"), @Column(name =
"location_latitude") })
protected LongitudeLatitude location;
}
Why does the developer need to specify each column?
I'd really rather let the CompositeUserType take care of that for me. Now, I have to
tie the @Columns to the # of properties in my CompositeUserType AND the order in which
they are defined? This seems to defeat the purpose of having a class (CompositeUserType)
to tell Hibernate how to store it.
Couldn't Hibernate prepend the property name 'location' and '_' to
the front of each property name in the CompositeUserType?
Perhaps (more than likely) I'm doing something wrong, but I get a failure if I do not
specify the columns.
Thanks,
Michael
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:10 p.m.
New subject: [Hibernate-JIRA] Commented: (ANN-640) use property names defined in CompositeUserType as default column names
[
http://opensource.atlassian.com/projects/hibernate/browse/ANN-640?page=co...
]
Michael Newcomb commented on ANN-640:
-------------------------------------
Thanks for the reply Emmanuel!
So, the property names returned by getPropertyNames() are unrelated to types returned in
getPropertyTypes() are unrelated?
I would like to hear your thoughts on having to know detailed information about the
(column order and #) every time you use the composite user type. If you change the user
type, you need to go find all @Columns and change them as well (maintenance nightmare).
Perhaps adding String[] getPropertyTypeNames() would alleiviate the need to specify
@Columns?
Thanks,
Michael
use property names defined in CompositeUserType as default column
names
-----------------------------------------------------------------------
Key: ANN-640
URL: http://opensource.atlassian.com/projects/hibernate/browse/ANN-640
Project: Hibernate Annotations
Issue Type: New Feature
Affects Versions: 3.3.0.ga
Reporter: Michael Newcomb
Priority: Minor
Consider:
public class LongitudeLatitude
{
protected double longitude;
protected double latitude;
}
public class LongitudeLatitudeCompositeUserType
implements CompositeUserType
{
public String[] getPropertyNames()
{
return new String[] { "longitude", "latitude" };
}
public Type[] getPropertyTypes()
{
return new Type[] { Hibernate.DOUBLE, Hibernate.DOUBLE };
}
...
}
@Entity
public class Test
{
@Basic(optional = false)
@Type(type = "foo.bar.LongitudeLatitudeCompositeUserType")
@Columns(columns = { @Column(name = "location_longitude"), @Column(name =
"location_latitude") })
protected LongitudeLatitude location;
}
Why does the developer need to specify each column?
I'd really rather let the CompositeUserType take care of that for me. Now, I have to
tie the @Columns to the # of properties in my CompositeUserType AND the order in which
they are defined? This seems to defeat the purpose of having a class (CompositeUserType)
to tell Hibernate how to store it.
Couldn't Hibernate prepend the property name 'location' and '_' to
the front of each property name in the CompositeUserType?
Perhaps (more than likely) I'm doing something wrong, but I get a failure if I do not
specify the columns.
Thanks,
Michael
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:17 a.m.
New subject: [Hibernate-JIRA] Commented: (ANN-640) use property names defined in CompositeUserType as default column names
[
http://opensource.atlassian.com/projects/hibernate/browse/ANN-640?page=co...
]
Emmanuel Bernard commented on ANN-640:
--------------------------------------
they are related, but as I said getPropertyNames is optional
Frankly if you have to change your user type in a system, doing a smart find in your
favorite IDE is the least of your problem.
use property names defined in CompositeUserType as default column
names
-----------------------------------------------------------------------
Key: ANN-640
URL: http://opensource.atlassian.com/projects/hibernate/browse/ANN-640
Project: Hibernate Annotations
Issue Type: New Feature
Affects Versions: 3.3.0.ga
Reporter: Michael Newcomb
Priority: Minor
Consider:
public class LongitudeLatitude
{
protected double longitude;
protected double latitude;
}
public class LongitudeLatitudeCompositeUserType
implements CompositeUserType
{
public String[] getPropertyNames()
{
return new String[] { "longitude", "latitude" };
}
public Type[] getPropertyTypes()
{
return new Type[] { Hibernate.DOUBLE, Hibernate.DOUBLE };
}
...
}
@Entity
public class Test
{
@Basic(optional = false)
@Type(type = "foo.bar.LongitudeLatitudeCompositeUserType")
@Columns(columns = { @Column(name = "location_longitude"), @Column(name =
"location_latitude") })
protected LongitudeLatitude location;
}
Why does the developer need to specify each column?
I'd really rather let the CompositeUserType take care of that for me. Now, I have to
tie the @Columns to the # of properties in my CompositeUserType AND the order in which
they are defined? This seems to defeat the purpose of having a class (CompositeUserType)
to tell Hibernate how to store it.
Couldn't Hibernate prepend the property name 'location' and '_' to
the front of each property name in the CompositeUserType?
Perhaps (more than likely) I'm doing something wrong, but I get a failure if I do not
specify the columns.
Thanks,
Michael
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:07 p.m.
New subject: [Hibernate-JIRA] Commented: (ANN-640) use property names defined in CompositeUserType as default column names
[
http://opensource.atlassian.com/projects/hibernate/browse/ANN-640?page=co...
]
Michael Newcomb commented on ANN-640:
-------------------------------------
Intimate knowledge of a CompositeUserType (name, #, and order of columns) outside of the
CompositeUserType is bad.
There is no similar requirement on @Embeddable, which IMHO, is similar to a
CompositeUserType.
I think we are going to have to agree to disagree.
use property names defined in CompositeUserType as default column
names
-----------------------------------------------------------------------
Key: ANN-640
URL: http://opensource.atlassian.com/projects/hibernate/browse/ANN-640
Project: Hibernate Annotations
Issue Type: New Feature
Affects Versions: 3.3.0.ga
Reporter: Michael Newcomb
Priority: Minor
Consider:
public class LongitudeLatitude
{
protected double longitude;
protected double latitude;
}
public class LongitudeLatitudeCompositeUserType
implements CompositeUserType
{
public String[] getPropertyNames()
{
return new String[] { "longitude", "latitude" };
}
public Type[] getPropertyTypes()
{
return new Type[] { Hibernate.DOUBLE, Hibernate.DOUBLE };
}
...
}
@Entity
public class Test
{
@Basic(optional = false)
@Type(type = "foo.bar.LongitudeLatitudeCompositeUserType")
@Columns(columns = { @Column(name = "location_longitude"), @Column(name =
"location_latitude") })
protected LongitudeLatitude location;
}
Why does the developer need to specify each column?
I'd really rather let the CompositeUserType take care of that for me. Now, I have to
tie the @Columns to the # of properties in my CompositeUserType AND the order in which
they are defined? This seems to defeat the purpose of having a class (CompositeUserType)
to tell Hibernate how to store it.
Couldn't Hibernate prepend the property name 'location' and '_' to
the front of each property name in the CompositeUserType?
Perhaps (more than likely) I'm doing something wrong, but I get a failure if I do not
specify the columns.
Thanks,
Michael
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:57 a.m.
New subject: [Hibernate-JIRA] Commented: (ANN-640) use property names defined in CompositeUserType as default column names
[
http://opensource.atlassian.com/projects/hibernate/browse/ANN-640?page=co...
]
Barry Kaplan commented on ANN-640:
----------------------------------
I agree that it is noisy, a DRY violation, and painful to have to specify the @Column
attributes for composite user types. There should be some way to default the column
names.
use property names defined in CompositeUserType as default column
names
-----------------------------------------------------------------------
Key: ANN-640
URL: http://opensource.atlassian.com/projects/hibernate/browse/ANN-640
Project: Hibernate Annotations
Issue Type: New Feature
Affects Versions: 3.3.0.ga
Reporter: Michael Newcomb
Priority: Minor
Consider:
public class LongitudeLatitude
{
protected double longitude;
protected double latitude;
}
public class LongitudeLatitudeCompositeUserType
implements CompositeUserType
{
public String[] getPropertyNames()
{
return new String[] { "longitude", "latitude" };
}
public Type[] getPropertyTypes()
{
return new Type[] { Hibernate.DOUBLE, Hibernate.DOUBLE };
}
...
}
@Entity
public class Test
{
@Basic(optional = false)
@Type(type = "foo.bar.LongitudeLatitudeCompositeUserType")
@Columns(columns = { @Column(name = "location_longitude"), @Column(name =
"location_latitude") })
protected LongitudeLatitude location;
}
Why does the developer need to specify each column?
I'd really rather let the CompositeUserType take care of that for me. Now, I have to
tie the @Columns to the # of properties in my CompositeUserType AND the order in which
they are defined? This seems to defeat the purpose of having a class (CompositeUserType)
to tell Hibernate how to store it.
Couldn't Hibernate prepend the property name 'location' and '_' to
the front of each property name in the CompositeUserType?
Perhaps (more than likely) I'm doing something wrong, but I get a failure if I do not
specify the columns.
Thanks,
Michael
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:14 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-4347) use property names defined in CompositeUserType as default column names
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4347?page=c...
]
Xavier Dury commented on HHH-4347:
----------------------------------
please, some smart defaults would be very nice to have =) I think many people are using
hibernate as their main jpa implementation because of all the useful things not covered by
the specification... and user types are one of them. For my part, I have a composite user
type for joda-time intervals and it would be nice if I wasn't forced to put @Columns
everywhere.
use property names defined in CompositeUserType as default column
names
-----------------------------------------------------------------------
Key: HHH-4347
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4347
Project: Hibernate Core
Issue Type: New Feature
Components: annotations
Reporter: Michael Newcomb
Priority: Minor
Consider:
public class LongitudeLatitude
{
protected double longitude;
protected double latitude;
}
public class LongitudeLatitudeCompositeUserType
implements CompositeUserType
{
public String[] getPropertyNames()
{
return new String[] { "longitude", "latitude" };
}
public Type[] getPropertyTypes()
{
return new Type[] { Hibernate.DOUBLE, Hibernate.DOUBLE };
}
...
}
@Entity
public class Test
{
@Basic(optional = false)
@Type(type = "foo.bar.LongitudeLatitudeCompositeUserType")
@Columns(columns = { @Column(name = "location_longitude"), @Column(name =
"location_latitude") })
protected LongitudeLatitude location;
}
Why does the developer need to specify each column?
I'd really rather let the CompositeUserType take care of that for me. Now, I have to
tie the @Columns to the # of properties in my CompositeUserType AND the order in which
they are defined? This seems to defeat the purpose of having a class (CompositeUserType)
to tell Hibernate how to store it.
Couldn't Hibernate prepend the property name 'location' and '_' to
the front of each property name in the CompositeUserType?
Perhaps (more than likely) I'm doing something wrong, but I get a failure if I do not
specify the columns.
Thanks,
Michael
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:24 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-4347) use property names defined in CompositeUserType as default column names
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4347?page=c...
]
Michael Newcomb commented on HHH-4347:
--------------------------------------
Don't think it is going to happen Xavier... typical response is that you don't
know what you are talking about or something like that.
There is a bug where Map.remove() fails
(http://opensource.atlassian.com/projects/hibernate/browse/HHH-3223) but no one has
bothered to fix it even though it has been fixed for Map.put()...
Not sure what is happening with Hibernate.
use property names defined in CompositeUserType as default column
names
-----------------------------------------------------------------------
Key: HHH-4347
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4347
Project: Hibernate Core
Issue Type: New Feature
Components: annotations
Reporter: Michael Newcomb
Priority: Minor
Consider:
public class LongitudeLatitude
{
protected double longitude;
protected double latitude;
}
public class LongitudeLatitudeCompositeUserType
implements CompositeUserType
{
public String[] getPropertyNames()
{
return new String[] { "longitude", "latitude" };
}
public Type[] getPropertyTypes()
{
return new Type[] { Hibernate.DOUBLE, Hibernate.DOUBLE };
}
...
}
@Entity
public class Test
{
@Basic(optional = false)
@Type(type = "foo.bar.LongitudeLatitudeCompositeUserType")
@Columns(columns = { @Column(name = "location_longitude"), @Column(name =
"location_latitude") })
protected LongitudeLatitude location;
}
Why does the developer need to specify each column?
I'd really rather let the CompositeUserType take care of that for me. Now, I have to
tie the @Columns to the # of properties in my CompositeUserType AND the order in which
they are defined? This seems to defeat the purpose of having a class (CompositeUserType)
to tell Hibernate how to store it.
Couldn't Hibernate prepend the property name 'location' and '_' to
the front of each property name in the CompositeUserType?
Perhaps (more than likely) I'm doing something wrong, but I get a failure if I do not
specify the columns.
Thanks,
Michael
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:28 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-4347) use property names defined in CompositeUserType as default column names
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4347?page=c...
]
Steve Ebersole updated HHH-4347:
--------------------------------
Comment: was deleted
(was: Don't think it is going to happen Xavier... typical response is that you
don't know what you are talking about or something like that.
There is a bug where Map.remove() fails
(http://opensource.atlassian.com/projects/hibernate/browse/HHH-3223) but no one has
bothered to fix it even though it has been fixed for Map.put()...
Not sure what is happening with Hibernate.
)
use property names defined in CompositeUserType as default column
names
-----------------------------------------------------------------------
Key: HHH-4347
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4347
Project: Hibernate Core
Issue Type: New Feature
Components: annotations
Reporter: Michael Newcomb
Priority: Minor
Consider:
public class LongitudeLatitude
{
protected double longitude;
protected double latitude;
}
public class LongitudeLatitudeCompositeUserType
implements CompositeUserType
{
public String[] getPropertyNames()
{
return new String[] { "longitude", "latitude" };
}
public Type[] getPropertyTypes()
{
return new Type[] { Hibernate.DOUBLE, Hibernate.DOUBLE };
}
...
}
@Entity
public class Test
{
@Basic(optional = false)
@Type(type = "foo.bar.LongitudeLatitudeCompositeUserType")
@Columns(columns = { @Column(name = "location_longitude"), @Column(name =
"location_latitude") })
protected LongitudeLatitude location;
}
Why does the developer need to specify each column?
I'd really rather let the CompositeUserType take care of that for me. Now, I have to
tie the @Columns to the # of properties in my CompositeUserType AND the order in which
they are defined? This seems to defeat the purpose of having a class (CompositeUserType)
to tell Hibernate how to store it.
Couldn't Hibernate prepend the property name 'location' and '_' to
the front of each property name in the CompositeUserType?
Perhaps (more than likely) I'm doing something wrong, but I get a failure if I do not
specify the columns.
Thanks,
Michael
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:28 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-4347) use property names defined in CompositeUserType as default column names
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4347?page=c...
]
Steve Ebersole commented on HHH-4347:
-------------------------------------
If it is important to y'all why don't you provide a patch for it? We all work on
things that are important to us; welcome to the world of open source...
use property names defined in CompositeUserType as default column
names
-----------------------------------------------------------------------
Key: HHH-4347
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4347
Project: Hibernate Core
Issue Type: New Feature
Components: annotations
Reporter: Michael Newcomb
Priority: Minor
Consider:
public class LongitudeLatitude
{
protected double longitude;
protected double latitude;
}
public class LongitudeLatitudeCompositeUserType
implements CompositeUserType
{
public String[] getPropertyNames()
{
return new String[] { "longitude", "latitude" };
}
public Type[] getPropertyTypes()
{
return new Type[] { Hibernate.DOUBLE, Hibernate.DOUBLE };
}
...
}
@Entity
public class Test
{
@Basic(optional = false)
@Type(type = "foo.bar.LongitudeLatitudeCompositeUserType")
@Columns(columns = { @Column(name = "location_longitude"), @Column(name =
"location_latitude") })
protected LongitudeLatitude location;
}
Why does the developer need to specify each column?
I'd really rather let the CompositeUserType take care of that for me. Now, I have to
tie the @Columns to the # of properties in my CompositeUserType AND the order in which
they are defined? This seems to defeat the purpose of having a class (CompositeUserType)
to tell Hibernate how to store it.
Couldn't Hibernate prepend the property name 'location' and '_' to
the front of each property name in the CompositeUserType?
Perhaps (more than likely) I'm doing something wrong, but I get a failure if I do not
specify the columns.
Thanks,
Michael
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:55 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-4347) use property names defined in CompositeUserType as default column names
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4347?page=c...
]
Michael Newcomb commented on HHH-4347:
--------------------------------------
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2584 has a patch that I
applied to my local copy of PersistentMap and that is a bug where Map.remove() doesn't
work, pretty significant if you ask me, yet it hasn't been applied...
However, this is an enhancement request. I'll gladly provide a patch, but Emmanuel
Bernard's earlier comments led me to believe that it would not be applied.
Emmanuel Bernard:
"Frankly if you have to change your user type in a system, doing a smart find in your
favorite IDE is the least of your problem."
use property names defined in CompositeUserType as default column
names
-----------------------------------------------------------------------
Key: HHH-4347
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4347
Project: Hibernate Core
Issue Type: New Feature
Components: annotations
Reporter: Michael Newcomb
Priority: Minor
Consider:
public class LongitudeLatitude
{
protected double longitude;
protected double latitude;
}
public class LongitudeLatitudeCompositeUserType
implements CompositeUserType
{
public String[] getPropertyNames()
{
return new String[] { "longitude", "latitude" };
}
public Type[] getPropertyTypes()
{
return new Type[] { Hibernate.DOUBLE, Hibernate.DOUBLE };
}
...
}
@Entity
public class Test
{
@Basic(optional = false)
@Type(type = "foo.bar.LongitudeLatitudeCompositeUserType")
@Columns(columns = { @Column(name = "location_longitude"), @Column(name =
"location_latitude") })
protected LongitudeLatitude location;
}
Why does the developer need to specify each column?
I'd really rather let the CompositeUserType take care of that for me. Now, I have to
tie the @Columns to the # of properties in my CompositeUserType AND the order in which
they are defined? This seems to defeat the purpose of having a class (CompositeUserType)
to tell Hibernate how to store it.
Couldn't Hibernate prepend the property name 'location' and '_' to
the front of each property name in the CompositeUserType?
Perhaps (more than likely) I'm doing something wrong, but I get a failure if I do not
specify the columns.
Thanks,
Michael
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:13 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-4347) use property names defined in CompositeUserType as default column names
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4347?page=c...
]
Steve Ebersole commented on HHH-4347:
-------------------------------------
You know mainly one person working on a project this size things do sometimes fall through
the cracks :) Part of the problem is that someone trying to be nice closed the wrong
issue (the one with the patch) as duplicate.
And here I think the more fundamental issue is that the component property names are just
really not good enough. Take the typical Address example, with "line1",
"line2", city". Personally I'd much rather have the column name be a
form of concatenation between the component property name and the individual sub-property
names (HOME_LINE1, HOME_CITY, MAIL_LINE1, etc).
use property names defined in CompositeUserType as default column
names
-----------------------------------------------------------------------
Key: HHH-4347
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4347
Project: Hibernate Core
Issue Type: New Feature
Components: annotations
Reporter: Michael Newcomb
Priority: Minor
Consider:
public class LongitudeLatitude
{
protected double longitude;
protected double latitude;
}
public class LongitudeLatitudeCompositeUserType
implements CompositeUserType
{
public String[] getPropertyNames()
{
return new String[] { "longitude", "latitude" };
}
public Type[] getPropertyTypes()
{
return new Type[] { Hibernate.DOUBLE, Hibernate.DOUBLE };
}
...
}
@Entity
public class Test
{
@Basic(optional = false)
@Type(type = "foo.bar.LongitudeLatitudeCompositeUserType")
@Columns(columns = { @Column(name = "location_longitude"), @Column(name =
"location_latitude") })
protected LongitudeLatitude location;
}
Why does the developer need to specify each column?
I'd really rather let the CompositeUserType take care of that for me. Now, I have to
tie the @Columns to the # of properties in my CompositeUserType AND the order in which
they are defined? This seems to defeat the purpose of having a class (CompositeUserType)
to tell Hibernate how to store it.
Couldn't Hibernate prepend the property name 'location' and '_' to
the front of each property name in the CompositeUserType?
Perhaps (more than likely) I'm doing something wrong, but I get a failure if I do not
specify the columns.
Thanks,
Michael
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:45 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-4347) use property names defined in CompositeUserType as default column names
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4347?page=c...
]
Michael Newcomb commented on HHH-4347:
--------------------------------------
Steve, that is exactly how @Embeddable works, it prepends the variable's name to the
properties of the @Embeddable object. So, in the example above, the columns would be:
location_longitude
location_latitude
Property names should still be longitude and latitude but to reference them from a query
it would be location.latitude or location.longitude.
If a patch was made that implemented the above (and worked), would it be applied?
use property names defined in CompositeUserType as default column
names
-----------------------------------------------------------------------
Key: HHH-4347
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4347
Project: Hibernate Core
Issue Type: New Feature
Components: annotations
Reporter: Michael Newcomb
Priority: Minor
Consider:
public class LongitudeLatitude
{
protected double longitude;
protected double latitude;
}
public class LongitudeLatitudeCompositeUserType
implements CompositeUserType
{
public String[] getPropertyNames()
{
return new String[] { "longitude", "latitude" };
}
public Type[] getPropertyTypes()
{
return new Type[] { Hibernate.DOUBLE, Hibernate.DOUBLE };
}
...
}
@Entity
public class Test
{
@Basic(optional = false)
@Type(type = "foo.bar.LongitudeLatitudeCompositeUserType")
@Columns(columns = { @Column(name = "location_longitude"), @Column(name =
"location_latitude") })
protected LongitudeLatitude location;
}
Why does the developer need to specify each column?
I'd really rather let the CompositeUserType take care of that for me. Now, I have to
tie the @Columns to the # of properties in my CompositeUserType AND the order in which
they are defined? This seems to defeat the purpose of having a class (CompositeUserType)
to tell Hibernate how to store it.
Couldn't Hibernate prepend the property name 'location' and '_' to
the front of each property name in the CompositeUserType?
Perhaps (more than likely) I'm doing something wrong, but I get a failure if I do not
specify the columns.
Thanks,
Michael
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:51 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-4347) use property names defined in CompositeUserType as default column names
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4347?page=c...
]
Steve Ebersole commented on HHH-4347:
-------------------------------------
If a patch implemented this feature and defined the proper test cases sure.
use property names defined in CompositeUserType as default column
names
-----------------------------------------------------------------------
Key: HHH-4347
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4347
Project: Hibernate Core
Issue Type: New Feature
Components: annotations
Reporter: Michael Newcomb
Priority: Minor
Consider:
public class LongitudeLatitude
{
protected double longitude;
protected double latitude;
}
public class LongitudeLatitudeCompositeUserType
implements CompositeUserType
{
public String[] getPropertyNames()
{
return new String[] { "longitude", "latitude" };
}
public Type[] getPropertyTypes()
{
return new Type[] { Hibernate.DOUBLE, Hibernate.DOUBLE };
}
...
}
@Entity
public class Test
{
@Basic(optional = false)
@Type(type = "foo.bar.LongitudeLatitudeCompositeUserType")
@Columns(columns = { @Column(name = "location_longitude"), @Column(name =
"location_latitude") })
protected LongitudeLatitude location;
}
Why does the developer need to specify each column?
I'd really rather let the CompositeUserType take care of that for me. Now, I have to
tie the @Columns to the # of properties in my CompositeUserType AND the order in which
they are defined? This seems to defeat the purpose of having a class (CompositeUserType)
to tell Hibernate how to store it.
Couldn't Hibernate prepend the property name 'location' and '_' to
the front of each property name in the CompositeUserType?
Perhaps (more than likely) I'm doing something wrong, but I get a failure if I do not
specify the columns.
Thanks,
Michael
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:57 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-4347) use property names defined in CompositeUserType as default column names
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4347?page=c...
]
Steve Ebersole commented on HHH-4347:
-------------------------------------
Some of tests I'd specifically be interested in seeing:
What happens as you get nested CompositeUserTypes?
What happens as these default columns get too long (especially considering the commonality
is 'toward the front')?
What happens to UserTypes that are not CompositeUserType whose mapping does not define
columns?
etc...
use property names defined in CompositeUserType as default column
names
-----------------------------------------------------------------------
Key: HHH-4347
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4347
Project: Hibernate Core
Issue Type: New Feature
Components: annotations
Reporter: Michael Newcomb
Priority: Minor
Consider:
public class LongitudeLatitude
{
protected double longitude;
protected double latitude;
}
public class LongitudeLatitudeCompositeUserType
implements CompositeUserType
{
public String[] getPropertyNames()
{
return new String[] { "longitude", "latitude" };
}
public Type[] getPropertyTypes()
{
return new Type[] { Hibernate.DOUBLE, Hibernate.DOUBLE };
}
...
}
@Entity
public class Test
{
@Basic(optional = false)
@Type(type = "foo.bar.LongitudeLatitudeCompositeUserType")
@Columns(columns = { @Column(name = "location_longitude"), @Column(name =
"location_latitude") })
protected LongitudeLatitude location;
}
Why does the developer need to specify each column?
I'd really rather let the CompositeUserType take care of that for me. Now, I have to
tie the @Columns to the # of properties in my CompositeUserType AND the order in which
they are defined? This seems to defeat the purpose of having a class (CompositeUserType)
to tell Hibernate how to store it.
Couldn't Hibernate prepend the property name 'location' and '_' to
the front of each property name in the CompositeUserType?
Perhaps (more than likely) I'm doing something wrong, but I get a failure if I do not
specify the columns.
Thanks,
Michael
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:41 a.m.
New subject: [Hibernate-JIRA] Updated: (HHH-4347) use property names defined in CompositeUserType as default column names
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4347?page=c...
]
Frode Carlsen updated HHH-4347:
-------------------------------
Attachment: HH-4347-hibernate-testsuite.patch
HH-4347-hibernate-core.patch
I've created a small patch for hibernate-core 3.6.0 to allow a CompositeUserType to
define a default column mapping (using @Columns and @Column annotations), which will be
concatenated with the name of the property to give unique names for an entity.
I opted to allow the @Column annotations instead of the getPropertyNames(), as it is
conceptually the same as using these on the property in the entity containing the type
today, and it allows for defining other defaults as well (length, precision, nullable,
etc).
This means that when annotations are used, they are handled the same whether they are
defined on the property (as today) or defined by default on the CompositeUserType, with
the only difference being that in the latter case the name defined on the @Column
annotation will be prefixed by the name of the property. Also, column names are allowed
to be different to the names used in queries, at the implementor's discretion.
The patch is backwards-compatible so if any CompositeUserType does not define any of these
annotations then everything works the same as before. Also, any @Columns/@Column
annotations on a property in an entity will override the default defined.
use property names defined in CompositeUserType as default column
names
-----------------------------------------------------------------------
Key: HHH-4347
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4347
Project: Hibernate Core
Issue Type: New Feature
Components: annotations
Reporter: Michael Newcomb
Priority: Minor
Attachments: HH-4347-hibernate-core.patch, HH-4347-hibernate-testsuite.patch
Consider:
public class LongitudeLatitude
{
protected double longitude;
protected double latitude;
}
public class LongitudeLatitudeCompositeUserType
implements CompositeUserType
{
public String[] getPropertyNames()
{
return new String[] { "longitude", "latitude" };
}
public Type[] getPropertyTypes()
{
return new Type[] { Hibernate.DOUBLE, Hibernate.DOUBLE };
}
...
}
@Entity
public class Test
{
@Basic(optional = false)
@Type(type = "foo.bar.LongitudeLatitudeCompositeUserType")
@Columns(columns = { @Column(name = "location_longitude"), @Column(name =
"location_latitude") })
protected LongitudeLatitude location;
}
Why does the developer need to specify each column?
I'd really rather let the CompositeUserType take care of that for me. Now, I have to
tie the @Columns to the # of properties in my CompositeUserType AND the order in which
they are defined? This seems to defeat the purpose of having a class (CompositeUserType)
to tell Hibernate how to store it.
Couldn't Hibernate prepend the property name 'location' and '_' to
the front of each property name in the CompositeUserType?
Perhaps (more than likely) I'm doing something wrong, but I get a failure if I do not
specify the columns.
Thanks,
Michael
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:19 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-4347) use property names defined in CompositeUserType as default column names
[
https://hibernate.onjira.com/browse/HHH-4347?page=com.atlassian.jira.plug...
]
Steve Ebersole updated HHH-4347:
--------------------------------
Pull Requests: https://github.com/hibernate/hibernate-orm/pull/11
Fix Version/s: 5.0.0
Targetting this for 5.0 because as I mentioned in my last comment, I am worried about
column names that end up exceeding the identifier length limits for the particular
dialect. Because the commonality (path) is all prefixed, simply truncating an applying
suffix is counter-productive.
use property names defined in CompositeUserType as default column
names
-----------------------------------------------------------------------
Key: HHH-4347
URL: https://hibernate.onjira.com/browse/HHH-4347
Project: Hibernate ORM
Issue Type: New Feature
Components: annotations
Reporter: Michael Newcomb
Priority: Minor
Fix For: 5.0.0
Attachments: HH-4347-hibernate-core.patch, HH-4347-hibernate-testsuite.patch
Consider:
public class LongitudeLatitude
{
protected double longitude;
protected double latitude;
}
public class LongitudeLatitudeCompositeUserType
implements CompositeUserType
{
public String[] getPropertyNames()
{
return new String[] { "longitude", "latitude" };
}
public Type[] getPropertyTypes()
{
return new Type[] { Hibernate.DOUBLE, Hibernate.DOUBLE };
}
...
}
@Entity
public class Test
{
@Basic(optional = false)
@Type(type = "foo.bar.LongitudeLatitudeCompositeUserType")
@Columns(columns = { @Column(name = "location_longitude"), @Column(name =
"location_latitude") })
protected LongitudeLatitude location;
}
Why does the developer need to specify each column?
I'd really rather let the CompositeUserType take care of that for me. Now, I have to
tie the @Columns to the # of properties in my CompositeUserType AND the order in which
they are defined? This seems to defeat the purpose of having a class (CompositeUserType)
to tell Hibernate how to store it.
Couldn't Hibernate prepend the property name 'location' and '_' to
the front of each property name in the CompositeUserType?
Perhaps (more than likely) I'm doing something wrong, but I get a failure if I do not
specify the columns.
Thanks,
Michael
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4440
days inactive
6126
days old
hibernate-issues@lists.jboss.org
16 comments
6 participants
participants (6)
-
Barry Kaplan (JIRA) -
Emmanuel Bernard (JIRA)
-
Frode Carlsen (JIRA)
-
Michael Newcomb (JIRA)
-
Steve Ebersole (JIRA)
-
Xavier Dury (JIRA)