[Hibernate-JIRA] Created: (HHH-2309) fetch only the lazy property needed

[Hibernate-JIRA] Created:...

[Hibernate-JIRA] Updated:...

German de la Cruz (JIRA)

Wednesday, 13 December 2006 Wed, 13 Dec '06

8:48 p.m.

fetch only the lazy property needed ------------------------------------ Key: HHH-2309 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2309 Project: Hibernate3 Type: New Feature Components: core Versions: 3.2.1 Reporter: German de la Cruz The method AbstractEntityPersister.initializeLazyProperty(..) load all lazy properties when it's called. It would be great if could only load the requested property. I think the only change we need is in AbstractEntityPersister.initializeLazyPropertiesFromDatastore(...) and AbstractEntityPersister.initializeLazyPropertiesFromCache(...). We must change them in a way that only the referenced property is loaded. After that, we must change AbstractFieldInterceptor.intercept(..) to update in a better way the unitializedFields collection (I mean, removing the actual property only instead of null it). Besides. Why in line 777 to 780 a query is executed? I think it isn't necessary. Thanks. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

Show replies by date

nikita tovstoles (JIRA)

Monday, 25 May Mon, 25 May

4:27 a.m.

New subject: [Hibernate-JIRA] Updated: (HHH-2309) fetch only the lazy property needed

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2309?page=c... ] nikita tovstoles updated HHH-2309: ---------------------------------- Attachment: HHH-2309-nikitaAtDoppelgangerDotCom-version1.patch

...

fetch only the lazy property needed ------------------------------------ Key: HHH-2309 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2309 Project: Hibernate Core Issue Type: New Feature Components: core Affects Versions: 3.2.1 Reporter: German de la Cruz Attachments: HHH-2309-nikitaAtDoppelgangerDotCom-version1.patch The method AbstractEntityPersister.initializeLazyProperty(..) load all lazy properties when it's called. It would be great if could only load the requested property. I think the only change we need is in AbstractEntityPersister.initializeLazyPropertiesFromDatastore(...) and AbstractEntityPersister.initializeLazyPropertiesFromCache(...). We must change them in a way that only the referenced property is loaded. After that, we must change AbstractFieldInterceptor.intercept(..) to update in a better way the unitializedFields collection (I mean, removing the actual property only instead of null it). Besides. Why in line 777 to 780 a query is executed? I think it isn't necessary. Thanks.

-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

nikita tovstoles (JIRA)

4:44 a.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2309) fetch only the lazy property needed

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2309?page=c... ] nikita tovstoles commented on HHH-2309: --------------------------------------- Patch Submission Attached HHH-2309-nikitaAtDoppelgangerDotCom-version1.patch fixes this issue for the case when all lazy properties are one-to-one's on a shared PK. in this case AbstractEntityPersister.initializeLazyProperty: -no longer needlessly goes to the 2nd level cache -initializes requested property only -Fully passes Hibernate Core testsuite This patch is based on Hibernate Core 3.3.1.GA and should be applied from within the parent directory of 'core' and 'testsuite' dirs. What about the general case? I think the only thing(s) left to do to enable un-batched lazy property initialization for cases other than one-to-one on a shared PK are: - generate appropriate sql lazySelectString given property being requested (in AEP.initializeLazyPropertiesFromDatastore) - possibly alter CacheEntry to enumerate uninitialized properties (rather than simply store a boolean value) That's it Impl Notes -bulk of work invloved replacing calls to AbstractEntityPersister.hasUninitializedLazyProperties() with ones to a new AbstractEntityPersister.getUninitializedLazyPropertyNames() -generates appropriate SQL in AbstractEntityPersister.update (see comments around line 2655) -made an assumption that StandardPropertyName.getName() returns the same string as in AbstractFieldInterceptor.uninitializedFields (i.e. fieldName == property name). This assumption seems safe because it's already been made in PojoEntityTuplizer.afterInitialize() where lazyProps are being passed in for FieldInterceptionHelper.injectFieldInterceptor(..,..,uninitializedFieldNames) -left AbstractEntityPersister.generateLazySelectString() unchanged, and so AEP.initializeLazyPropertiesFromDatastore() will execute the same sql as before when lazySelect != null. (that is when lazy props include columns other than shared PKs) Implications: initializeLazyPropertiesFromDatastore will be called every time as long as hasUninitializedLazyProperties will keep returning true

...

fetch only the lazy property needed ------------------------------------ Key: HHH-2309 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2309 Project: Hibernate Core Issue Type: New Feature Components: core Affects Versions: 3.2.1 Reporter: German de la Cruz Attachments: HHH-2309-nikitaAtDoppelgangerDotCom-version1.patch The method AbstractEntityPersister.initializeLazyProperty(..) load all lazy properties when it's called. It would be great if could only load the requested property. I think the only change we need is in AbstractEntityPersister.initializeLazyPropertiesFromDatastore(...) and AbstractEntityPersister.initializeLazyPropertiesFromCache(...). We must change them in a way that only the referenced property is loaded. After that, we must change AbstractFieldInterceptor.intercept(..) to update in a better way the unitializedFields collection (I mean, removing the actual property only instead of null it). Besides. Why in line 777 to 780 a query is executed? I think it isn't necessary. Thanks.

Steve Ebersole (JIRA)

Friday, 29 May Fri, 29 May

9:08 p.m.

New subject: [Hibernate-JIRA] Updated: (HHH-2309) fetch only the lazy property needed

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2309?page=c... ] Steve Ebersole updated HHH-2309: -------------------------------- Assignee: Steve Ebersole Fix Version/s: 3.5 3.3.x

...

fetch only the lazy property needed ------------------------------------ Key: HHH-2309 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2309 Project: Hibernate Core Issue Type: New Feature Components: core Affects Versions: 3.2.1 Reporter: German de la Cruz Assignee: Steve Ebersole Fix For: 3.3.x, 3.5 Attachments: HHH-2309-nikitaAtDoppelgangerDotCom-version1.patch The method AbstractEntityPersister.initializeLazyProperty(..) load all lazy properties when it's called. It would be great if could only load the requested property. I think the only change we need is in AbstractEntityPersister.initializeLazyPropertiesFromDatastore(...) and AbstractEntityPersister.initializeLazyPropertiesFromCache(...). We must change them in a way that only the referenced property is loaded. After that, we must change AbstractFieldInterceptor.intercept(..) to update in a better way the unitializedFields collection (I mean, removing the actual property only instead of null it). Besides. Why in line 777 to 780 a query is executed? I think it isn't necessary. Thanks.

Steve Ebersole (JIRA)

9:38 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2309) fetch only the lazy property needed

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2309?page=c... ] Steve Ebersole commented on HHH-2309: ------------------------------------- nikita, first thanks for the patch. The changes to Cascade happened to be the first one in the patch so its what I noticed first. Note sure if this applies to the other uses or not yet. Because it is always checking against the "full set" of lazy property names from the persister it is currently going to skip lazy properties which have in fact been initialized.

...

fetch only the lazy property needed ------------------------------------ Key: HHH-2309 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2309 Project: Hibernate Core Issue Type: New Feature Components: core Affects Versions: 3.2.1 Reporter: German de la Cruz Assignee: Steve Ebersole Fix For: 3.3.x, 3.5 Attachments: HHH-2309-nikitaAtDoppelgangerDotCom-version1.patch The method AbstractEntityPersister.initializeLazyProperty(..) load all lazy properties when it's called. It would be great if could only load the requested property. I think the only change we need is in AbstractEntityPersister.initializeLazyPropertiesFromDatastore(...) and AbstractEntityPersister.initializeLazyPropertiesFromCache(...). We must change them in a way that only the referenced property is loaded. After that, we must change AbstractFieldInterceptor.intercept(..) to update in a better way the unitializedFields collection (I mean, removing the actual property only instead of null it). Besides. Why in line 777 to 780 a query is executed? I think it isn't necessary. Thanks.

Steve Ebersole (JIRA)

Tuesday, 23 June Tue, 23 Jun

10:08 p.m.

New subject: [Hibernate-JIRA] Updated: (HHH-2309) fetch only the lazy property needed

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2309?page=c... ] Steve Ebersole updated HHH-2309: -------------------------------- Fix Version/s: (was: 3.3.2) 3.3.x

...

fetch only the lazy property needed ------------------------------------ Key: HHH-2309 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2309 Project: Hibernate Core Issue Type: New Feature Components: core Affects Versions: 3.2.1 Reporter: German de la Cruz Assignee: Steve Ebersole Fix For: 3.3.x, 3.5 Attachments: HHH-2309-nikitaAtDoppelgangerDotCom-version1.patch The method AbstractEntityPersister.initializeLazyProperty(..) load all lazy properties when it's called. It would be great if could only load the requested property. I think the only change we need is in AbstractEntityPersister.initializeLazyPropertiesFromDatastore(...) and AbstractEntityPersister.initializeLazyPropertiesFromCache(...). We must change them in a way that only the referenced property is loaded. After that, we must change AbstractFieldInterceptor.intercept(..) to update in a better way the unitializedFields collection (I mean, removing the actual property only instead of null it). Besides. Why in line 777 to 780 a query is executed? I think it isn't necessary. Thanks.

Steve Ebersole (JIRA)

Tuesday, 18 August Tue, 18 Aug

2:26 p.m.

New subject: [Hibernate-JIRA] Updated: (HHH-2309) fetch only the lazy property needed

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2309?page=c... ] Steve Ebersole updated HHH-2309: -------------------------------- Fix Version/s: (was: 3.5.0.Beta-1) 3.5-tmp

...

fetch only the lazy property needed ------------------------------------ Key: HHH-2309 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2309 Project: Hibernate Core Issue Type: New Feature Components: core Affects Versions: 3.2.1 Reporter: German de la Cruz Assignee: Steve Ebersole Fix For: 3.3.x, 3.5 Attachments: HHH-2309-nikitaAtDoppelgangerDotCom-version1.patch The method AbstractEntityPersister.initializeLazyProperty(..) load all lazy properties when it's called. It would be great if could only load the requested property. I think the only change we need is in AbstractEntityPersister.initializeLazyPropertiesFromDatastore(...) and AbstractEntityPersister.initializeLazyPropertiesFromCache(...). We must change them in a way that only the referenced property is loaded. After that, we must change AbstractFieldInterceptor.intercept(..) to update in a better way the unitializedFields collection (I mean, removing the actual property only instead of null it). Besides. Why in line 777 to 780 a query is executed? I think it isn't necessary. Thanks.

Steve Ebersole (JIRA)

Tuesday, 16 February Tue, 16 Feb

10:27 p.m.

New subject: [Hibernate-JIRA] Updated: (HHH-2309) fetch only the lazy property needed

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2309?page=c... ] Steve Ebersole updated HHH-2309: -------------------------------- Fix Version/s: (was: 3.5.0-CR-2) 3.5.x

...

fetch only the lazy property needed ------------------------------------ Key: HHH-2309 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2309 Project: Hibernate Core Issue Type: New Feature Components: core Affects Versions: 3.2.1 Reporter: German de la Cruz Assignee: Steve Ebersole Fix For: 3.5.x Attachments: HHH-2309-nikitaAtDoppelgangerDotCom-version1.patch The method AbstractEntityPersister.initializeLazyProperty(..) load all lazy properties when it's called. It would be great if could only load the requested property. I think the only change we need is in AbstractEntityPersister.initializeLazyPropertiesFromDatastore(...) and AbstractEntityPersister.initializeLazyPropertiesFromCache(...). We must change them in a way that only the referenced property is loaded. After that, we must change AbstractFieldInterceptor.intercept(..) to update in a better way the unitializedFields collection (I mean, removing the actual property only instead of null it). Besides. Why in line 777 to 780 a query is executed? I think it isn't necessary. Thanks.

Steve Ebersole (JIRA)

Wednesday, 14 April Wed, 14 Apr

8:14 p.m.

New subject: [Hibernate-JIRA] Updated: (HHH-2309) fetch only the lazy property needed

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2309?page=c... ] Steve Ebersole updated HHH-2309: -------------------------------- Fix Version/s: (was: 3.5.1) 3.5.x

...

fetch only the lazy property needed ------------------------------------ Key: HHH-2309 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2309 Project: Hibernate Core Issue Type: New Feature Components: core Affects Versions: 3.2.1 Reporter: German de la Cruz Assignee: Steve Ebersole Fix For: 3.5.x Attachments: HHH-2309-nikitaAtDoppelgangerDotCom-version1.patch The method AbstractEntityPersister.initializeLazyProperty(..) load all lazy properties when it's called. It would be great if could only load the requested property. I think the only change we need is in AbstractEntityPersister.initializeLazyPropertiesFromDatastore(...) and AbstractEntityPersister.initializeLazyPropertiesFromCache(...). We must change them in a way that only the referenced property is loaded. After that, we must change AbstractFieldInterceptor.intercept(..) to update in a better way the unitializedFields collection (I mean, removing the actual property only instead of null it). Besides. Why in line 777 to 780 a query is executed? I think it isn't necessary. Thanks.

Paul Benedict (JIRA)

10:59 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2309) fetch only the lazy property needed

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2309?page=c... ] Paul Benedict commented on HHH-2309: ------------------------------------ I would like this be an additional Lazy Fetching constant.

...

fetch only the lazy property needed ------------------------------------ Key: HHH-2309 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2309 Project: Hibernate Core Issue Type: New Feature Components: core Affects Versions: 3.2.1 Reporter: German de la Cruz Assignee: Steve Ebersole Fix For: 3.5.x Attachments: HHH-2309-nikitaAtDoppelgangerDotCom-version1.patch The method AbstractEntityPersister.initializeLazyProperty(..) load all lazy properties when it's called. It would be great if could only load the requested property. I think the only change we need is in AbstractEntityPersister.initializeLazyPropertiesFromDatastore(...) and AbstractEntityPersister.initializeLazyPropertiesFromCache(...). We must change them in a way that only the referenced property is loaded. After that, we must change AbstractFieldInterceptor.intercept(..) to update in a better way the unitializedFields collection (I mean, removing the actual property only instead of null it). Besides. Why in line 777 to 780 a query is executed? I think it isn't necessary. Thanks.

Gail Badner (JIRA)

Monday, 14 June Mon, 14 Jun

8:21 p.m.

New subject: [Hibernate-JIRA] Updated: (HHH-2309) fetch only the lazy property needed

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2309?page=c... ] Gail Badner updated HHH-2309: ----------------------------- Fix Version/s: (was: 3.5.3) 3.5.x

...

fetch only the lazy property needed ------------------------------------ Key: HHH-2309 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2309 Project: Hibernate Core Issue Type: New Feature Components: core Affects Versions: 3.2.1 Reporter: German de la Cruz Assignee: Steve Ebersole Fix For: 3.5.x Attachments: HHH-2309-nikitaAtDoppelgangerDotCom-version1.patch The method AbstractEntityPersister.initializeLazyProperty(..) load all lazy properties when it's called. It would be great if could only load the requested property. I think the only change we need is in AbstractEntityPersister.initializeLazyPropertiesFromDatastore(...) and AbstractEntityPersister.initializeLazyPropertiesFromCache(...). We must change them in a way that only the referenced property is loaded. After that, we must change AbstractFieldInterceptor.intercept(..) to update in a better way the unitializedFields collection (I mean, removing the actual property only instead of null it). Besides. Why in line 777 to 780 a query is executed? I think it isn't necessary. Thanks.

Gail Badner (JIRA)

Monday, 12 July Mon, 12 Jul

6:44 p.m.

New subject: [Hibernate-JIRA] Updated: (HHH-2309) fetch only the lazy property needed

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2309?page=c... ] Gail Badner updated HHH-2309: ----------------------------- Fix Version/s: (was: 3.5.4) 3.5.x

...

fetch only the lazy property needed ------------------------------------ Key: HHH-2309 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2309 Project: Hibernate Core Issue Type: New Feature Components: core Affects Versions: 3.2.1 Reporter: German de la Cruz Assignee: Steve Ebersole Fix For: 3.5.x Attachments: HHH-2309-nikitaAtDoppelgangerDotCom-version1.patch The method AbstractEntityPersister.initializeLazyProperty(..) load all lazy properties when it's called. It would be great if could only load the requested property. I think the only change we need is in AbstractEntityPersister.initializeLazyPropertiesFromDatastore(...) and AbstractEntityPersister.initializeLazyPropertiesFromCache(...). We must change them in a way that only the referenced property is loaded. After that, we must change AbstractFieldInterceptor.intercept(..) to update in a better way the unitializedFields collection (I mean, removing the actual property only instead of null it). Besides. Why in line 777 to 780 a query is executed? I think it isn't necessary. Thanks.

Gail Badner (JIRA)

10:12 p.m.

New subject: [Hibernate-JIRA] Updated: (HHH-2309) fetch only the lazy property needed

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2309?page=c... ] Gail Badner updated HHH-2309: ----------------------------- This issue is currently scheduled for 3.5.x, but not 3.6. Should this issue be fixed in 3.6 as well (or instead)? If so, please correct the fix version(s). Thanks, Gail

...

fetch only the lazy property needed ------------------------------------ Key: HHH-2309 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2309 Project: Hibernate Core Issue Type: New Feature Components: core Affects Versions: 3.2.1 Reporter: German de la Cruz Assignee: Steve Ebersole Fix For: 3.5.x Attachments: HHH-2309-nikitaAtDoppelgangerDotCom-version1.patch The method AbstractEntityPersister.initializeLazyProperty(..) load all lazy properties when it's called. It would be great if could only load the requested property. I think the only change we need is in AbstractEntityPersister.initializeLazyPropertiesFromDatastore(...) and AbstractEntityPersister.initializeLazyPropertiesFromCache(...). We must change them in a way that only the referenced property is loaded. After that, we must change AbstractFieldInterceptor.intercept(..) to update in a better way the unitializedFields collection (I mean, removing the actual property only instead of null it). Besides. Why in line 777 to 780 a query is executed? I think it isn't necessary. Thanks.

5037

days inactive

6344

days old

hibernate-issues@lists.jboss.org

Manage subscription

12 comments

5 participants

tags (0)

participants (5)

Gail Badner (JIRA)
German de la Cruz (JIRA)
nikita tovstoles (JIRA)
Paul Benedict (JIRA)
Steve Ebersole (JIRA)

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

[Hibernate-JIRA] Created: (HHH-2309) fetch only the lazy property needed