[Hibernate-JIRA] Created: (HV-146) ValidatorTypeHelper.resolveTypes ignores return value of recursive call
4:52 p.m.
ValidatorTypeHelper.resolveTypes ignores return value of recursive call
-----------------------------------------------------------------------
Key: HV-146
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-146
Project: Hibernate Validator
Issue Type: Bug
Affects Versions: 4.0.0.Alpha3
Reporter: Eddy Verbruggen
My Validator classes extend a common superclass, which in turn implements the
ConstraintValidator interface. This version of Hibernate Validator can't cope with
that class structure due to a little bug in ValidatorTypeHelper.resolveTypes.
The last bit of that method calls itself recursively, but ignores returnvalues, so the
code always falls through to "return null".
else {
resolveTypes( resolvedTypes, rawType.getGenericSuperclass() );
for ( Type genericInterface : rawType.getGenericInterfaces() ) {
resolveTypes( resolvedTypes, genericInterface );
}
}
}
//else we don't care I think
return null;
Can it be changed to something like this please:
else {
Type returnedType = resolveTypes( resolvedTypes, rawType.getGenericSuperclass() );
if ( returnedType != null ) {
return returnedType;
}
for ( Type genericInterface : rawType.getGenericInterfaces() ) {
returnedType = resolveTypes( resolvedTypes, genericInterface );
if ( returnedType != null ) {
return returnedType;
}
}
}
}
//else we don't care I think
return null;
The stacktrace is:
java.lang.NullPointerException
at
org.hibernate.validation.util.ValidatorTypeHelper.extractType(ValidatorTypeHelper.java:68)
at
org.hibernate.validation.util.ValidatorTypeHelper.getValidatorsTypes(ValidatorTypeHelper.java:57)
at
org.hibernate.validation.engine.ConstraintTree.findMatchingValidatorClass(ConstraintTree.java:163)
at
org.hibernate.validation.engine.ConstraintTree.getInitalizedValidator(ConstraintTree.java:144)
at
org.hibernate.validation.engine.ConstraintTree.validateConstraints(ConstraintTree.java:113)
at
org.hibernate.validation.engine.MetaConstraint.validateConstraint(MetaConstraint.java:126)
at
org.hibernate.validation.engine.ValidatorImpl.validatePropertyForGroup(ValidatorImpl.java:419)
at
org.hibernate.validation.engine.ValidatorImpl.validateProperty(ValidatorImpl.java:373)
at
org.hibernate.validation.engine.ValidatorImpl.validateProperty(ValidatorImpl.java:132)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:07 p.m.
New subject: [Hibernate-JIRA] Commented: (HV-146) ValidatorTypeHelper.resolveTypes ignores return value of recursive call
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-146?page=com...
]
Eddy Verbruggen commented on HV-146:
------------------------------------
For the record, I've tested the proposed change locally now and it works like a dream.
Having it fixed in the 4.0.0.GA version would be much appreciated.
ValidatorTypeHelper.resolveTypes ignores return value of recursive
call
-----------------------------------------------------------------------
Key: HV-146
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-146
Project: Hibernate Validator
Issue Type: Bug
Affects Versions: 4.0.0.Alpha3
Reporter: Eddy Verbruggen
Original Estimate: 1 hour
Remaining Estimate: 1 hour
My Validator classes extend a common superclass, which in turn implements the
ConstraintValidator interface. This version of Hibernate Validator can't cope with
that class structure due to a little bug in ValidatorTypeHelper.resolveTypes.
The last bit of that method calls itself recursively, but ignores returnvalues, so the
code always falls through to "return null".
else {
resolveTypes( resolvedTypes, rawType.getGenericSuperclass() );
for ( Type genericInterface : rawType.getGenericInterfaces() ) {
resolveTypes( resolvedTypes, genericInterface );
}
}
}
//else we don't care I think
return null;
Can it be changed to something like this please:
else {
Type returnedType = resolveTypes( resolvedTypes, rawType.getGenericSuperclass() );
if ( returnedType != null ) {
return returnedType;
}
for ( Type genericInterface : rawType.getGenericInterfaces() ) {
returnedType = resolveTypes( resolvedTypes, genericInterface );
if ( returnedType != null ) {
return returnedType;
}
}
}
}
//else we don't care I think
return null;
The stacktrace is:
java.lang.NullPointerException
at
org.hibernate.validation.util.ValidatorTypeHelper.extractType(ValidatorTypeHelper.java:68)
at
org.hibernate.validation.util.ValidatorTypeHelper.getValidatorsTypes(ValidatorTypeHelper.java:57)
at
org.hibernate.validation.engine.ConstraintTree.findMatchingValidatorClass(ConstraintTree.java:163)
at
org.hibernate.validation.engine.ConstraintTree.getInitalizedValidator(ConstraintTree.java:144)
at
org.hibernate.validation.engine.ConstraintTree.validateConstraints(ConstraintTree.java:113)
at
org.hibernate.validation.engine.MetaConstraint.validateConstraint(MetaConstraint.java:126)
at
org.hibernate.validation.engine.ValidatorImpl.validatePropertyForGroup(ValidatorImpl.java:419)
at
org.hibernate.validation.engine.ValidatorImpl.validateProperty(ValidatorImpl.java:373)
at
org.hibernate.validation.engine.ValidatorImpl.validateProperty(ValidatorImpl.java:132)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:06 p.m.
New subject: [Hibernate-JIRA] Updated: (HV-146) ConstraintValidator impls cannot inherit from a super class implementing ConstraintValidator
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-146?page=com...
]
Emmanuel Bernard updated HV-146:
--------------------------------
Component/s: engine
Fix Version/s: 4.0.0.Beta2
Summary: ConstraintValidator impls cannot inherit from a super class
implementing ConstraintValidator (was: ValidatorTypeHelper.resolveTypes ignores return
value of recursive call)
Thanks for the report, I've added a test and a modified version of what you proposed.
If you have a chance, give it a try from trunk
ConstraintValidator impls cannot inherit from a super class
implementing ConstraintValidator
--------------------------------------------------------------------------------------------
Key: HV-146
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-146
Project: Hibernate Validator
Issue Type: Bug
Components: engine
Affects Versions: 4.0.0.Alpha3
Reporter: Eddy Verbruggen
Fix For: 4.0.0.Beta2
Original Estimate: 1 hour
Remaining Estimate: 1 hour
My Validator classes extend a common superclass, which in turn implements the
ConstraintValidator interface. This version of Hibernate Validator can't cope with
that class structure due to a little bug in ValidatorTypeHelper.resolveTypes.
The last bit of that method calls itself recursively, but ignores returnvalues, so the
code always falls through to "return null".
else {
resolveTypes( resolvedTypes, rawType.getGenericSuperclass() );
for ( Type genericInterface : rawType.getGenericInterfaces() ) {
resolveTypes( resolvedTypes, genericInterface );
}
}
}
//else we don't care I think
return null;
Can it be changed to something like this please:
else {
Type returnedType = resolveTypes( resolvedTypes, rawType.getGenericSuperclass() );
if ( returnedType != null ) {
return returnedType;
}
for ( Type genericInterface : rawType.getGenericInterfaces() ) {
returnedType = resolveTypes( resolvedTypes, genericInterface );
if ( returnedType != null ) {
return returnedType;
}
}
}
}
//else we don't care I think
return null;
The stacktrace is:
java.lang.NullPointerException
at
org.hibernate.validation.util.ValidatorTypeHelper.extractType(ValidatorTypeHelper.java:68)
at
org.hibernate.validation.util.ValidatorTypeHelper.getValidatorsTypes(ValidatorTypeHelper.java:57)
at
org.hibernate.validation.engine.ConstraintTree.findMatchingValidatorClass(ConstraintTree.java:163)
at
org.hibernate.validation.engine.ConstraintTree.getInitalizedValidator(ConstraintTree.java:144)
at
org.hibernate.validation.engine.ConstraintTree.validateConstraints(ConstraintTree.java:113)
at
org.hibernate.validation.engine.MetaConstraint.validateConstraint(MetaConstraint.java:126)
at
org.hibernate.validation.engine.ValidatorImpl.validatePropertyForGroup(ValidatorImpl.java:419)
at
org.hibernate.validation.engine.ValidatorImpl.validateProperty(ValidatorImpl.java:373)
at
org.hibernate.validation.engine.ValidatorImpl.validateProperty(ValidatorImpl.java:132)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:06 p.m.
New subject: [Hibernate-JIRA] Resolved: (HV-146) ConstraintValidator impls cannot inherit from a super class implementing ConstraintValidator
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-146?page=com...
]
Emmanuel Bernard resolved HV-146.
---------------------------------
Resolution: Fixed
ConstraintValidator impls cannot inherit from a super class
implementing ConstraintValidator
--------------------------------------------------------------------------------------------
Key: HV-146
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-146
Project: Hibernate Validator
Issue Type: Bug
Components: engine
Affects Versions: 4.0.0.Alpha3
Reporter: Eddy Verbruggen
Fix For: 4.0.0.Beta2
Original Estimate: 1 hour
Remaining Estimate: 1 hour
My Validator classes extend a common superclass, which in turn implements the
ConstraintValidator interface. This version of Hibernate Validator can't cope with
that class structure due to a little bug in ValidatorTypeHelper.resolveTypes.
The last bit of that method calls itself recursively, but ignores returnvalues, so the
code always falls through to "return null".
else {
resolveTypes( resolvedTypes, rawType.getGenericSuperclass() );
for ( Type genericInterface : rawType.getGenericInterfaces() ) {
resolveTypes( resolvedTypes, genericInterface );
}
}
}
//else we don't care I think
return null;
Can it be changed to something like this please:
else {
Type returnedType = resolveTypes( resolvedTypes, rawType.getGenericSuperclass() );
if ( returnedType != null ) {
return returnedType;
}
for ( Type genericInterface : rawType.getGenericInterfaces() ) {
returnedType = resolveTypes( resolvedTypes, genericInterface );
if ( returnedType != null ) {
return returnedType;
}
}
}
}
//else we don't care I think
return null;
The stacktrace is:
java.lang.NullPointerException
at
org.hibernate.validation.util.ValidatorTypeHelper.extractType(ValidatorTypeHelper.java:68)
at
org.hibernate.validation.util.ValidatorTypeHelper.getValidatorsTypes(ValidatorTypeHelper.java:57)
at
org.hibernate.validation.engine.ConstraintTree.findMatchingValidatorClass(ConstraintTree.java:163)
at
org.hibernate.validation.engine.ConstraintTree.getInitalizedValidator(ConstraintTree.java:144)
at
org.hibernate.validation.engine.ConstraintTree.validateConstraints(ConstraintTree.java:113)
at
org.hibernate.validation.engine.MetaConstraint.validateConstraint(MetaConstraint.java:126)
at
org.hibernate.validation.engine.ValidatorImpl.validatePropertyForGroup(ValidatorImpl.java:419)
at
org.hibernate.validation.engine.ValidatorImpl.validateProperty(ValidatorImpl.java:373)
at
org.hibernate.validation.engine.ValidatorImpl.validateProperty(ValidatorImpl.java:132)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:33 a.m.
New subject: [Hibernate-JIRA] Closed: (HV-146) ConstraintValidator impls cannot inherit from a super class implementing ConstraintValidator
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-146?page=com...
]
Eddy Verbruggen closed HV-146.
------------------------------
I've tested your change and it works perfectly.
Thanks a lot!
ConstraintValidator impls cannot inherit from a super class
implementing ConstraintValidator
--------------------------------------------------------------------------------------------
Key: HV-146
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-146
Project: Hibernate Validator
Issue Type: Bug
Components: engine
Affects Versions: 4.0.0.Alpha3
Reporter: Eddy Verbruggen
Fix For: 4.0.0.Beta2
Original Estimate: 1 hour
Remaining Estimate: 1 hour
My Validator classes extend a common superclass, which in turn implements the
ConstraintValidator interface. This version of Hibernate Validator can't cope with
that class structure due to a little bug in ValidatorTypeHelper.resolveTypes.
The last bit of that method calls itself recursively, but ignores returnvalues, so the
code always falls through to "return null".
else {
resolveTypes( resolvedTypes, rawType.getGenericSuperclass() );
for ( Type genericInterface : rawType.getGenericInterfaces() ) {
resolveTypes( resolvedTypes, genericInterface );
}
}
}
//else we don't care I think
return null;
Can it be changed to something like this please:
else {
Type returnedType = resolveTypes( resolvedTypes, rawType.getGenericSuperclass() );
if ( returnedType != null ) {
return returnedType;
}
for ( Type genericInterface : rawType.getGenericInterfaces() ) {
returnedType = resolveTypes( resolvedTypes, genericInterface );
if ( returnedType != null ) {
return returnedType;
}
}
}
}
//else we don't care I think
return null;
The stacktrace is:
java.lang.NullPointerException
at
org.hibernate.validation.util.ValidatorTypeHelper.extractType(ValidatorTypeHelper.java:68)
at
org.hibernate.validation.util.ValidatorTypeHelper.getValidatorsTypes(ValidatorTypeHelper.java:57)
at
org.hibernate.validation.engine.ConstraintTree.findMatchingValidatorClass(ConstraintTree.java:163)
at
org.hibernate.validation.engine.ConstraintTree.getInitalizedValidator(ConstraintTree.java:144)
at
org.hibernate.validation.engine.ConstraintTree.validateConstraints(ConstraintTree.java:113)
at
org.hibernate.validation.engine.MetaConstraint.validateConstraint(MetaConstraint.java:126)
at
org.hibernate.validation.engine.ValidatorImpl.validatePropertyForGroup(ValidatorImpl.java:419)
at
org.hibernate.validation.engine.ValidatorImpl.validateProperty(ValidatorImpl.java:373)
at
org.hibernate.validation.engine.ValidatorImpl.validateProperty(ValidatorImpl.java:132)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5521
days inactive
5532
days old
hibernate-issues@lists.jboss.org
4 comments
2 participants
participants (2)
-
Eddy Verbruggen (JIRA) -
Emmanuel Bernard (JIRA)