[ http://opensource.atlassian.com/projects/hibernate/browse/HV-269?page=com... ] Hardy Ferentschik updated HV-269: --------------------------------- Affects Version/s: 4.0.2.GA Fix Version/s: 4.1.0 Component/s: validators engine We can create a new module for this and use a similar setup as for the JPA2 meta model annotation processor. Adding this module to the current build will, however, mean that we are forcing the build to use JDK 6. The annotation processor API is only official since Java 6. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-269?page=com... ] Hardy Ferentschik commented on HV-269: -------------------------------------- I created a module for the annotation processor in the trunk. Some thoughts: * The processor probably should have a flag on whether to fail the compilation on a wrongly configured constraint or whether to just print a warning. * Tests should probably utilize the javax.tools.JavaCompiler API. * Which constraints should we support. Should we just list the constraints we want to verify in @SupportedAnnotationTypes of the processor. This makes the processing easier/faster. If we use @SupportedAnnotationTypes(*) we have to first check whether the annotation is a constraint (ConstraintHelper.isConstraintAnnotation) and then we have to somehow decide whether there is anything to check. This approach would be interesting if we could somehow let people provide their own constraint declaration check implementations. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-269?page=com... ] Emmanuel Bernard commented on HV-269: ------------------------------------- no it should be all constraint annotations. The minute you add options to a safety system, people disable it and it's useless. If really we have performance issues (but compilation is really 1/100th of a build time these days), then we can revisit. Plus incremental compilation will only revisit changes classes. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-269?page=com... ] Emmanuel Bernard commented on HV-269: ------------------------------------- Hardy, you're talking about HV-270 let's start with the basics of verifying the return propery type compatibility first. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-269?page=com... ] Gunnar Morling commented on HV-269: ----------------------------------- Work in progress: sent a patch with a first version of the processor to Hardy. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-269?page=com... ] Hardy Ferentschik resolved HV-269. ---------------------------------- Resolution: Fixed The main implementation is complete. From now we create new issues for bugs -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira