[Hibernate-JIRA] Created: (HHH-3718) call to id getter initializes proxy when using AccessType( "field" )
11:42 p.m.
call to id getter initializes proxy when using AccessType( "field" )
--------------------------------------------------------------------
Key: HHH-3718
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3718
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.3.1
Environment: hibernate 3.3.1, hibernate annotations 3.4.0, running on windows,
linux and solaris, using sybase 15
Reporter: Paul Lorenz
Calling getter for id when using AccessType( "field" ) causes proxy
initialization.
In org.hibernate.proxy.proxy.pojo.BasicLazyInitializer there is the code
else if ( isUninitialized() && method.equals(getIdentifierMethod) ) {
return getIdentifier();
}
However, when using field access, the getIdentifierMethod will be null. I fixed this for
us by changing DirectPropertyAccessor by adding a Method attribute to the DirectGetter
inner class, and looking up the appropriate getter in the constructor. As far as I can
tell, getMethod is only used in two places. In the above case, to the get the identity
getter and in PojoComponentTupilizer.isMethodOf. This doesn't seem to break anything.
I don't know if this is a clean solution, seems a little hacky to me, however, it
would be great if the issue could be fixed somehow.
public static final class DirectGetter implements Getter {
private final transient Field field;
private final Class clazz;
private final String name;
private Method method;
DirectGetter(Field field, Class clazz, String name) {
this.field = field;
this.clazz = clazz;
this.name = name;
try
{
BeanInfo beanInfo = Introspector.getBeanInfo( clazz );
PropertyDescriptor[] pdArray = beanInfo.getPropertyDescriptors();
if ( pdArray != null )
{
for (PropertyDescriptor pd : pdArray )
{
if ( pd.getName().equals( name ) )
{
this.method = pd.getReadMethod();
}
}
}
}
catch ( Exception e )
{
// ignore
}
}
public Object get(Object target) throws HibernateException {
try {
return field.get(target);
}
catch (Exception e) {
throw new PropertyAccessException(e, "could not get a field value by
reflection", false, clazz, name);
}
}
public Object getForInsert(Object target, Map mergeMap, SessionImplementor session) {
return get( target );
}
public Method getMethod() {
return method;
}
public String getMethodName() {
return method == null ? null : method.getName();
}
public Class getReturnType() {
return field.getType();
}
Object readResolve() {
return new DirectGetter( getField(clazz, name), clazz, name );
}
public String toString() {
return "DirectGetter(" + clazz.getName() + '.' + name +
')';
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:19 a.m.
New subject: [Hibernate-JIRA] Updated: (HHH-3718) call to id getter initializes proxy when using AccessType( "field" )
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3718?page=c...
]
Paul Lorenz updated HHH-3718:
-----------------------------
Attachment: ids.patch
Patch to solve issues with @AccessType( "field" ) and id getter invocation
causing proxy initialization.
call to id getter initializes proxy when using AccessType(
"field" )
--------------------------------------------------------------------
Key: HHH-3718
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3718
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.3.1
Environment: hibernate 3.3.1, hibernate annotations 3.4.0, running on windows,
linux and solaris, using sybase 15
Reporter: Paul Lorenz
Attachments: ids.patch
Calling getter for id when using AccessType( "field" ) causes proxy
initialization.
In org.hibernate.proxy.proxy.pojo.BasicLazyInitializer there is the code
else if ( isUninitialized() && method.equals(getIdentifierMethod) ) {
return getIdentifier();
}
However, when using field access, the getIdentifierMethod will be null. I fixed this for
us by changing DirectPropertyAccessor by adding a Method attribute to the DirectGetter
inner class, and looking up the appropriate getter in the constructor. As far as I can
tell, getMethod is only used in two places. In the above case, to the get the identity
getter and in PojoComponentTupilizer.isMethodOf. This doesn't seem to break anything.
I don't know if this is a clean solution, seems a little hacky to me, however, it
would be great if the issue could be fixed somehow.
public static final class DirectGetter implements Getter {
private final transient Field field;
private final Class clazz;
private final String name;
private Method method;
DirectGetter(Field field, Class clazz, String name) {
this.field = field;
this.clazz = clazz;
this.name = name;
try
{
BeanInfo beanInfo = Introspector.getBeanInfo( clazz );
PropertyDescriptor[] pdArray = beanInfo.getPropertyDescriptors();
if ( pdArray != null )
{
for (PropertyDescriptor pd : pdArray )
{
if ( pd.getName().equals( name ) )
{
this.method = pd.getReadMethod();
}
}
}
}
catch ( Exception e )
{
// ignore
}
}
public Object get(Object target) throws HibernateException {
try {
return field.get(target);
}
catch (Exception e) {
throw new PropertyAccessException(e, "could not get a field value by
reflection", false, clazz, name);
}
}
public Object getForInsert(Object target, Map mergeMap, SessionImplementor session)
{
return get( target );
}
public Method getMethod() {
return method;
}
public String getMethodName() {
return method == null ? null : method.getName();
}
public Class getReturnType() {
return field.getType();
}
Object readResolve() {
return new DirectGetter( getField(clazz, name), clazz, name );
}
public String toString() {
return "DirectGetter(" + clazz.getName() + '.' + name +
')';
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:22 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3718) call to id getter initializes proxy when using AccessType( "field" )
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3718?page=c...
]
Paul Lorenz commented on HHH-3718:
----------------------------------
I've added a patch to solve this problem slightly different, using a lazy lookup of
the method.
We're also having a problem where the method being invoked is different from
identified get method.
We have a common interface for entities which includes a method
Serializable getId ()
in a subclass, we have
Long getId ()
When the proxy is invoked, it invokes the Serializable getId () method, however the
getIdentifierMethod in BasicLazyInitializer is the Long getId() method. Since they
don't match, it initializes the proxy.
I replaced this with a heuristic based on method name and number of arguments, since this
should be more accurate.
call to id getter initializes proxy when using AccessType(
"field" )
--------------------------------------------------------------------
Key: HHH-3718
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3718
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.3.1
Environment: hibernate 3.3.1, hibernate annotations 3.4.0, running on windows,
linux and solaris, using sybase 15
Reporter: Paul Lorenz
Attachments: ids.patch
Calling getter for id when using AccessType( "field" ) causes proxy
initialization.
In org.hibernate.proxy.proxy.pojo.BasicLazyInitializer there is the code
else if ( isUninitialized() && method.equals(getIdentifierMethod) ) {
return getIdentifier();
}
However, when using field access, the getIdentifierMethod will be null. I fixed this for
us by changing DirectPropertyAccessor by adding a Method attribute to the DirectGetter
inner class, and looking up the appropriate getter in the constructor. As far as I can
tell, getMethod is only used in two places. In the above case, to the get the identity
getter and in PojoComponentTupilizer.isMethodOf. This doesn't seem to break anything.
I don't know if this is a clean solution, seems a little hacky to me, however, it
would be great if the issue could be fixed somehow.
public static final class DirectGetter implements Getter {
private final transient Field field;
private final Class clazz;
private final String name;
private Method method;
DirectGetter(Field field, Class clazz, String name) {
this.field = field;
this.clazz = clazz;
this.name = name;
try
{
BeanInfo beanInfo = Introspector.getBeanInfo( clazz );
PropertyDescriptor[] pdArray = beanInfo.getPropertyDescriptors();
if ( pdArray != null )
{
for (PropertyDescriptor pd : pdArray )
{
if ( pd.getName().equals( name ) )
{
this.method = pd.getReadMethod();
}
}
}
}
catch ( Exception e )
{
// ignore
}
}
public Object get(Object target) throws HibernateException {
try {
return field.get(target);
}
catch (Exception e) {
throw new PropertyAccessException(e, "could not get a field value by
reflection", false, clazz, name);
}
}
public Object getForInsert(Object target, Map mergeMap, SessionImplementor session)
{
return get( target );
}
public Method getMethod() {
return method;
}
public String getMethodName() {
return method == null ? null : method.getName();
}
public Class getReturnType() {
return field.getType();
}
Object readResolve() {
return new DirectGetter( getField(clazz, name), clazz, name );
}
public String toString() {
return "DirectGetter(" + clazz.getName() + '.' + name +
')';
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:39 a.m.
New subject: [Hibernate-JIRA] Updated: (HHH-3718) call to id getter initializes proxy when using AccessType( "field" )
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3718?page=c...
]
Paul Lorenz updated HHH-3718:
-----------------------------
Attachment: ids.patch
Fixed patch. Original patch was reversed.
call to id getter initializes proxy when using AccessType(
"field" )
--------------------------------------------------------------------
Key: HHH-3718
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3718
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.3.1
Environment: hibernate 3.3.1, hibernate annotations 3.4.0, running on windows,
linux and solaris, using sybase 15
Reporter: Paul Lorenz
Attachments: ids.patch, ids.patch
Calling getter for id when using AccessType( "field" ) causes proxy
initialization.
In org.hibernate.proxy.proxy.pojo.BasicLazyInitializer there is the code
else if ( isUninitialized() && method.equals(getIdentifierMethod) ) {
return getIdentifier();
}
However, when using field access, the getIdentifierMethod will be null. I fixed this for
us by changing DirectPropertyAccessor by adding a Method attribute to the DirectGetter
inner class, and looking up the appropriate getter in the constructor. As far as I can
tell, getMethod is only used in two places. In the above case, to the get the identity
getter and in PojoComponentTupilizer.isMethodOf. This doesn't seem to break anything.
I don't know if this is a clean solution, seems a little hacky to me, however, it
would be great if the issue could be fixed somehow.
public static final class DirectGetter implements Getter {
private final transient Field field;
private final Class clazz;
private final String name;
private Method method;
DirectGetter(Field field, Class clazz, String name) {
this.field = field;
this.clazz = clazz;
this.name = name;
try
{
BeanInfo beanInfo = Introspector.getBeanInfo( clazz );
PropertyDescriptor[] pdArray = beanInfo.getPropertyDescriptors();
if ( pdArray != null )
{
for (PropertyDescriptor pd : pdArray )
{
if ( pd.getName().equals( name ) )
{
this.method = pd.getReadMethod();
}
}
}
}
catch ( Exception e )
{
// ignore
}
}
public Object get(Object target) throws HibernateException {
try {
return field.get(target);
}
catch (Exception e) {
throw new PropertyAccessException(e, "could not get a field value by
reflection", false, clazz, name);
}
}
public Object getForInsert(Object target, Map mergeMap, SessionImplementor session)
{
return get( target );
}
public Method getMethod() {
return method;
}
public String getMethodName() {
return method == null ? null : method.getName();
}
public Class getReturnType() {
return field.getType();
}
Object readResolve() {
return new DirectGetter( getField(clazz, name), clazz, name );
}
public String toString() {
return "DirectGetter(" + clazz.getName() + '.' + name +
')';
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:04 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3718) call to id getter initializes proxy when using AccessType( "field" )
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3718?page=c...
]
Paul Benedict commented on HHH-3718:
------------------------------------
Sounds like an important bug to fix. I learned about it here:
http://blog.xebia.com/2009/06/13/jpa-implementation-patterns-field-access...
call to id getter initializes proxy when using AccessType(
"field" )
--------------------------------------------------------------------
Key: HHH-3718
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3718
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.3.1
Environment: hibernate 3.3.1, hibernate annotations 3.4.0, running on windows,
linux and solaris, using sybase 15
Reporter: Paul Lorenz
Attachments: ids.patch, ids.patch
Calling getter for id when using AccessType( "field" ) causes proxy
initialization.
In org.hibernate.proxy.proxy.pojo.BasicLazyInitializer there is the code
else if ( isUninitialized() && method.equals(getIdentifierMethod) ) {
return getIdentifier();
}
However, when using field access, the getIdentifierMethod will be null. I fixed this for
us by changing DirectPropertyAccessor by adding a Method attribute to the DirectGetter
inner class, and looking up the appropriate getter in the constructor. As far as I can
tell, getMethod is only used in two places. In the above case, to the get the identity
getter and in PojoComponentTupilizer.isMethodOf. This doesn't seem to break anything.
I don't know if this is a clean solution, seems a little hacky to me, however, it
would be great if the issue could be fixed somehow.
public static final class DirectGetter implements Getter {
private final transient Field field;
private final Class clazz;
private final String name;
private Method method;
DirectGetter(Field field, Class clazz, String name) {
this.field = field;
this.clazz = clazz;
this.name = name;
try
{
BeanInfo beanInfo = Introspector.getBeanInfo( clazz );
PropertyDescriptor[] pdArray = beanInfo.getPropertyDescriptors();
if ( pdArray != null )
{
for (PropertyDescriptor pd : pdArray )
{
if ( pd.getName().equals( name ) )
{
this.method = pd.getReadMethod();
}
}
}
}
catch ( Exception e )
{
// ignore
}
}
public Object get(Object target) throws HibernateException {
try {
return field.get(target);
}
catch (Exception e) {
throw new PropertyAccessException(e, "could not get a field value by
reflection", false, clazz, name);
}
}
public Object getForInsert(Object target, Map mergeMap, SessionImplementor session)
{
return get( target );
}
public Method getMethod() {
return method;
}
public String getMethodName() {
return method == null ? null : method.getName();
}
public Class getReturnType() {
return field.getType();
}
Object readResolve() {
return new DirectGetter( getField(clazz, name), clazz, name );
}
public String toString() {
return "DirectGetter(" + clazz.getName() + '.' + name +
')';
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:59 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3718) call to id getter initializes proxy when using AccessType( "field" )
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3718?page=c...
]
Jean-Francois Larouche commented on HHH-3718:
---------------------------------------------
Yeah, i lost 5 hours on this bug. When i started debugging hibernate and found problem i
realised that it is already known... grr oh well.
call to id getter initializes proxy when using AccessType(
"field" )
--------------------------------------------------------------------
Key: HHH-3718
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3718
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.3.1
Environment: hibernate 3.3.1, hibernate annotations 3.4.0, running on windows,
linux and solaris, using sybase 15
Reporter: Paul Lorenz
Attachments: ids.patch, ids.patch
Calling getter for id when using AccessType( "field" ) causes proxy
initialization.
In org.hibernate.proxy.proxy.pojo.BasicLazyInitializer there is the code
else if ( isUninitialized() && method.equals(getIdentifierMethod) ) {
return getIdentifier();
}
However, when using field access, the getIdentifierMethod will be null. I fixed this for
us by changing DirectPropertyAccessor by adding a Method attribute to the DirectGetter
inner class, and looking up the appropriate getter in the constructor. As far as I can
tell, getMethod is only used in two places. In the above case, to the get the identity
getter and in PojoComponentTupilizer.isMethodOf. This doesn't seem to break anything.
I don't know if this is a clean solution, seems a little hacky to me, however, it
would be great if the issue could be fixed somehow.
public static final class DirectGetter implements Getter {
private final transient Field field;
private final Class clazz;
private final String name;
private Method method;
DirectGetter(Field field, Class clazz, String name) {
this.field = field;
this.clazz = clazz;
this.name = name;
try
{
BeanInfo beanInfo = Introspector.getBeanInfo( clazz );
PropertyDescriptor[] pdArray = beanInfo.getPropertyDescriptors();
if ( pdArray != null )
{
for (PropertyDescriptor pd : pdArray )
{
if ( pd.getName().equals( name ) )
{
this.method = pd.getReadMethod();
}
}
}
}
catch ( Exception e )
{
// ignore
}
}
public Object get(Object target) throws HibernateException {
try {
return field.get(target);
}
catch (Exception e) {
throw new PropertyAccessException(e, "could not get a field value by
reflection", false, clazz, name);
}
}
public Object getForInsert(Object target, Map mergeMap, SessionImplementor session)
{
return get( target );
}
public Method getMethod() {
return method;
}
public String getMethodName() {
return method == null ? null : method.getName();
}
public Class getReturnType() {
return field.getType();
}
Object readResolve() {
return new DirectGetter( getField(clazz, name), clazz, name );
}
public String toString() {
return "DirectGetter(" + clazz.getName() + '.' + name +
')';
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:43 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3718) call to id getter initializes proxy when using AccessType( "field" )
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3718?page=c...
]
Ondrej Medek commented on HHH-3718:
-----------------------------------
Workaround to get the id from an application without fetching the entity:
{noformat}
public static Integer getIdDirect(MyEntity entity) {
if (entity instanceof HibernateProxy) {
LazyInitializer lazyInitializer = ((HibernateProxy)
entity).getHibernateLazyInitializer();
if (lazyInitializer.isUninitialized()) {
return (Integer) lazyInitializer.getIdentifier();
}
}
return entity.getId();
}
{noformat}
call to id getter initializes proxy when using AccessType(
"field" )
--------------------------------------------------------------------
Key: HHH-3718
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3718
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.3.1
Environment: hibernate 3.3.1, hibernate annotations 3.4.0, running on windows,
linux and solaris, using sybase 15
Reporter: Paul Lorenz
Attachments: ids.patch, ids.patch
Calling getter for id when using AccessType( "field" ) causes proxy
initialization.
In org.hibernate.proxy.proxy.pojo.BasicLazyInitializer there is the code
else if ( isUninitialized() && method.equals(getIdentifierMethod) ) {
return getIdentifier();
}
However, when using field access, the getIdentifierMethod will be null. I fixed this for
us by changing DirectPropertyAccessor by adding a Method attribute to the DirectGetter
inner class, and looking up the appropriate getter in the constructor. As far as I can
tell, getMethod is only used in two places. In the above case, to the get the identity
getter and in PojoComponentTupilizer.isMethodOf. This doesn't seem to break anything.
I don't know if this is a clean solution, seems a little hacky to me, however, it
would be great if the issue could be fixed somehow.
public static final class DirectGetter implements Getter {
private final transient Field field;
private final Class clazz;
private final String name;
private Method method;
DirectGetter(Field field, Class clazz, String name) {
this.field = field;
this.clazz = clazz;
this.name = name;
try
{
BeanInfo beanInfo = Introspector.getBeanInfo( clazz );
PropertyDescriptor[] pdArray = beanInfo.getPropertyDescriptors();
if ( pdArray != null )
{
for (PropertyDescriptor pd : pdArray )
{
if ( pd.getName().equals( name ) )
{
this.method = pd.getReadMethod();
}
}
}
}
catch ( Exception e )
{
// ignore
}
}
public Object get(Object target) throws HibernateException {
try {
return field.get(target);
}
catch (Exception e) {
throw new PropertyAccessException(e, "could not get a field value by
reflection", false, clazz, name);
}
}
public Object getForInsert(Object target, Map mergeMap, SessionImplementor session)
{
return get( target );
}
public Method getMethod() {
return method;
}
public String getMethodName() {
return method == null ? null : method.getName();
}
public Class getReturnType() {
return field.getType();
}
Object readResolve() {
return new DirectGetter( getField(clazz, name), clazz, name );
}
public String toString() {
return "DirectGetter(" + clazz.getName() + '.' + name +
')';
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:45 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3718) call to id getter initializes proxy when using AccessType( "field" )
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3718?page=c...
]
Jean-Francois Larouche commented on HHH-3718:
---------------------------------------------
Bah i just did it the simple way and added on every @id @Access(value =
AccessType.PROPERTY)
call to id getter initializes proxy when using AccessType(
"field" )
--------------------------------------------------------------------
Key: HHH-3718
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3718
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.3.1
Environment: hibernate 3.3.1, hibernate annotations 3.4.0, running on windows,
linux and solaris, using sybase 15
Reporter: Paul Lorenz
Attachments: ids.patch, ids.patch
Calling getter for id when using AccessType( "field" ) causes proxy
initialization.
In org.hibernate.proxy.proxy.pojo.BasicLazyInitializer there is the code
else if ( isUninitialized() && method.equals(getIdentifierMethod) ) {
return getIdentifier();
}
However, when using field access, the getIdentifierMethod will be null. I fixed this for
us by changing DirectPropertyAccessor by adding a Method attribute to the DirectGetter
inner class, and looking up the appropriate getter in the constructor. As far as I can
tell, getMethod is only used in two places. In the above case, to the get the identity
getter and in PojoComponentTupilizer.isMethodOf. This doesn't seem to break anything.
I don't know if this is a clean solution, seems a little hacky to me, however, it
would be great if the issue could be fixed somehow.
public static final class DirectGetter implements Getter {
private final transient Field field;
private final Class clazz;
private final String name;
private Method method;
DirectGetter(Field field, Class clazz, String name) {
this.field = field;
this.clazz = clazz;
this.name = name;
try
{
BeanInfo beanInfo = Introspector.getBeanInfo( clazz );
PropertyDescriptor[] pdArray = beanInfo.getPropertyDescriptors();
if ( pdArray != null )
{
for (PropertyDescriptor pd : pdArray )
{
if ( pd.getName().equals( name ) )
{
this.method = pd.getReadMethod();
}
}
}
}
catch ( Exception e )
{
// ignore
}
}
public Object get(Object target) throws HibernateException {
try {
return field.get(target);
}
catch (Exception e) {
throw new PropertyAccessException(e, "could not get a field value by
reflection", false, clazz, name);
}
}
public Object getForInsert(Object target, Map mergeMap, SessionImplementor session)
{
return get( target );
}
public Method getMethod() {
return method;
}
public String getMethodName() {
return method == null ? null : method.getName();
}
public Class getReturnType() {
return field.getType();
}
Object readResolve() {
return new DirectGetter( getField(clazz, name), clazz, name );
}
public String toString() {
return "DirectGetter(" + clazz.getName() + '.' + name +
')';
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3718) call to id getter initializes proxy when using AccessType( "field" )
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3718?page=c...
]
Karsten Wutzke commented on HHH-3718:
-------------------------------------
Yet another Hibernate head-shaker... I suppose this is still unresolved as is.
call to id getter initializes proxy when using AccessType(
"field" )
--------------------------------------------------------------------
Key: HHH-3718
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3718
Project: Hibernate ORM
Issue Type: Bug
Components: core
Affects Versions: 3.3.1
Environment: hibernate 3.3.1, hibernate annotations 3.4.0, running on windows,
linux and solaris, using sybase 15
Reporter: Paul Lorenz
Attachments: ids.patch, ids.patch
Calling getter for id when using AccessType( "field" ) causes proxy
initialization.
In org.hibernate.proxy.proxy.pojo.BasicLazyInitializer there is the code
else if ( isUninitialized() && method.equals(getIdentifierMethod) ) {
return getIdentifier();
}
However, when using field access, the getIdentifierMethod will be null. I fixed this for
us by changing DirectPropertyAccessor by adding a Method attribute to the DirectGetter
inner class, and looking up the appropriate getter in the constructor. As far as I can
tell, getMethod is only used in two places. In the above case, to the get the identity
getter and in PojoComponentTupilizer.isMethodOf. This doesn't seem to break anything.
I don't know if this is a clean solution, seems a little hacky to me, however, it
would be great if the issue could be fixed somehow.
public static final class DirectGetter implements Getter {
private final transient Field field;
private final Class clazz;
private final String name;
private Method method;
DirectGetter(Field field, Class clazz, String name) {
this.field = field;
this.clazz = clazz;
this.name = name;
try
{
BeanInfo beanInfo = Introspector.getBeanInfo( clazz );
PropertyDescriptor[] pdArray = beanInfo.getPropertyDescriptors();
if ( pdArray != null )
{
for (PropertyDescriptor pd : pdArray )
{
if ( pd.getName().equals( name ) )
{
this.method = pd.getReadMethod();
}
}
}
}
catch ( Exception e )
{
// ignore
}
}
public Object get(Object target) throws HibernateException {
try {
return field.get(target);
}
catch (Exception e) {
throw new PropertyAccessException(e, "could not get a field value by
reflection", false, clazz, name);
}
}
public Object getForInsert(Object target, Map mergeMap, SessionImplementor session)
{
return get( target );
}
public Method getMethod() {
return method;
}
public String getMethodName() {
return method == null ? null : method.getName();
}
public Class getReturnType() {
return field.getType();
}
Object readResolve() {
return new DirectGetter( getField(clazz, name), clazz, name );
}
public String toString() {
return "DirectGetter(" + clazz.getName() + '.' + name +
')';
}
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:22 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3718) call to id getter initializes proxy when using AccessType( "field" )
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3718?page=c...
]
Michael Rudolf commented on HHH-3718:
-------------------------------------
Added pull request https://github.com/hibernate/hibernate-orm/pull/258 for the first part
of this issue, the second part needs to be handled in a different issue.
call to id getter initializes proxy when using AccessType(
"field" )
--------------------------------------------------------------------
Key: HHH-3718
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3718
Project: Hibernate ORM
Issue Type: Bug
Components: core
Affects Versions: 3.3.1
Environment: hibernate 3.3.1, hibernate annotations 3.4.0, running on windows,
linux and solaris, using sybase 15
Reporter: Paul Lorenz
Attachments: ids.patch, ids.patch
Calling getter for id when using AccessType( "field" ) causes proxy
initialization.
In org.hibernate.proxy.proxy.pojo.BasicLazyInitializer there is the code
else if ( isUninitialized() && method.equals(getIdentifierMethod) ) {
return getIdentifier();
}
However, when using field access, the getIdentifierMethod will be null. I fixed this for
us by changing DirectPropertyAccessor by adding a Method attribute to the DirectGetter
inner class, and looking up the appropriate getter in the constructor. As far as I can
tell, getMethod is only used in two places. In the above case, to the get the identity
getter and in PojoComponentTupilizer.isMethodOf. This doesn't seem to break anything.
I don't know if this is a clean solution, seems a little hacky to me, however, it
would be great if the issue could be fixed somehow.
public static final class DirectGetter implements Getter {
private final transient Field field;
private final Class clazz;
private final String name;
private Method method;
DirectGetter(Field field, Class clazz, String name) {
this.field = field;
this.clazz = clazz;
this.name = name;
try
{
BeanInfo beanInfo = Introspector.getBeanInfo( clazz );
PropertyDescriptor[] pdArray = beanInfo.getPropertyDescriptors();
if ( pdArray != null )
{
for (PropertyDescriptor pd : pdArray )
{
if ( pd.getName().equals( name ) )
{
this.method = pd.getReadMethod();
}
}
}
}
catch ( Exception e )
{
// ignore
}
}
public Object get(Object target) throws HibernateException {
try {
return field.get(target);
}
catch (Exception e) {
throw new PropertyAccessException(e, "could not get a field value by
reflection", false, clazz, name);
}
}
public Object getForInsert(Object target, Map mergeMap, SessionImplementor session)
{
return get( target );
}
public Method getMethod() {
return method;
}
public String getMethodName() {
return method == null ? null : method.getName();
}
public Class getReturnType() {
return field.getType();
}
Object readResolve() {
return new DirectGetter( getField(clazz, name), clazz, name );
}
public String toString() {
return "DirectGetter(" + clazz.getName() + '.' + name +
')';
}
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:44 a.m.
New subject: [Hibernate-JIRA] Updated: (HHH-3718) call to id getter initializes proxy when using AccessType( "field" )
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3718?page=c...
]
Gail Badner updated HHH-3718:
-----------------------------
Pull Requests: https://github.com/hibernate/hibernate-orm/pull/258
call to id getter initializes proxy when using AccessType(
"field" )
--------------------------------------------------------------------
Key: HHH-3718
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3718
Project: Hibernate ORM
Issue Type: Bug
Components: core
Affects Versions: 3.3.1
Environment: hibernate 3.3.1, hibernate annotations 3.4.0, running on windows,
linux and solaris, using sybase 15
Reporter: Paul Lorenz
Attachments: ids.patch, ids.patch
Calling getter for id when using AccessType( "field" ) causes proxy
initialization.
In org.hibernate.proxy.proxy.pojo.BasicLazyInitializer there is the code
else if ( isUninitialized() && method.equals(getIdentifierMethod) ) {
return getIdentifier();
}
However, when using field access, the getIdentifierMethod will be null. I fixed this for
us by changing DirectPropertyAccessor by adding a Method attribute to the DirectGetter
inner class, and looking up the appropriate getter in the constructor. As far as I can
tell, getMethod is only used in two places. In the above case, to the get the identity
getter and in PojoComponentTupilizer.isMethodOf. This doesn't seem to break anything.
I don't know if this is a clean solution, seems a little hacky to me, however, it
would be great if the issue could be fixed somehow.
public static final class DirectGetter implements Getter {
private final transient Field field;
private final Class clazz;
private final String name;
private Method method;
DirectGetter(Field field, Class clazz, String name) {
this.field = field;
this.clazz = clazz;
this.name = name;
try
{
BeanInfo beanInfo = Introspector.getBeanInfo( clazz );
PropertyDescriptor[] pdArray = beanInfo.getPropertyDescriptors();
if ( pdArray != null )
{
for (PropertyDescriptor pd : pdArray )
{
if ( pd.getName().equals( name ) )
{
this.method = pd.getReadMethod();
}
}
}
}
catch ( Exception e )
{
// ignore
}
}
public Object get(Object target) throws HibernateException {
try {
return field.get(target);
}
catch (Exception e) {
throw new PropertyAccessException(e, "could not get a field value by
reflection", false, clazz, name);
}
}
public Object getForInsert(Object target, Map mergeMap, SessionImplementor session)
{
return get( target );
}
public Method getMethod() {
return method;
}
public String getMethodName() {
return method == null ? null : method.getName();
}
public Class getReturnType() {
return field.getType();
}
Object readResolve() {
return new DirectGetter( getField(clazz, name), clazz, name );
}
public String toString() {
return "DirectGetter(" + clazz.getName() + '.' + name +
')';
}
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:17 p.m.
New subject: [Hibernate-JIRA] Assigned: (HHH-3718) call to id getter initializes proxy when using AccessType( "field" )
[
https://hibernate.onjira.com/browse/HHH-3718?page=com.atlassian.jira.plug...
]
Strong Liu reassigned HHH-3718:
-------------------------------
Assignee: Strong Liu
call to id getter initializes proxy when using AccessType(
"field" )
--------------------------------------------------------------------
Key: HHH-3718
URL: https://hibernate.onjira.com/browse/HHH-3718
Project: Hibernate ORM
Issue Type: Bug
Components: core
Affects Versions: 3.3.1
Environment: hibernate 3.3.1, hibernate annotations 3.4.0, running on windows,
linux and solaris, using sybase 15
Reporter: Paul Lorenz
Assignee: Strong Liu
Attachments: ids.patch, ids.patch
Calling getter for id when using AccessType( "field" ) causes proxy
initialization.
In org.hibernate.proxy.proxy.pojo.BasicLazyInitializer there is the code
else if ( isUninitialized() && method.equals(getIdentifierMethod) ) {
return getIdentifier();
}
However, when using field access, the getIdentifierMethod will be null. I fixed this for
us by changing DirectPropertyAccessor by adding a Method attribute to the DirectGetter
inner class, and looking up the appropriate getter in the constructor. As far as I can
tell, getMethod is only used in two places. In the above case, to the get the identity
getter and in PojoComponentTupilizer.isMethodOf. This doesn't seem to break anything.
I don't know if this is a clean solution, seems a little hacky to me, however, it
would be great if the issue could be fixed somehow.
public static final class DirectGetter implements Getter {
private final transient Field field;
private final Class clazz;
private final String name;
private Method method;
DirectGetter(Field field, Class clazz, String name) {
this.field = field;
this.clazz = clazz;
this.name = name;
try
{
BeanInfo beanInfo = Introspector.getBeanInfo( clazz );
PropertyDescriptor[] pdArray = beanInfo.getPropertyDescriptors();
if ( pdArray != null )
{
for (PropertyDescriptor pd : pdArray )
{
if ( pd.getName().equals( name ) )
{
this.method = pd.getReadMethod();
}
}
}
}
catch ( Exception e )
{
// ignore
}
}
public Object get(Object target) throws HibernateException {
try {
return field.get(target);
}
catch (Exception e) {
throw new PropertyAccessException(e, "could not get a field value by
reflection", false, clazz, name);
}
}
public Object getForInsert(Object target, Map mergeMap, SessionImplementor session)
{
return get( target );
}
public Method getMethod() {
return method;
}
public String getMethodName() {
return method == null ? null : method.getName();
}
public Class getReturnType() {
return field.getType();
}
Object readResolve() {
return new DirectGetter( getField(clazz, name), clazz, name );
}
public String toString() {
return "DirectGetter(" + clazz.getName() + '.' + name +
')';
}
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:40 p.m.
New subject: [Hibernate-JIRA] Resolved: (HHH-3718) call to id getter initializes proxy when using AccessType( "field" )
[
https://hibernate.onjira.com/browse/HHH-3718?page=com.atlassian.jira.plug...
]
Strong Liu resolved HHH-3718.
-----------------------------
Resolution: Fixed
Fix Version/s: 4.1.x
pull request pushed, thanks man
call to id getter initializes proxy when using AccessType(
"field" )
--------------------------------------------------------------------
Key: HHH-3718
URL: https://hibernate.onjira.com/browse/HHH-3718
Project: Hibernate ORM
Issue Type: Bug
Components: core
Affects Versions: 3.3.1
Environment: hibernate 3.3.1, hibernate annotations 3.4.0, running on windows,
linux and solaris, using sybase 15
Reporter: Paul Lorenz
Assignee: Strong Liu
Fix For: 4.1.x
Attachments: ids.patch, ids.patch
Calling getter for id when using AccessType( "field" ) causes proxy
initialization.
In org.hibernate.proxy.proxy.pojo.BasicLazyInitializer there is the code
else if ( isUninitialized() && method.equals(getIdentifierMethod) ) {
return getIdentifier();
}
However, when using field access, the getIdentifierMethod will be null. I fixed this for
us by changing DirectPropertyAccessor by adding a Method attribute to the DirectGetter
inner class, and looking up the appropriate getter in the constructor. As far as I can
tell, getMethod is only used in two places. In the above case, to the get the identity
getter and in PojoComponentTupilizer.isMethodOf. This doesn't seem to break anything.
I don't know if this is a clean solution, seems a little hacky to me, however, it
would be great if the issue could be fixed somehow.
public static final class DirectGetter implements Getter {
private final transient Field field;
private final Class clazz;
private final String name;
private Method method;
DirectGetter(Field field, Class clazz, String name) {
this.field = field;
this.clazz = clazz;
this.name = name;
try
{
BeanInfo beanInfo = Introspector.getBeanInfo( clazz );
PropertyDescriptor[] pdArray = beanInfo.getPropertyDescriptors();
if ( pdArray != null )
{
for (PropertyDescriptor pd : pdArray )
{
if ( pd.getName().equals( name ) )
{
this.method = pd.getReadMethod();
}
}
}
}
catch ( Exception e )
{
// ignore
}
}
public Object get(Object target) throws HibernateException {
try {
return field.get(target);
}
catch (Exception e) {
throw new PropertyAccessException(e, "could not get a field value by
reflection", false, clazz, name);
}
}
public Object getForInsert(Object target, Map mergeMap, SessionImplementor session)
{
return get( target );
}
public Method getMethod() {
return method;
}
public String getMethodName() {
return method == null ? null : method.getName();
}
public Class getReturnType() {
return field.getType();
}
Object readResolve() {
return new DirectGetter( getField(clazz, name), clazz, name );
}
public String toString() {
return "DirectGetter(" + clazz.getName() + '.' + name +
')';
}
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:51 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3718) call to id getter initializes proxy when using AccessType( "field" )
[
https://hibernate.onjira.com/browse/HHH-3718?page=com.atlassian.jira.plug...
]
Christian Bauer commented on HHH-3718:
--------------------------------------
This is a breaking change. Some applications might rely on proxy initialization when an
(identifier) getter method has been called. This was a clear and documented issue: If you
mapped with field access, any method call initializes the proxy. Now this behavior depends
on some not-documented detection procedure in the DirectPropertyAccessor. This doesn't
solve anything, it just makes it even harder for people to figure why their proxy might be
(or not) initialized.
(I'm not talking about the inheritance id getter detection problem, that seems like an
obvious bug.)
call to id getter initializes proxy when using AccessType(
"field" )
--------------------------------------------------------------------
Key: HHH-3718
URL: https://hibernate.onjira.com/browse/HHH-3718
Project: Hibernate ORM
Issue Type: Bug
Components: core
Affects Versions: 3.3.1
Environment: hibernate 3.3.1, hibernate annotations 3.4.0, running on windows,
linux and solaris, using sybase 15
Reporter: Paul Lorenz
Assignee: Strong Liu
Fix For: 4.1.x
Attachments: ids.patch, ids.patch
Calling getter for id when using AccessType( "field" ) causes proxy
initialization.
In org.hibernate.proxy.proxy.pojo.BasicLazyInitializer there is the code
else if ( isUninitialized() && method.equals(getIdentifierMethod) ) {
return getIdentifier();
}
However, when using field access, the getIdentifierMethod will be null. I fixed this for
us by changing DirectPropertyAccessor by adding a Method attribute to the DirectGetter
inner class, and looking up the appropriate getter in the constructor. As far as I can
tell, getMethod is only used in two places. In the above case, to the get the identity
getter and in PojoComponentTupilizer.isMethodOf. This doesn't seem to break anything.
I don't know if this is a clean solution, seems a little hacky to me, however, it
would be great if the issue could be fixed somehow.
public static final class DirectGetter implements Getter {
private final transient Field field;
private final Class clazz;
private final String name;
private Method method;
DirectGetter(Field field, Class clazz, String name) {
this.field = field;
this.clazz = clazz;
this.name = name;
try
{
BeanInfo beanInfo = Introspector.getBeanInfo( clazz );
PropertyDescriptor[] pdArray = beanInfo.getPropertyDescriptors();
if ( pdArray != null )
{
for (PropertyDescriptor pd : pdArray )
{
if ( pd.getName().equals( name ) )
{
this.method = pd.getReadMethod();
}
}
}
}
catch ( Exception e )
{
// ignore
}
}
public Object get(Object target) throws HibernateException {
try {
return field.get(target);
}
catch (Exception e) {
throw new PropertyAccessException(e, "could not get a field value by
reflection", false, clazz, name);
}
}
public Object getForInsert(Object target, Map mergeMap, SessionImplementor session)
{
return get( target );
}
public Method getMethod() {
return method;
}
public String getMethodName() {
return method == null ? null : method.getName();
}
public Class getReturnType() {
return field.getType();
}
Object readResolve() {
return new DirectGetter( getField(clazz, name), clazz, name );
}
public String toString() {
return "DirectGetter(" + clazz.getName() + '.' + name +
')';
}
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:18 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3718) call to id getter initializes proxy when using AccessType( "field" )
[
https://hibernate.onjira.com/browse/HHH-3718?page=com.atlassian.jira.plug...
]
Ondrej Medek commented on HHH-3718:
-----------------------------------
Although I would like Hibernate would behave the same way with access type either field or
property, I have to agree with Christian. This path is a nice try, but makes thinks more
obfuscated when the patch does not find the proper @Id getter method.
Maybe a "clean" solution would be to have an annotation like
@Id(property="myID") which could tell Hibernate which property to look for when
it has some uncommon name. Maybe such "property" property could be for every
field @Basic(property="...") and then Hibernate could behave always like for
AccessType("property").
Furthermore, this patch does not create the getter name in a proper way. E.g. a Java
convention for a field like "cId" is to make getter "getcId" (yes,
lower case "c"). That is, does not capitalize the first letter when the second
letter is a capital.
call to id getter initializes proxy when using AccessType(
"field" )
--------------------------------------------------------------------
Key: HHH-3718
URL: https://hibernate.onjira.com/browse/HHH-3718
Project: Hibernate ORM
Issue Type: Bug
Components: core
Affects Versions: 3.3.1
Environment: hibernate 3.3.1, hibernate annotations 3.4.0, running on windows,
linux and solaris, using sybase 15
Reporter: Paul Lorenz
Assignee: Strong Liu
Fix For: 4.1.x
Attachments: ids.patch, ids.patch
Calling getter for id when using AccessType( "field" ) causes proxy
initialization.
In org.hibernate.proxy.proxy.pojo.BasicLazyInitializer there is the code
else if ( isUninitialized() && method.equals(getIdentifierMethod) ) {
return getIdentifier();
}
However, when using field access, the getIdentifierMethod will be null. I fixed this for
us by changing DirectPropertyAccessor by adding a Method attribute to the DirectGetter
inner class, and looking up the appropriate getter in the constructor. As far as I can
tell, getMethod is only used in two places. In the above case, to the get the identity
getter and in PojoComponentTupilizer.isMethodOf. This doesn't seem to break anything.
I don't know if this is a clean solution, seems a little hacky to me, however, it
would be great if the issue could be fixed somehow.
public static final class DirectGetter implements Getter {
private final transient Field field;
private final Class clazz;
private final String name;
private Method method;
DirectGetter(Field field, Class clazz, String name) {
this.field = field;
this.clazz = clazz;
this.name = name;
try
{
BeanInfo beanInfo = Introspector.getBeanInfo( clazz );
PropertyDescriptor[] pdArray = beanInfo.getPropertyDescriptors();
if ( pdArray != null )
{
for (PropertyDescriptor pd : pdArray )
{
if ( pd.getName().equals( name ) )
{
this.method = pd.getReadMethod();
}
}
}
}
catch ( Exception e )
{
// ignore
}
}
public Object get(Object target) throws HibernateException {
try {
return field.get(target);
}
catch (Exception e) {
throw new PropertyAccessException(e, "could not get a field value by
reflection", false, clazz, name);
}
}
public Object getForInsert(Object target, Map mergeMap, SessionImplementor session)
{
return get( target );
}
public Method getMethod() {
return method;
}
public String getMethodName() {
return method == null ? null : method.getName();
}
public Class getReturnType() {
return field.getType();
}
Object readResolve() {
return new DirectGetter( getField(clazz, name), clazz, name );
}
public String toString() {
return "DirectGetter(" + clazz.getName() + '.' + name +
')';
}
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:55 p.m.
New subject: [Hibernate-JIRA] Reopened: (HHH-3718) call to id getter initializes proxy when using AccessType( "field" )
[
https://hibernate.onjira.com/browse/HHH-3718?page=com.atlassian.jira.plug...
]
Strong Liu reopened HHH-3718:
-----------------------------
call to id getter initializes proxy when using AccessType(
"field" )
--------------------------------------------------------------------
Key: HHH-3718
URL: https://hibernate.onjira.com/browse/HHH-3718
Project: Hibernate ORM
Issue Type: Bug
Components: core
Affects Versions: 3.3.1
Environment: hibernate 3.3.1, hibernate annotations 3.4.0, running on windows,
linux and solaris, using sybase 15
Reporter: Paul Lorenz
Assignee: Strong Liu
Fix For: 4.1.x
Attachments: ids.patch, ids.patch
Calling getter for id when using AccessType( "field" ) causes proxy
initialization.
In org.hibernate.proxy.proxy.pojo.BasicLazyInitializer there is the code
else if ( isUninitialized() && method.equals(getIdentifierMethod) ) {
return getIdentifier();
}
However, when using field access, the getIdentifierMethod will be null. I fixed this for
us by changing DirectPropertyAccessor by adding a Method attribute to the DirectGetter
inner class, and looking up the appropriate getter in the constructor. As far as I can
tell, getMethod is only used in two places. In the above case, to the get the identity
getter and in PojoComponentTupilizer.isMethodOf. This doesn't seem to break anything.
I don't know if this is a clean solution, seems a little hacky to me, however, it
would be great if the issue could be fixed somehow.
public static final class DirectGetter implements Getter {
private final transient Field field;
private final Class clazz;
private final String name;
private Method method;
DirectGetter(Field field, Class clazz, String name) {
this.field = field;
this.clazz = clazz;
this.name = name;
try
{
BeanInfo beanInfo = Introspector.getBeanInfo( clazz );
PropertyDescriptor[] pdArray = beanInfo.getPropertyDescriptors();
if ( pdArray != null )
{
for (PropertyDescriptor pd : pdArray )
{
if ( pd.getName().equals( name ) )
{
this.method = pd.getReadMethod();
}
}
}
}
catch ( Exception e )
{
// ignore
}
}
public Object get(Object target) throws HibernateException {
try {
return field.get(target);
}
catch (Exception e) {
throw new PropertyAccessException(e, "could not get a field value by
reflection", false, clazz, name);
}
}
public Object getForInsert(Object target, Map mergeMap, SessionImplementor session)
{
return get( target );
}
public Method getMethod() {
return method;
}
public String getMethodName() {
return method == null ? null : method.getName();
}
public Class getReturnType() {
return field.getType();
}
Object readResolve() {
return new DirectGetter( getField(clazz, name), clazz, name );
}
public String toString() {
return "DirectGetter(" + clazz.getName() + '.' + name +
')';
}
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:55 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3718) call to id getter initializes proxy when using AccessType( "field" )
[
https://hibernate.onjira.com/browse/HHH-3718?page=com.atlassian.jira.plug...
]
Strong Liu commented on HHH-3718:
---------------------------------
yeah, you're right, i have rolled back the change.
call to id getter initializes proxy when using AccessType(
"field" )
--------------------------------------------------------------------
Key: HHH-3718
URL: https://hibernate.onjira.com/browse/HHH-3718
Project: Hibernate ORM
Issue Type: Bug
Components: core
Affects Versions: 3.3.1
Environment: hibernate 3.3.1, hibernate annotations 3.4.0, running on windows,
linux and solaris, using sybase 15
Reporter: Paul Lorenz
Assignee: Strong Liu
Fix For: 4.1.x
Attachments: ids.patch, ids.patch
Calling getter for id when using AccessType( "field" ) causes proxy
initialization.
In org.hibernate.proxy.proxy.pojo.BasicLazyInitializer there is the code
else if ( isUninitialized() && method.equals(getIdentifierMethod) ) {
return getIdentifier();
}
However, when using field access, the getIdentifierMethod will be null. I fixed this for
us by changing DirectPropertyAccessor by adding a Method attribute to the DirectGetter
inner class, and looking up the appropriate getter in the constructor. As far as I can
tell, getMethod is only used in two places. In the above case, to the get the identity
getter and in PojoComponentTupilizer.isMethodOf. This doesn't seem to break anything.
I don't know if this is a clean solution, seems a little hacky to me, however, it
would be great if the issue could be fixed somehow.
public static final class DirectGetter implements Getter {
private final transient Field field;
private final Class clazz;
private final String name;
private Method method;
DirectGetter(Field field, Class clazz, String name) {
this.field = field;
this.clazz = clazz;
this.name = name;
try
{
BeanInfo beanInfo = Introspector.getBeanInfo( clazz );
PropertyDescriptor[] pdArray = beanInfo.getPropertyDescriptors();
if ( pdArray != null )
{
for (PropertyDescriptor pd : pdArray )
{
if ( pd.getName().equals( name ) )
{
this.method = pd.getReadMethod();
}
}
}
}
catch ( Exception e )
{
// ignore
}
}
public Object get(Object target) throws HibernateException {
try {
return field.get(target);
}
catch (Exception e) {
throw new PropertyAccessException(e, "could not get a field value by
reflection", false, clazz, name);
}
}
public Object getForInsert(Object target, Map mergeMap, SessionImplementor session)
{
return get( target );
}
public Method getMethod() {
return method;
}
public String getMethodName() {
return method == null ? null : method.getName();
}
public Class getReturnType() {
return field.getType();
}
Object readResolve() {
return new DirectGetter( getField(clazz, name), clazz, name );
}
public String toString() {
return "DirectGetter(" + clazz.getName() + '.' + name +
')';
}
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:53 a.m.
New subject: [Hibernate-JIRA] Updated: (HHH-3718) call to id getter initializes proxy when using AccessType( "field" )
[
https://hibernate.onjira.com/browse/HHH-3718?page=com.atlassian.jira.plug...
]
Steve Ebersole updated HHH-3718:
--------------------------------
Pull Requests: https://github.com/hibernate/hibernate-orm/pull/258 (was:
https://github.com/hibernate/hibernate-orm/pull/258)
Fix Version/s: (was: 4.1.1)
Christian is absolutely right. This is a breaking change and cannot be introduced in a
point release. Additionally, as he alluded to, this is a documented beahvior and
therefore cannot be a bug either.
Really this is an enhancement request. We can consider it for 5.
call to id getter initializes proxy when using AccessType(
"field" )
--------------------------------------------------------------------
Key: HHH-3718
URL: https://hibernate.onjira.com/browse/HHH-3718
Project: Hibernate ORM
Issue Type: Bug
Components: core
Affects Versions: 3.3.1
Environment: hibernate 3.3.1, hibernate annotations 3.4.0, running on windows,
linux and solaris, using sybase 15
Reporter: Paul Lorenz
Assignee: Strong Liu
Attachments: ids.patch, ids.patch
Calling getter for id when using AccessType( "field" ) causes proxy
initialization.
In org.hibernate.proxy.proxy.pojo.BasicLazyInitializer there is the code
else if ( isUninitialized() && method.equals(getIdentifierMethod) ) {
return getIdentifier();
}
However, when using field access, the getIdentifierMethod will be null. I fixed this for
us by changing DirectPropertyAccessor by adding a Method attribute to the DirectGetter
inner class, and looking up the appropriate getter in the constructor. As far as I can
tell, getMethod is only used in two places. In the above case, to the get the identity
getter and in PojoComponentTupilizer.isMethodOf. This doesn't seem to break anything.
I don't know if this is a clean solution, seems a little hacky to me, however, it
would be great if the issue could be fixed somehow.
public static final class DirectGetter implements Getter {
private final transient Field field;
private final Class clazz;
private final String name;
private Method method;
DirectGetter(Field field, Class clazz, String name) {
this.field = field;
this.clazz = clazz;
this.name = name;
try
{
BeanInfo beanInfo = Introspector.getBeanInfo( clazz );
PropertyDescriptor[] pdArray = beanInfo.getPropertyDescriptors();
if ( pdArray != null )
{
for (PropertyDescriptor pd : pdArray )
{
if ( pd.getName().equals( name ) )
{
this.method = pd.getReadMethod();
}
}
}
}
catch ( Exception e )
{
// ignore
}
}
public Object get(Object target) throws HibernateException {
try {
return field.get(target);
}
catch (Exception e) {
throw new PropertyAccessException(e, "could not get a field value by
reflection", false, clazz, name);
}
}
public Object getForInsert(Object target, Map mergeMap, SessionImplementor session)
{
return get( target );
}
public Method getMethod() {
return method;
}
public String getMethodName() {
return method == null ? null : method.getName();
}
public Class getReturnType() {
return field.getType();
}
Object readResolve() {
return new DirectGetter( getField(clazz, name), clazz, name );
}
public String toString() {
return "DirectGetter(" + clazz.getName() + '.' + name +
')';
}
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:36 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-3718) call to id getter initializes proxy when using AccessType( "field" )
[
https://hibernate.onjira.com/browse/HHH-3718?page=com.atlassian.jira.plug...
]
Strong Liu updated HHH-3718:
----------------------------
Pull Requests: https://github.com/hibernate/hibernate-orm/pull/258 (was:
https://github.com/hibernate/hibernate-orm/pull/258)
Issue Type: Improvement (was: Bug)
call to id getter initializes proxy when using AccessType(
"field" )
--------------------------------------------------------------------
Key: HHH-3718
URL: https://hibernate.onjira.com/browse/HHH-3718
Project: Hibernate ORM
Issue Type: Improvement
Components: core
Affects Versions: 3.3.1
Environment: hibernate 3.3.1, hibernate annotations 3.4.0, running on windows,
linux and solaris, using sybase 15
Reporter: Paul Lorenz
Assignee: Strong Liu
Attachments: ids.patch, ids.patch
Calling getter for id when using AccessType( "field" ) causes proxy
initialization.
In org.hibernate.proxy.proxy.pojo.BasicLazyInitializer there is the code
else if ( isUninitialized() && method.equals(getIdentifierMethod) ) {
return getIdentifier();
}
However, when using field access, the getIdentifierMethod will be null. I fixed this for
us by changing DirectPropertyAccessor by adding a Method attribute to the DirectGetter
inner class, and looking up the appropriate getter in the constructor. As far as I can
tell, getMethod is only used in two places. In the above case, to the get the identity
getter and in PojoComponentTupilizer.isMethodOf. This doesn't seem to break anything.
I don't know if this is a clean solution, seems a little hacky to me, however, it
would be great if the issue could be fixed somehow.
public static final class DirectGetter implements Getter {
private final transient Field field;
private final Class clazz;
private final String name;
private Method method;
DirectGetter(Field field, Class clazz, String name) {
this.field = field;
this.clazz = clazz;
this.name = name;
try
{
BeanInfo beanInfo = Introspector.getBeanInfo( clazz );
PropertyDescriptor[] pdArray = beanInfo.getPropertyDescriptors();
if ( pdArray != null )
{
for (PropertyDescriptor pd : pdArray )
{
if ( pd.getName().equals( name ) )
{
this.method = pd.getReadMethod();
}
}
}
}
catch ( Exception e )
{
// ignore
}
}
public Object get(Object target) throws HibernateException {
try {
return field.get(target);
}
catch (Exception e) {
throw new PropertyAccessException(e, "could not get a field value by
reflection", false, clazz, name);
}
}
public Object getForInsert(Object target, Map mergeMap, SessionImplementor session)
{
return get( target );
}
public Method getMethod() {
return method;
}
public String getMethodName() {
return method == null ? null : method.getName();
}
public Class getReturnType() {
return field.getType();
}
Object readResolve() {
return new DirectGetter( getField(clazz, name), clazz, name );
}
public String toString() {
return "DirectGetter(" + clazz.getName() + '.' + name +
')';
}
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4397
days inactive
5600
days old
hibernate-issues@lists.jboss.org
18 comments
10 participants
participants (10)
-
Christian Bauer (JIRA) -
Gail Badner (JIRA)
-
Jean-Francois Larouche (JIRA)
-
Karsten Wutzke (JIRA)
-
Michael Rudolf (JIRA)
-
Ondrej Medek (JIRA)
-
Paul Benedict (JIRA)
-
Paul Lorenz (JIRA)
-
Steve Ebersole (JIRA)
-
Strong Liu (JIRA)