[ http://opensource.atlassian.com/projects/hibernate/browse/ANN-423?page=all ] Dan Armak updated ANN-423: -------------------------- Attachment: Test.java Code demonstrating the bug -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/ANN-423?page=co... ] Dan Armak commented on ANN-423: ------------------------------- I've attached a fix for MinValidator and MaxValidator, as well as code demonstrating the bug. However, RangeValidator cannot be fixed trivially. If both min and max properties are used then, since they are of type long (as defined in @Range), a BigInteger is equivalent to a long anyway. If, however, only min= or max= is used (functionally equivalent to @Min or @Max), the other parameter takes the value Long.MIN_VALUE or MAX_VALUE (default values defined in @Range). This means validation will be broken for BigIntegers that cannot be represented as longs, even if the sign bug is fixed. Worse, that default value is also set as a range constraint in the db, so if I have a bigger than 64bit numerical DB type I can't use @Range. (Is there such a type? I actually mapped by bigints as varchars in SQL Server 2000.) This behavior can be surprising. I suggest that either the default values should be changed to null (so that no check is made), or @Range is clearly documented not to work with BigIntegers and BigDecimals. Of course, it would be best to make the @Min/@Max/@Range parameters BigIntegers themselves. But that would break BC, so it's up to you I guess. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/ANN-423?page=all ] Emmanuel Bernard updated ANN-423: --------------------------------- Fix Version: 3.2.0.cr2 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/ANN-423?page=co... ] Emmanuel Bernard commented on ANN-423: -------------------------------------- "Worse, that default value is also set as a range constraint in the db, so if I have a bigger than 64bit numerical DB type I can't use @Range." Hum no it's not, we exclude limit when there is a default value -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/ANN-423?page=co... ] Emmanuel Bernard commented on ANN-423: -------------------------------------- Commited: BigDecimal is used to parse string use of BigXxx.compareTo( ) when needed in @Min and @Max -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/ANN-423?page=all ] Emmanuel Bernard resolved ANN-423: ---------------------------------- Resolution: Fixed Opened a new case for @Range -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira