July 2018 - infinispan-issues - Jboss List Archives

[JBoss JIRA] (IPROTO-63) writeObject throws IllegalArgumentException with oneof label

by Adrian Nistor (JIRA)

[ https://issues.jboss.org/browse/IPROTO-63?page=com.atlassian.jira.plugin.... ] Work on IPROTO-63 started by Adrian Nistor. ------------------------------------------- > writeObject throws IllegalArgumentException with oneof label > ------------------------------------------------------------ > > Key: IPROTO-63 > URL: https://issues.jboss.org/browse/IPROTO-63 > Project: Infinispan ProtoStream > Issue Type: Bug > Reporter: Ryan Emerson > Assignee: Adrian Nistor > > The below schema results in the following exception: > Schema: > {code:java} > message EntryVersion { > oneof version { > NumericVersion numeric = 1; > ClusteredVersion clustered = 2; > } > // optional NumericVersion numeric = 1; > // optional ClusteredVersion clustered = 2; > } > message NumericVersion { > required int64 version = 1; > } > message ClusteredVersion { > required int64 version = 1; > required int32 topology = 2; > } > {code} > Exception: > {code:java} > java.lang.IllegalArgumentException: Declared field type is not a message or an enum : numeric > {code} > It seems this is caused because the type for the field "numeric" is null in the associated FieldDescriptor object that is retrieved in the [writeObject impl|https://github.com/infinispan/protostream/blob/master/core/src/main/...]. > If the oneof label is replaced with the commented optional fields, the marshallers work as expected. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 5 months

1
0
0 / 0

[JBoss JIRA] (IPROTO-64) Annotation based marshallers should unmarshall empty repeatable fields as empty collections instead of null

by Adrian Nistor (JIRA)

[ https://issues.jboss.org/browse/IPROTO-64?page=com.atlassian.jira.plugin.... ] Adrian Nistor updated IPROTO-64: -------------------------------- Status: Pull Request Sent (was: Coding In Progress) Git Pull Request: https://github.com/infinispan/protostream/pull/40 > Annotation based marshallers should unmarshall empty repeatable fields as empty collections instead of null > ----------------------------------------------------------------------------------------------------------- > > Key: IPROTO-64 > URL: https://issues.jboss.org/browse/IPROTO-64 > Project: Infinispan ProtoStream > Issue Type: Bug > Affects Versions: 3.0.5.Final > Reporter: Adrian Nistor > Assignee: Adrian Nistor > Fix For: 4.3.0.Alpha1, 4.3.0.Final > > > They are currently set to null but it would be more useful to set them to empty collections. > Protobuf does not have a representation for null or for empty/missing repeatable fields. Whether these are represented as null or empty collection in Java code is just a matter of convenience. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 5 months

1
0
0 / 0

[JBoss JIRA] (IPROTO-64) Annotation based marshallers should unmarshall empty repeatable fields as empty collections instead of null

by Adrian Nistor (JIRA)

[ https://issues.jboss.org/browse/IPROTO-64?page=com.atlassian.jira.plugin.... ] Adrian Nistor updated IPROTO-64: -------------------------------- Fix Version/s: 4.3.0.Alpha1 4.3.0.Final > Annotation based marshallers should unmarshall empty repeatable fields as empty collections instead of null > ----------------------------------------------------------------------------------------------------------- > > Key: IPROTO-64 > URL: https://issues.jboss.org/browse/IPROTO-64 > Project: Infinispan ProtoStream > Issue Type: Bug > Affects Versions: 3.0.5.Final > Reporter: Adrian Nistor > Assignee: Adrian Nistor > Fix For: 4.3.0.Alpha1, 4.3.0.Final > > > They are currently set to null but it would be more useful to set them to empty collections. > Protobuf does not have a representation for null or for empty/missing repeatable fields. Whether these are represented as null or empty collection in Java code is just a matter of convenience. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 5 months

1
0
0 / 0

[JBoss JIRA] (ISPN-9348) Remove anonymous inner classes in lambdas for stores

by William Burns (JIRA)

[ https://issues.jboss.org/browse/ISPN-9348?page=com.atlassian.jira.plugin.... ] William Burns updated ISPN-9348: -------------------------------- Status: Open (was: New) > Remove anonymous inner classes in lambdas for stores > ---------------------------------------------------- > > Key: ISPN-9348 > URL: https://issues.jboss.org/browse/ISPN-9348 > Project: Infinispan > Issue Type: Bug > Reporter: William Burns > Assignee: William Burns > Fix For: 9.4.0.Alpha1 > > > With the store refactoring, a lot of anonymous inner classes inside lambdas made it into the code base. This doesn't compile due to https://youtrack.jetbrains.com/issue/IDEA-177431 so we should fix it to not have people run into it with newer IDEA versions. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 5 months

1
0
0 / 0

[JBoss JIRA] (ISPN-9348) Remove anonymous inner classes in lambdas for stores

by William Burns (JIRA)

[ https://issues.jboss.org/browse/ISPN-9348?page=com.atlassian.jira.plugin.... ] William Burns updated ISPN-9348: -------------------------------- Status: Pull Request Sent (was: Open) Git Pull Request: https://github.com/infinispan/infinispan/pull/6126 > Remove anonymous inner classes in lambdas for stores > ---------------------------------------------------- > > Key: ISPN-9348 > URL: https://issues.jboss.org/browse/ISPN-9348 > Project: Infinispan > Issue Type: Bug > Reporter: William Burns > Assignee: William Burns > Fix For: 9.4.0.Alpha1 > > > With the store refactoring, a lot of anonymous inner classes inside lambdas made it into the code base. This doesn't compile due to https://youtrack.jetbrains.com/issue/IDEA-177431 so we should fix it to not have people run into it with newer IDEA versions. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 5 months

1
0
0 / 0

[JBoss JIRA] (IPROTO-64) Annotation based marshallers should unmarshall empty repeatable fields as empty collections instead of null

by Adrian Nistor (JIRA)

[ https://issues.jboss.org/browse/IPROTO-64?page=com.atlassian.jira.plugin.... ] Adrian Nistor reassigned IPROTO-64: ----------------------------------- Assignee: Adrian Nistor > Annotation based marshallers should unmarshall empty repeatable fields as empty collections instead of null > ----------------------------------------------------------------------------------------------------------- > > Key: IPROTO-64 > URL: https://issues.jboss.org/browse/IPROTO-64 > Project: Infinispan ProtoStream > Issue Type: Bug > Affects Versions: 3.0.5.Final > Reporter: Adrian Nistor > Assignee: Adrian Nistor > > They are currently set to null but it would be more useful to set them to empty collections. > Protobuf does not have a representation for null or for empty/missing repeatable fields. Whether these are represented as null or empty collection in Java code is just a matter of convenience. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 5 months

1
0
0 / 0

[JBoss JIRA] (IPROTO-64) Annotation based marshallers should unmarshall empty repeatable fields as empty collections instead of null

by Adrian Nistor (JIRA)

[ https://issues.jboss.org/browse/IPROTO-64?page=com.atlassian.jira.plugin.... ] Adrian Nistor updated IPROTO-64: -------------------------------- Status: Open (was: New) > Annotation based marshallers should unmarshall empty repeatable fields as empty collections instead of null > ----------------------------------------------------------------------------------------------------------- > > Key: IPROTO-64 > URL: https://issues.jboss.org/browse/IPROTO-64 > Project: Infinispan ProtoStream > Issue Type: Bug > Affects Versions: 3.0.5.Final > Reporter: Adrian Nistor > Assignee: Adrian Nistor > > They are currently set to null but it would be more useful to set them to empty collections. > Protobuf does not have a representation for null or for empty/missing repeatable fields. Whether these are represented as null or empty collection in Java code is just a matter of convenience. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 5 months

1
0
0 / 0

[JBoss JIRA] (IPROTO-64) Annotation based marshallers should unmarshall empty repeatable fields as empty collections instead of null

by Adrian Nistor (JIRA)

[ https://issues.jboss.org/browse/IPROTO-64?page=com.atlassian.jira.plugin.... ] Work on IPROTO-64 started by Adrian Nistor. ------------------------------------------- > Annotation based marshallers should unmarshall empty repeatable fields as empty collections instead of null > ----------------------------------------------------------------------------------------------------------- > > Key: IPROTO-64 > URL: https://issues.jboss.org/browse/IPROTO-64 > Project: Infinispan ProtoStream > Issue Type: Bug > Affects Versions: 3.0.5.Final > Reporter: Adrian Nistor > Assignee: Adrian Nistor > > They are currently set to null but it would be more useful to set them to empty collections. > Protobuf does not have a representation for null or for empty/missing repeatable fields. Whether these are represented as null or empty collection in Java code is just a matter of convenience. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 5 months

1
0
0 / 0

[JBoss JIRA] (IPROTO-64) Annotation based marshallers should unmarshall empty repeatable fields as empty collections instead of null

by Adrian Nistor (JIRA)

Adrian Nistor created IPROTO-64: ----------------------------------- Summary: Annotation based marshallers should unmarshall empty repeatable fields as empty collections instead of null Key: IPROTO-64 URL: https://issues.jboss.org/browse/IPROTO-64 Project: Infinispan ProtoStream Issue Type: Bug Affects Versions: 3.0.5.Final Reporter: Adrian Nistor They are currently set to null but it would be more useful to set them to empty collections. Protobuf does not have a representation for null or for empty/missing repeatable fields. Whether these are represented as null or empty collection in Java code is just a matter of convenience. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 5 months

1
0
0 / 0

[JBoss JIRA] (ISPN-9348) Remove anonymous inner classes in lambdas for stores

by William Burns (JIRA)

William Burns created ISPN-9348: ----------------------------------- Summary: Remove anonymous inner classes in lambdas for stores Key: ISPN-9348 URL: https://issues.jboss.org/browse/ISPN-9348 Project: Infinispan Issue Type: Bug Reporter: William Burns Assignee: William Burns Fix For: 9.4.0.Alpha1 With the store refactoring, a lot of anonymous inner classes inside lambdas made it into the code base. This doesn't compile due to https://youtrack.jetbrains.com/issue/IDEA-177431 so we should fix it to not have people run into it with newer IDEA versions. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 5 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

infinispan-issues July 2018