[JBoss JIRA] (ISPN-4646) BoundedCHM fixes
by Galder Zamarreño (JIRA)
[ https://issues.jboss.org/browse/ISPN-4646?page=com.atlassian.jira.plugin.... ]
Galder Zamarreño updated ISPN-4646:
-----------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/infinispan/infinispan/pull/2788
> BoundedCHM fixes
> ----------------
>
> Key: ISPN-4646
> URL: https://issues.jboss.org/browse/ISPN-4646
> Project: Infinispan
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 6.0.2.Final
> Reporter: Galder Zamarreño
> Assignee: Galder Zamarreño
> Fix For: 7.0.0.Beta2, 7.0.0.Final
>
>
> Here are a few fixes to the eviction algorithms in BoundedConcurrentHashMap, in order of importance.
> (1) Fixes a (nearly) endless loop that killed our production servers.
> (2-3) Fix minor bugs in cache hit processing.
> (4-6) Minor optimizations and code cleanup.
> (7) A side effect of this is that it (mostly) separates eviction algorithm and hash map implementations, so its a step towards allowing arbitrary eviction algorithms.
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
11 years, 7 months
[JBoss JIRA] (ISPN-4646) BoundedCHM fixes
by Galder Zamarreño (JIRA)
[ https://issues.jboss.org/browse/ISPN-4646?page=com.atlassian.jira.plugin.... ]
Galder Zamarreño updated ISPN-4646:
-----------------------------------
Description:
Here are a few fixes to the eviction algorithms in BoundedConcurrentHashMap, in order of importance.
(1) Fixes a (nearly) endless loop that killed our production servers.
(2-3) Fix minor bugs in cache hit processing.
(4-6) Minor optimizations and code cleanup.
(7) A side effect of this is that it (mostly) separates eviction algorithm and hash map implementations, so its a step towards allowing arbitrary eviction algorithms.
was:Wrapper for fixes in https://github.com/infinispan/infinispan/pull/2788
> BoundedCHM fixes
> ----------------
>
> Key: ISPN-4646
> URL: https://issues.jboss.org/browse/ISPN-4646
> Project: Infinispan
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 6.0.2.Final
> Reporter: Galder Zamarreño
> Assignee: Galder Zamarreño
> Fix For: 7.0.0.Beta2, 7.0.0.Final
>
>
> Here are a few fixes to the eviction algorithms in BoundedConcurrentHashMap, in order of importance.
> (1) Fixes a (nearly) endless loop that killed our production servers.
> (2-3) Fix minor bugs in cache hit processing.
> (4-6) Minor optimizations and code cleanup.
> (7) A side effect of this is that it (mostly) separates eviction algorithm and hash map implementations, so its a step towards allowing arbitrary eviction algorithms.
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
11 years, 7 months
[JBoss JIRA] (ISPN-4323) ConditionalOperationsConcurrentWriteSkewTest fails randomly
by William Burns (JIRA)
[ https://issues.jboss.org/browse/ISPN-4323?page=com.atlassian.jira.plugin.... ]
William Burns commented on ISPN-4323:
-------------------------------------
Also to note this test failure occurred where the test was taking over 5 minutes to complete!!!
http://ci.infinispan.org/viewLog.html?buildId=10899&buildTypeId=bt9
> ConditionalOperationsConcurrentWriteSkewTest fails randomly
> -----------------------------------------------------------
>
> Key: ISPN-4323
> URL: https://issues.jboss.org/browse/ISPN-4323
> Project: Infinispan
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Core
> Affects Versions: 7.0.0.Alpha1, 7.0.0.Alpha2, 7.0.0.Alpha3, 7.0.0.Alpha4
> Environment: RHEL and Open JDK
> Reporter: Vitalii Chepeliuk
> Assignee: William Burns
> Priority: Blocker
> Labels: testsuite_stability
> Attachments: ConditionalOperationsConcurrentWriteSkewTest.log.zip, ConditionalOperationsConcurrentWriteSkewTest.tar.bz2
>
>
> Following tests fail with TImeout exception
> org.infinispan.api.ConditionalOperationsConcurrentWriteSkewTest.testConditionalRemove
> org.infinispan.api.ConditionalOperationsConcurrentWriteSkewTest.testReplace
> org.infinispan.api.ConditionalOperationsConcurrentWriteSkewTest.testPutIfAbsent
> {noformat}
> java.lang.AssertionError: java.lang.RuntimeException: java.util.concurrent.TimeoutException
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertFalse(Assert.java:64)
> at org.infinispan.api.ConditionalOperationsConcurrentTest.testOnCaches(ConditionalOperationsConcurrentTest.java:129)
> at org.infinispan.api.ConditionalOperationsConcurrentWriteSkewTest.testConditionalRemove(ConditionalOperationsConcurrentWriteSkewTest.java:56)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:80)
> at org.testng.internal.Invoker.invokeMethod(Invoker.java:714)
> at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:901)
> at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1231)
> at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127)
> at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111)
> at org.testng.TestRunner.privateRun(TestRunner.java:767)
> at org.testng.TestRunner.run(TestRunner.java:617)
> at org.testng.SuiteRunner.runTest(SuiteRunner.java:334)
> at org.testng.SuiteRunner.access$000(SuiteRunner.java:37)
> at org.testng.SuiteRunner$SuiteWorker.run(SuiteRunner.java:368)
> at org.testng.internal.thread.ThreadUtil$2.call(ThreadUtil.java:64)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:744)
> {noformat}
> Failing tests in Jenkins
> https://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/JDG/view/FUNC/job/e...
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
11 years, 7 months
[JBoss JIRA] (ISPN-4323) ConditionalOperationsConcurrentWriteSkewTest fails randomly
by William Burns (JIRA)
[ https://issues.jboss.org/browse/ISPN-4323?page=com.atlassian.jira.plugin.... ]
William Burns commented on ISPN-4323:
-------------------------------------
Also can confirm that thread remote-thread-ConditionalOperationsConcurrentWriteSkewTest-NodeC-p29549-t3: should have been idle during this period so it could have operated even if the other thread was stuck.
> ConditionalOperationsConcurrentWriteSkewTest fails randomly
> -----------------------------------------------------------
>
> Key: ISPN-4323
> URL: https://issues.jboss.org/browse/ISPN-4323
> Project: Infinispan
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Core
> Affects Versions: 7.0.0.Alpha1, 7.0.0.Alpha2, 7.0.0.Alpha3, 7.0.0.Alpha4
> Environment: RHEL and Open JDK
> Reporter: Vitalii Chepeliuk
> Assignee: William Burns
> Priority: Blocker
> Labels: testsuite_stability
> Attachments: ConditionalOperationsConcurrentWriteSkewTest.log.zip, ConditionalOperationsConcurrentWriteSkewTest.tar.bz2
>
>
> Following tests fail with TImeout exception
> org.infinispan.api.ConditionalOperationsConcurrentWriteSkewTest.testConditionalRemove
> org.infinispan.api.ConditionalOperationsConcurrentWriteSkewTest.testReplace
> org.infinispan.api.ConditionalOperationsConcurrentWriteSkewTest.testPutIfAbsent
> {noformat}
> java.lang.AssertionError: java.lang.RuntimeException: java.util.concurrent.TimeoutException
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertFalse(Assert.java:64)
> at org.infinispan.api.ConditionalOperationsConcurrentTest.testOnCaches(ConditionalOperationsConcurrentTest.java:129)
> at org.infinispan.api.ConditionalOperationsConcurrentWriteSkewTest.testConditionalRemove(ConditionalOperationsConcurrentWriteSkewTest.java:56)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:80)
> at org.testng.internal.Invoker.invokeMethod(Invoker.java:714)
> at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:901)
> at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1231)
> at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127)
> at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111)
> at org.testng.TestRunner.privateRun(TestRunner.java:767)
> at org.testng.TestRunner.run(TestRunner.java:617)
> at org.testng.SuiteRunner.runTest(SuiteRunner.java:334)
> at org.testng.SuiteRunner.access$000(SuiteRunner.java:37)
> at org.testng.SuiteRunner$SuiteWorker.run(SuiteRunner.java:368)
> at org.testng.internal.thread.ThreadUtil$2.call(ThreadUtil.java:64)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:744)
> {noformat}
> Failing tests in Jenkins
> https://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/JDG/view/FUNC/job/e...
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
11 years, 7 months
[JBoss JIRA] (ISPN-4323) ConditionalOperationsConcurrentWriteSkewTest fails randomly
by William Burns (JIRA)
[ https://issues.jboss.org/browse/ISPN-4323?page=com.atlassian.jira.plugin.... ]
William Burns commented on ISPN-4323:
-------------------------------------
Looking at some of the logs it does indeed appear to be some sort of GC or other test.
For example this one failed because there is a pause in the log file over over 11 seconds
{code}
02:54:51,183 ERROR (ConditionalOperationsConcurrentWriteSkewTest-7:) [InvocationContextInterceptor] ISPN000136: Execution error
... Stack trace ommitted..
02:55:22,823 TRACE (ConditionalOperationsConcurrentWriteSkewTest-7:) [InvocationContextInterceptor] Transaction marked for rollback as exception was received.
{code}
No other thread updates anything in this log file for this test during this period.
> ConditionalOperationsConcurrentWriteSkewTest fails randomly
> -----------------------------------------------------------
>
> Key: ISPN-4323
> URL: https://issues.jboss.org/browse/ISPN-4323
> Project: Infinispan
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Core
> Affects Versions: 7.0.0.Alpha1, 7.0.0.Alpha2, 7.0.0.Alpha3, 7.0.0.Alpha4
> Environment: RHEL and Open JDK
> Reporter: Vitalii Chepeliuk
> Assignee: William Burns
> Priority: Blocker
> Labels: testsuite_stability
> Attachments: ConditionalOperationsConcurrentWriteSkewTest.log.zip, ConditionalOperationsConcurrentWriteSkewTest.tar.bz2
>
>
> Following tests fail with TImeout exception
> org.infinispan.api.ConditionalOperationsConcurrentWriteSkewTest.testConditionalRemove
> org.infinispan.api.ConditionalOperationsConcurrentWriteSkewTest.testReplace
> org.infinispan.api.ConditionalOperationsConcurrentWriteSkewTest.testPutIfAbsent
> {noformat}
> java.lang.AssertionError: java.lang.RuntimeException: java.util.concurrent.TimeoutException
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertFalse(Assert.java:64)
> at org.infinispan.api.ConditionalOperationsConcurrentTest.testOnCaches(ConditionalOperationsConcurrentTest.java:129)
> at org.infinispan.api.ConditionalOperationsConcurrentWriteSkewTest.testConditionalRemove(ConditionalOperationsConcurrentWriteSkewTest.java:56)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:80)
> at org.testng.internal.Invoker.invokeMethod(Invoker.java:714)
> at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:901)
> at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1231)
> at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127)
> at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111)
> at org.testng.TestRunner.privateRun(TestRunner.java:767)
> at org.testng.TestRunner.run(TestRunner.java:617)
> at org.testng.SuiteRunner.runTest(SuiteRunner.java:334)
> at org.testng.SuiteRunner.access$000(SuiteRunner.java:37)
> at org.testng.SuiteRunner$SuiteWorker.run(SuiteRunner.java:368)
> at org.testng.internal.thread.ThreadUtil$2.call(ThreadUtil.java:64)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:744)
> {noformat}
> Failing tests in Jenkins
> https://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/JDG/view/FUNC/job/e...
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
11 years, 7 months