[JBoss JIRA] (ISPN-4627) QueryInterceptor start() event mutates the SearchFactory multiple times
by Adrian Nistor (JIRA)
[ https://issues.jboss.org/browse/ISPN-4627?page=com.atlassian.jira.plugin.... ]
Adrian Nistor commented on ISPN-4627:
-------------------------------------
Excellent catch!
> QueryInterceptor start() event mutates the SearchFactory multiple times
> -----------------------------------------------------------------------
>
> Key: ISPN-4627
> URL: https://issues.jboss.org/browse/ISPN-4627
> Project: Infinispan
> Issue Type: Enhancement
> Security Level: Public(Everyone can see)
> Components: Embedded Querying
> Reporter: Sanne Grinovero
> Assignee: Sanne Grinovero
> Priority: Minor
> Fix For: 7.0.0.Beta1
>
>
> Just spotted while reviewing unrelated patches:
> the {{@Start}} annotated method of component {{QueryInterceptor}} loops throught the known entries of the {{clusterRegistry}} field, and will reboot the {{SearchFactory}} once for each entry.
> It's important to use the capability to pass multiple class types at once when mutating the SearchFactory, as this is an extremely slow operation, and especially in this case, if it's a node joining an existing cluster we expect to see a considerable amount of indexed types (probably all of them).
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
11 years, 8 months
[JBoss JIRA] (ISPN-4627) QueryInterceptor start() event mutates the SearchFactory multiple times
by Sanne Grinovero (JIRA)
[ https://issues.jboss.org/browse/ISPN-4627?page=com.atlassian.jira.plugin.... ]
Sanne Grinovero updated ISPN-4627:
----------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/infinispan/infinispan/pull/2789
> QueryInterceptor start() event mutates the SearchFactory multiple times
> -----------------------------------------------------------------------
>
> Key: ISPN-4627
> URL: https://issues.jboss.org/browse/ISPN-4627
> Project: Infinispan
> Issue Type: Enhancement
> Security Level: Public(Everyone can see)
> Components: Embedded Querying
> Reporter: Sanne Grinovero
> Assignee: Sanne Grinovero
> Priority: Minor
> Fix For: 7.0.0.Beta1
>
>
> Just spotted while reviewing unrelated patches:
> the {{@Start}} annotated method of component {{QueryInterceptor}} loops throught the known entries of the {{clusterRegistry}} field, and will reboot the {{SearchFactory}} once for each entry.
> It's important to use the capability to pass multiple class types at once when mutating the SearchFactory, as this is an extremely slow operation, and especially in this case, if it's a node joining an existing cluster we expect to see a considerable amount of indexed types (probably all of them).
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
11 years, 8 months
[JBoss JIRA] (ISPN-4627) QueryInterceptor start() event mutates the SearchFactory multiple times
by Sanne Grinovero (JIRA)
[ https://issues.jboss.org/browse/ISPN-4627?page=com.atlassian.jira.plugin.... ]
Sanne Grinovero reassigned ISPN-4627:
-------------------------------------
Assignee: Sanne Grinovero (was: Gustavo Fernandes)
> QueryInterceptor start() event mutates the SearchFactory multiple times
> -----------------------------------------------------------------------
>
> Key: ISPN-4627
> URL: https://issues.jboss.org/browse/ISPN-4627
> Project: Infinispan
> Issue Type: Enhancement
> Security Level: Public(Everyone can see)
> Components: Embedded Querying
> Reporter: Sanne Grinovero
> Assignee: Sanne Grinovero
> Priority: Minor
> Fix For: 7.0.0.Beta1
>
>
> Just spotted while reviewing unrelated patches:
> the {{@Start}} annotated method of component {{QueryInterceptor}} loops throught the known entries of the {{clusterRegistry}} field, and will reboot the {{SearchFactory}} once for each entry.
> It's important to use the capability to pass multiple class types at once when mutating the SearchFactory, as this is an extremely slow operation, and especially in this case, if it's a node joining an existing cluster we expect to see a considerable amount of indexed types (probably all of them).
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
11 years, 8 months