[JBoss JIRA] (ISPN-3716) Shareability of Configuration and ConfigurationBuilder instances (and global versions)
by Tristan Tarrant (JIRA)
[ https://issues.jboss.org/browse/ISPN-3716?page=com.atlassian.jira.plugin.... ]
Tristan Tarrant reassigned ISPN-3716:
-------------------------------------
Assignee: (was: Mircea Markus)
> Shareability of Configuration and ConfigurationBuilder instances (and global versions)
> --------------------------------------------------------------------------------------
>
> Key: ISPN-3716
> URL: https://issues.jboss.org/browse/ISPN-3716
> Project: Infinispan
> Issue Type: Enhancement
> Components: Configuration
> Reporter: Galder Zamarreño
>
> Widlfly is using Configuration/GlobalConfiguration instances of one cache/cachemanager to create other cache managers.
> Configuration/GlobalConfiguration are probably not designed to be shareable at this point in time. The builder classes should be sharable but sharing them would not have resolved the issue in ISPN-3698.
> It probably makes sense to change marshaller to be a factory or lookup configuration to be able to create instances of marshaller when configuration is created.
> ConfigurationBuilder/GlobalConfigurationBuilder classes are expected to be shareable.
> Tests and verifications should be added.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 2 months
[JBoss JIRA] (ISPN-3716) Shareability of Configuration and ConfigurationBuilder instances (and global versions)
by Tristan Tarrant (JIRA)
[ https://issues.jboss.org/browse/ISPN-3716?page=com.atlassian.jira.plugin.... ]
Tristan Tarrant updated ISPN-3716:
----------------------------------
Fix Version/s: (was: 7.1.0.CR1)
> Shareability of Configuration and ConfigurationBuilder instances (and global versions)
> --------------------------------------------------------------------------------------
>
> Key: ISPN-3716
> URL: https://issues.jboss.org/browse/ISPN-3716
> Project: Infinispan
> Issue Type: Enhancement
> Components: Configuration
> Reporter: Galder Zamarreño
>
> Widlfly is using Configuration/GlobalConfiguration instances of one cache/cachemanager to create other cache managers.
> Configuration/GlobalConfiguration are probably not designed to be shareable at this point in time. The builder classes should be sharable but sharing them would not have resolved the issue in ISPN-3698.
> It probably makes sense to change marshaller to be a factory or lookup configuration to be able to create instances of marshaller when configuration is created.
> ConfigurationBuilder/GlobalConfigurationBuilder classes are expected to be shareable.
> Tests and verifications should be added.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 2 months
[JBoss JIRA] (ISPN-4051) ProtoStream should provide guidelines when it fails to resolve dependencies correctly
by Adrian Nistor (JIRA)
[ https://issues.jboss.org/browse/ISPN-4051?page=com.atlassian.jira.plugin.... ]
Adrian Nistor resolved ISPN-4051.
---------------------------------
Resolution: Out of Date
This is no longer an issue since we no longer use binary descriptors.
> ProtoStream should provide guidelines when it fails to resolve dependencies correctly
> -------------------------------------------------------------------------------------
>
> Key: ISPN-4051
> URL: https://issues.jboss.org/browse/ISPN-4051
> Project: Infinispan
> Issue Type: Bug
> Reporter: Tristan Tarrant
> Assignee: Adrian Nistor
>
> Attempting to import a ProtoBuf definition which uses imports fails with:
> Caused by: com.google.protobuf.Descriptors$DescriptorValidationException: AeiReaderMessage_M.proto: Dependencies passed to FileDescriptor.buildFrom() don't match those listed in the FileDescriptorProto.
> at com.google.protobuf.Descriptors$FileDescriptor.buildFrom(Descriptors.java:240)
> at org.infinispan.protostream.impl.SerializationContextImpl.registerProtofile(SerializationContextImpl.java:61)
> at org.infinispan.query.remote.ProtobufMetadataManager$ProtobufMetadataRegistryListener.registerProtofile(ProtobufMetadataManager.java:154)
> at org.infinispan.query.remote.ProtobufMetadataManager$ProtobufMetadataRegistryListener.modified(ProtobufMetadataManager.java:149)
> This is caused by the fact that SerializationContextImpl#resolveDeps returns an empty array even though the inlcuded file is actually in the definition.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 2 months
[JBoss JIRA] (ISPN-3769) Disallow async marshalling when the replication queue is enabled
by Tristan Tarrant (JIRA)
[ https://issues.jboss.org/browse/ISPN-3769?page=com.atlassian.jira.plugin.... ]
Tristan Tarrant updated ISPN-3769:
----------------------------------
Fix Version/s: (was: 7.1.0.CR1)
> Disallow async marshalling when the replication queue is enabled
> ----------------------------------------------------------------
>
> Key: ISPN-3769
> URL: https://issues.jboss.org/browse/ISPN-3769
> Project: Infinispan
> Issue Type: Task
> Components: Core
> Affects Versions: 6.0.0.Final
> Reporter: Dan Berindei
> Assignee: Mircea Markus
>
> The rationale is similar to ISPN-2939, the async marshalling option can cause inconsistencies because it can reorder commands.
> But the case is stronger when the replication queue is in use, because the {{RpcManager.invokeRemotely()}} call already happens on a the replication queue's background thread. The user thread is already free to do its thing, so there isn't any reason to do the RPC on yet another background thread.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 2 months
[JBoss JIRA] (ISPN-3769) Disallow async marshalling when the replication queue is enabled
by Tristan Tarrant (JIRA)
[ https://issues.jboss.org/browse/ISPN-3769?page=com.atlassian.jira.plugin.... ]
Tristan Tarrant reassigned ISPN-3769:
-------------------------------------
Assignee: Pedro Ruivo (was: Mircea Markus)
> Disallow async marshalling when the replication queue is enabled
> ----------------------------------------------------------------
>
> Key: ISPN-3769
> URL: https://issues.jboss.org/browse/ISPN-3769
> Project: Infinispan
> Issue Type: Task
> Components: Core
> Affects Versions: 6.0.0.Final
> Reporter: Dan Berindei
> Assignee: Pedro Ruivo
>
> The rationale is similar to ISPN-2939, the async marshalling option can cause inconsistencies because it can reorder commands.
> But the case is stronger when the replication queue is in use, because the {{RpcManager.invokeRemotely()}} call already happens on a the replication queue's background thread. The user thread is already free to do its thing, so there isn't any reason to do the RPC on yet another background thread.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 2 months
[JBoss JIRA] (ISPN-3743) Silence "IllegalStateException: Default cache is in 'STOPPING' state" exceptions
by Tristan Tarrant (JIRA)
[ https://issues.jboss.org/browse/ISPN-3743?page=com.atlassian.jira.plugin.... ]
Tristan Tarrant updated ISPN-3743:
----------------------------------
Fix Version/s: (was: 7.1.0.CR1)
> Silence "IllegalStateException: Default cache is in 'STOPPING' state" exceptions
> --------------------------------------------------------------------------------
>
> Key: ISPN-3743
> URL: https://issues.jboss.org/browse/ISPN-3743
> Project: Infinispan
> Issue Type: Feature Request
> Components: Core
> Affects Versions: 6.0.0.Final
> Reporter: Dan Berindei
> Labels: testsuite_stability
>
> When a cache in STOPPING state receives a command, the exception is propagated all the way to the caller:
> {noformat}
> 09:33:02,005 ERROR (testng-NonTxPutIfAbsentDuringLeaveStressTest:) [UnitTestTestNGListener] Test testNodeLeavingDuringPutIfAbsent(org.infinispan.distribution.rehash.NonTxPutIfAbsentDuringLeaveStressTest) failed.
> java.util.concurrent.ExecutionException: org.infinispan.remoting.RemoteException: ISPN000217: Received exception from NodeC-25987, see cause for remote stack trace
> at java.util.concurrent.FutureTask.report(FutureTask.java:122)
> Caused by: org.infinispan.remoting.RemoteException: ISPN000217: Received exception from NodeC-25987, see cause for remote stack trace
> at org.infinispan.remoting.transport.AbstractTransport.checkResponse(AbstractTransport.java:41)
> Caused by: org.infinispan.remoting.RemoteException: ISPN000217: Received exception from NodeD-57301, see cause for remote stack trace
> at org.infinispan.remoting.transport.AbstractTransport.checkResponse(AbstractTransport.java:41)
> Caused by: java.lang.IllegalStateException: Default cache is in 'STOPPING' state and this is an invocation not belonging to an on-going transaction, so it does not accept new invocations. Either restart it or recreate the cache container.
> at org.infinispan.interceptors.InvocationContextInterceptor.handleAll(InvocationContextInterceptor.java:93)
> {noformat}
> This causes random failures in NonTxPutIfAbsentDuringLeaveStressTest.testNodeLeavingDuringPutIfAbsent.
> The originator should either ignore the IllegalStateException or wait for a new cache topology and retry the operation, just like it should for SuspectExceptions (ISPN-2577).
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 2 months
[JBoss JIRA] (ISPN-3795) QueryInterceptor incorrectly relies on the return value of a RemoveCommand
by Tristan Tarrant (JIRA)
[ https://issues.jboss.org/browse/ISPN-3795?page=com.atlassian.jira.plugin.... ]
Tristan Tarrant updated ISPN-3795:
----------------------------------
Fix Version/s: (was: 7.1.0.CR1)
> QueryInterceptor incorrectly relies on the return value of a RemoveCommand
> --------------------------------------------------------------------------
>
> Key: ISPN-3795
> URL: https://issues.jboss.org/browse/ISPN-3795
> Project: Infinispan
> Issue Type: Bug
> Components: Embedded Querying
> Affects Versions: 6.0.0.Final
> Reporter: Dan Berindei
>
> QueryInterceptor uses the return value from RemoveCommand/ReplaceCommand to remove the value from the index.
> But both RemoveCommand and ReplaceCommand have a variant with an expected value parameter, and this variant return a boolean value instead of the removed/replaced value. In that case, the previous value won't be removed from the index.
> QueryInterceptor should probably use the previous value from the context entries to update the index instead.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 2 months