April 2015 - infinispan-issues - Jboss List Archives

[JBoss JIRA] (ISPN-3729) Minimize the number of moved segments for SyncConsistentHashFactory

by Gustavo Fernandes (JIRA)

[ https://issues.jboss.org/browse/ISPN-3729?page=com.atlassian.jira.plugin.... ] Gustavo Fernandes updated ISPN-3729: ------------------------------------ Fix Version/s: 7.2.0.Final (was: 7.2.0.CR1) > Minimize the number of moved segments for SyncConsistentHashFactory > ------------------------------------------------------------------- > > Key: ISPN-3729 > URL: https://issues.jboss.org/browse/ISPN-3729 > Project: Infinispan > Issue Type: Bug > Components: Core > Affects Versions: 6.0.0.Final > Reporter: Dan Berindei > Assignee: Dan Berindei > Fix For: 7.2.0.Final > > > SyncConsistentHash uses an algorithm that's similar to consistent hashing, but when there is a collision (two nodes map to the same segment), the second node is moved to the next segment. Since the nodes are ordered by their UUID, that means it's possible for a joiner to change the mapping of existing nodes. > In order to make the load distribution more even, SyncConsistentHash also uses "virtual nodes": each node actually maps to multiple segments. This makes the number of collisions much higher (and implicitly, the number of extra moved segments). > Reading the original [consistent hashing paper|http://thor.cs.ucsb.edu/~ravenben/papers/coreos/kll%2B97.pdf], it looks like the collision handling should be done differently: a joiner should replace an existing node when it's "closer" to the segment boundary, but the existing node should never "lose" segments to another existing node (the property of monotonicity mentioned in the paper). We should investigate whether changing this would allow us to achieve better load balancing by using a much higher number of "virtual nodes" (without moving extra segments). If successful, we could even use SyncConsistentHashFactory as the default hash algorithm. -- This message was sent by Atlassian JIRA (v6.3.11#6341)

10 years, 11 months

1
0
0 / 0

[JBoss JIRA] (ISPN-3985) In BCHM traverse internal segments for parallel map/reduce execution

by Gustavo Fernandes (JIRA)

[ https://issues.jboss.org/browse/ISPN-3985?page=com.atlassian.jira.plugin.... ] Gustavo Fernandes updated ISPN-3985: ------------------------------------ Fix Version/s: 7.2.0.Final (was: 7.2.0.CR1) > In BCHM traverse internal segments for parallel map/reduce execution > -------------------------------------------------------------------- > > Key: ISPN-3985 > URL: https://issues.jboss.org/browse/ISPN-3985 > Project: Infinispan > Issue Type: Enhancement > Components: Core > Affects Versions: 7.0.0.Final > Reporter: Vladimir Blagojevic > Fix For: 7.2.0.Final > > > Currently when BoundedConcurrentHashMap is used in DataContainer we split input keys and traverse key/value pairs in parallel using executor. That is all good, however, we should optimize this solution as each segment in BCHM is a separate map we can iterate over each segment in a separate thread rather than blindly splitting input keys. -- This message was sent by Atlassian JIRA (v6.3.11#6341)

10 years, 11 months

1
0
0 / 0

[JBoss JIRA] (ISPN-3938) AdvancedAsyncCacheLoader.process() concurrency issues

by Gustavo Fernandes (JIRA)

[ https://issues.jboss.org/browse/ISPN-3938?page=com.atlassian.jira.plugin.... ] Gustavo Fernandes updated ISPN-3938: ------------------------------------ Fix Version/s: 7.2.0.Final (was: 7.2.0.CR1) > AdvancedAsyncCacheLoader.process() concurrency issues > ----------------------------------------------------- > > Key: ISPN-3938 > URL: https://issues.jboss.org/browse/ISPN-3938 > Project: Infinispan > Issue Type: Bug > Components: Core, Loaders and Stores > Affects Versions: 6.0.0.Final > Reporter: Dan Berindei > Assignee: William Burns > Fix For: 7.2.0.Final > > > {{AdvancedAsyncCacheLoader.process()}} calls {{advancedLoader().process()}} to collect all the keys in the store, but the HashSet used to collect the keys it not thread-safe. This can cause problems, e.g. during state transfer: > {noformat} > WARN cheTopologyControlCommand | ISPN000071: Caught exception when handling command CacheTopologyControlCommand{cache=sessions, type=CH_UPDATE, sender=alfie-lt-46127, joinInfo=null, topologyId=3, currentCH=DefaultConsistentHash{numSegments=60, numOwners=1, members=[alfie-lt-46127]}, pendingCH=null, throwable=null, viewId=1}java.util.ConcurrentModificationException > at java.util.HashMap$HashIterator.nextEntry(HashMap.java:926) > at java.util.HashMap$KeyIterator.next(HashMap.java:960) > at org.infinispan.persistence.async.AdvancedAsyncCacheLoader.process(AdvancedAsyncCacheLoader.java:80) > at org.infinispan.persistence.manager.PersistenceManagerImpl.processOnAllStores(PersistenceManagerImpl.java:414) > at org.infinispan.statetransfer.StateConsumerImpl.invalidateSegments(StateConsumerImpl.java:910) > at org.infinispan.statetransfer.StateConsumerImpl.onTopologyUpdate(StateConsumerImpl.java:393) > at org.infinispan.statetransfer.StateTransferManagerImpl.doTopologyUpdate(StateTransferManagerImpl.java:178) > at org.infinispan.statetransfer.StateTransferManagerImpl.access$000(StateTransferManagerImpl.java:38) > at org.infinispan.statetransfer.StateTransferManagerImpl$1.updateConsistentHash(StateTransferManagerImpl.java:100) > at org.infinispan.topology.LocalTopologyManagerImpl.handleConsistentHashUpdate(LocalTopologyManagerImpl.java:191) > at org.infinispan.topology.CacheTopologyControlCommand.doPerform(CacheTopologyControlCommand.java:152) > at org.infinispan.topology.CacheTopologyControlCommand.perform(CacheTopologyControlCommand.java:124) > at org.infinispan.topology.ClusterTopologyManagerImpl$3.run(ClusterTopologyManagerImpl.java:606) > at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) > at java.util.concurrent.FutureTask.run(FutureTask.java:262) > at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) > at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) > at java.lang.Thread.run(Thread.java:744) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.11#6341)

10 years, 11 months

1
0
0 / 0

[JBoss JIRA] (ISPN-3918) Inconsistent view of the cache with putIfAbsent in a non-tx cache during state transfer

by Gustavo Fernandes (JIRA)

[ https://issues.jboss.org/browse/ISPN-3918?page=com.atlassian.jira.plugin.... ] Gustavo Fernandes updated ISPN-3918: ------------------------------------ Fix Version/s: 7.2.0.Final (was: 7.2.0.CR1) > Inconsistent view of the cache with putIfAbsent in a non-tx cache during state transfer > --------------------------------------------------------------------------------------- > > Key: ISPN-3918 > URL: https://issues.jboss.org/browse/ISPN-3918 > Project: Infinispan > Issue Type: Bug > Components: Core, State Transfer > Affects Versions: 6.0.0.Final > Reporter: Dan Berindei > Fix For: 7.2.0.Final > > Attachments: ntpiadjst.log.gz > > > In a non-tx cache, sometimes it's possible for a {{get(k)}} to return {{null}} even though a previous {{putIfAbsent(k, v)}} returned a non-null value and the only concurrent operations on the cache are concurrent putIfAbsent calls. > Say \[B, A, C] are the owners of k (C just joined) > 1. A starts a {{putIfAbsent(k, v1)}} command, sends it to B > 2. B forwards the command to A and C > 3. C writes {{k=v1}} > 4. C becomes the primary owner of k (owners are now \[C, A]) > 5. A/B see the new topology before committing and throw an outdatedTopologyException > 6. A retries the command, sends it to C > 7. C forwards the command to A, which writes {{k=v1}} > 8. C doesn't have to update the entry, returns null > If, between steps 3 and 7, another thread on A starts a {{putIfAbsent(k, v2)}} command, the command will fail and return {{v1}} (because the primary owner already has a value). However, a subsequent {{get(k)}} command will return {{null}}, because A is an owner and doesn't have the value. -- This message was sent by Atlassian JIRA (v6.3.11#6341)

10 years, 11 months

1
0
0 / 0

[JBoss JIRA] (ISPN-3906) Do not place ProtobufValueWrapper instances in the cache

by Gustavo Fernandes (JIRA)

[ https://issues.jboss.org/browse/ISPN-3906?page=com.atlassian.jira.plugin.... ] Gustavo Fernandes updated ISPN-3906: ------------------------------------ Fix Version/s: 7.2.0.Final (was: 7.2.0.CR1) > Do not place ProtobufValueWrapper instances in the cache > -------------------------------------------------------- > > Key: ISPN-3906 > URL: https://issues.jboss.org/browse/ISPN-3906 > Project: Infinispan > Issue Type: Task > Components: Embedded Querying > Affects Versions: 6.0.0.Final > Reporter: Adrian Nistor > Assignee: Adrian Nistor > Fix For: 7.2.0.Final > > > ProtobufValueWrapper is only needed in order to provide a classbridge so we can integrate with Hibernate Search. Still, we should not need to wrap the protobuf encoded byte array put in the cache with this class. It should only be created as a temporary wrapper just before we feed the data to Hibernate Search. -- This message was sent by Atlassian JIRA (v6.3.11#6341)

10 years, 11 months

1
0
0 / 0

[JBoss JIRA] (ISPN-3905) Murmurhash3 implementation is slow on String keys

by Gustavo Fernandes (JIRA)

[ https://issues.jboss.org/browse/ISPN-3905?page=com.atlassian.jira.plugin.... ] Gustavo Fernandes updated ISPN-3905: ------------------------------------ Fix Version/s: 7.2.0.Final (was: 7.2.0.CR1) > Murmurhash3 implementation is slow on String keys > ------------------------------------------------- > > Key: ISPN-3905 > URL: https://issues.jboss.org/browse/ISPN-3905 > Project: Infinispan > Issue Type: Enhancement > Components: Core > Affects Versions: 6.0.0.Final, 6.0.1.Final > Reporter: Sanne Grinovero > Assignee: Dan Berindei > Priority: Minor > Fix For: 7.2.0.Final > > > String instances are a common choice for being used as key entries, still the getBytes() operation being performed allocates costly buffers, and the computation to get those bytes looks like expensive too. > I suspect there might be good reasons for not using the String's own hashcode directly as an input to Murmurhash? Still that's what other implementations seem to do. -- This message was sent by Atlassian JIRA (v6.3.11#6341)

10 years, 11 months

1
0
0 / 0

[JBoss JIRA] (ISPN-4340) Automatically setup shared indexes when indexing is enabled

by Gustavo Fernandes (JIRA)

[ https://issues.jboss.org/browse/ISPN-4340?page=com.atlassian.jira.plugin.... ] Gustavo Fernandes updated ISPN-4340: ------------------------------------ Fix Version/s: 7.2.0.Final (was: 7.2.0.CR1) > Automatically setup shared indexes when indexing is enabled > ----------------------------------------------------------- > > Key: ISPN-4340 > URL: https://issues.jboss.org/browse/ISPN-4340 > Project: Infinispan > Issue Type: Feature Request > Components: Embedded Querying > Reporter: Sanne Grinovero > Assignee: Gustavo Fernandes > Labels: 64QueryBlockers > Fix For: 7.2.0.Final > > > - on replicated Caches, we should create a default index on a FSDirectory and provide some appropriate default tuning, for example enabling NRT. > - distributed Caches will need the Infinispan Directory (shared) and a master/slave backend (Infinispan IndexManager, while NRT is not compatible in this case) > We want to keep the properties configuration structure as well as an "advanced tuning" and override capabilities of the default choices. > Some more common options like sync/async indexing should probably be promoted to be controlled by the XML elements and configuration DSL excplicitly. -- This message was sent by Atlassian JIRA (v6.3.11#6341)

10 years, 11 months

1
0
0 / 0

[JBoss JIRA] (ISPN-4286) Two concurrent putIfAbsent operations can both return null during rebalance

by Gustavo Fernandes (JIRA)

[ https://issues.jboss.org/browse/ISPN-4286?page=com.atlassian.jira.plugin.... ] Gustavo Fernandes updated ISPN-4286: ------------------------------------ Fix Version/s: 7.2.0.Final (was: 7.2.0.CR1) > Two concurrent putIfAbsent operations can both return null during rebalance > --------------------------------------------------------------------------- > > Key: ISPN-4286 > URL: https://issues.jboss.org/browse/ISPN-4286 > Project: Infinispan > Issue Type: Bug > Components: Core, State Transfer > Affects Versions: 6.0.2.Final > Reporter: Dan Berindei > Assignee: Dan Berindei > Priority: Critical > Fix For: 7.2.0.Final > > > If the cache topology changes while executing a putIfAbsent operation, the old primary owner will throw an OutdatedTopologyException, and the originator will retry on the new owner. > When retrying the PutKeyValueCommand on the new primary owner, we compare the current value with the command's new value. If they are equal, we assume that the initial command wrote the old value, and we return {{null}}. > However, the value might have been written by another putIfAbsent operation. So we could have two {{putIfAbsent(k, v)}} operations, both returning {{null}}. > {code} > A is the originator, B is the primary owner, k = null > A -> B: putIfAbsent(k, v1) > B dies before writing v, C is now primary owner > D -> C: putIfAbsent(k, v1) // another put operation from D, with the same value > C -> D: null // correct > A -> C: retry_putIfAbsent(k, v1) > C -> A: null // C assumes A is overwriting its own value, so it's also returning null > {code} -- This message was sent by Atlassian JIRA (v6.3.11#6341)

10 years, 11 months

1
0
0 / 0

[JBoss JIRA] (ISPN-4159) DefaultTwoWayKey2StringMapper encodes objects to strings in a manner that is incompatible with string handling of some databases

by Gustavo Fernandes (JIRA)

[ https://issues.jboss.org/browse/ISPN-4159?page=com.atlassian.jira.plugin.... ] Gustavo Fernandes updated ISPN-4159: ------------------------------------ Fix Version/s: 7.2.0.Final (was: 7.2.0.CR1) > DefaultTwoWayKey2StringMapper encodes objects to strings in a manner that is incompatible with string handling of some databases > -------------------------------------------------------------------------------------------------------------------------------- > > Key: ISPN-4159 > URL: https://issues.jboss.org/browse/ISPN-4159 > Project: Infinispan > Issue Type: Bug > Components: Loaders and Stores > Affects Versions: 6.0.0.Final > Reporter: Adrian Nistor > Assignee: Adrian Nistor > Fix For: 7.2.0.Final > > > DefaultTwoWayKey2StringMapper uses two neat tricks. > 1. it does not encode all supported types, it only encodes non-Strings. Strings are kept unmodified. > 2. it uses a special prefix (unicode char 0xfeff) to mark which strings were encoded and which are plain. > Unfortunately some databases, notably MySql, interpret the endianness mark (0xfeff, 0xfffe), convert to native byte order and then drop it. > This leaves us with no clue the string is not an actual String but an encoded representation of another type. This misinterpretation leads later to ClassCastExceptions in various places in core and user code. > Proposed fix: get rid of #1 and #2 optimisations. Encode all objects, including Strings and always use the ?n prefix (where n stands for the original type). Drop the 0xFEFF marker prefix. -- This message was sent by Atlassian JIRA (v6.3.11#6341)

10 years, 11 months

1
0
0 / 0

[JBoss JIRA] (ISPN-4722) CLI remove is not cluster-wide

by Gustavo Fernandes (JIRA)

[ https://issues.jboss.org/browse/ISPN-4722?page=com.atlassian.jira.plugin.... ] Gustavo Fernandes updated ISPN-4722: ------------------------------------ Fix Version/s: 7.2.0.Final (was: 7.2.0.CR1) > CLI remove is not cluster-wide > ------------------------------ > > Key: ISPN-4722 > URL: https://issues.jboss.org/browse/ISPN-4722 > Project: Infinispan > Issue Type: Bug > Components: CLI > Affects Versions: 6.0.2.Final, 7.0.0.Beta1 > Reporter: Galder Zamarreño > Assignee: Tristan Tarrant > Fix For: 7.2.0.Final > > > In CLI, the "remove" command does not delete entries in all nodes of a clustered environment, only the local copy. However, the "put" command does write in all nodes. Is it the expected behavior? See example below: > {code} > node 1 > put k1 v1 > get k1 -> v1 > node 2 > get k1 -> v1 > node 1 > remove k1 > get k1 -> null > node 2 > get k1 -> v1 > {code} > I know that these commands provided by CLI are not used in real world, but they are useful to demonstrate the correct configuration of a JDG cluster. -- This message was sent by Atlassian JIRA (v6.3.11#6341)

10 years, 11 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

infinispan-issues April 2015