[JBoss JIRA] (ISPN-5358) FuturesTest.testCombineWithCompletionErrors random failures
by Gustavo Fernandes (JIRA)
[ https://issues.jboss.org/browse/ISPN-5358?page=com.atlassian.jira.plugin.... ]
Gustavo Fernandes commented on ISPN-5358:
-----------------------------------------
Looks like the failure above is on an old branch based on 7.1, that does not contain ISPN-5198 fix
Has it been failing on Master?
> FuturesTest.testCombineWithCompletionErrors random failures
> -----------------------------------------------------------
>
> Key: ISPN-5358
> URL: https://issues.jboss.org/browse/ISPN-5358
> Project: Infinispan
> Issue Type: Bug
> Components: Core, Test Suite - Core
> Affects Versions: 7.2.0.Beta2
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Blocker
> Fix For: 7.2.0.Final
>
>
> {noformat}
> [pri:0, instance:org.infinispan.commons.util.concurrent.FuturesTest@241ecdba] should have thrown an exception of class java.util.concurrent.ExecutionException
> at org.testng.internal.Invoker.handleInvocationResults(Invoker.java:1512)
> at org.testng.internal.Invoker.invokeMethod(Invoker.java:754)
> {noformat}
> http://ci.infinispan.org/viewLog.html?buildId=24682&buildTypeId=bt9&guest=1
> I believe this can happen because {{NotifyingFutureImpl}}'s {{actualReturnValue}} and {{exceptionThrown}} fields are not {{volatile}}.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years
[JBoss JIRA] (ISPN-5358) FuturesTest.testCombineWithCompletionErrors random failures
by Dan Berindei (JIRA)
Dan Berindei created ISPN-5358:
----------------------------------
Summary: FuturesTest.testCombineWithCompletionErrors random failures
Key: ISPN-5358
URL: https://issues.jboss.org/browse/ISPN-5358
Project: Infinispan
Issue Type: Bug
Components: Core, Test Suite - Core
Affects Versions: 7.2.0.Beta2
Reporter: Dan Berindei
Priority: Blocker
Fix For: 7.2.0.Final
{noformat}
[pri:0, instance:org.infinispan.commons.util.concurrent.FuturesTest@241ecdba] should have thrown an exception of class java.util.concurrent.ExecutionException
at org.testng.internal.Invoker.handleInvocationResults(Invoker.java:1512)
at org.testng.internal.Invoker.invokeMethod(Invoker.java:754)
{noformat}
http://ci.infinispan.org/viewLog.html?buildId=24682&buildTypeId=bt9&guest=1
I believe this can happen because {{NotifyingFutureImpl}}'s {{actualReturnValue}} and {{exceptionThrown}} fields are not {{volatile}}.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years
[JBoss JIRA] (ISPN-5342) Refactor Hot Rod server code
by Galder Zamarreño (JIRA)
[ https://issues.jboss.org/browse/ISPN-5342?page=com.atlassian.jira.plugin.... ]
Galder Zamarreño commented on ISPN-5342:
----------------------------------------
All sounds good to me :). Going beyond the server code, the protocol should be redone at some point to better make sure of CPU and buffering, see ISPN-5357
> Refactor Hot Rod server code
> ----------------------------
>
> Key: ISPN-5342
> URL: https://issues.jboss.org/browse/ISPN-5342
> Project: Infinispan
> Issue Type: Task
> Components: Server
> Affects Versions: 7.2.0.Beta2
> Reporter: Gustavo Fernandes
>
> This should include:
> * Use ByteToMessageDecoder rather than ReplayDecoder
> * Decouple Decoder/Encoder from cache/exec operations invocation and channel IO related tasks. Decoder/Encoders should deal only with Bytes to Messages transformations, and could be possibly re-used in a eventual Netty Client
> * Define more clearly Hot Rod Requests and Responses objects, and add a channel handler to operate on those messages by invoking cache or scripts operations
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years
[JBoss JIRA] (ISPN-5357) Hot Rod protocol 3.0
by Galder Zamarreño (JIRA)
[ https://issues.jboss.org/browse/ISPN-5357?page=com.atlassian.jira.plugin.... ]
Galder Zamarreño updated ISPN-5357:
-----------------------------------
Issue Type: Enhancement (was: Feature Request)
> Hot Rod protocol 3.0
> --------------------
>
> Key: ISPN-5357
> URL: https://issues.jboss.org/browse/ISPN-5357
> Project: Infinispan
> Issue Type: Enhancement
> Reporter: Galder Zamarreño
>
> A binary protocol rethink is needed to take better advantage of CPUs and buffering. This is based on the ideas of Martin Thompson's Simple Binary Encoding [blog post|http://mechanical-sympathy.blogspot.cz/2014/05/simple-binary-encoding.html]
> In essence, we need to move Hot Rod protocol towards having mostly fixed size fields, hence getting rid of `vInt` and `vLong` formats which although safe some bytes, they hinder long stream reading patterns.
> An optional part here would be whether to consider using SBE directly, but this JIRA should be mostly oriented at making sure we have a protocol that can be read fast and efficiently.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years
[JBoss JIRA] (ISPN-5357) Hot Rod protocol 3.0
by Galder Zamarreño (JIRA)
Galder Zamarreño created ISPN-5357:
--------------------------------------
Summary: Hot Rod protocol 3.0
Key: ISPN-5357
URL: https://issues.jboss.org/browse/ISPN-5357
Project: Infinispan
Issue Type: Feature Request
Reporter: Galder Zamarreño
A binary protocol rethink is needed to take better advantage of CPUs and buffering. This is based on the ideas of Martin Thompson's Simple Binary Encoding [blog post|http://mechanical-sympathy.blogspot.cz/2014/05/simple-binary-encoding.html]
In essence, we need to move Hot Rod protocol towards having mostly fixed size fields, hence getting rid of `vInt` and `vLong` formats which although safe some bytes, they hinder long stream reading patterns.
An optional part here would be whether to consider using SBE directly, but this JIRA should be mostly oriented at making sure we have a protocol that can be read fast and efficiently.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years