[JBoss JIRA] (ISPN-7218) FIFO command does not wait for topology
by Pedro Ruivo (JIRA)
[ https://issues.jboss.org/browse/ISPN-7218?page=com.atlassian.jira.plugin.... ]
Pedro Ruivo updated ISPN-7218:
------------------------------
Status: Open (was: New)
> FIFO command does not wait for topology
> ---------------------------------------
>
> Key: ISPN-7218
> URL: https://issues.jboss.org/browse/ISPN-7218
> Project: Infinispan
> Issue Type: Bug
> Components: Core
> Reporter: Pedro Ruivo
> Assignee: Pedro Ruivo
>
> FIFO order commands are handled in the deliver thread.
> However, they don't wait in the {{future}} before checking if the node is a valid member (check code below)
> {code:java}
> switch (topologyMode) {
> case WAIT_TOPOLOGY:
> future = handler.getStateTransferLock().topologyFuture(waitTopology());
> break;
> case WAIT_TX_DATA:
> future = handler.getStateTransferLock().transactionDataFuture(waitTopology());
> break;
> default:
> break;
> }
> if (handler.isCommandSentBeforeFirstTopology(commandTopologyId)) {
> return future == null ? CompletableFuture.completedFuture(CacheNotFoundResponse.INSTANCE) :
> future.thenApply(nil -> CacheNotFoundResponse.INSTANCE);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 4 months
[JBoss JIRA] (ISPN-7218) FIFO command does not wait for topology
by Pedro Ruivo (JIRA)
[ https://issues.jboss.org/browse/ISPN-7218?page=com.atlassian.jira.plugin.... ]
Pedro Ruivo updated ISPN-7218:
------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/infinispan/infinispan/pull/4675
> FIFO command does not wait for topology
> ---------------------------------------
>
> Key: ISPN-7218
> URL: https://issues.jboss.org/browse/ISPN-7218
> Project: Infinispan
> Issue Type: Bug
> Components: Core
> Reporter: Pedro Ruivo
> Assignee: Pedro Ruivo
>
> FIFO order commands are handled in the deliver thread.
> However, they don't wait in the {{future}} before checking if the node is a valid member (check code below)
> {code:java}
> switch (topologyMode) {
> case WAIT_TOPOLOGY:
> future = handler.getStateTransferLock().topologyFuture(waitTopology());
> break;
> case WAIT_TX_DATA:
> future = handler.getStateTransferLock().transactionDataFuture(waitTopology());
> break;
> default:
> break;
> }
> if (handler.isCommandSentBeforeFirstTopology(commandTopologyId)) {
> return future == null ? CompletableFuture.completedFuture(CacheNotFoundResponse.INSTANCE) :
> future.thenApply(nil -> CacheNotFoundResponse.INSTANCE);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 4 months
[JBoss JIRA] (ISPN-7218) FIFO command does not wait for topology
by Pedro Ruivo (JIRA)
[ https://issues.jboss.org/browse/ISPN-7218?page=com.atlassian.jira.plugin.... ]
Pedro Ruivo updated ISPN-7218:
------------------------------
Description:
FIFO order commands are handled in the deliver thread.
However, they don't wait in the {{future}} before checking if the node is a valid member (check code below)
{code:java}
switch (topologyMode) {
case WAIT_TOPOLOGY:
future = handler.getStateTransferLock().topologyFuture(waitTopology());
break;
case WAIT_TX_DATA:
future = handler.getStateTransferLock().transactionDataFuture(waitTopology());
break;
default:
break;
}
if (handler.isCommandSentBeforeFirstTopology(commandTopologyId)) {
return future == null ? CompletableFuture.completedFuture(CacheNotFoundResponse.INSTANCE) :
future.thenApply(nil -> CacheNotFoundResponse.INSTANCE);
}
{code}
was:
FIFO order commands are handles in the deliver thread. However, they don't wait in the future before checking if the node is a valid member (check code below)
{code:java}
switch (topologyMode) {
case WAIT_TOPOLOGY:
future = handler.getStateTransferLock().topologyFuture(waitTopology());
break;
case WAIT_TX_DATA:
future = handler.getStateTransferLock().transactionDataFuture(waitTopology());
break;
default:
break;
}
if (handler.isCommandSentBeforeFirstTopology(commandTopologyId)) {
return future == null ? CompletableFuture.completedFuture(CacheNotFoundResponse.INSTANCE) :
future.thenApply(nil -> CacheNotFoundResponse.INSTANCE);
}
{code}
> FIFO command does not wait for topology
> ---------------------------------------
>
> Key: ISPN-7218
> URL: https://issues.jboss.org/browse/ISPN-7218
> Project: Infinispan
> Issue Type: Bug
> Components: Core
> Reporter: Pedro Ruivo
> Assignee: Pedro Ruivo
>
> FIFO order commands are handled in the deliver thread.
> However, they don't wait in the {{future}} before checking if the node is a valid member (check code below)
> {code:java}
> switch (topologyMode) {
> case WAIT_TOPOLOGY:
> future = handler.getStateTransferLock().topologyFuture(waitTopology());
> break;
> case WAIT_TX_DATA:
> future = handler.getStateTransferLock().transactionDataFuture(waitTopology());
> break;
> default:
> break;
> }
> if (handler.isCommandSentBeforeFirstTopology(commandTopologyId)) {
> return future == null ? CompletableFuture.completedFuture(CacheNotFoundResponse.INSTANCE) :
> future.thenApply(nil -> CacheNotFoundResponse.INSTANCE);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 4 months
[JBoss JIRA] (ISPN-7218) FIFO ordered commands does not wait for topology
by Pedro Ruivo (JIRA)
Pedro Ruivo created ISPN-7218:
---------------------------------
Summary: FIFO ordered commands does not wait for topology
Key: ISPN-7218
URL: https://issues.jboss.org/browse/ISPN-7218
Project: Infinispan
Issue Type: Bug
Components: Core
Reporter: Pedro Ruivo
Assignee: Pedro Ruivo
FIFO order commands are handles in the deliver thread. However, they don't wait in the future before checking if the node is a valid member (check code below)
{code:java}
switch (topologyMode) {
case WAIT_TOPOLOGY:
future = handler.getStateTransferLock().topologyFuture(waitTopology());
break;
case WAIT_TX_DATA:
future = handler.getStateTransferLock().transactionDataFuture(waitTopology());
break;
default:
break;
}
if (handler.isCommandSentBeforeFirstTopology(commandTopologyId)) {
return future == null ? CompletableFuture.completedFuture(CacheNotFoundResponse.INSTANCE) :
future.thenApply(nil -> CacheNotFoundResponse.INSTANCE);
}
{code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 4 months
[JBoss JIRA] (ISPN-7218) FIFO command does not wait for topology
by Pedro Ruivo (JIRA)
[ https://issues.jboss.org/browse/ISPN-7218?page=com.atlassian.jira.plugin.... ]
Pedro Ruivo updated ISPN-7218:
------------------------------
Summary: FIFO command does not wait for topology (was: FIFO ordered commands does not wait for topology)
> FIFO command does not wait for topology
> ---------------------------------------
>
> Key: ISPN-7218
> URL: https://issues.jboss.org/browse/ISPN-7218
> Project: Infinispan
> Issue Type: Bug
> Components: Core
> Reporter: Pedro Ruivo
> Assignee: Pedro Ruivo
>
> FIFO order commands are handles in the deliver thread. However, they don't wait in the future before checking if the node is a valid member (check code below)
> {code:java}
> switch (topologyMode) {
> case WAIT_TOPOLOGY:
> future = handler.getStateTransferLock().topologyFuture(waitTopology());
> break;
> case WAIT_TX_DATA:
> future = handler.getStateTransferLock().transactionDataFuture(waitTopology());
> break;
> default:
> break;
> }
> if (handler.isCommandSentBeforeFirstTopology(commandTopologyId)) {
> return future == null ? CompletableFuture.completedFuture(CacheNotFoundResponse.INSTANCE) :
> future.thenApply(nil -> CacheNotFoundResponse.INSTANCE);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 4 months
[JBoss JIRA] (ISPN-6866) OffHeap Data Container
by William Burns (JIRA)
[ https://issues.jboss.org/browse/ISPN-6866?page=com.atlassian.jira.plugin.... ]
William Burns updated ISPN-6866:
--------------------------------
Status: Open (was: New)
> OffHeap Data Container
> ----------------------
>
> Key: ISPN-6866
> URL: https://issues.jboss.org/browse/ISPN-6866
> Project: Infinispan
> Issue Type: Feature Request
> Components: Core
> Reporter: Tristan Tarrant
> Assignee: William Burns
> Fix For: 9.0.0.Final
>
>
> We want to be able to allocate data off-heap.
> Requirements / ideas:
> * data should be stored in Direct ByteBuffers, or easily accessible as such so that integration with other types of I/O (clustering, persistence, server) can be done efficiently
> * consider both raw byte[] storage (such as that performed by servers) and store as binary
> * allocator should be pluggable
> * out-of-the-box implementation should use Netty Buffers
> * type of allocation (heap or off-heap) should be per-cache
> * off-heap allocation configuration should be global (per-container) or possibly shared among multiple containers
> * optional off-heap allocation for keys
> * ability to monitor both global and per-cache memory usage
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 4 months
[JBoss JIRA] (ISPN-6866) OffHeap Data Container
by William Burns (JIRA)
[ https://issues.jboss.org/browse/ISPN-6866?page=com.atlassian.jira.plugin.... ]
William Burns updated ISPN-6866:
--------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/infinispan/infinispan/pull/4673
> OffHeap Data Container
> ----------------------
>
> Key: ISPN-6866
> URL: https://issues.jboss.org/browse/ISPN-6866
> Project: Infinispan
> Issue Type: Feature Request
> Components: Core
> Reporter: Tristan Tarrant
> Assignee: William Burns
> Fix For: 9.0.0.Final
>
>
> We want to be able to allocate data off-heap.
> Requirements / ideas:
> * data should be stored in Direct ByteBuffers, or easily accessible as such so that integration with other types of I/O (clustering, persistence, server) can be done efficiently
> * consider both raw byte[] storage (such as that performed by servers) and store as binary
> * allocator should be pluggable
> * out-of-the-box implementation should use Netty Buffers
> * type of allocation (heap or off-heap) should be per-cache
> * off-heap allocation configuration should be global (per-container) or possibly shared among multiple containers
> * optional off-heap allocation for keys
> * ability to monitor both global and per-cache memory usage
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 4 months