[JBoss JIRA] (ISPN-6432) Remove MurmurHash2
by Dan Berindei (JIRA)
[ https://issues.jboss.org/browse/ISPN-6432?page=com.atlassian.jira.plugin.... ]
Dan Berindei edited comment on ISPN-6432 at 3/23/16 1:24 PM:
-------------------------------------------------------------
-The server also supports hash version 1, sort of: when the client supports only version 1.x, the server selects an encoder that sends back hash version 1 in the topology updates. But the caches still uses {{MurmurHash3}} for locating keys, so sending a non-hash-aware response would work just as well.-
Update: I misread the server code, {{DEFAULT_CONSISTENT_HASH_VERSION_1x}} is actually hash version 2, so the server never uses hash version 1.
was (Author: dan.berindei):
The server also supports hash version 1, sort of: when the client supports only version 1.x, the server selects an encoder that sends back hash version 1 in the topology updates. But the caches still uses {{MurmurHash3}} for locating keys, so sending a non-hash-aware response would work just as well.
> Remove MurmurHash2
> ------------------
>
> Key: ISPN-6432
> URL: https://issues.jboss.org/browse/ISPN-6432
> Project: Infinispan
> Issue Type: Task
> Components: Core
> Reporter: Dan Berindei
> Priority: Minor
>
> Officially deprecated in 8.2, but in practice it wasn't used since {{MurmurHash3}} was introduced in 5.0.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years
[JBoss JIRA] (ISPN-6432) Remove MurmurHash2
by Dan Berindei (JIRA)
[ https://issues.jboss.org/browse/ISPN-6432?page=com.atlassian.jira.plugin.... ]
Dan Berindei commented on ISPN-6432:
------------------------------------
The server also supports hash version 1, sort of: when the client supports only version 1.x, the server selects an encoder that sends back hash version 1 in the topology updates. But the caches still uses {{MurmurHash3}} for locating keys, so sending a non-hash-aware response would work just as well.
> Remove MurmurHash2
> ------------------
>
> Key: ISPN-6432
> URL: https://issues.jboss.org/browse/ISPN-6432
> Project: Infinispan
> Issue Type: Task
> Components: Core
> Reporter: Dan Berindei
> Priority: Minor
>
> Officially deprecated in 8.2, but in practice it wasn't used since {{MurmurHash3}} was introduced in 5.0.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years
[JBoss JIRA] (ISPN-6432) Remove MurmurHash2
by Dan Berindei (JIRA)
[ https://issues.jboss.org/browse/ISPN-6432?page=com.atlassian.jira.plugin.... ]
Dan Berindei commented on ISPN-6432:
------------------------------------
Turns out we can't remove it yet: support for HotRod protocol version 1.x in the client requires {{MurmurHash2}}. First we have to update the protocol to explicitly prohibit hash function version 1 when the protocol version is 2+, and we can then remove {{MurmurHash2}} when we remove support for versions 1.x of the protocol.
> Remove MurmurHash2
> ------------------
>
> Key: ISPN-6432
> URL: https://issues.jboss.org/browse/ISPN-6432
> Project: Infinispan
> Issue Type: Task
> Components: Core
> Reporter: Dan Berindei
> Assignee: Dan Berindei
>
> Officially deprecated in 8.2, but in practice it wasn't used since {{MurmurHash3}} was introduced in 5.0.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years
[JBoss JIRA] (ISPN-6432) Remove MurmurHash2
by Dan Berindei (JIRA)
Dan Berindei created ISPN-6432:
----------------------------------
Summary: Remove MurmurHash2
Key: ISPN-6432
URL: https://issues.jboss.org/browse/ISPN-6432
Project: Infinispan
Issue Type: Task
Components: Core
Reporter: Dan Berindei
Assignee: Dan Berindei
Fix For: 9.0.0.Final, 9.0.0.Alpha1
Officially deprecated in 8.2, but in practice it wasn't used since {{MurmurHash3}} was introduced in 5.0.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years