March 2016 - infinispan-issues - Jboss List Archives

[JBoss JIRA] (ISPN-6414) Hybrid query + compat mode applies type conversion too early (perf issue)

by Adrian Nistor (JIRA)

[ https://issues.jboss.org/browse/ISPN-6414?page=com.atlassian.jira.plugin.... ] Adrian Nistor updated ISPN-6414: -------------------------------- Git Pull Request: https://github.com/infinispan/infinispan/pull/4154, https://github.com/infinispan/infinispan/pull/4155 (was: https://github.com/infinispan/infinispan/pull/4154) > Hybrid query + compat mode applies type conversion too early (perf issue) > ------------------------------------------------------------------------- > > Key: ISPN-6414 > URL: https://issues.jboss.org/browse/ISPN-6414 > Project: Infinispan > Issue Type: Bug > Components: Remote Querying > Affects Versions: 8.2.0.Final > Reporter: Adrian Nistor > Assignee: Adrian Nistor > Fix For: 9.0.0.Final, 9.0.0.Alpha1, 8.2.1.Final > > > To reproduce we need a compat mode cache and a remote hybrid query or any query that is executed in two phases (indexed + non indexed). The type conversion interceptor will convert the result of the first phase (from Java object to protobuf) and then the second phase will execute a matcher on the protobuf output of the first phase. > This can be optimized by avoiding early type conversion. The output of the first phase should produce unconverted results, ie. java objects. Then the second phase matcher should filter on these objects (ReflectionMatcher). These results are then implicitly type-converted when are marshalled back to the client, but the type converter interceptor is no longer involved. To avoid type conversion kicking in early we need to stop obtaining the cache using the Flag.OPERATION_HOTROD in org.infinispan.query.remote.impl.LifecycleManager, and then there are some other places in RemoteQueryEngine and friends that need to be adjusted following this change. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

10 years

1
0
0 / 0

[JBoss JIRA] (ISPN-6410) Fix unstable ReplicationQueueTest.testReplicationQueueMultipleThreads

by Dan Berindei (JIRA)

[ https://issues.jboss.org/browse/ISPN-6410?page=com.atlassian.jira.plugin.... ] Dan Berindei commented on ISPN-6410: ------------------------------------ For future reference, this is the failure: {noformat} java.lang.AssertionError: expected:<0> but was:<1> at org.testng.AssertJUnit.fail(AssertJUnit.java:59) at org.testng.AssertJUnit.failNotEquals(AssertJUnit.java:364) at org.testng.AssertJUnit.assertEquals(AssertJUnit.java:80) at org.testng.AssertJUnit.assertEquals(AssertJUnit.java:245) at org.testng.AssertJUnit.assertEquals(AssertJUnit.java:252) at org.infinispan.replication.ReplicationQueueTest.testReplicationQueueMultipleThreads(ReplicationQueueTest.java:193) {noformat} > Fix unstable ReplicationQueueTest.testReplicationQueueMultipleThreads > --------------------------------------------------------------------- > > Key: ISPN-6410 > URL: https://issues.jboss.org/browse/ISPN-6410 > Project: Infinispan > Issue Type: Bug > Components: Test Suite - Core > Reporter: Sebastian Łaskawiec > Assignee: Sebastian Łaskawiec > Priority: Minor > Labels: testsuite_stability > Fix For: 9.0.0.Alpha1, 8.2.1.Final > > > http://ci.infinispan.org/viewLog.html?buildId=37670&tab=buildResultsDiv&b... -- This message was sent by Atlassian JIRA (v6.4.11#64026)

10 years

1
0
0 / 0

[JBoss JIRA] (ISPN-6414) Hybrid query + compat mode applies type conversion too early (perf issue)

by Adrian Nistor (JIRA)

[ https://issues.jboss.org/browse/ISPN-6414?page=com.atlassian.jira.plugin.... ] Adrian Nistor updated ISPN-6414: -------------------------------- Status: Pull Request Sent (was: Coding In Progress) Git Pull Request: https://github.com/infinispan/infinispan/pull/4154 > Hybrid query + compat mode applies type conversion too early (perf issue) > ------------------------------------------------------------------------- > > Key: ISPN-6414 > URL: https://issues.jboss.org/browse/ISPN-6414 > Project: Infinispan > Issue Type: Bug > Components: Remote Querying > Affects Versions: 8.2.0.Final > Reporter: Adrian Nistor > Assignee: Adrian Nistor > Fix For: 9.0.0.Final, 9.0.0.Alpha1, 8.2.1.Final > > > To reproduce we need a compat mode cache and a remote hybrid query or any query that is executed in two phases (indexed + non indexed). The type conversion interceptor will convert the result of the first phase (from Java object to protobuf) and then the second phase will execute a matcher on the protobuf output of the first phase. > This can be optimized by avoiding early type conversion. The output of the first phase should produce unconverted results, ie. java objects. Then the second phase matcher should filter on these objects (ReflectionMatcher). These results are then implicitly type-converted when are marshalled back to the client, but the type converter interceptor is no longer involved. To avoid type conversion kicking in early we need to stop obtaining the cache using the Flag.OPERATION_HOTROD in org.infinispan.query.remote.impl.LifecycleManager, and then there are some other places in RemoteQueryEngine and friends that need to be adjusted following this change. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

10 years

1
0
0 / 0

[JBoss JIRA] (ISPN-6414) Hybrid query + compat mode applies type conversion too early (perf issue)

by Adrian Nistor (JIRA)

[ https://issues.jboss.org/browse/ISPN-6414?page=com.atlassian.jira.plugin.... ] Work on ISPN-6414 started by Adrian Nistor. ------------------------------------------- > Hybrid query + compat mode applies type conversion too early (perf issue) > ------------------------------------------------------------------------- > > Key: ISPN-6414 > URL: https://issues.jboss.org/browse/ISPN-6414 > Project: Infinispan > Issue Type: Bug > Components: Remote Querying > Affects Versions: 8.2.0.Final > Reporter: Adrian Nistor > Assignee: Adrian Nistor > Fix For: 9.0.0.Final, 9.0.0.Alpha1, 8.2.1.Final > > > To reproduce we need a compat mode cache and a remote hybrid query or any query that is executed in two phases (indexed + non indexed). The type conversion interceptor will convert the result of the first phase (from Java object to protobuf) and then the second phase will execute a matcher on the protobuf output of the first phase. > This can be optimized by avoiding early type conversion. The output of the first phase should produce unconverted results, ie. java objects. Then the second phase matcher should filter on these objects (ReflectionMatcher). These results are then implicitly type-converted when are marshalled back to the client, but the type converter interceptor is no longer involved. To avoid type conversion kicking in early we need to stop obtaining the cache using the Flag.OPERATION_HOTROD in org.infinispan.query.remote.impl.LifecycleManager, and then there are some other places in RemoteQueryEngine and friends that need to be adjusted following this change. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

10 years

1
0
0 / 0

[JBoss JIRA] (ISPN-6414) Hybrid query + compat mode applies type conversion too early (perf issue)

by Adrian Nistor (JIRA)

Adrian Nistor created ISPN-6414: ----------------------------------- Summary: Hybrid query + compat mode applies type conversion too early (perf issue) Key: ISPN-6414 URL: https://issues.jboss.org/browse/ISPN-6414 Project: Infinispan Issue Type: Bug Components: Remote Querying Affects Versions: 8.2.0.Final Reporter: Adrian Nistor Assignee: Adrian Nistor Fix For: 9.0.0.Final, 9.0.0.Alpha1, 8.2.1.Final To reproduce we need a compat mode cache and a remote hybrid query or any query that is executed in two phases (indexed + non indexed). The type conversion interceptor will convert the result of the first phase (from Java object to protobuf) and then the second phase will execute a matcher on the protobuf output of the first phase. This can be optimized by avoiding early type conversion. The output of the first phase should produce unconverted results, ie. java objects. Then the second phase matcher should filter on these objects (ReflectionMatcher). These results are then implicitly type-converted when are marshalled back to the client, but the type converter interceptor is no longer involved. To avoid type conversion kicking in early we need to stop obtaining the cache using the Flag.OPERATION_HOTROD in org.infinispan.query.remote.impl.LifecycleManager, and then there are some other places in RemoteQueryEngine and friends that need to be adjusted following this change. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

10 years

1
0
0 / 0

[JBoss JIRA] (ISPN-6414) Hybrid query + compat mode applies type conversion too early (perf issue)

by Adrian Nistor (JIRA)

[ https://issues.jboss.org/browse/ISPN-6414?page=com.atlassian.jira.plugin.... ] Adrian Nistor updated ISPN-6414: -------------------------------- Status: Open (was: New) > Hybrid query + compat mode applies type conversion too early (perf issue) > ------------------------------------------------------------------------- > > Key: ISPN-6414 > URL: https://issues.jboss.org/browse/ISPN-6414 > Project: Infinispan > Issue Type: Bug > Components: Remote Querying > Affects Versions: 8.2.0.Final > Reporter: Adrian Nistor > Assignee: Adrian Nistor > Fix For: 9.0.0.Final, 9.0.0.Alpha1, 8.2.1.Final > > > To reproduce we need a compat mode cache and a remote hybrid query or any query that is executed in two phases (indexed + non indexed). The type conversion interceptor will convert the result of the first phase (from Java object to protobuf) and then the second phase will execute a matcher on the protobuf output of the first phase. > This can be optimized by avoiding early type conversion. The output of the first phase should produce unconverted results, ie. java objects. Then the second phase matcher should filter on these objects (ReflectionMatcher). These results are then implicitly type-converted when are marshalled back to the client, but the type converter interceptor is no longer involved. To avoid type conversion kicking in early we need to stop obtaining the cache using the Flag.OPERATION_HOTROD in org.infinispan.query.remote.impl.LifecycleManager, and then there are some other places in RemoteQueryEngine and friends that need to be adjusted following this change. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

10 years

1
0
0 / 0

[JBoss JIRA] (ISPN-6410) Fix unstable ReplicationQueueTest.testReplicationQueueMultipleThreads

by Dan Berindei (JIRA)

[ https://issues.jboss.org/browse/ISPN-6410?page=com.atlassian.jira.plugin.... ] Dan Berindei updated ISPN-6410: ------------------------------- Labels: testsuite_stability (was: ) > Fix unstable ReplicationQueueTest.testReplicationQueueMultipleThreads > --------------------------------------------------------------------- > > Key: ISPN-6410 > URL: https://issues.jboss.org/browse/ISPN-6410 > Project: Infinispan > Issue Type: Bug > Components: Test Suite - Core > Reporter: Sebastian Łaskawiec > Assignee: Sebastian Łaskawiec > Priority: Minor > Labels: testsuite_stability > Fix For: 9.0.0.Alpha1, 8.2.1.Final > > > http://ci.infinispan.org/viewLog.html?buildId=37670&tab=buildResultsDiv&b... -- This message was sent by Atlassian JIRA (v6.4.11#64026)

10 years

1
0
0 / 0

[JBoss JIRA] (ISPN-6410) Fix unstable ReplicationQueueTest.testReplicationQueueMultipleThreads

by Dan Berindei (JIRA)

[ https://issues.jboss.org/browse/ISPN-6410?page=com.atlassian.jira.plugin.... ] Dan Berindei updated ISPN-6410: ------------------------------- Status: Resolved (was: Pull Request Sent) Fix Version/s: 9.0.0.Alpha1 8.2.1.Final Resolution: Done > Fix unstable ReplicationQueueTest.testReplicationQueueMultipleThreads > --------------------------------------------------------------------- > > Key: ISPN-6410 > URL: https://issues.jboss.org/browse/ISPN-6410 > Project: Infinispan > Issue Type: Bug > Reporter: Sebastian Łaskawiec > Assignee: Sebastian Łaskawiec > Priority: Minor > Fix For: 9.0.0.Alpha1, 8.2.1.Final > > > http://ci.infinispan.org/viewLog.html?buildId=37670&tab=buildResultsDiv&b... -- This message was sent by Atlassian JIRA (v6.4.11#64026)

10 years

1
0
0 / 0

[JBoss JIRA] (ISPN-6410) Fix unstable ReplicationQueueTest.testReplicationQueueMultipleThreads

by Dan Berindei (JIRA)

[ https://issues.jboss.org/browse/ISPN-6410?page=com.atlassian.jira.plugin.... ] Dan Berindei updated ISPN-6410: ------------------------------- Component/s: Test Suite - Core > Fix unstable ReplicationQueueTest.testReplicationQueueMultipleThreads > --------------------------------------------------------------------- > > Key: ISPN-6410 > URL: https://issues.jboss.org/browse/ISPN-6410 > Project: Infinispan > Issue Type: Bug > Components: Test Suite - Core > Reporter: Sebastian Łaskawiec > Assignee: Sebastian Łaskawiec > Priority: Minor > Fix For: 9.0.0.Alpha1, 8.2.1.Final > > > http://ci.infinispan.org/viewLog.html?buildId=37670&tab=buildResultsDiv&b... -- This message was sent by Atlassian JIRA (v6.4.11#64026)

10 years

1
0
0 / 0

[JBoss JIRA] (ISPN-6392) Convert NotifyingFuture and friends to CompletableFuture

by Tristan Tarrant (JIRA)

[ https://issues.jboss.org/browse/ISPN-6392?page=com.atlassian.jira.plugin.... ] Tristan Tarrant updated ISPN-6392: ---------------------------------- Status: Resolved (was: Pull Request Sent) Fix Version/s: 9.0.0.Final Resolution: Done > Convert NotifyingFuture and friends to CompletableFuture > -------------------------------------------------------- > > Key: ISPN-6392 > URL: https://issues.jboss.org/browse/ISPN-6392 > Project: Infinispan > Issue Type: Enhancement > Components: Core > Reporter: William Burns > Assignee: William Burns > Fix For: 9.0.0.Final, 9.0.0.Alpha1 > > > Now that we have Java 8 we should be using standard classes as much as possible. Before we had special future instances to handle callbacks and we should change all of these to use CompletableFuture instead so the API is what users would be used to. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

10 years

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

infinispan-issues March 2016