[JBoss JIRA] (ISPN-6691) Simplify Distributed Stream local intermediate operations
by Dan Berindei (JIRA)
[ https://issues.jboss.org/browse/ISPN-6691?page=com.atlassian.jira.plugin.... ]
Dan Berindei updated ISPN-6691:
-------------------------------
Status: Resolved (was: Pull Request Sent)
Fix Version/s: 9.0.0.Alpha3
Resolution: Done
> Simplify Distributed Stream local intermediate operations
> ---------------------------------------------------------
>
> Key: ISPN-6691
> URL: https://issues.jboss.org/browse/ISPN-6691
> Project: Infinispan
> Issue Type: Enhancement
> Components: Distributed Execution and Map/Reduce
> Reporter: William Burns
> Assignee: William Burns
> Fix For: 9.0.0.Alpha3, 9.0.0.Final
>
>
> Currently whenever a local intermediate operation (sort, limit, distinct, skip) is invoked on a distributed stream it tries to separate the invoctions based on if it should run remotely or locally. This code is quite hard to read and maintain. It also prevents the ability from adding new functionality without complicating the code substantially.
> We can rewrite this to have a new IntermediateDistributedCache that acts a bridge between the distributed (remote) stream and the local stream required for these operations.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 10 months
[JBoss JIRA] (ISPN-6700) Restart required dialog show only after editing distributed cache
by Jiří Holuša (JIRA)
[ https://issues.jboss.org/browse/ISPN-6700?page=com.atlassian.jira.plugin.... ]
Jiří Holuša commented on ISPN-6700:
-----------------------------------
There is obviously something strange going on, since I've just discovered another thing. When editing eviction configuration of a distributed cache, when I edit "Type" of "Strategy" fields, the restart dialog pops up. However, when I edit just "Size" field, the restart dialog is not shown.
> Restart required dialog show only after editing distributed cache
> -----------------------------------------------------------------
>
> Key: ISPN-6700
> URL: https://issues.jboss.org/browse/ISPN-6700
> Project: Infinispan
> Issue Type: Bug
> Components: Console
> Affects Versions: 8.2.2.Final
> Reporter: Jiří Holuša
> Assignee: Vladimir Blagojevic
>
> Page: Cache configuration page (select cache container -> select cache -> click Configuration)
> When editing any property of replicated, local and invalidation cache, for example expiration lifespan. When I change somehow the value, right next to the input box, there appears: " (Undo) Restart needed". Then I click "Apply changes", a confirmation dialog pops up with text: "Update configuration template <cache>?", I click "Update" and it's done. I have to manually search for the option of restarting the cluster.
> However, if I do it with distributed cache, after clicking "Update" in confirmation dialog, another dialog pops up with text: "Attributes changed require a restart of the affected servers. If you need to make additional configuration changes right now, consider restarting servers after the last change." with options "Restart now" and "Restart later".
> IMHO this should be consistent and the latter option is correct. If restart is needed (as the tooltip says), console should offer it right away.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 10 months
[JBoss JIRA] (ISPN-6406) NullPointerException while executed javascript returns null to js-client
by Galder Zamarreño (JIRA)
[ https://issues.jboss.org/browse/ISPN-6406?page=com.atlassian.jira.plugin.... ]
Galder Zamarreño commented on ISPN-6406:
----------------------------------------
This was fixed in Alpha2. The new test has been indirectly fixed by other commits.
> NullPointerException while executed javascript returns null to js-client
> ------------------------------------------------------------------------
>
> Key: ISPN-6406
> URL: https://issues.jboss.org/browse/ISPN-6406
> Project: Infinispan
> Issue Type: Bug
> Components: Remote Protocols
> Affects Versions: 8.2.1.Final, 9.0.0.Alpha1
> Reporter: Anna Manukyan
> Assignee: Galder Zamarreño
> Fix For: 9.0.0.Alpha2, 9.0.0.Final
>
>
> In case when executing a javascript on local node, which returns as a result null, the following exception is thrown on the server:
> {code}
> 17:25:26,127 ERROR [org.infinispan.server.hotrod.HotRodEncoder] (HotRodServerWorker-7-119) ISPN005022: Exception writing response with messageId=188: java.lang.NullPointerException
> at org.infinispan.server.core.transport.ExtendedByteBuf$.writeRangedBytes(ExtendedByteBuf.scala:65)
> at org.infinispan.server.hotrod.Encoder2x$.writeResponse(Encoder2x.scala:340)
> at org.infinispan.server.hotrod.HotRodEncoder.encode(HotRodEncoder.scala:45)
> at io.netty.handler.codec.MessageToByteEncoder.write(MessageToByteEncoder.java:107)
> at io.netty.channel.AbstractChannelHandlerContext.invokeWrite(AbstractChannelHandlerContext.java:633)
> at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:691)
> at io.netty.channel.AbstractChannelHandlerContext.writeAndFlush(AbstractChannelHandlerContext.java:681)
> at io.netty.channel.AbstractChannelHandlerContext.writeAndFlush(AbstractChannelHandlerContext.java:716)
> at io.netty.channel.DefaultChannelPipeline.writeAndFlush(DefaultChannelPipeline.java:954)
> at io.netty.channel.AbstractChannel.writeAndFlush(AbstractChannel.java:243)
> at org.infinispan.server.hotrod.HotRodDecoder.writeResponse(HotRodDecoder.scala:250)
> at org.infinispan.server.hotrod.HotRodDecoder.customDecodeHeader(HotRodDecoder.scala:209)
> at org.infinispan.server.hotrod.HotRodDecoder.org$infinispan$server$hotrod$HotRodDecoder$$decodeHeader(HotRodDecoder.scala:97)
> at org.infinispan.server.hotrod.HotRodDecoder$$anonfun$decode$1.apply$mcV$sp(HotRodDecoder.scala:52)
> at org.infinispan.server.hotrod.HotRodDecoder.wrapSecurity(HotRodDecoder.scala:224)
> at org.infinispan.server.hotrod.HotRodDecoder.decode(HotRodDecoder.scala:50)
> at io.netty.handler.codec.ReplayingDecoder.callDecode(ReplayingDecoder.java:370)
> at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:168)
> at org.infinispan.server.hotrod.HotRodDecoder.org$infinispan$server$core$transport$StatsChannelHandler$$super$channelRead(HotRodDecoder.scala:32)
> at org.infinispan.server.core.transport.StatsChannelHandler$class.channelRead(StatsChannelHandler.scala:32)
> at org.infinispan.server.hotrod.HotRodDecoder.channelRead(HotRodDecoder.scala:32)
> at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:308)
> at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:294)
> at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:846)
> at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:130)
> at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:511)
> at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:468)
> at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:382)
> at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:354)
> at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:116)
> at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:137)
> at java.lang.Thread.run(Thread.java:745)
> {code}
> The code is:
> {code}
> //Executable javascript:
> // mode=local,language=javascript,datatype='text/plain; charset=utf-8'
> cacheManager.getAddress()
> And the Test:
> it('can execute a script remotely to get node address from cacheManager', function(done) {
> Promise.all([client, readFile('spec/utils/test-cacheManager.js')])
> .then(function(vals) {
> var c = vals[0];
> return c.addScript('test-cacheManager.js', vals[1].toString())
> .then(function() { return c; } );
> })
> .then(t.assert(t.exec('test-cacheManager.js'),
> t.toBeUndefined))
> .catch(failed(done)).finally(done);
> });
> {code}
> The result of the test execution is:
> {code}
> Message:
> java.lang.NullPointerException
> Stacktrace:
> undefined
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 10 months
[JBoss JIRA] (ISPN-6406) NullPointerException while executed javascript returns null to js-client
by Galder Zamarreño (JIRA)
[ https://issues.jboss.org/browse/ISPN-6406?page=com.atlassian.jira.plugin.... ]
Galder Zamarreño resolved ISPN-6406.
------------------------------------
Fix Version/s: 9.0.0.Alpha2
(was: 9.0.0.Alpha3)
Resolution: Done
> NullPointerException while executed javascript returns null to js-client
> ------------------------------------------------------------------------
>
> Key: ISPN-6406
> URL: https://issues.jboss.org/browse/ISPN-6406
> Project: Infinispan
> Issue Type: Bug
> Components: Remote Protocols
> Affects Versions: 8.2.1.Final, 9.0.0.Alpha1
> Reporter: Anna Manukyan
> Assignee: Galder Zamarreño
> Fix For: 9.0.0.Final, 9.0.0.Alpha2
>
>
> In case when executing a javascript on local node, which returns as a result null, the following exception is thrown on the server:
> {code}
> 17:25:26,127 ERROR [org.infinispan.server.hotrod.HotRodEncoder] (HotRodServerWorker-7-119) ISPN005022: Exception writing response with messageId=188: java.lang.NullPointerException
> at org.infinispan.server.core.transport.ExtendedByteBuf$.writeRangedBytes(ExtendedByteBuf.scala:65)
> at org.infinispan.server.hotrod.Encoder2x$.writeResponse(Encoder2x.scala:340)
> at org.infinispan.server.hotrod.HotRodEncoder.encode(HotRodEncoder.scala:45)
> at io.netty.handler.codec.MessageToByteEncoder.write(MessageToByteEncoder.java:107)
> at io.netty.channel.AbstractChannelHandlerContext.invokeWrite(AbstractChannelHandlerContext.java:633)
> at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:691)
> at io.netty.channel.AbstractChannelHandlerContext.writeAndFlush(AbstractChannelHandlerContext.java:681)
> at io.netty.channel.AbstractChannelHandlerContext.writeAndFlush(AbstractChannelHandlerContext.java:716)
> at io.netty.channel.DefaultChannelPipeline.writeAndFlush(DefaultChannelPipeline.java:954)
> at io.netty.channel.AbstractChannel.writeAndFlush(AbstractChannel.java:243)
> at org.infinispan.server.hotrod.HotRodDecoder.writeResponse(HotRodDecoder.scala:250)
> at org.infinispan.server.hotrod.HotRodDecoder.customDecodeHeader(HotRodDecoder.scala:209)
> at org.infinispan.server.hotrod.HotRodDecoder.org$infinispan$server$hotrod$HotRodDecoder$$decodeHeader(HotRodDecoder.scala:97)
> at org.infinispan.server.hotrod.HotRodDecoder$$anonfun$decode$1.apply$mcV$sp(HotRodDecoder.scala:52)
> at org.infinispan.server.hotrod.HotRodDecoder.wrapSecurity(HotRodDecoder.scala:224)
> at org.infinispan.server.hotrod.HotRodDecoder.decode(HotRodDecoder.scala:50)
> at io.netty.handler.codec.ReplayingDecoder.callDecode(ReplayingDecoder.java:370)
> at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:168)
> at org.infinispan.server.hotrod.HotRodDecoder.org$infinispan$server$core$transport$StatsChannelHandler$$super$channelRead(HotRodDecoder.scala:32)
> at org.infinispan.server.core.transport.StatsChannelHandler$class.channelRead(StatsChannelHandler.scala:32)
> at org.infinispan.server.hotrod.HotRodDecoder.channelRead(HotRodDecoder.scala:32)
> at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:308)
> at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:294)
> at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:846)
> at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:130)
> at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:511)
> at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:468)
> at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:382)
> at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:354)
> at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:116)
> at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:137)
> at java.lang.Thread.run(Thread.java:745)
> {code}
> The code is:
> {code}
> //Executable javascript:
> // mode=local,language=javascript,datatype='text/plain; charset=utf-8'
> cacheManager.getAddress()
> And the Test:
> it('can execute a script remotely to get node address from cacheManager', function(done) {
> Promise.all([client, readFile('spec/utils/test-cacheManager.js')])
> .then(function(vals) {
> var c = vals[0];
> return c.addScript('test-cacheManager.js', vals[1].toString())
> .then(function() { return c; } );
> })
> .then(t.assert(t.exec('test-cacheManager.js'),
> t.toBeUndefined))
> .catch(failed(done)).finally(done);
> });
> {code}
> The result of the test execution is:
> {code}
> Message:
> java.lang.NullPointerException
> Stacktrace:
> undefined
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 10 months
[JBoss JIRA] (ISPN-6700) Restart required dialog show only after editing distributed cache
by Jiří Holuša (JIRA)
Jiří Holuša created ISPN-6700:
---------------------------------
Summary: Restart required dialog show only after editing distributed cache
Key: ISPN-6700
URL: https://issues.jboss.org/browse/ISPN-6700
Project: Infinispan
Issue Type: Bug
Components: Console
Affects Versions: 8.2.2.Final
Reporter: Jiří Holuša
Assignee: Vladimir Blagojevic
Page: Cache configuration page (select cache container -> select cache -> click Configuration)
When editing any property of replicated, local and invalidation cache, for example expiration lifespan. When I change somehow the value, right next to the input box, there appears: " (Undo) Restart needed". Then I click "Apply changes", a confirmation dialog pops up with text: "Update configuration template <cache>?", I click "Update" and it's done. I have to manually search for the option of restarting the cluster.
However, if I do it with distributed cache, after clicking "Update" in confirmation dialog, another dialog pops up with text: "Attributes changed require a restart of the affected servers. If you need to make additional configuration changes right now, consider restarting servers after the last change." with options "Restart now" and "Restart later".
IMHO this should be consistent and the latter option is correct. If restart is needed (as the tooltip says), console should offer it right away.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 10 months
[JBoss JIRA] (HRJS-15) Add test for undefined return in distributed exec script
by Galder Zamarreño (JIRA)
[ https://issues.jboss.org/browse/HRJS-15?page=com.atlassian.jira.plugin.sy... ]
Galder Zamarreño resolved HRJS-15.
----------------------------------
Fix Version/s: 0.3.0
Assignee: Galder Zamarreño
Resolution: Done
> Add test for undefined return in distributed exec script
> --------------------------------------------------------
>
> Key: HRJS-15
> URL: https://issues.jboss.org/browse/HRJS-15
> Project: Infinispan Javascript client
> Issue Type: Enhancement
> Affects Versions: 0.2.0
> Reporter: Galder Zamarreño
> Assignee: Galder Zamarreño
> Fix For: 0.3.0
>
>
> Add test to verify that a distributed script that return undefined does not return NPE error and instead returns empty results, e.g.
> {code}
> // mode=distributed,language=javascript,datatype='text/plain; charset=utf-8'
> cache.get("not-exist");
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 10 months
[JBoss JIRA] (HRJS-15) Add test for undefined return in distributed exec script
by Galder Zamarreño (JIRA)
Galder Zamarreño created HRJS-15:
------------------------------------
Summary: Add test for undefined return in distributed exec script
Key: HRJS-15
URL: https://issues.jboss.org/browse/HRJS-15
Project: Infinispan Javascript client
Issue Type: Enhancement
Affects Versions: 0.2.0
Reporter: Galder Zamarreño
Add test to verify that a distributed script that return undefined does not return NPE error and instead returns empty results, e.g.
{code}
// mode=distributed,language=javascript,datatype='text/plain; charset=utf-8'
cache.get("not-exist");
{code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 10 months