[JBoss JIRA] (ISPN-6844) Remove redundant enabled flag and disableInterceptor method from CacheWriter/Loader Interceptors
by Tristan Tarrant (JIRA)
[ https://issues.jboss.org/browse/ISPN-6844?page=com.atlassian.jira.plugin.... ]
Tristan Tarrant updated ISPN-6844:
----------------------------------
Status: Resolved (was: Pull Request Sent)
Fix Version/s: 9.0.0.Beta1
9.0.0.Final
Resolution: Done
> Remove redundant enabled flag and disableInterceptor method from CacheWriter/Loader Interceptors
> ------------------------------------------------------------------------------------------------
>
> Key: ISPN-6844
> URL: https://issues.jboss.org/browse/ISPN-6844
> Project: Infinispan
> Issue Type: Enhancement
> Components: Loaders and Stores
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
> Fix For: 9.0.0.Beta1, 9.0.0.Final
>
>
> Currently both the CacheWriter and CacheLoader interceptors utilise a method disableInterceptor which sets a boolean flag to false. This method is only every called by PersistenceManagerImpl when removing the interceptor, at which point it should not be possible for any of the removed interceptor's methods to be executed. Therefore we should be able to remove this flag, associated checks and the disableInterceptor method without issue.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 7 months
[JBoss JIRA] (ISPN-6712) JdbcStringStore doesn't notify entry expiration events
by Tristan Tarrant (JIRA)
[ https://issues.jboss.org/browse/ISPN-6712?page=com.atlassian.jira.plugin.... ]
Tristan Tarrant updated ISPN-6712:
----------------------------------
Status: Resolved (was: Pull Request Sent)
Fix Version/s: 9.0.0.Beta1
9.0.0.Final
Resolution: Done
> JdbcStringStore doesn't notify entry expiration events
> ------------------------------------------------------
>
> Key: ISPN-6712
> URL: https://issues.jboss.org/browse/ISPN-6712
> Project: Infinispan
> Issue Type: Enhancement
> Components: Listeners, Loaders and Stores
> Affects Versions: 9.0.0.Alpha2
> Reporter: William Burns
> Assignee: Ryan Emerson
> Fix For: 9.0.0.Beta1, 9.0.0.Final
>
>
> The JdbcStringStore does a DELETE directly to the database on a purge. This limits our ability to raise an event due to this expiration occurring. The JdbcBinaryStore does do events and we may want to duplicate that code instead.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 7 months
[JBoss JIRA] (ISPN-6710) TableManager when creating a table should also add index for expiration column
by Tristan Tarrant (JIRA)
[ https://issues.jboss.org/browse/ISPN-6710?page=com.atlassian.jira.plugin.... ]
Tristan Tarrant updated ISPN-6710:
----------------------------------
Status: Resolved (was: Pull Request Sent)
Fix Version/s: 9.0.0.Final
Resolution: Done
> TableManager when creating a table should also add index for expiration column
> ------------------------------------------------------------------------------
>
> Key: ISPN-6710
> URL: https://issues.jboss.org/browse/ISPN-6710
> Project: Infinispan
> Issue Type: Enhancement
> Components: Loaders and Stores
> Reporter: William Burns
> Assignee: Ryan Emerson
> Fix For: 9.0.0.Beta1, 9.0.0.Final
>
>
> All stores are required to have purging enabled now. This can cause performance issues with stores like Jdbc*Store since it may cause a full table scan without an index. We should make sure these tables have an index on this field to prevent possible performance issues.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 7 months
[JBoss JIRA] (ISPN-6711) Shared stores should only be purged from coordinator
by Tristan Tarrant (JIRA)
[ https://issues.jboss.org/browse/ISPN-6711?page=com.atlassian.jira.plugin.... ]
Tristan Tarrant updated ISPN-6711:
----------------------------------
Status: Resolved (was: Pull Request Sent)
Fix Version/s: 9.0.0.Final
Resolution: Done
> Shared stores should only be purged from coordinator
> ----------------------------------------------------
>
> Key: ISPN-6711
> URL: https://issues.jboss.org/browse/ISPN-6711
> Project: Infinispan
> Issue Type: Enhancement
> Components: Loaders and Stores
> Reporter: William Burns
> Assignee: Ryan Emerson
> Fix For: 9.0.0.Beta1, 9.0.0.Final
>
>
> A shared store's data is accessible from all nodes. Therefore we should only have to purge from 1 node instead of all. Thus we should only purge shared stores if the node is the coordinator. This will reduce possible load on the stores by an amount equal to the number of nodes in worst case, which could be huge.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 7 months
[JBoss JIRA] (ISPN-6681) Replace C3P0 with HikariCP
by Tristan Tarrant (JIRA)
[ https://issues.jboss.org/browse/ISPN-6681?page=com.atlassian.jira.plugin.... ]
Tristan Tarrant updated ISPN-6681:
----------------------------------
Status: Resolved (was: Pull Request Sent)
Fix Version/s: 9.0.0.Beta1
9.0.0.Final
Resolution: Done
> Replace C3P0 with HikariCP
> --------------------------
>
> Key: ISPN-6681
> URL: https://issues.jboss.org/browse/ISPN-6681
> Project: Infinispan
> Issue Type: Enhancement
> Affects Versions: 9.0.0.Alpha2
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
> Priority: Minor
> Fix For: 9.0.0.Beta1, 9.0.0.Final
>
>
> HikariCP seems to be a very lightweight and performant connection pool. It's possible that a refactor will increase the performance of our standalone connection-pool
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 8 months