August 2016 - infinispan-issues - Jboss List Archives

[JBoss JIRA] (ISPN-5151) DistributedSharedCacheTwoNodesMapReduceTest.testInvokeMapReduceOnAllKeys random failures

by William Burns (JIRA)

[ https://issues.jboss.org/browse/ISPN-5151?page=com.atlassian.jira.plugin.... ] William Burns updated ISPN-5151: -------------------------------- Fix Version/s: 9.0.0.Beta1 (was: 9.0.0.Alpha4) > DistributedSharedCacheTwoNodesMapReduceTest.testInvokeMapReduceOnAllKeys random failures > ---------------------------------------------------------------------------------------- > > Key: ISPN-5151 > URL: https://issues.jboss.org/browse/ISPN-5151 > Project: Infinispan > Issue Type: Bug > Components: Core, Test Suite - Core > Affects Versions: 7.0.3.Final > Reporter: Dan Berindei > Assignee: Dan Berindei > Priority: Blocker > Labels: testsuite_stability > Fix For: 9.0.0.Beta1 > > > The method {{invokeMapReduce()}} doesn't really invoke the M/R task, it only creates it, and the execution only starts when the test method calls {{task.execute()}} explicitly. It shouldn't try to check the contents of the shared intermediary cache, because the intermediary cache may not exist yet - and it may accidentally create it with the wrong configuration. I get this error when I run only the {{testInvokeMapReduceOnAllKeys}} method: > {noformat} > 09:55:37,632 TRACE (testng-DistributedSharedCacheTwoNodesMapReduceTest:) [DefaultCacheManager] About to wire and start cache __tmpMapReduce > 09:55:37,646 DEBUG (testng-DistributedSharedCacheTwoNodesMapReduceTest:) [MapReduceTask] Invoking CreateCacheCommand{cacheManager=null, cacheNameToCreate='__tmpMapReduce', cacheConfigurationName='__tmpMapReduce', start=true', size=2} across members [DistributedSharedCacheTwoNodesMapReduceTest-NodeA-19271, DistributedSharedCacheTwoNodesMapReduceTest-NodeB-10341] > 10:32:56,324 ERROR (testng-DistributedSharedCacheTwoNodesMapReduceTest:) [UnitTestTestNGListener] Test testInvokeMapReduceOnAllKeys(org.infinispan.distexec.mapreduce.DistributedSharedCacheTwoNodesMapReduceTest) failed. > org.infinispan.distexec.mapreduce.MapReduceException: Map phase failed > at org.infinispan.distexec.mapreduce.MapReduceTask.executeMapPhase(MapReduceTask.java:607) > at org.infinispan.distexec.mapreduce.MapReduceTask.executeHelper(MapReduceTask.java:473) > at org.infinispan.distexec.mapreduce.MapReduceTask.execute(MapReduceTask.java:414) > at org.infinispan.distexec.mapreduce.BaseWordCountMapReduceTest.testInvokeMapReduceOnAllKeys(BaseWordCountMapReduceTest.java:162) > Caused by: org.infinispan.commons.CacheException: java.lang.NullPointerException > at org.infinispan.distexec.mapreduce.MapReduceManagerImpl.mapAndCombineForDistributedReduction(MapReduceManagerImpl.java:105) > at org.infinispan.distexec.mapreduce.MapReduceTask$MapTaskPart.invokeMapCombineLocally(MapReduceTask.java:1174) > at org.infinispan.distexec.mapreduce.MapReduceTask$MapTaskPart.access$300(MapReduceTask.java:1101) > at org.infinispan.distexec.mapreduce.MapReduceTask$MapTaskPart$1.call(MapReduceTask.java:1123) > at org.infinispan.distexec.mapreduce.MapReduceTask$MapTaskPart$1.call(MapReduceTask.java:1119) > at java.util.concurrent.FutureTask.run(FutureTask.java:262) > at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) > at java.util.concurrent.FutureTask.run(FutureTask.java:262) > at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) > at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) > at java.lang.Thread.run(Thread.java:745) > Caused by: java.lang.NullPointerException > at org.infinispan.distexec.mapreduce.MapReduceManagerImpl.mapKeysToNodes(MapReduceManagerImpl.java:363) > at org.infinispan.distexec.mapreduce.MapReduceManagerImpl.migrateIntermediateKeysAndValues(MapReduceManagerImpl.java:327) > at org.infinispan.distexec.mapreduce.MapReduceManagerImpl.mapAndCombine(MapReduceManagerImpl.java:260) > at org.infinispan.distexec.mapreduce.MapReduceManagerImpl.mapAndCombineForDistributedReduction(MapReduceManagerImpl.java:103) > ... 10 more > {noformat} > Even if the check is moved after the M/R task is finished, it still wouldn't be correct, because the task only cleans up the shared intermediary cache asynchronously. So it needs to use {{eventually()}} to avoid errors like this: > {noformat} > 04:06:32,260 ERROR (testng-DistributedSharedCacheTwoNodesMapReduceTest:) [UnitTestTestNGListener] Test testInvokeMapReduceOnAllKeys(org.infinispan.distexec.mapreduce.DistributedSharedCacheTwoNodesMapReduceTest) failed. > java.lang.AssertionError: Shared cache __tmpMapReduce is not empty. It has 5 keys/values: [ImmortalCacheEntry{key=IntermediateCompositeKey [taskId=88948a8b-2a8a-4c13-bc45-4dc3a9f6b0fb, key=is], value=org.infinispan.distexec.mapreduce.MapReduceManagerImpl$DeltaAwareList@21ae10d3}, ImmortalCacheEntry{key=IntermediateCompositeKey [taskId=88948a8b-2a8a-4c13-bc45-4dc3a9f6b0fb, key=JUDCon], value=org.infinispan.distexec.mapreduce.MapReduceManagerImpl$DeltaAwareList@108d6b51}, ImmortalCacheEntry{key=IntermediateCompositeKey [taskId=88948a8b-2a8a-4c13-bc45-4dc3a9f6b0fb, key=cool], value=org.infinispan.distexec.mapreduce.MapReduceManagerImpl$DeltaAwareList@77949e8f}, ImmortalCacheEntry{key=IntermediateCompositeKey [taskId=88948a8b-2a8a-4c13-bc45-4dc3a9f6b0fb, key=Infinispan], value=org.infinispan.distexec.mapreduce.MapReduceManagerImpl$DeltaAwareList@712a6071}, ImmortalCacheEntry{key=IntermediateCompositeKey [taskId=88948a8b-2a8a-4c13-bc45-4dc3a9f6b0fb, key=community], value=org.infinispan.distexec.mapreduce.MapReduceManagerImpl$DeltaAwareList@291bdf76}] expected:<0> but was:<5> > at org.junit.Assert.fail(Assert.java:88) > at org.junit.Assert.failNotEquals(Assert.java:743) > at org.junit.Assert.assertEquals(Assert.java:118) > at org.junit.Assert.assertEquals(Assert.java:555) > at org.infinispan.distexec.mapreduce.DistributedSharedCacheTwoNodesMapReduceTest.invokeMapReduce(DistributedSharedCacheTwoNodesMapReduceTest.java:44) > at org.infinispan.distexec.mapreduce.BaseWordCountMapReduceTest.testInvokeMapReduceOnAllKeys(BaseWordCountMapReduceTest.java:161) > 04:06:32,579 TRACE (transport-thread-NodeA-p29577-t6:) [InvocationContextInterceptor] Invoked with command RemoveCommand{key=IntermediateCompositeKey [taskId=eb7da48a-5922-4671-9037-4077e209744c, key=RedHat], value=null, flags=null, valueMatcher=MATCH_ALWAYS} and InvocationContext [org.infinispan.context.SingleKeyNonTxInvocationContext@c0bbc61] > {noformat} -- This message was sent by Atlassian JIRA (v6.4.11#64026)

7 years, 11 months

1
0
0 / 0

[JBoss JIRA] (ISPN-5093) Granularity of remote event listener implementations doing the same job

by William Burns (JIRA)

[ https://issues.jboss.org/browse/ISPN-5093?page=com.atlassian.jira.plugin.... ] William Burns updated ISPN-5093: -------------------------------- Fix Version/s: 9.0.0.Beta1 (was: 9.0.0.Alpha4) > Granularity of remote event listener implementations doing the same job > ----------------------------------------------------------------------- > > Key: ISPN-5093 > URL: https://issues.jboss.org/browse/ISPN-5093 > Project: Infinispan > Issue Type: Enhancement > Components: Remote Protocols > Reporter: Galder Zamarreño > Assignee: Galder Zamarreño > Fix For: 9.0.0.Beta1 > > > Currently, if N clients add the same listener to a cache that does the same job, e.g. keeping a near cache consistent, this results in N server-side cluster listeners created, each potentially installed in different nodes. If one of those nodes fails, all clients that had a listener registered to that node will have to find a different node for this listener. > The downsides of this approach is that there are as many cluster listeners installed as clients have added listeners (or have near cache enabled), which might not very efficient. If a node goes down, all clients that have cluster listeners there need to failover to some other node. > The advantage of this approach is simplicity of the approach to decide where to add the listener and where to failover to. > For this type of scenarios, an alternative set up might be worth exploring: > If all these client side listeners are interested in exactly the same events, and the client ID would be exposed via the RemoteCache API, a server side cluster listener multi-plexing between all these clients could be potentially built. In other words, instead of having N clients register N cluster listeners, the first client would register the cluster listener with a client listener ID, and if more registrations were added with the same client listener ID, the connections would be added to the existing cluster listener implementation. > The maximise the efficiency of this solution, all clients (even running in different JMVs), given the same client listener ID, should agree upon the node to add the listener in. For a distributed cache, hashing on the cache name would work. For replicated caches, since there's no hashing available, the first node of the view could be used. > Since the logic to be executed server-side varies between being the first node adding the client listener vs the others, synchronization would be added to make sure that the first invocation only creates the cluster listener, and the others simply add the channel to the listener. > Failover is a bit more tricky too, because if the node with the cluster listener goes down, all the clients have to failover, which again exposes a 1st vs the others type of logic. > Advantages of this approach is the reduction in number of cluster listeners and potentially efficiency coming from a single cluster listener implementation server side. > The disadvantages come from the server side logic to add/failover a cluster listener, which need to take into account if the listener is present or not. Other disadvantages come from needing the clients to use some specific routing for adding listeners for same node. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

7 years, 11 months

1
0
0 / 0

[JBoss JIRA] (ISPN-5424) SemaphoreCompletionService improvements

by William Burns (JIRA)

[ https://issues.jboss.org/browse/ISPN-5424?page=com.atlassian.jira.plugin.... ] William Burns updated ISPN-5424: -------------------------------- Fix Version/s: 9.0.0.Beta1 (was: 9.0.0.Alpha4) > SemaphoreCompletionService improvements > --------------------------------------- > > Key: ISPN-5424 > URL: https://issues.jboss.org/browse/ISPN-5424 > Project: Infinispan > Issue Type: Task > Components: Core > Affects Versions: 7.2.0.CR1 > Reporter: Dan Berindei > Assignee: Dan Berindei > Fix For: 9.0.0.Beta1 > > > Turns out the {{CompletionService}} features aren't that necessary, and it makes the use of {{Runnable}} more cumbersome. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

7 years, 11 months

1
0
0 / 0

[JBoss JIRA] (ISPN-5415) Expose protobuf entries to scripting

by William Burns (JIRA)

[ https://issues.jboss.org/browse/ISPN-5415?page=com.atlassian.jira.plugin.... ] William Burns updated ISPN-5415: -------------------------------- Fix Version/s: 9.0.0.Beta1 (was: 9.0.0.Alpha4) > Expose protobuf entries to scripting > ------------------------------------ > > Key: ISPN-5415 > URL: https://issues.jboss.org/browse/ISPN-5415 > Project: Infinispan > Issue Type: Feature Request > Components: Remote Querying > Affects Versions: 8.0.0.Final > Reporter: Adrian Nistor > Assignee: Adrian Nistor > Fix For: 9.0.0.Beta1 > > > We need an alternative API for Protostream marshalling that is easy to consume from scripting languages. The messages need to be unmarshalled into a map-like object that can be accessed easily from scripting languages. No marshaller implementation code should be provided by users, also no annotations. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

7 years, 11 months

1
0
0 / 0

[JBoss JIRA] (ISPN-5241) Cache topology updates should use the NO_FC flag

by William Burns (JIRA)

[ https://issues.jboss.org/browse/ISPN-5241?page=com.atlassian.jira.plugin.... ] William Burns updated ISPN-5241: -------------------------------- Fix Version/s: 9.0.0.Beta1 (was: 9.0.0.Alpha4) > Cache topology updates should use the NO_FC flag > ------------------------------------------------ > > Key: ISPN-5241 > URL: https://issues.jboss.org/browse/ISPN-5241 > Project: Infinispan > Issue Type: Bug > Components: Core, State Transfer > Affects Versions: 7.1.0.Final > Reporter: Dan Berindei > Assignee: Dan Berindei > Priority: Critical > Fix For: 9.0.0.Beta1 > > > Topology updates are sent while holding the ClusterCacheStatus lock, so they should never block. However, when MFC is present, the topology update can block waiting for enough credits. As most CacheTopologyControlCommands need to acquire the ClusterCacheStatus lock, this can easily lead to a full remote-executor pool (and OOB pool) and the appearance of a deadlock. > What's more, if one node is not responsive, it can block all the other nodes from receiving further topology updates. Topology updates should be as prompt as possible, so we should use the NO_FC flag to ensure that each node receives topology updates as soon as possible. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

7 years, 11 months

1
0
0 / 0

[JBoss JIRA] (ISPN-5218) Add batching to the AdvancedCacheWriter interface

by William Burns (JIRA)

[ https://issues.jboss.org/browse/ISPN-5218?page=com.atlassian.jira.plugin.... ] William Burns updated ISPN-5218: -------------------------------- Fix Version/s: 9.0.0.Beta1 (was: 9.0.0.Alpha4) > Add batching to the AdvancedCacheWriter interface > ------------------------------------------------- > > Key: ISPN-5218 > URL: https://issues.jboss.org/browse/ISPN-5218 > Project: Infinispan > Issue Type: Enhancement > Components: Loaders and Stores > Reporter: Tristan Tarrant > Assignee: Ryan Emerson > Fix For: 9.0.0.Beta1 > > > The AdvancedCacheWriter should be extended with a write operation which takes multiple entries so that stores which can do batching can optimize this. This would benefit both passivation and the async writer. > Immediate users would be the JDBC stores. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

7 years, 11 months

1
0
0 / 0

[JBoss JIRA] (ISPN-5211) NPE on NumericVersionGenerator.start() when JGroups configuration resource not found

by William Burns (JIRA)

[ https://issues.jboss.org/browse/ISPN-5211?page=com.atlassian.jira.plugin.... ] William Burns updated ISPN-5211: -------------------------------- Fix Version/s: 9.0.0.Beta1 (was: 9.0.0.Alpha4) > NPE on NumericVersionGenerator.start() when JGroups configuration resource not found > ------------------------------------------------------------------------------------ > > Key: ISPN-5211 > URL: https://issues.jboss.org/browse/ISPN-5211 > Project: Infinispan > Issue Type: Bug > Components: Core > Affects Versions: 7.1.0.Final > Reporter: Sanne Grinovero > Fix For: 9.0.0.Beta1 > > > This is easy to reproduce: start a {{CacheManager}} which has a {{Transport}} configured with a non-existent resource name for the JGroups configuration. > Would be great to have a better error message. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

7 years, 11 months

1
0
0 / 0

[JBoss JIRA] (ISPN-5210) Support writing multiple modifications to cache stores in batch when using Transactions

by William Burns (JIRA)

[ https://issues.jboss.org/browse/ISPN-5210?page=com.atlassian.jira.plugin.... ] William Burns updated ISPN-5210: -------------------------------- Fix Version/s: 9.0.0.Beta1 (was: 9.0.0.Alpha4) > Support writing multiple modifications to cache stores in batch when using Transactions > --------------------------------------------------------------------------------------- > > Key: ISPN-5210 > URL: https://issues.jboss.org/browse/ISPN-5210 > Project: Infinispan > Issue Type: Feature Request > Components: Loaders and Stores > Affects Versions: 6.0.2.Final, 7.1.0.Final > Reporter: Richard Lucas > Assignee: Ryan Emerson > Fix For: 9.0.0.Beta1 > > > Currently writes to a cache store are performed individually for each modification to the cache. > While this makes sense when using a non-tx cache it would be beneficial to support writing multiple modifications to a cache store in a single call when using a Tx cache. > Currently all writes are performed in the commit phase and are done by looping through the modifications in the Tx and writing each one in turn to the the store. > Instead of doing this it would useful to pass all modifications to the store in a single call, this would allow: > a) Taking advantage of support for batch updates in underlying stores (JDBC, MongoDB, DynamoDB) for a more efficient write through. > b) Allow store implementations the chance to clean up if one or more updates in the batch fail (this is especially useful if the store does not support Tx and rollbacks as it means the store implementation can at least try to clean up any partial updates it has performed, something which is not currently possible). -- This message was sent by Atlassian JIRA (v6.4.11#64026)

7 years, 11 months

1
0
0 / 0

[JBoss JIRA] (ISPN-5470) Remote-executor threads should not block to acquire locks

by William Burns (JIRA)

[ https://issues.jboss.org/browse/ISPN-5470?page=com.atlassian.jira.plugin.... ] William Burns updated ISPN-5470: -------------------------------- Fix Version/s: 9.0.0.Beta1 (was: 9.0.0.Alpha4) > Remote-executor threads should not block to acquire locks > --------------------------------------------------------- > > Key: ISPN-5470 > URL: https://issues.jboss.org/browse/ISPN-5470 > Project: Infinispan > Issue Type: Task > Components: Core > Affects Versions: 7.2.1.Final > Reporter: Dan Berindei > Fix For: 9.0.0.Beta1 > > > Currently, enabling the queue on the remote-executor thread pool can cause deadlocks, because a CommitCommand/1PCPrepareCommand could end up in the queue while a remote-executor thread is busy waiting to acquire the same lock that this commit would release. > If trying to acquire a lock would free the thread until the key has been acquired, we could enable the queue on the remote-executor/OOB thread pools, and we would need a lot less threads for the same load. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

7 years, 11 months

1
0
0 / 0

[JBoss JIRA] (ISPN-5469) Remote-executor threads should not block during RPCs

by William Burns (JIRA)

[ https://issues.jboss.org/browse/ISPN-5469?page=com.atlassian.jira.plugin.... ] William Burns updated ISPN-5469: -------------------------------- Fix Version/s: 9.0.0.Beta1 (was: 9.0.0.Alpha4) > Remote-executor threads should not block during RPCs > ---------------------------------------------------- > > Key: ISPN-5469 > URL: https://issues.jboss.org/browse/ISPN-5469 > Project: Infinispan > Issue Type: Task > Components: Core > Affects Versions: 7.2.1.Final > Reporter: Dan Berindei > Assignee: Dan Berindei > Fix For: 9.0.0.Beta1 > > > This is particularly important in non-transactional caches, where the primary owner has to forward a command to the backup owners. The remote-executor thread on the primary should not be blocked while waiting for the backup responses, and instead process other commands. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

7 years, 11 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

infinispan-issues August 2016