[JBoss JIRA] (ISPN-7302) ClusteredConditionalCommandTest.testPutIfAbsentOnNonOwnerWithIgnoreReturnValues random failures
by Galder Zamarreño (JIRA)
[ https://issues.jboss.org/browse/ISPN-7302?page=com.atlassian.jira.plugin.... ]
Galder Zamarreño updated ISPN-7302:
-----------------------------------
Fix Version/s: 9.0.0.Beta3
(was: 9.0.0.Beta2)
> ClusteredConditionalCommandTest.testPutIfAbsentOnNonOwnerWithIgnoreReturnValues random failures
> -----------------------------------------------------------------------------------------------
>
> Key: ISPN-7302
> URL: https://issues.jboss.org/browse/ISPN-7302
> Project: Infinispan
> Issue Type: Bug
> Components: Test Suite - Core
> Affects Versions: 9.0.0.Beta1
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Critical
> Labels: testsuite_stability
> Fix For: 9.0.0.Beta3
>
>
> When the backup owner replies before the primary had a chance to load the value from persistence, the number of loads from the primary can be {{0}} at the time the test checks it.
> {noformat}
> 00:21:48,941 TRACE (testng-Test:[]) [JGroupsTransport] dests=[Test-NodeB-56150, Test-NodeA-13512], command=ClusteredGetCommand{key=Test-key, flags=[IGNORE_RETURN_VALUES]}, mode=WAIT_FOR_VALID_RESPONSE, timeout=15000
> 00:21:48,942 TRACE (jgroups-7,Test-NodeB-56150:[]) [InvocationContextInterceptor] Invoked with command GetCacheEntryCommand {key=Test-key, flags=[SKIP_REMOTE_LOOKUP, IGNORE_RETURN_VALUES]} and InvocationContext [org.infinispan.context.impl.NonTxInvocationContext@5f931934]
> 00:21:48,943 TRACE (jgroups-7,Test-NodeB-56150:[]) [EntryFactoryImpl] Wrap Test-key for read. Entry=NullCacheEntry{}
> 00:21:48,946 TRACE (jgroups-8,Test-NodeA-13512:[]) [InvocationContextInterceptor] Invoked with command GetCacheEntryCommand {key=Test-key, flags=[SKIP_REMOTE_LOOKUP, IGNORE_RETURN_VALUES]} and InvocationContext [org.infinispan.context.impl.NonTxInvocationContext@265c6c97]
> 00:21:48,946 TRACE (jgroups-8,Test-NodeA-13512:[]) [PersistenceUtil] Loaded MarshalledEntryImpl{keyBytes=null, valueBytes=null, metadataBytes=null, key=Test-key, value=Test-value1, metadata=null, marshaller=org.infinispan.marshall.core.GlobalMarshaller@1aee2408} for key Test-key from persistence.
> 00:21:48,946 TRACE (jgroups-8,Test-NodeA-13512:[]) [CommandAwareRpcDispatcher] About to send back response SuccessfulResponse{responseValue=ImmortalCacheValue {value=Test-value1}} for command ClusteredGetCommand{key=Test-key, flags=[IGNORE_RETURN_VALUES]}
> 00:21:48,948 ERROR (testng-Test:[]) [TestSuiteProgress] Test failed: org.infinispan.persistence.ClusteredTxConditionalCommandTest.testPutIfAbsentOnNonOwnerWithIgnoreReturnValues[tx=true]
> java.lang.AssertionError: primary owner load expected:<1> but was:<0>
> at org.testng.AssertJUnit.fail(AssertJUnit.java:59) ~[testng-6.8.8.jar:?]
> at org.testng.AssertJUnit.failNotEquals(AssertJUnit.java:364) ~[testng-6.8.8.jar:?]
> at org.testng.AssertJUnit.assertEquals(AssertJUnit.java:80) ~[testng-6.8.8.jar:?]
> at org.testng.AssertJUnit.assertEquals(AssertJUnit.java:170) ~[testng-6.8.8.jar:?]
> at org.infinispan.persistence.ClusteredTxConditionalCommandTest.assertLoadAfterOperation(ClusteredTxConditionalCommandTest.java:46) ~[test-classes/:?]
> at org.infinispan.persistence.ClusteredConditionalCommandTest.doTest(ClusteredConditionalCommandTest.java:121) ~[test-classes/:?]
> at org.infinispan.persistence.ClusteredConditionalCommandTest.testPutIfAbsentOnNonOwnerWithIgnoreReturnValues(ClusteredConditionalCommandTest.java:242) ~[test-classes/:?]
> 00:21:48,953 TRACE (jgroups-7,Test-NodeB-56150:[]) [PersistenceUtil] Loaded null for key Test-key from persistence.
> 00:21:48,953 TRACE (jgroups-7,Test-NodeB-56150:[]) [CommandAwareRpcDispatcher] About to send back response SuccessfulResponse{responseValue=null} for command ClusteredGetCommand{key=Test-key, flags=[IGNORE_RETURN_VALUES]}
> {noformat}
> Possible fix: replace {{assertEquals}} with {{eventuallyEquals}}.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months
[JBoss JIRA] (ISPN-7377) RPCs to non-members throw spurious TimeoutException
by Galder Zamarreño (JIRA)
[ https://issues.jboss.org/browse/ISPN-7377?page=com.atlassian.jira.plugin.... ]
Galder Zamarreño updated ISPN-7377:
-----------------------------------
Fix Version/s: 9.0.0.Beta3
(was: 9.0.0.Beta2)
> RPCs to non-members throw spurious TimeoutException
> ---------------------------------------------------
>
> Key: ISPN-7377
> URL: https://issues.jboss.org/browse/ISPN-7377
> Project: Infinispan
> Issue Type: Bug
> Components: Core
> Affects Versions: 9.0.0.Beta1
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Fix For: 9.0.0.Beta3
>
>
> {{MessageDispatcher.cast()}} filters out the recipients that are not members in the JGroups view, and if none of the recipients are members, it returns an empty {{RspList}}.
> {{JGroupsTransport.invokeRemotelyAsync()}} instead expects that the {{RspList}} always contains a {{Rsp}} instance for each recipient, and it throws a {{TimeoutException}} if a {{Rsp}} is missing.
> {noformat}
> 19:26:36,088 INFO (jgroups-8,Test-NodeE-27588:[]) [JGroupsTransport] ISPN000094: Received new cluster view for channel ISPN: [Test-NodeE-27588|4] (3) [Test-NodeE-27588, Test-NodeF-40780, Test-NodeG-29022]
> 19:26:36,090 TRACE (stateTransferExecutor-thread-Test-NodeE-p16301-t3:[]) [JGroupsTransport] dests=[Test-NodeH-40364], command=StateRequestCommand{cache=dist, origin=Test-NodeE-27588, type=START_STATE_TRANSFER, topologyId=9, segments=[128, 1, 129, 130, 3, 4, 199, 200, 12, 144, 208, 145, 146, 92, 100, 101, 109, 110, 111, 112, 176, 49, 50, 51, 54, 188, 189, 253, 190, 127]}, mode=SYNCHRONOUS_IGNORE_LEAVERS, timeout=240000
> 19:26:36,098 TRACE (stateTransferExecutor-thread-Test-NodeE-p16301-t3:[]) [JGroupsTransport] Responses: Responses{}
> 19:26:36,098 TRACE (stateTransferExecutor-thread-Test-NodeE-p16301-t3:[]) [RpcManagerImpl] Replication exception
> org.infinispan.util.concurrent.TimeoutException: Timed out waiting for valid responses!
> at org.infinispan.remoting.transport.jgroups.JGroupsTransport.lambda$invokeRemotelyAsync$2(JGroupsTransport.java:661) ~[classes/:?]
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months
[JBoss JIRA] (ISPN-7351) Support @Named in CDI extension
by Seto Kaiba (JIRA)
[ https://issues.jboss.org/browse/ISPN-7351?page=com.atlassian.jira.plugin.... ]
Seto Kaiba edited comment on ISPN-7351 at 1/23/17 9:01 PM:
-----------------------------------------------------------
Maybe extends @ConfigureCache("name-cache") as @Qualifier would be great. Just a small suggest. I mean the code as below.
{code:java}
@ConfigureCache("name-cache")
@Produces
public Configuration nameCacheConfig() {
ConfigurationBuilder builder = new ConfigurationBuilder();
builder.storeAsBinary().enable();
return builder.build();
}
@Inject
@ConfigureCache("name-cache")
Cache<String, String> nameCache;
{code}
was (Author: seto):
Maybe extends @ConfigureCache("name-cache") as @Qualifier would be great.
Just a small suggest.
I mean the code as below.
{code:java}
@ConfigureCache("name-cache")
@Produces
public Configuration nameCacheConfig() {
ConfigurationBuilder builder = new ConfigurationBuilder();
builder.storeAsBinary().enable();
return builder.build();
}
@Inject
@ConfigureCache("name-cache")
Cache<String, String> nameCache;
{code}
> Support @Named in CDI extension
> -------------------------------
>
> Key: ISPN-7351
> URL: https://issues.jboss.org/browse/ISPN-7351
> Project: Infinispan
> Issue Type: Feature Request
> Components: CDI Integration
> Reporter: Sebastian Łaskawiec
> Assignee: Sebastian Łaskawiec
>
> Currently our users have to create lots and lots of {{@Qualifier}} type of annotations. It would be desirable to support {{@Named("driver")}} type of annotations.
> Useful links:
> * {{@Named}} Javadoc: http://docs.oracle.com/javaee/6/api/javax/inject/Named.html
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months
[JBoss JIRA] (ISPN-7351) Support @Named in CDI extension
by Seto Kaiba (JIRA)
[ https://issues.jboss.org/browse/ISPN-7351?page=com.atlassian.jira.plugin.... ]
Seto Kaiba edited comment on ISPN-7351 at 1/23/17 9:00 PM:
-----------------------------------------------------------
The injection is working. The problem is not about @Named. But the problem is org.infinispan.cdi.DefaultEmbeddedCacheManagerProducer.getDefaultEmbeddedCacheManager(DefaultEmbeddedCacheManagerProducer.java:38) will inject the @Default Configuration. @Named is not treated as normal @Qualifier. The built-in @Default will be added. Then ambiguous dependencies will occur.
Anyway, there's a simple workaround below. Define a normal Qualifier called NamedCache.
{code:java}
@Qualifier
@Target({ElementType.FIELD, ElementType.PARAMETER, ElementType.METHOD})
@Retention(RetentionPolicy.RUNTIME)
@Documented
public @interface NamedCache {
}
{code}
And then use it together with @Named to annotate the Configuration producer.
{code:java}
@ConfigureCache("named1")
@NamedCache
@Named("named1")
@Produces
public Configuration named1CacheConfig() {
return distributeConfig(defaultConfig()).build();
}
{code}
And then inject cache using @Named only.
{code:java}
@Inject
@Named("named1")
Cache<String,String> named1;
{code}
-Still, ask for a multiple @ConfigureCache support.-
Multiple @ConfigureCache maybe able to apply the Configuration. But there's no way for qualifiers to qualify the actual Cache. Maybe it's a wrong feature request.
was (Author: seto):
The injection is working. The problem is not about @Named.
But the problem is org.infinispan.cdi.DefaultEmbeddedCacheManagerProducer.getDefaultEmbeddedCacheManager(DefaultEmbeddedCacheManagerProducer.java:38) will inject the @Default Configuration. @Named is not treated as normal @Qualifier. The built-in @Default will be added.
Then ambiguous dependencies will occur.
Anyway, there's a simple workaround below.
Define a normal Qualifier called NamedCache.
{code:java}
@Qualifier
@Target({ElementType.FIELD, ElementType.PARAMETER, ElementType.METHOD})
@Retention(RetentionPolicy.RUNTIME)
@Documented
public @interface NamedCache {
}
{code}
And then use it together with @Named to annotate the Configuration producer.
{code:java}
@ConfigureCache("named1")
@NamedCache
@Named("named1")
@Produces
public Configuration named1CacheConfig() {
return distributeConfig(defaultConfig()).build();
}
{code}
And then inject cache using @Named only.
{code:java}
@Inject
@Named("named1")
Cache<String,String> named1;
{code}
-Still, ask for a multiple @ConfigureCache support.-
Multiple @ConfigureCache maybe able to apply the Configuration. But there's no way for qualifiers to qualify the actual Cache. Maybe it's a wrong feature request.
> Support @Named in CDI extension
> -------------------------------
>
> Key: ISPN-7351
> URL: https://issues.jboss.org/browse/ISPN-7351
> Project: Infinispan
> Issue Type: Feature Request
> Components: CDI Integration
> Reporter: Sebastian Łaskawiec
> Assignee: Sebastian Łaskawiec
>
> Currently our users have to create lots and lots of {{@Qualifier}} type of annotations. It would be desirable to support {{@Named("driver")}} type of annotations.
> Useful links:
> * {{@Named}} Javadoc: http://docs.oracle.com/javaee/6/api/javax/inject/Named.html
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months
[JBoss JIRA] (ISPN-7351) Support @Named in CDI extension
by Seto Kaiba (JIRA)
[ https://issues.jboss.org/browse/ISPN-7351?page=com.atlassian.jira.plugin.... ]
Seto Kaiba edited comment on ISPN-7351 at 1/23/17 8:59 PM:
-----------------------------------------------------------
Or maybe still with @Named and @Qualifier.
=========================================================================
--But to allow multiple @ConfigureCache. It's convenience for Cache share the same configs.-
-This should be another feature request I think.-
Multiple @ConfigureCache maybe able to apply the Configuration. But there's no way for qualifiers to qualify the actual Cache. Maybe it's a wrong feature request.
was (Author: seto):
Or maybe still with @Named and @Qualifier.
=========================================================================
-But to allow multiple @ConfigureCache. It's convenience for Cache share the same configs.
This should be another feature request I think.-
Multiple @ConfigureCache maybe able to apply the Configuration. But there's no way for qualifiers to qualify the actual Cache. Maybe it's a wrong feature request.
> Support @Named in CDI extension
> -------------------------------
>
> Key: ISPN-7351
> URL: https://issues.jboss.org/browse/ISPN-7351
> Project: Infinispan
> Issue Type: Feature Request
> Components: CDI Integration
> Reporter: Sebastian Łaskawiec
> Assignee: Sebastian Łaskawiec
>
> Currently our users have to create lots and lots of {{@Qualifier}} type of annotations. It would be desirable to support {{@Named("driver")}} type of annotations.
> Useful links:
> * {{@Named}} Javadoc: http://docs.oracle.com/javaee/6/api/javax/inject/Named.html
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months
[JBoss JIRA] (ISPN-7351) Support @Named in CDI extension
by Seto Kaiba (JIRA)
[ https://issues.jboss.org/browse/ISPN-7351?page=com.atlassian.jira.plugin.... ]
Seto Kaiba edited comment on ISPN-7351 at 1/23/17 8:59 PM:
-----------------------------------------------------------
Or maybe still with @Named and @Qualifier.
=========================================================================
--But to allow multiple @ConfigureCache. It's convenience for Cache share the same configs. This should be another feature request I think.-
Multiple @ConfigureCache maybe able to apply the Configuration. But there's no way for qualifiers to qualify the actual Cache. Maybe it's a wrong feature request.
was (Author: seto):
Or maybe still with @Named and @Qualifier.
=========================================================================
--But to allow multiple @ConfigureCache. It's convenience for Cache share the same configs.-
-This should be another feature request I think.-
Multiple @ConfigureCache maybe able to apply the Configuration. But there's no way for qualifiers to qualify the actual Cache. Maybe it's a wrong feature request.
> Support @Named in CDI extension
> -------------------------------
>
> Key: ISPN-7351
> URL: https://issues.jboss.org/browse/ISPN-7351
> Project: Infinispan
> Issue Type: Feature Request
> Components: CDI Integration
> Reporter: Sebastian Łaskawiec
> Assignee: Sebastian Łaskawiec
>
> Currently our users have to create lots and lots of {{@Qualifier}} type of annotations. It would be desirable to support {{@Named("driver")}} type of annotations.
> Useful links:
> * {{@Named}} Javadoc: http://docs.oracle.com/javaee/6/api/javax/inject/Named.html
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months
[JBoss JIRA] (ISPN-7351) Support @Named in CDI extension
by Seto Kaiba (JIRA)
[ https://issues.jboss.org/browse/ISPN-7351?page=com.atlassian.jira.plugin.... ]
Seto Kaiba edited comment on ISPN-7351 at 1/23/17 8:58 PM:
-----------------------------------------------------------
The injection is working. The problem is not about @Named.
But the problem is org.infinispan.cdi.DefaultEmbeddedCacheManagerProducer.getDefaultEmbeddedCacheManager(DefaultEmbeddedCacheManagerProducer.java:38) will inject the @Default Configuration. @Named is not treated as normal @Qualifier. The built-in @Default will be added.
Then ambiguous dependencies will occur.
Anyway, there's a simple workaround below.
Define a normal Qualifier called NamedCache.
{code:java}
@Qualifier
@Target({ElementType.FIELD, ElementType.PARAMETER, ElementType.METHOD})
@Retention(RetentionPolicy.RUNTIME)
@Documented
public @interface NamedCache {
}
{code}
And then use it together with @Named to annotate the Configuration producer.
{code:java}
@ConfigureCache("named1")
@NamedCache
@Named("named1")
@Produces
public Configuration named1CacheConfig() {
return distributeConfig(defaultConfig()).build();
}
{code}
And then inject cache using @Named only.
{code:java}
@Inject
@Named("named1")
Cache<String,String> named1;
{code}
-Still, ask for a multiple @ConfigureCache support.-
Multiple @ConfigureCache maybe able to apply the Configuration. But there's no way for qualifiers to qualify the actual Cache. Maybe it's a wrong feature request.
was (Author: seto):
The injection is working. The problem is not about @Named.
But the problem is org.infinispan.cdi.DefaultEmbeddedCacheManagerProducer.getDefaultEmbeddedCacheManager(DefaultEmbeddedCacheManagerProducer.java:38) will inject the @Default Configuration. @Named is not treated as normal @Qualifier. The built-in @Default will be added.
Then ambiguous dependencies will occur.
Anyway, there's a simple workaround below.
Define a normal Qualifier called NamedCache.
{code:java}
@Qualifier
@Target({ElementType.FIELD, ElementType.PARAMETER, ElementType.METHOD})
@Retention(RetentionPolicy.RUNTIME)
@Documented
public @interface NamedCache {
}
{code}
And then use it together with @Named to annotate the Configuration producer.
{code:java}
@ConfigureCache("named1")
@NamedCache
@Named("named1")
@Produces
public Configuration named1CacheConfig() {
return distributeConfig(defaultConfig()).build();
}
{code}
And then inject cache using @Named only.
{code:java}
@Inject
@Named("named1")
Cache<String,String> named1;
{code}
Still, ask for a multiple @ConfigureCache support.
> Support @Named in CDI extension
> -------------------------------
>
> Key: ISPN-7351
> URL: https://issues.jboss.org/browse/ISPN-7351
> Project: Infinispan
> Issue Type: Feature Request
> Components: CDI Integration
> Reporter: Sebastian Łaskawiec
> Assignee: Sebastian Łaskawiec
>
> Currently our users have to create lots and lots of {{@Qualifier}} type of annotations. It would be desirable to support {{@Named("driver")}} type of annotations.
> Useful links:
> * {{@Named}} Javadoc: http://docs.oracle.com/javaee/6/api/javax/inject/Named.html
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months