[JBoss JIRA] (ISPN-7806) QueryInterceptor should not load entries from DC but context
by Gustavo Fernandes (JIRA)
[ https://issues.jboss.org/browse/ISPN-7806?page=com.atlassian.jira.plugin.... ]
Gustavo Fernandes reassigned ISPN-7806:
---------------------------------------
Assignee: Gustavo Fernandes (was: Adrian Nistor)
> QueryInterceptor should not load entries from DC but context
> ------------------------------------------------------------
>
> Key: ISPN-7806
> URL: https://issues.jboss.org/browse/ISPN-7806
> Project: Infinispan
> Issue Type: Bug
> Components: Embedded Querying
> Affects Versions: 9.0.0.Final
> Reporter: Radim Vansa
> Assignee: Gustavo Fernandes
>
> Currently in {{visitPrepareCommand}} the query interceptor is loading data directly from data container. That's wrong - if the entry is passivated/evicted, the previous value is incorrect.
> As the data is not loaded (from DC/persistence) at current QI position, we should move QueryInterceptor after EntryWrappingInterceptor, CacheLoaderInterceptor and xDistributionInterceptor (which may load the data from remote node), and load the previous entry from context instead. The same approach should be taken for non-tx command, rather than relying on their return value.
> There will still be issues if the command has SKIP_CACHE_LOAD flag: I suggest warning message if it doesn't have SKIP_INDEXING flag as well.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 11 months
[JBoss JIRA] (ISPN-7806) QueryInterceptor should not load entries from DC but context
by Adrian Nistor (JIRA)
[ https://issues.jboss.org/browse/ISPN-7806?page=com.atlassian.jira.plugin.... ]
Adrian Nistor updated ISPN-7806:
--------------------------------
Status: Open (was: New)
> QueryInterceptor should not load entries from DC but context
> ------------------------------------------------------------
>
> Key: ISPN-7806
> URL: https://issues.jboss.org/browse/ISPN-7806
> Project: Infinispan
> Issue Type: Bug
> Components: Embedded Querying
> Affects Versions: 9.0.0.Final
> Reporter: Radim Vansa
> Assignee: Gustavo Fernandes
>
> Currently in {{visitPrepareCommand}} the query interceptor is loading data directly from data container. That's wrong - if the entry is passivated/evicted, the previous value is incorrect.
> As the data is not loaded (from DC/persistence) at current QI position, we should move QueryInterceptor after EntryWrappingInterceptor, CacheLoaderInterceptor and xDistributionInterceptor (which may load the data from remote node), and load the previous entry from context instead. The same approach should be taken for non-tx command, rather than relying on their return value.
> There will still be issues if the command has SKIP_CACHE_LOAD flag: I suggest warning message if it doesn't have SKIP_INDEXING flag as well.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 11 months
[JBoss JIRA] (ISPN-3795) QueryInterceptor incorrectly relies on the return value of a RemoveCommand
by Gustavo Fernandes (JIRA)
[ https://issues.jboss.org/browse/ISPN-3795?page=com.atlassian.jira.plugin.... ]
Gustavo Fernandes reassigned ISPN-3795:
---------------------------------------
Assignee: Gustavo Fernandes (was: Sanne Grinovero)
> QueryInterceptor incorrectly relies on the return value of a RemoveCommand
> --------------------------------------------------------------------------
>
> Key: ISPN-3795
> URL: https://issues.jboss.org/browse/ISPN-3795
> Project: Infinispan
> Issue Type: Bug
> Components: Embedded Querying
> Affects Versions: 6.0.0.Final
> Reporter: Dan Berindei
> Assignee: Gustavo Fernandes
>
> QueryInterceptor uses the return value from RemoveCommand/ReplaceCommand to remove the value from the index.
> But both RemoveCommand and ReplaceCommand have a variant with an expected value parameter, and this variant return a boolean value instead of the removed/replaced value. In that case, the previous value won't be removed from the index.
> QueryInterceptor should probably use the previous value from the context entries to update the index instead.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 11 months
[JBoss JIRA] (ISPN-7826) LocalClusterExecutor doesn't apply timeout properly upon chaining
by William Burns (JIRA)
William Burns created ISPN-7826:
-----------------------------------
Summary: LocalClusterExecutor doesn't apply timeout properly upon chaining
Key: ISPN-7826
URL: https://issues.jboss.org/browse/ISPN-7826
Project: Infinispan
Issue Type: Bug
Components: Core
Reporter: William Burns
Assignee: William Burns
Fix For: 9.1.0.Alpha1
LocalClusterExecutor was originally written assuming timeout would not work with a local execution. Support was added later, but the chain methods when calling various filters were not updated to reflect this. This can cause issues where timeout is not adhered to or possibly RuntimeExceptions as timeout has to be greater than 0.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 11 months
[JBoss JIRA] (ISPN-7479) Add Failover and Execution Policy to ClusterExecutor
by William Burns (JIRA)
[ https://issues.jboss.org/browse/ISPN-7479?page=com.atlassian.jira.plugin.... ]
William Burns updated ISPN-7479:
--------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
> Add Failover and Execution Policy to ClusterExecutor
> ----------------------------------------------------
>
> Key: ISPN-7479
> URL: https://issues.jboss.org/browse/ISPN-7479
> Project: Infinispan
> Issue Type: Enhancement
> Components: Distributed Execution and Map/Reduce
> Reporter: William Burns
> Assignee: William Burns
> Fix For: 9.1.0.Alpha1
>
>
> The ClusterExecutor interface was added in Infinispan 8 to allow for a user to run commands without a cache (just cache manager). This is very similar to DistributedExecutor. However DistributedExecutor also had policies for failover and execution. We should add this functionality to ClusterExecutor as well.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 11 months