[JBoss JIRA] (ISPN-8204) Remove should be conditional
by Radim Vansa (JIRA)
Radim Vansa created ISPN-8204:
---------------------------------
Summary: Remove should be conditional
Key: ISPN-8204
URL: https://issues.jboss.org/browse/ISPN-8204
Project: Infinispan
Issue Type: Bug
Components: Core
Affects Versions: 9.1.0.Final
Reporter: Radim Vansa
Assignee: Radim Vansa
If {{cache.remove(k)}} is called on non-existent key, it should become a no-op, marking the command as unsuccessful, and not replicating the change to backup owners. That makes the command effectively conditional (as it checks previous value), in the same way as {{cache.replace(k, newValue)}} is.
While I think that this is the correct behaviour, it's a breaking change for transactions. Some transactions may become read-only and there are multiple tests in the testsuite that would be broken by this.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (ISPN-8204) Remove should be conditional
by Radim Vansa (JIRA)
[ https://issues.jboss.org/browse/ISPN-8204?page=com.atlassian.jira.plugin.... ]
Radim Vansa commented on ISPN-8204:
-----------------------------------
[~dan.berindei] [~pruivo] WDYT?
> Remove should be conditional
> ----------------------------
>
> Key: ISPN-8204
> URL: https://issues.jboss.org/browse/ISPN-8204
> Project: Infinispan
> Issue Type: Bug
> Components: Core
> Affects Versions: 9.1.0.Final
> Reporter: Radim Vansa
> Assignee: Radim Vansa
>
> If {{cache.remove(k)}} is called on non-existent key, it should become a no-op, marking the command as unsuccessful, and not replicating the change to backup owners. That makes the command effectively conditional (as it checks previous value), in the same way as {{cache.replace(k, newValue)}} is.
> While I think that this is the correct behaviour, it's a breaking change for transactions. Some transactions may become read-only and there are multiple tests in the testsuite that would be broken by this.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (ISPN-6952) JCacheTwoCachesBasicOpsTest.testRemovedListener fails
by Sebastian Łaskawiec (JIRA)
[ https://issues.jboss.org/browse/ISPN-6952?page=com.atlassian.jira.plugin.... ]
Sebastian Łaskawiec updated ISPN-6952:
--------------------------------------
Status: Resolved (was: Pull Request Sent)
Fix Version/s: 9.1.1.Final
Resolution: Done
> JCacheTwoCachesBasicOpsTest.testRemovedListener fails
> -----------------------------------------------------
>
> Key: ISPN-6952
> URL: https://issues.jboss.org/browse/ISPN-6952
> Project: Infinispan
> Issue Type: Bug
> Components: JCache
> Reporter: Sebastian Łaskawiec
> Assignee: Tristan Tarrant
> Priority: Critical
> Labels: testsuite_stability
> Fix For: 9.1.1.Final
>
> Attachments: JCacheTwoCachesBasicOpsTest_20161106.log.gz
>
>
> http://ci.infinispan.org/project.html?projectId=Infinispan&testNameId=804...
> {noformat}
> java.lang.AssertionError: expected [1] but found [2]
> at org.testng.Assert.fail(Assert.java:94)
> at org.testng.Assert.failNotEquals(Assert.java:494)
> at org.testng.Assert.assertEquals(Assert.java:123)
> at org.testng.Assert.assertEquals(Assert.java:370)
> at org.testng.Assert.assertEquals(Assert.java:380)
> at org.infinispan.jcache.AbstractTwoCachesBasicOpsTest.testRemovedListener(AbstractTwoCachesBasicOpsTest.java:302)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:84)
> at org.testng.internal.Invoker.invokeMethod(Invoker.java:714)
> at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:901)
> at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1231)
> at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127)
> at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111)
> at org.testng.TestRunner.privateRun(TestRunner.java:767)
> at org.testng.TestRunner.run(TestRunner.java:617)
> at org.testng.SuiteRunner.runTest(SuiteRunner.java:348)
> at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:343)
> at org.testng.SuiteRunner.privateRun(SuiteRunner.java:305)
> at org.testng.SuiteRunner.run(SuiteRunner.java:254)
> at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
> at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
> at org.testng.TestNG.runSuitesSequentially(TestNG.java:1224)
> at org.testng.TestNG.runSuitesLocally(TestNG.java:1149)
> at org.testng.TestNG.run(TestNG.java:1057)
> at org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:115)
> at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.executeMulti(TestNGDirectoryTestSuite.java:205)
> at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.execute(TestNGDirectoryTestSuite.java:108)
> at org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:111)
> at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
> at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155)
> at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
> ------- Stdout: -------
> [TestSuiteProgress] Test starting: org.infinispan.jcache.JCacheTwoCachesBasicOpsTest.testRemovedListener
> [TestSuiteProgress] Test failed: org.infinispan.jcache.JCacheTwoCachesBasicOpsTest.testRemovedListener
> 12:50:19,634 ERROR (testng-JCacheTwoCachesBasicOpsTest) [TestSuiteProgress] Test failed: org.infinispan.jcache.JCacheTwoCachesBasicOpsTest.testRemovedListener
> java.lang.AssertionError: expected [1] but found [2]
> at org.testng.Assert.fail(Assert.java:94)
> at org.testng.Assert.failNotEquals(Assert.java:494)
> at org.testng.Assert.assertEquals(Assert.java:123)
> at org.testng.Assert.assertEquals(Assert.java:370)
> at org.testng.Assert.assertEquals(Assert.java:380)
> at org.infinispan.jcache.AbstractTwoCachesBasicOpsTest.testRemovedListener(AbstractTwoCachesBasicOpsTest.java:302)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)[TestSuiteProgress] Tests succeeded: 19, failed: 1, skipped: 0
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (ISPN-6952) JCacheTwoCachesBasicOpsTest.testRemovedListener fails
by Sebastian Łaskawiec (JIRA)
[ https://issues.jboss.org/browse/ISPN-6952?page=com.atlassian.jira.plugin.... ]
Sebastian Łaskawiec reassigned ISPN-6952:
-----------------------------------------
Assignee: Tristan Tarrant (was: Sebastian Łaskawiec)
> JCacheTwoCachesBasicOpsTest.testRemovedListener fails
> -----------------------------------------------------
>
> Key: ISPN-6952
> URL: https://issues.jboss.org/browse/ISPN-6952
> Project: Infinispan
> Issue Type: Bug
> Components: JCache
> Reporter: Sebastian Łaskawiec
> Assignee: Tristan Tarrant
> Priority: Critical
> Labels: testsuite_stability
> Attachments: JCacheTwoCachesBasicOpsTest_20161106.log.gz
>
>
> http://ci.infinispan.org/project.html?projectId=Infinispan&testNameId=804...
> {noformat}
> java.lang.AssertionError: expected [1] but found [2]
> at org.testng.Assert.fail(Assert.java:94)
> at org.testng.Assert.failNotEquals(Assert.java:494)
> at org.testng.Assert.assertEquals(Assert.java:123)
> at org.testng.Assert.assertEquals(Assert.java:370)
> at org.testng.Assert.assertEquals(Assert.java:380)
> at org.infinispan.jcache.AbstractTwoCachesBasicOpsTest.testRemovedListener(AbstractTwoCachesBasicOpsTest.java:302)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:84)
> at org.testng.internal.Invoker.invokeMethod(Invoker.java:714)
> at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:901)
> at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1231)
> at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127)
> at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111)
> at org.testng.TestRunner.privateRun(TestRunner.java:767)
> at org.testng.TestRunner.run(TestRunner.java:617)
> at org.testng.SuiteRunner.runTest(SuiteRunner.java:348)
> at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:343)
> at org.testng.SuiteRunner.privateRun(SuiteRunner.java:305)
> at org.testng.SuiteRunner.run(SuiteRunner.java:254)
> at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
> at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
> at org.testng.TestNG.runSuitesSequentially(TestNG.java:1224)
> at org.testng.TestNG.runSuitesLocally(TestNG.java:1149)
> at org.testng.TestNG.run(TestNG.java:1057)
> at org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:115)
> at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.executeMulti(TestNGDirectoryTestSuite.java:205)
> at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.execute(TestNGDirectoryTestSuite.java:108)
> at org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:111)
> at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
> at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155)
> at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
> ------- Stdout: -------
> [TestSuiteProgress] Test starting: org.infinispan.jcache.JCacheTwoCachesBasicOpsTest.testRemovedListener
> [TestSuiteProgress] Test failed: org.infinispan.jcache.JCacheTwoCachesBasicOpsTest.testRemovedListener
> 12:50:19,634 ERROR (testng-JCacheTwoCachesBasicOpsTest) [TestSuiteProgress] Test failed: org.infinispan.jcache.JCacheTwoCachesBasicOpsTest.testRemovedListener
> java.lang.AssertionError: expected [1] but found [2]
> at org.testng.Assert.fail(Assert.java:94)
> at org.testng.Assert.failNotEquals(Assert.java:494)
> at org.testng.Assert.assertEquals(Assert.java:123)
> at org.testng.Assert.assertEquals(Assert.java:370)
> at org.testng.Assert.assertEquals(Assert.java:380)
> at org.infinispan.jcache.AbstractTwoCachesBasicOpsTest.testRemovedListener(AbstractTwoCachesBasicOpsTest.java:302)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)[TestSuiteProgress] Tests succeeded: 19, failed: 1, skipped: 0
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (ISPN-8114) Random failures in loading from Hibernate Cache
by Galder Zamarreño (JIRA)
[ https://issues.jboss.org/browse/ISPN-8114?page=com.atlassian.jira.plugin.... ]
Galder Zamarreño reopened ISPN-8114:
------------------------------------
Random test still failing after integrating fix:
11th August master build shows:
{code}
java.lang.AssertionError: Citizen (1234) should have present in the cache
at org.junit.Assert.fail(Assert.java:88)
at org.infinispan.test.hibernate.cache.functional.cluster.NaturalIdInvalidationTest.assertLoadedFromCache(NaturalIdInvalidationTest.java:155)
at org.infinispan.test.hibernate.cache.functional.cluster.NaturalIdInvalidationTest.testAll(NaturalIdInvalidationTest.java:122)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
at org.hibernate.testing.junit4.ExtendedFrameworkMethod.invokeExplosively(ExtendedFrameworkMethod.java:45)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
at org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)
{code}
> Random failures in loading from Hibernate Cache
> -----------------------------------------------
>
> Key: ISPN-8114
> URL: https://issues.jboss.org/browse/ISPN-8114
> Project: Infinispan
> Issue Type: Bug
> Components: Hibernate Cache
> Affects Versions: 9.1.0.Final
> Reporter: Galder Zamarreño
> Assignee: Galder Zamarreño
> Labels: testsuite_stability
> Fix For: 9.1.1.Final
>
>
> {{org.infinispan.test.hibernate.cache.functional.cluster.NaturalIdInvalidationTest.testAll[read-only, INVALIDATION_SYNC]}}
> {{org.infinispan.test.hibernate.cache.functional.cluster.NaturalIdInvalidationTest.testAll[transactional, INVALIDATION_SYNC]}}
> {code}
> java.lang.AssertionError: Citizen (1234) should have present in the cache
> at org.junit.Assert.fail(Assert.java:88)
> at org.infinispan.test.hibernate.cache.functional.cluster.NaturalIdInvalidationTest.assertLoadedFromCache(NaturalIdInvalidationTest.java:144)
> at org.infinispan.test.hibernate.cache.functional.cluster.NaturalIdInvalidationTest.testAll(NaturalIdInvalidationTest.java:114)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
> at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
> at org.hibernate.testing.junit4.ExtendedFrameworkMethod.invokeExplosively(ExtendedFrameworkMethod.java:45)
> at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months