[JBoss JIRA] (ISPN-8111) OffHeapBoundedSingleNodeTest.testMultiThreaded fails with trace logging enabled
by William Burns (JIRA)
[ https://issues.jboss.org/browse/ISPN-8111?page=com.atlassian.jira.plugin.... ]
William Burns updated ISPN-8111:
--------------------------------
Fix Version/s: 9.2.0.Final
9.1.1.Final
> OffHeapBoundedSingleNodeTest.testMultiThreaded fails with trace logging enabled
> -------------------------------------------------------------------------------
>
> Key: ISPN-8111
> URL: https://issues.jboss.org/browse/ISPN-8111
> Project: Infinispan
> Issue Type: Bug
> Components: Test Suite - Core
> Affects Versions: 9.1.0.Final
> Reporter: Dan Berindei
> Assignee: William Burns
> Priority: Critical
> Labels: testsuite_stability
> Fix For: 9.2.0.Final, 9.1.1.Final
>
>
> This is related to ISPN-8110, but it may be possible to fix ISPN-8110 and still have {{OffHeapBoundedSingleNodeTest.testMultiThreaded}} take more than 10 seconds.
> 10 seconds seems more than enough for a CPU-bound test, but maybe we need to allow for more time when trace logging is enabled, or maybe we can test only the data container to eliminate the unrelated logging from the (unnecessary, I think) commands and interceptors:
> {noformat}
> 15:52:10,227 TRACE (testng-Test:[]) [InvocationContextInterceptor] Invoked with command PutKeyValueCommand{key=WrappedByteArray{bytes=[B0x010201046B657931, hashCode=1745974967}, value=WrappedByteArray{bytes=[B0x0102010676616C75..[10], hashCode=635645735}, flags=[], commandInvocationId=, putIfAbsent=false, valueMatcher=MATCH_ALWAYS, metadata=EmbeddedExpirableMetadata{lifespan=-1, maxIdle=-1, version=null}, successful=true, topologyId=-1} and InvocationContext [org.infinispan.context.impl.LocalTxInvocationContext@5f3c06c1]
> 15:52:10,229 TRACE (testng-Test:[]) [InvocationContextInterceptor] Invoked with command PrepareCommand {modifications=[PutKeyValueCommand{key=WrappedByteArray{bytes=[B0x010201046B657931, hashCode=1745974967}, value=WrappedByteArray{bytes=[B0x0102010676616C75..[10], hashCode=635645735}, flags=[], commandInvocationId=, putIfAbsent=false, valueMatcher=MATCH_ALWAYS, metadata=EmbeddedExpirableMetadata{lifespan=-1, maxIdle=-1, version=null}, successful=true, topologyId=-1}], onePhaseCommit=false, retried=false, gtx=GlobalTx:local:2, cacheName='___defaultcache', topologyId=-1} and InvocationContext [org.infinispan.context.impl.LocalTxInvocationContext@3bc20a52]
> 15:52:10,231 TRACE (testng-Test:[]) [InvocationContextInterceptor] Invoked with command CommitCommand {gtx=GlobalTx:local:2, cacheName='___defaultcache', topologyId=-1} and InvocationContext [org.infinispan.context.impl.LocalTxInvocationContext@2af56f39]
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 6 months
[JBoss JIRA] (ISPN-8111) OffHeapBoundedSingleNodeTest.testMultiThreaded fails with trace logging enabled
by William Burns (JIRA)
[ https://issues.jboss.org/browse/ISPN-8111?page=com.atlassian.jira.plugin.... ]
William Burns updated ISPN-8111:
--------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/infinispan/infinispan/pull/5438
> OffHeapBoundedSingleNodeTest.testMultiThreaded fails with trace logging enabled
> -------------------------------------------------------------------------------
>
> Key: ISPN-8111
> URL: https://issues.jboss.org/browse/ISPN-8111
> Project: Infinispan
> Issue Type: Bug
> Components: Test Suite - Core
> Affects Versions: 9.1.0.Final
> Reporter: Dan Berindei
> Assignee: William Burns
> Priority: Critical
> Labels: testsuite_stability
> Fix For: 9.2.0.Final, 9.1.1.Final
>
>
> This is related to ISPN-8110, but it may be possible to fix ISPN-8110 and still have {{OffHeapBoundedSingleNodeTest.testMultiThreaded}} take more than 10 seconds.
> 10 seconds seems more than enough for a CPU-bound test, but maybe we need to allow for more time when trace logging is enabled, or maybe we can test only the data container to eliminate the unrelated logging from the (unnecessary, I think) commands and interceptors:
> {noformat}
> 15:52:10,227 TRACE (testng-Test:[]) [InvocationContextInterceptor] Invoked with command PutKeyValueCommand{key=WrappedByteArray{bytes=[B0x010201046B657931, hashCode=1745974967}, value=WrappedByteArray{bytes=[B0x0102010676616C75..[10], hashCode=635645735}, flags=[], commandInvocationId=, putIfAbsent=false, valueMatcher=MATCH_ALWAYS, metadata=EmbeddedExpirableMetadata{lifespan=-1, maxIdle=-1, version=null}, successful=true, topologyId=-1} and InvocationContext [org.infinispan.context.impl.LocalTxInvocationContext@5f3c06c1]
> 15:52:10,229 TRACE (testng-Test:[]) [InvocationContextInterceptor] Invoked with command PrepareCommand {modifications=[PutKeyValueCommand{key=WrappedByteArray{bytes=[B0x010201046B657931, hashCode=1745974967}, value=WrappedByteArray{bytes=[B0x0102010676616C75..[10], hashCode=635645735}, flags=[], commandInvocationId=, putIfAbsent=false, valueMatcher=MATCH_ALWAYS, metadata=EmbeddedExpirableMetadata{lifespan=-1, maxIdle=-1, version=null}, successful=true, topologyId=-1}], onePhaseCommit=false, retried=false, gtx=GlobalTx:local:2, cacheName='___defaultcache', topologyId=-1} and InvocationContext [org.infinispan.context.impl.LocalTxInvocationContext@3bc20a52]
> 15:52:10,231 TRACE (testng-Test:[]) [InvocationContextInterceptor] Invoked with command CommitCommand {gtx=GlobalTx:local:2, cacheName='___defaultcache', topologyId=-1} and InvocationContext [org.infinispan.context.impl.LocalTxInvocationContext@2af56f39]
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 6 months
[JBoss JIRA] (ISPN-8237) State transfer doesn't replace L1 entry with regular entry
by Dan Berindei (JIRA)
[ https://issues.jboss.org/browse/ISPN-8237?page=com.atlassian.jira.plugin.... ]
Dan Berindei updated ISPN-8237:
-------------------------------
Status: Open (was: New)
> State transfer doesn't replace L1 entry with regular entry
> ----------------------------------------------------------
>
> Key: ISPN-8237
> URL: https://issues.jboss.org/browse/ISPN-8237
> Project: Infinispan
> Issue Type: Bug
> Components: Core
> Affects Versions: 9.1.0.Final
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Labels: testsuite_stability
>
> An L1 entry is preserved when the local node becomes an owner, it is only removed if the application removes the key explicitly. Otherwise state transfer overwrites the L1 entry with the entry received from a previous owner, making it immortal (assuming the original entry didn't have a lifespan/maxIdle).
> A transaction writing to a key while the local node is only a write owner will not remove the L1 metadata from the entry either, but it will set the {{PUT_FOR_STATE_TRANSFER}} flag in {{CommitManager}}. Since state transfer doesn't overwrite an entry tracked in {{CommitManager}}, that means the L1 entry is never replaced with an immortal entry.
> This started appearing in {{ConcurrentNonOverlappingLeaveTest}} once I changed {{TxDistributionInterceptor}} to cause a retry when the topology changes during commit (for ISPN-8195). There, the entry is first wrapped on the originator before it becomes the primary owner, and the commit happens multiple times, but neither seems to be required.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 6 months
[JBoss JIRA] (ISPN-8237) State transfer doesn't replace L1 entry with regular entry
by Dan Berindei (JIRA)
[ https://issues.jboss.org/browse/ISPN-8237?page=com.atlassian.jira.plugin.... ]
Dan Berindei updated ISPN-8237:
-------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/infinispan/infinispan/pull/5437
> State transfer doesn't replace L1 entry with regular entry
> ----------------------------------------------------------
>
> Key: ISPN-8237
> URL: https://issues.jboss.org/browse/ISPN-8237
> Project: Infinispan
> Issue Type: Bug
> Components: Core
> Affects Versions: 9.1.0.Final
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Labels: testsuite_stability
>
> An L1 entry is preserved when the local node becomes an owner, it is only removed if the application removes the key explicitly. Otherwise state transfer overwrites the L1 entry with the entry received from a previous owner, making it immortal (assuming the original entry didn't have a lifespan/maxIdle).
> A transaction writing to a key while the local node is only a write owner will not remove the L1 metadata from the entry either, but it will set the {{PUT_FOR_STATE_TRANSFER}} flag in {{CommitManager}}. Since state transfer doesn't overwrite an entry tracked in {{CommitManager}}, that means the L1 entry is never replaced with an immortal entry.
> This started appearing in {{ConcurrentNonOverlappingLeaveTest}} once I changed {{TxDistributionInterceptor}} to cause a retry when the topology changes during commit (for ISPN-8195). There, the entry is first wrapped on the originator before it becomes the primary owner, and the commit happens multiple times, but neither seems to be required.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 6 months
[JBoss JIRA] (ISPN-8195) Transaction fails to commit when a node crashes
by Dan Berindei (JIRA)
[ https://issues.jboss.org/browse/ISPN-8195?page=com.atlassian.jira.plugin.... ]
Dan Berindei updated ISPN-8195:
-------------------------------
Status: Open (was: New)
> Transaction fails to commit when a node crashes
> -----------------------------------------------
>
> Key: ISPN-8195
> URL: https://issues.jboss.org/browse/ISPN-8195
> Project: Infinispan
> Issue Type: Bug
> Components: Core, Transactions
> Affects Versions: 9.1.0.Final
> Reporter: Radim Vansa
> Assignee: Dan Berindei
> Attachments: log.zip
>
>
> Nodes ABC, key is owned by BC:
> 1. C prepares a transaction modifying only one key [BC], prepare succeeds on both
> 2. B crashes
> 3. C tries to send CommitCommand to B and gets {{CacheNotFoundResponse}}
> 4. C throws OTE, which gets handled by STI and retried
> 5. A becomes an owner of key in the next topology
> 6. C sends CommitCommand to all owners, including A
> 7. A does not find the transaction prepared and throws {{IllegalStateException: Remote transaction not found: GlobalTx:test-NodeC-45028:1}}
> 8. C fails the transaction because of the {{IllegalStateException}}
> Usually A should request transactions during state transfer, but the CommitCommand is sent in the first topology with higher id - in this case it's the "Hey we've lost B!" topology which does not start rebalance yet.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 6 months
[JBoss JIRA] (ISPN-8195) Transaction fails to commit when a node crashes
by Dan Berindei (JIRA)
[ https://issues.jboss.org/browse/ISPN-8195?page=com.atlassian.jira.plugin.... ]
Dan Berindei updated ISPN-8195:
-------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/infinispan/infinispan/pull/5437
> Transaction fails to commit when a node crashes
> -----------------------------------------------
>
> Key: ISPN-8195
> URL: https://issues.jboss.org/browse/ISPN-8195
> Project: Infinispan
> Issue Type: Bug
> Components: Core, Transactions
> Affects Versions: 9.1.0.Final
> Reporter: Radim Vansa
> Assignee: Dan Berindei
> Attachments: log.zip
>
>
> Nodes ABC, key is owned by BC:
> 1. C prepares a transaction modifying only one key [BC], prepare succeeds on both
> 2. B crashes
> 3. C tries to send CommitCommand to B and gets {{CacheNotFoundResponse}}
> 4. C throws OTE, which gets handled by STI and retried
> 5. A becomes an owner of key in the next topology
> 6. C sends CommitCommand to all owners, including A
> 7. A does not find the transaction prepared and throws {{IllegalStateException: Remote transaction not found: GlobalTx:test-NodeC-45028:1}}
> 8. C fails the transaction because of the {{IllegalStateException}}
> Usually A should request transactions during state transfer, but the CommitCommand is sent in the first topology with higher id - in this case it's the "Hey we've lost B!" topology which does not start rebalance yet.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 6 months
[JBoss JIRA] (ISPN-8306) InfinispanRegionFactory should use MemoryConfiguration
by Ryan Emerson (JIRA)
[ https://issues.jboss.org/browse/ISPN-8306?page=com.atlassian.jira.plugin.... ]
Ryan Emerson updated ISPN-8306:
-------------------------------
Description: InfinispanRegionFactory still utilises EvictionConfiguration which will have no affect on the created caches, instead they should utilise the MemoryConfiguration.
> InfinispanRegionFactory should use MemoryConfiguration
> ------------------------------------------------------
>
> Key: ISPN-8306
> URL: https://issues.jboss.org/browse/ISPN-8306
> Project: Infinispan
> Issue Type: Bug
> Components: Hibernate Cache
> Affects Versions: 9.1.0.Final
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
>
> InfinispanRegionFactory still utilises EvictionConfiguration which will have no affect on the created caches, instead they should utilise the MemoryConfiguration.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 6 months