[JBoss JIRA] (ISPN-8003) ProtobufMetadataManagerInterceptor fail the InterceptorDefinesAllReadWritesCheck
by Adrian Nistor (Jira)
[ https://issues.jboss.org/browse/ISPN-8003?page=com.atlassian.jira.plugin.... ]
Adrian Nistor updated ISPN-8003:
--------------------------------
Summary: ProtobufMetadataManagerInterceptor fail the InterceptorDefinesAllReadWritesCheck (was: QueryInterceptor and ProtobufMetadataManagerInterceptor fail the InterceptorDefinesAllReadWritesCheck)
> ProtobufMetadataManagerInterceptor fail the InterceptorDefinesAllReadWritesCheck
> --------------------------------------------------------------------------------
>
> Key: ISPN-8003
> URL: https://issues.jboss.org/browse/ISPN-8003
> Project: Infinispan
> Issue Type: Bug
> Affects Versions: 8.2.0.Final, 9.0.0.Final
> Reporter: Adrian Nistor
> Assignee: Adrian Nistor
> Priority: Major
> Fix For: 9.4.1.Final
>
>
> {code}
> ProtobufMetadataManagerInterceptor.java:43, InterceptorDefinesAllReadWritesCheck, Priority: Normal
> Interceptor defines methods [visitPutKeyValueCommand, visitRemoveCommand, visitPutMapCommand, visitReplaceCommand] but does not define [visitReadWriteKeyCommand, visitReadWriteManyCommand, visitReadWriteKeyValueCommand, visitReadWriteManyEntriesCommand] [not required for tests]
> {code}
> {code}
> QueryInterceptor.java:69, InterceptorDefinesAllReadWritesCheck, Priority: Normal
> Interceptor defines methods [visitPutKeyValueCommand, visitRemoveCommand, visitPutMapCommand, visitReplaceCommand] but does not define [visitReadWriteKeyCommand, visitReadWriteManyCommand, visitReadWriteKeyValueCommand, visitReadWriteManyEntriesCommand] [not required for tests]
> {code}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (ISPN-8003) QueryInterceptor and ProtobufMetadataManagerInterceptor fail the InterceptorDefinesAllReadWritesCheck
by Adrian Nistor (Jira)
[ https://issues.jboss.org/browse/ISPN-8003?page=com.atlassian.jira.plugin.... ]
Adrian Nistor updated ISPN-8003:
--------------------------------
Status: Pull Request Sent (was: Coding In Progress)
Git Pull Request: https://github.com/infinispan/infinispan/pull/6322
> QueryInterceptor and ProtobufMetadataManagerInterceptor fail the InterceptorDefinesAllReadWritesCheck
> -----------------------------------------------------------------------------------------------------
>
> Key: ISPN-8003
> URL: https://issues.jboss.org/browse/ISPN-8003
> Project: Infinispan
> Issue Type: Bug
> Affects Versions: 8.2.0.Final, 9.0.0.Final
> Reporter: Adrian Nistor
> Assignee: Adrian Nistor
> Priority: Major
> Fix For: 9.4.1.Final
>
>
> {code}
> ProtobufMetadataManagerInterceptor.java:43, InterceptorDefinesAllReadWritesCheck, Priority: Normal
> Interceptor defines methods [visitPutKeyValueCommand, visitRemoveCommand, visitPutMapCommand, visitReplaceCommand] but does not define [visitReadWriteKeyCommand, visitReadWriteManyCommand, visitReadWriteKeyValueCommand, visitReadWriteManyEntriesCommand] [not required for tests]
> {code}
> {code}
> QueryInterceptor.java:69, InterceptorDefinesAllReadWritesCheck, Priority: Normal
> Interceptor defines methods [visitPutKeyValueCommand, visitRemoveCommand, visitPutMapCommand, visitReplaceCommand] but does not define [visitReadWriteKeyCommand, visitReadWriteManyCommand, visitReadWriteKeyValueCommand, visitReadWriteManyEntriesCommand] [not required for tests]
> {code}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (ISPN-9589) Client Listener notifications can deadlock
by Tristan Tarrant (Jira)
[ https://issues.jboss.org/browse/ISPN-9589?page=com.atlassian.jira.plugin.... ]
Tristan Tarrant reassigned ISPN-9589:
-------------------------------------
Assignee: William Burns
> Client Listener notifications can deadlock
> ------------------------------------------
>
> Key: ISPN-9589
> URL: https://issues.jboss.org/browse/ISPN-9589
> Project: Infinispan
> Issue Type: Bug
> Components: Listeners, Server
> Reporter: William Burns
> Assignee: William Burns
> Priority: Critical
>
> When a node does a write and it is the primary owner it will send the client listener event. Unfortunately this can block waiting to put in the eventQueue. Unfortunately the thread that is executing this method can be the event loop for that listener, which in turn can cause it to block forever. I believe this came about after ISPN-8621.
> I have found a few ways to fix this at the moment:
> # Make the client listener async - this way it is fired on the notification thread
> # Change the listener event to check if the current thread is the event loop and subsequently fire the events directly instead of submitting it to the Executor.
> # Make the various write operations still use the worker thread pool - this was changed in the above mentioned JIRA so I am guessing we don't want to do that
> The former of the fixes seems to be much more performant, but I don't know if I like that fix. The latter still has hiccups since it reduces availability of threads to respond to socket requests.
> This is very easy to reproduce by running the ClientEventStressTest test on master as is since it only has 3 io threads (but the default is CPU * 2 - so in some cases this isn't that much)
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (ISPN-8616) DistAsyncFuncTest.testMergeFromNonOwner random failures
by Dan Berindei (Jira)
[ https://issues.jboss.org/browse/ISPN-8616?page=com.atlassian.jira.plugin.... ]
Dan Berindei reopened ISPN-8616:
--------------------------------
Assignee: Dan Berindei (was: Radim Vansa)
I saw the failure again on master. The problem seems to be that {{resetEagerCommands()}} can run before all of a test method's asynchronous commands have finished executing:
{noformat}
19:26:44,888 DEBUG (testng-Test:[]) [TestSuiteProgress] Test configuration finished: org.infinispan.distribution.DistAsyncFuncTest.resetEagerCommands
19:26:44,890 DEBUG (remote-thread-Test-NodeD-p8114-t1:[]) [ReplListener] [Test-NodeD-22728] ReplListener saw command PutKeyValueCommand{key=k3, value=value3-changed, flags=[SKIP_LOCKING, IGNORE_RETURN_VALUES], commandInvocationId=CommandInvocation:Test-NodeB-52740:8912, putIfAbsent=false, valueMatcher=MATCH_ALWAYS, metadata=EmbeddedExpirableMetadata{lifespan=-1, maxIdle=-1, version=null}, successful=true, topologyId=13}
19:26:44,902 INFO (testng-Test:[]) [TestSuiteProgress] Test starting: org.infinispan.distribution.DistAsyncFuncTest.testMergeFromNonOwner[DIST_ASYNC, tx=false]
19:26:45,032 DEBUG (testng-Test:[]) [ReplListener] [Test-NodeD-22728] Waiting for 1 command(s)
19:26:45,032 DEBUG (testng-Test:[]) [ReplListener] [Test-NodeD-22728] Matched command PutKeyValueCommand{key=k3, value=value3-changed, flags=[SKIP_LOCKING, IGNORE_RETURN_VALUES], commandInvocationId=CommandInvocation:Test-NodeB-52740:8912, putIfAbsent=false, valueMatcher=MATCH_ALWAYS, metadata=EmbeddedExpirableMetadata{lifespan=-1, maxIdle=-1, version=null}, successful=true, topologyId=13}
19:26:45,035 DEBUG (remote-thread-Test-NodeD-p8114-t3:[]) [ReplListener] [Test-NodeD-22728] ReplListener saw command PutKeyValueCommand{key=k1, value=value, flags=[SKIP_LOCKING, IGNORE_RETURN_VALUES], commandInvocationId=CommandInvocation:Test-NodeA-34864:9015, putIfAbsent=false, valueMatcher=MATCH_ALWAYS, metadata=EmbeddedExpirableMetadata{lifespan=-1, maxIdle=-1, version=null}, successful=true, topologyId=13}
19:26:45,035 ERROR (testng-Test:[]) [TestSuiteProgress] Test failed: org.infinispan.distribution.DistAsyncFuncTest.testMergeFromNonOwner[DIST_ASYNC, tx=false]
java.lang.AssertionError: Fail on owner cache Test-NodeD-22728: dc.get(k1) returned null
at org.infinispan.distribution.BaseDistFunctionalTest.assertOwnershipAndNonOwnership(BaseDistFunctionalTest.java:191) ~[test-classes/:?]
at org.infinispan.distribution.BaseDistFunctionalTest.assertOnAllCachesAndOwnership(BaseDistFunctionalTest.java:162) ~[test-classes/:?]
at org.infinispan.distribution.BaseDistFunctionalTest.initAndTest(BaseDistFunctionalTest.java:142) ~[test-classes/:?]
at org.infinispan.distribution.DistSyncFuncTest.testMergeFromNonOwner(DistSyncFuncTest.java:387) ~[test-classes/:?]
{noformat}
> DistAsyncFuncTest.testMergeFromNonOwner random failures
> -------------------------------------------------------
>
> Key: ISPN-8616
> URL: https://issues.jboss.org/browse/ISPN-8616
> Project: Infinispan
> Issue Type: Bug
> Components: Test Suite - Core
> Affects Versions: 9.2.0.Beta1
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Major
> Labels: testsuite_stability
> Fix For: 10.0.0.Final
>
>
> {noformat}
> java.lang.AssertionError: Fail on owner cache DistAsyncFuncTest[DIST_ASYNC, tx=false]-NodeA-42474: dc.get(k1) returned null
> at org.infinispan.distribution.BaseDistFunctionalTest.assertOwnershipAndNonOwnership(BaseDistFunctionalTest.java:191)
> at org.infinispan.distribution.BaseDistFunctionalTest.assertOnAllCachesAndOwnership(BaseDistFunctionalTest.java:162)
> at org.infinispan.distribution.BaseDistFunctionalTest.initAndTest(BaseDistFunctionalTest.java:142)
> at org.infinispan.distribution.DistSyncFuncTest.testMergeFromNonOwner(DistSyncFuncTest.java:387)
> {noformat}
> The test method is new and the interceptors have changed, but it's probably the same problem with {{asyncWait}} signaled in ISPN-3741. I commented out the entire implementation of {{asyncWait}} in {{DistAsyncFuncTest}} and it still passed when run by itself, so we need a way to delay the commands and check that the test is not sensitive to such delays.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (ISPN-8616) DistAsyncFuncTest.testMergeFromNonOwner random failures
by Dan Berindei (Jira)
[ https://issues.jboss.org/browse/ISPN-8616?page=com.atlassian.jira.plugin.... ]
Dan Berindei updated ISPN-8616:
-------------------------------
Fix Version/s: 10.0.0.Final
> DistAsyncFuncTest.testMergeFromNonOwner random failures
> -------------------------------------------------------
>
> Key: ISPN-8616
> URL: https://issues.jboss.org/browse/ISPN-8616
> Project: Infinispan
> Issue Type: Bug
> Components: Test Suite - Core
> Affects Versions: 9.2.0.Beta1
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Major
> Labels: testsuite_stability
> Fix For: 10.0.0.Final
>
>
> {noformat}
> java.lang.AssertionError: Fail on owner cache DistAsyncFuncTest[DIST_ASYNC, tx=false]-NodeA-42474: dc.get(k1) returned null
> at org.infinispan.distribution.BaseDistFunctionalTest.assertOwnershipAndNonOwnership(BaseDistFunctionalTest.java:191)
> at org.infinispan.distribution.BaseDistFunctionalTest.assertOnAllCachesAndOwnership(BaseDistFunctionalTest.java:162)
> at org.infinispan.distribution.BaseDistFunctionalTest.initAndTest(BaseDistFunctionalTest.java:142)
> at org.infinispan.distribution.DistSyncFuncTest.testMergeFromNonOwner(DistSyncFuncTest.java:387)
> {noformat}
> The test method is new and the interceptors have changed, but it's probably the same problem with {{asyncWait}} signaled in ISPN-3741. I commented out the entire implementation of {{asyncWait}} in {{DistAsyncFuncTest}} and it still passed when run by itself, so we need a way to delay the commands and check that the test is not sensitive to such delays.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (ISPN-9594) Update the server trimming list against WF 14 components
by Tristan Tarrant (Jira)
Tristan Tarrant created ISPN-9594:
-------------------------------------
Summary: Update the server trimming list against WF 14 components
Key: ISPN-9594
URL: https://issues.jboss.org/browse/ISPN-9594
Project: Infinispan
Issue Type: Enhancement
Components: Build, Server
Affects Versions: 9.4.0.Final
Reporter: Tristan Tarrant
Assignee: Tristan Tarrant
Fix For: 9.4.1.Final
The 9.4.0.Final server is 214MB unpacked. We can remove a number of unneeded components to reduce it considerably.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (ISPN-9408) Support for query results in different formats in Hot Rod
by Diego Lovison (Jira)
[ https://issues.jboss.org/browse/ISPN-9408?page=com.atlassian.jira.plugin.... ]
Diego Lovison updated ISPN-9408:
--------------------------------
Tester: Diego Lovison
> Support for query results in different formats in Hot Rod
> ---------------------------------------------------------
>
> Key: ISPN-9408
> URL: https://issues.jboss.org/browse/ISPN-9408
> Project: Infinispan
> Issue Type: Enhancement
> Components: Remote Protocols
> Reporter: Gustavo Fernandes
> Assignee: Gustavo Fernandes
> Priority: Major
> Fix For: 9.4.0.CR1, 9.4.0.CR3
>
>
> ISPN-7420 introduced multiple format support for the Hot Rod client, but this is not covering the query results which are always protobuf. The data format specified in the client should propagate to the server and the response (query results or projections) should be converted to the specified format.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months