[JBoss JIRA] (ISPN-6011) ClassCastException in CDI generated keys for JCache
by Tristan Tarrant (Jira)
[ https://issues.jboss.org/browse/ISPN-6011?page=com.atlassian.jira.plugin.... ]
Tristan Tarrant updated ISPN-6011:
----------------------------------
Status: Open (was: Pull Request Sent)
> ClassCastException in CDI generated keys for JCache
> ---------------------------------------------------
>
> Key: ISPN-6011
> URL: https://issues.jboss.org/browse/ISPN-6011
> Project: Infinispan
> Issue Type: Bug
> Affects Versions: 8.1.0.CR1, 8.0.2.Final
> Reporter: Galder Zamarreño
> Assignee: Galder Zamarreño
> Priority: Major
> Fix For: 9.4.0.Final
>
>
> When using JCache-annotations the DefaultCacheKeyGenerator exclusively looks at parameter values to form the cache key. Therefore it will be very likely that collissions occur (resulting in difficult to find ClassCastExceptions). The provided patch uses the method- and class names as additionally values to make the cache key more unique.
> Might also add that I am aware that by spec this should not be an issue when no cachename is given (as it should generate a cache using the class-name), but when a cache name is given collissions may occur.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (ISPN-6477) Security tests always log a warning during cache manager shutdown
by Tristan Tarrant (Jira)
[ https://issues.jboss.org/browse/ISPN-6477?page=com.atlassian.jira.plugin.... ]
Tristan Tarrant updated ISPN-6477:
----------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
> Security tests always log a warning during cache manager shutdown
> -----------------------------------------------------------------
>
> Key: ISPN-6477
> URL: https://issues.jboss.org/browse/ISPN-6477
> Project: Infinispan
> Issue Type: Bug
> Components: Security, Test Suite - Core
> Affects Versions: 8.2.1.Final
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Minor
>
> The problem is that {{TestingUtil.killCacheManagers()}} first stops each cache explicitly, and then {{DefaultCacheManager.stop()}} fails because it can't access the global ACL cache to perform a security check:
> {noformat}
> 17:07:00,613 WARN (testng-ExecutionAuthorizationTest:[]) [TestingUtil] Problems killing cache manager org.infinispan.manager.DefaultCacheManager@4e83a98@Address:ExecutionAuthorizationTest-NodeB-14717
> org.infinispan.IllegalLifecycleStateException: ISPN000323: ___acl_cache is in 'TERMINATED' state and so it does not accept new invocations. Either restart it or recreate the cache container.
> at org.infinispan.cache.impl.SimpleCacheImpl.getDataContainer(SimpleCacheImpl.java:1044) ~[infinispan-core.jar:9.0.0-SNAPSHOT]
> at org.infinispan.cache.impl.SimpleCacheImpl.computeIfAbsentInternal(SimpleCacheImpl.java:1116) ~[infinispan-core.jar:9.0.0-SNAPSHOT]
> at org.infinispan.cache.impl.StatsCollectingCache.computeIfAbsentInternal(StatsCollectingCache.java:270) ~[infinispan-core.jar:9.0.0-SNAPSHOT]
> at org.infinispan.cache.impl.SimpleCacheImpl.computeIfAbsent(SimpleCacheImpl.java:1111) ~[infinispan-core.jar:9.0.0-SNAPSHOT]
> at org.infinispan.security.impl.AuthorizationHelper.checkSubjectPermissionAndRole(AuthorizationHelper.java:107) ~[infinispan-core.jar:9.0.0-SNAPSHOT]
> at org.infinispan.security.impl.AuthorizationHelper.checkPermission(AuthorizationHelper.java:76) ~[infinispan-core.jar:9.0.0-SNAPSHOT]
> at org.infinispan.security.impl.AuthorizationManagerImpl.checkPermission(AuthorizationManagerImpl.java:42) ~[infinispan-core.jar:9.0.0-SNAPSHOT]
> at org.infinispan.security.impl.SecureCacheImpl.getComponentRegistry(SecureCacheImpl.java:336) ~[infinispan-core.jar:9.0.0-SNAPSHOT]
> at org.infinispan.manager.DefaultCacheManager.unregisterCacheMBean(DefaultCacheManager.java:714) ~[infinispan-core.jar:9.0.0-SNAPSHOT]
> at org.infinispan.manager.DefaultCacheManager.terminate(DefaultCacheManager.java:671) ~[infinispan-core.jar:9.0.0-SNAPSHOT]
> at org.infinispan.manager.DefaultCacheManager.stopCaches(DefaultCacheManager.java:708) ~[infinispan-core.jar:9.0.0-SNAPSHOT]
> at org.infinispan.manager.DefaultCacheManager.stop(DefaultCacheManager.java:688) ~[infinispan-core.jar:9.0.0-SNAPSHOT]
> at org.infinispan.test.TestingUtil.killCacheManagers(TestingUtil.java:673) [infinispan-core-tests.jar:9.0.0-SNAPSHOT]
> at org.infinispan.test.TestingUtil.killCacheManagers(TestingUtil.java:656) [infinispan-core-tests.jar:9.0.0-SNAPSHOT]
> at org.infinispan.test.TestingUtil.killCacheManagers(TestingUtil.java:652) [infinispan-core-tests.jar:9.0.0-SNAPSHOT]
> at org.infinispan.test.MultipleCacheManagersTest.destroy(MultipleCacheManagersTest.java:87) [infinispan-core-tests.jar:9.0.0-SNAPSHOT]
> {noformat}
> {{DefaultCacheManager.stop()}} could check a cache's status before trying to unregister it from JMX, avoiding the security check when the cache is already {{TERMINATED}}.
> {{DefaultCacheManager.unregisterCacheMBean()}} could also extract the cache's component registry from the global component registry and avoid the security check, since {{DefaultCacheManager.stop()}} already performed a security check.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (ISPN-6477) Security tests always log a warning during cache manager shutdown
by Tristan Tarrant (Jira)
[ https://issues.jboss.org/browse/ISPN-6477?page=com.atlassian.jira.plugin.... ]
Tristan Tarrant updated ISPN-6477:
----------------------------------
Fix Version/s: (was: 9.0.0.Alpha1)
(was: 9.4.0.Final)
> Security tests always log a warning during cache manager shutdown
> -----------------------------------------------------------------
>
> Key: ISPN-6477
> URL: https://issues.jboss.org/browse/ISPN-6477
> Project: Infinispan
> Issue Type: Bug
> Components: Security, Test Suite - Core
> Affects Versions: 8.2.1.Final
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Minor
>
> The problem is that {{TestingUtil.killCacheManagers()}} first stops each cache explicitly, and then {{DefaultCacheManager.stop()}} fails because it can't access the global ACL cache to perform a security check:
> {noformat}
> 17:07:00,613 WARN (testng-ExecutionAuthorizationTest:[]) [TestingUtil] Problems killing cache manager org.infinispan.manager.DefaultCacheManager@4e83a98@Address:ExecutionAuthorizationTest-NodeB-14717
> org.infinispan.IllegalLifecycleStateException: ISPN000323: ___acl_cache is in 'TERMINATED' state and so it does not accept new invocations. Either restart it or recreate the cache container.
> at org.infinispan.cache.impl.SimpleCacheImpl.getDataContainer(SimpleCacheImpl.java:1044) ~[infinispan-core.jar:9.0.0-SNAPSHOT]
> at org.infinispan.cache.impl.SimpleCacheImpl.computeIfAbsentInternal(SimpleCacheImpl.java:1116) ~[infinispan-core.jar:9.0.0-SNAPSHOT]
> at org.infinispan.cache.impl.StatsCollectingCache.computeIfAbsentInternal(StatsCollectingCache.java:270) ~[infinispan-core.jar:9.0.0-SNAPSHOT]
> at org.infinispan.cache.impl.SimpleCacheImpl.computeIfAbsent(SimpleCacheImpl.java:1111) ~[infinispan-core.jar:9.0.0-SNAPSHOT]
> at org.infinispan.security.impl.AuthorizationHelper.checkSubjectPermissionAndRole(AuthorizationHelper.java:107) ~[infinispan-core.jar:9.0.0-SNAPSHOT]
> at org.infinispan.security.impl.AuthorizationHelper.checkPermission(AuthorizationHelper.java:76) ~[infinispan-core.jar:9.0.0-SNAPSHOT]
> at org.infinispan.security.impl.AuthorizationManagerImpl.checkPermission(AuthorizationManagerImpl.java:42) ~[infinispan-core.jar:9.0.0-SNAPSHOT]
> at org.infinispan.security.impl.SecureCacheImpl.getComponentRegistry(SecureCacheImpl.java:336) ~[infinispan-core.jar:9.0.0-SNAPSHOT]
> at org.infinispan.manager.DefaultCacheManager.unregisterCacheMBean(DefaultCacheManager.java:714) ~[infinispan-core.jar:9.0.0-SNAPSHOT]
> at org.infinispan.manager.DefaultCacheManager.terminate(DefaultCacheManager.java:671) ~[infinispan-core.jar:9.0.0-SNAPSHOT]
> at org.infinispan.manager.DefaultCacheManager.stopCaches(DefaultCacheManager.java:708) ~[infinispan-core.jar:9.0.0-SNAPSHOT]
> at org.infinispan.manager.DefaultCacheManager.stop(DefaultCacheManager.java:688) ~[infinispan-core.jar:9.0.0-SNAPSHOT]
> at org.infinispan.test.TestingUtil.killCacheManagers(TestingUtil.java:673) [infinispan-core-tests.jar:9.0.0-SNAPSHOT]
> at org.infinispan.test.TestingUtil.killCacheManagers(TestingUtil.java:656) [infinispan-core-tests.jar:9.0.0-SNAPSHOT]
> at org.infinispan.test.TestingUtil.killCacheManagers(TestingUtil.java:652) [infinispan-core-tests.jar:9.0.0-SNAPSHOT]
> at org.infinispan.test.MultipleCacheManagersTest.destroy(MultipleCacheManagersTest.java:87) [infinispan-core-tests.jar:9.0.0-SNAPSHOT]
> {noformat}
> {{DefaultCacheManager.stop()}} could check a cache's status before trying to unregister it from JMX, avoiding the security check when the cache is already {{TERMINATED}}.
> {{DefaultCacheManager.unregisterCacheMBean()}} could also extract the cache's component registry from the global component registry and avoid the security check, since {{DefaultCacheManager.stop()}} already performed a security check.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (ISPN-6956) AffinityPartitioner enabled as default partitioner
by Tristan Tarrant (Jira)
[ https://issues.jboss.org/browse/ISPN-6956?page=com.atlassian.jira.plugin.... ]
Tristan Tarrant updated ISPN-6956:
----------------------------------
Status: Open (was: Pull Request Sent)
> AffinityPartitioner enabled as default partitioner
> --------------------------------------------------
>
> Key: ISPN-6956
> URL: https://issues.jboss.org/browse/ISPN-6956
> Project: Infinispan
> Issue Type: Enhancement
> Components: Core
> Reporter: Sanne Grinovero
> Assignee: Sanne Grinovero
> Priority: Major
>
> Having the {{org.infinispan.distribution.ch.impl.AffinityPartitioner}} as default enabled {{KeyPartitioner}} will allow people to use the functionality offered by {{org.infinispan.distribution.ch.AffinityTaggedKey}} out of the box, without needing to enable it explicitly in configuration.
> {{AffinityTaggedKey}} is used by Query but not only.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (ISPN-6956) AffinityPartitioner enabled as default partitioner
by Tristan Tarrant (Jira)
[ https://issues.jboss.org/browse/ISPN-6956?page=com.atlassian.jira.plugin.... ]
Tristan Tarrant updated ISPN-6956:
----------------------------------
Fix Version/s: (was: 9.4.0.Final)
> AffinityPartitioner enabled as default partitioner
> --------------------------------------------------
>
> Key: ISPN-6956
> URL: https://issues.jboss.org/browse/ISPN-6956
> Project: Infinispan
> Issue Type: Enhancement
> Components: Core
> Reporter: Sanne Grinovero
> Assignee: Sanne Grinovero
> Priority: Major
>
> Having the {{org.infinispan.distribution.ch.impl.AffinityPartitioner}} as default enabled {{KeyPartitioner}} will allow people to use the functionality offered by {{org.infinispan.distribution.ch.AffinityTaggedKey}} out of the box, without needing to enable it explicitly in configuration.
> {{AffinityTaggedKey}} is used by Query but not only.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months