[JBoss JIRA] (ISPN-8930) RestOperationsTest#shouldPutImmortalEntryWithZeroTtlAndIdleTime random failure
by Katia Aresti (JIRA)
[ https://issues.jboss.org/browse/ISPN-8930?page=com.atlassian.jira.plugin.... ]
Katia Aresti updated ISPN-8930:
-------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
> RestOperationsTest#shouldPutImmortalEntryWithZeroTtlAndIdleTime random failure
> ------------------------------------------------------------------------------
>
> Key: ISPN-8930
> URL: https://issues.jboss.org/browse/ISPN-8930
> Project: Infinispan
> Issue Type: Bug
> Components: REST
> Affects Versions: 9.2.0.Final
> Reporter: William Burns
> Assignee: William Burns
> Fix For: 9.2.1.Final, 9.3.0.Alpha1
>
>
> This test can fail randomly with a NPE
> {code}
> java.lang.NullPointerException
> at org.infinispan.rest.BaseRestOperationsTest.shouldPutImmortalEntryWithZeroTtlAndIdleTime(BaseRestOperationsTest.java:853)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> ... Removed 16 stack frames
> {code}
> This is caused by the thread being stalled for > 100 ms after the put but before reading.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years
[JBoss JIRA] (ISPN-8936) Parameterized branding
by Tristan Tarrant (JIRA)
Tristan Tarrant created ISPN-8936:
-------------------------------------
Summary: Parameterized branding
Key: ISPN-8936
URL: https://issues.jboss.org/browse/ISPN-8936
Project: Infinispan
Issue Type: Enhancement
Components: Build
Reporter: Tristan Tarrant
Assignee: Tristan Tarrant
Fix For: 9.3.0.Final
The Infinispan name is included in a number of artifacts:
* javadocs
* documentation
* CLI
* Server startup banner
* Console
* zip distributions
These should be parameterizable for productization
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years
[JBoss JIRA] (ISPN-8935) AbstractFileLookup.lookupFileStrict does not work for jar scheme
by Damir Murat (JIRA)
Damir Murat created ISPN-8935:
---------------------------------
Summary: AbstractFileLookup.lookupFileStrict does not work for jar scheme
Key: ISPN-8935
URL: https://issues.jboss.org/browse/ISPN-8935
Project: Infinispan
Issue Type: Bug
Components: Configuration, JCache
Affects Versions: 9.2.0.Final, 9.1.6.Final
Environment: Spring Boot 1.5.10, Infinispan 9.1.6
Reporter: Damir Murat
As documented [here|https://docs.oracle.com/javase/7/docs/api/java/net/JarURLConnection....], JAR URL has following syntax {{jar:<url>!/\{entry\}}}. Current implementation of {{AbstractFileLookup.lookupFileStrict}} does not rely on this syntax, and fails when correctly specified JAR URI comes in.
I'm using Infinispan JCache implementation from Spring Boot. This works when run from gradle/maven/ide since in these cases {{file}} scheme is used. However, I'm targeting running Spring Boot app inside of Docker container where natural way for using Spring Boot apps is to deploy them as boot packaged fat jar. In that case, Spring Boot passes correct JAR URI into {{AbstractFileLookup.lookupFileStrict}}, which unfortunately fails silently and JCache reverts to default configuration.
I believe that {{AbstractFileLookup.lookupFileStrict}} can be fixed by replacing current jar scheme handling
{code}
case "jar":
String uriAsString = uri.toString();
String fileName = uriAsString.substring(uriAsString.lastIndexOf(":") + 1);
return new FileInputStream(new File(fileName));
{code}
with something like this
{code}
case "jar": {
// Invalid code commented out.
// String uriAsString = uri.toString();
// String fileName = uriAsString.substring(uriAsString.lastIndexOf(":") + 1);
// return new FileInputStream(new File(fileName));
// ===== fix - start =====
String uriAsString = uri.toString();
String insideJarFilePath = uriAsString.substring(uriAsString.lastIndexOf("!") + 1);
InputStream streamToBeReturned = getAsInputStreamFromClassLoader(insideJarFilePath, cl);
if (streamToBeReturned == null) {
throw log.unableToLoadFileUsingScheme(scheme);
}
return streamToBeReturned;
// ===== fix - end =====
}
{code}
I'm using Infinispan 9.1.6, but I think that 9.2.0 has same problem. I will try to submit pull request.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years
[JBoss JIRA] (ISPN-8839) ClusterTopologyManagerImplTest leaks threads
by Dan Berindei (JIRA)
[ https://issues.jboss.org/browse/ISPN-8839?page=com.atlassian.jira.plugin.... ]
Dan Berindei reopened ISPN-8839:
--------------------------------
The fix actually breaks the test:
{noformat}
10:43:22,001 ERROR (testng-Test:[]) [TestSuiteProgress] Test failed: org.infinispan.topology.ClusterTopologyManagerImplTest.testCoordinatorLostDuringRebalance
java.lang.AssertionError: Timed out waiting for topology 5
at org.testng.AssertJUnit.fail(AssertJUnit.java:59) ~[testng-6.9.9.jar:?]
at org.testng.AssertJUnit.assertTrue(AssertJUnit.java:24) ~[testng-6.9.9.jar:?]
at org.testng.AssertJUnit.assertNotNull(AssertJUnit.java:267) ~[testng-6.9.9.jar:?]
at org.infinispan.topology.MockLocalTopologyManager.expectTopology(MockLocalTopologyManager.java:60) ~[test-classes/:?]
at org.infinispan.topology.ClusterTopologyManagerImplTest.testCoordinatorLostDuringRebalance(ClusterTopologyManagerImplTest.java:192) ~[test-classes/:?]
{noformat}
> ClusterTopologyManagerImplTest leaks threads
> --------------------------------------------
>
> Key: ISPN-8839
> URL: https://issues.jboss.org/browse/ISPN-8839
> Project: Infinispan
> Issue Type: Bug
> Components: Test Suite - Core
> Affects Versions: 9.2.0.CR2
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Minor
> Fix For: 9.2.0.CR3
>
>
> Both test methods create an {{ExecutorService}} but don't shut it down.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years