[JBoss JIRA] (ISPN-9025) Transaction leak when API invoked with invalid arguments
by Dan Berindei (JIRA)
[ https://issues.jboss.org/browse/ISPN-9025?page=com.atlassian.jira.plugin.... ]
Dan Berindei updated ISPN-9025:
-------------------------------
Affects Version/s: 8.2.10.Final
> Transaction leak when API invoked with invalid arguments
> --------------------------------------------------------
>
> Key: ISPN-9025
> URL: https://issues.jboss.org/browse/ISPN-9025
> Project: Infinispan
> Issue Type: Bug
> Components: Core
> Affects Versions: 8.2.10.Final, 9.2.2.Final
> Reporter: Pedro Ruivo
> Assignee: Pedro Ruivo
> Fix For: 9.3.0.Beta1
>
>
> {{APINonTxTest}} is leaking transactions in {{testReplaceNullKeyParameter()}} and related methods (for transaction configurations). The implicit transaction is created and then a {{NullPointerException}} is thrown because of invalid arguments. The transaction stays in {{TransactionTable}} forever making the {{TransactionTable.stop()}} slow.
> {{testStopClearsData()}} runs slow (30sec) because it waits for the leaking transactions to finish (in a total of 2 min since the test is executed 4 times for different tx configurations)
> IMO, the best solution would be a {{Supplier}} or {{IntFunction}} and only create the {{InvocationContext}} and implicit transaction in the last moment.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 11 months
[JBoss JIRA] (ISPN-9025) Transaction leak when API invoked with invalid arguments
by Dan Berindei (JIRA)
[ https://issues.jboss.org/browse/ISPN-9025?page=com.atlassian.jira.plugin.... ]
Dan Berindei updated ISPN-9025:
-------------------------------
Status: Resolved (was: Pull Request Sent)
Fix Version/s: 9.3.0.Beta1
Resolution: Done
> Transaction leak when API invoked with invalid arguments
> --------------------------------------------------------
>
> Key: ISPN-9025
> URL: https://issues.jboss.org/browse/ISPN-9025
> Project: Infinispan
> Issue Type: Bug
> Reporter: Pedro Ruivo
> Assignee: Pedro Ruivo
> Fix For: 9.3.0.Beta1
>
>
> {{APINonTxTest}} is leaking transactions in {{testReplaceNullKeyParameter()}} and related methods (for transaction configurations). The implicit transaction is created and then a {{NullPointerException}} is thrown because of invalid arguments. The transaction stays in {{TransactionTable}} forever making the {{TransactionTable.stop()}} slow.
> {{testStopClearsData()}} runs slow (30sec) because it waits for the leaking transactions to finish (in a total of 2 min since the test is executed 4 times for different tx configurations)
> IMO, the best solution would be a {{Supplier}} or {{IntFunction}} and only create the {{InvocationContext}} and implicit transaction in the last moment.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 11 months
[JBoss JIRA] (ISPN-9002) LocalModeNoPassivationTest.testValuesWithEvictedEntries random failures
by William Burns (JIRA)
[ https://issues.jboss.org/browse/ISPN-9002?page=com.atlassian.jira.plugin.... ]
William Burns commented on ISPN-9002:
-------------------------------------
It seems to be an issue with _PersistenceManagerCloseableSupplier_ or the actual iteration
{code}
17:18:26,914 WARN (testng-LocalModeNoPassivationTest:[]) [DefaultCacheManager] ISPN000435: Cache manager initialized with a default cache configuration but without a name for it. Set it in the GlobalConfiguration.
17:18:26,927 TRACE (testng-LocalModeNoPassivationTest:[]) [PersistenceManagerCloseableSupplier] Returning entry: ImmortalCacheEntry{key=0, value=0}
17:18:26,927 TRACE (testng-LocalModeNoPassivationTest:[]) [PersistenceManagerCloseableSupplier] Returning entry: ImmortalCacheEntry{key=0, value=0}
17:18:26,927 TRACE (testng-LocalModeNoPassivationTest:[]) [PersistenceManagerCloseableSupplier] Returning entry: ImmortalCacheEntry{key=1, value=1}
17:18:26,927 TRACE (testng-LocalModeNoPassivationTest:[]) [PersistenceManagerCloseableSupplier] Returning entry: ImmortalCacheEntry{key=0, value=0}
17:18:26,927 TRACE (testng-LocalModeNoPassivationTest:[]) [PersistenceManagerCloseableSupplier] Returning entry: ImmortalCacheEntry{key=1, value=1}
17:18:26,927 TRACE (testng-LocalModeNoPassivationTest:[]) [PersistenceManagerCloseableSupplier] Returning entry: ImmortalCacheEntry{key=6, value=6}
17:18:26,927 TRACE (testng-LocalModeNoPassivationTest:[]) [PersistenceManagerCloseableSupplier] Returning entry: null
{code}
Oddly key 0 and 1 were returned multiple times as well, which happens even when it passes. I will have to look closer tomorrow, now that I know a little more where to target.
> LocalModeNoPassivationTest.testValuesWithEvictedEntries random failures
> -----------------------------------------------------------------------
>
> Key: ISPN-9002
> URL: https://issues.jboss.org/browse/ISPN-9002
> Project: Infinispan
> Issue Type: Bug
> Components: Test Suite - Core
> Affects Versions: 9.2.0.Final
> Reporter: Dan Berindei
> Assignee: William Burns
> Labels: testsuite_stability
> Fix For: 9.3.0.Beta1
>
> Attachments: LocalModeNoPassivationTest_ISPN-8962_preferavailabilitystrategy_20180327.log.gz
>
>
> {noformat}
> 12:59:16,370 ERROR (testng-Test:[]) [TestSuiteProgress] Test failed: org.infinispan.persistence.LocalModeNoPassivationTest.testValuesWithEvictedEntries
> java.lang.AssertionError: Value: 247 was not found!
> at org.testng.AssertJUnit.fail(AssertJUnit.java:59) ~[testng-6.9.9.jar:?]
> at org.testng.AssertJUnit.assertTrue(AssertJUnit.java:24) ~[testng-6.9.9.jar:?]
> at org.infinispan.persistence.LocalModePassivationTest.testValuesWithEvictedEntries(LocalModePassivationTest.java:203) ~[test-classes/:?]
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 11 months
[JBoss JIRA] (ISPN-9002) LocalModeNoPassivationTest.testValuesWithEvictedEntries random failures
by William Burns (JIRA)
[ https://issues.jboss.org/browse/ISPN-9002?page=com.atlassian.jira.plugin.... ]
William Burns commented on ISPN-9002:
-------------------------------------
Also I can reproduce the error when running LocalModePassivationTest as well - so it is definitely something with one of the classes you mentioned [~dan.berindei].
> LocalModeNoPassivationTest.testValuesWithEvictedEntries random failures
> -----------------------------------------------------------------------
>
> Key: ISPN-9002
> URL: https://issues.jboss.org/browse/ISPN-9002
> Project: Infinispan
> Issue Type: Bug
> Components: Test Suite - Core
> Affects Versions: 9.2.0.Final
> Reporter: Dan Berindei
> Assignee: William Burns
> Labels: testsuite_stability
> Fix For: 9.3.0.Beta1
>
> Attachments: LocalModeNoPassivationTest_ISPN-8962_preferavailabilitystrategy_20180327.log.gz
>
>
> {noformat}
> 12:59:16,370 ERROR (testng-Test:[]) [TestSuiteProgress] Test failed: org.infinispan.persistence.LocalModeNoPassivationTest.testValuesWithEvictedEntries
> java.lang.AssertionError: Value: 247 was not found!
> at org.testng.AssertJUnit.fail(AssertJUnit.java:59) ~[testng-6.9.9.jar:?]
> at org.testng.AssertJUnit.assertTrue(AssertJUnit.java:24) ~[testng-6.9.9.jar:?]
> at org.infinispan.persistence.LocalModePassivationTest.testValuesWithEvictedEntries(LocalModePassivationTest.java:203) ~[test-classes/:?]
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 11 months
[JBoss JIRA] (ISPN-9002) LocalModeNoPassivationTest.testValuesWithEvictedEntries random failures
by William Burns (JIRA)
[ https://issues.jboss.org/browse/ISPN-9002?page=com.atlassian.jira.plugin.... ]
William Burns commented on ISPN-9002:
-------------------------------------
The log is wrong. It should be REMOVE :)
> LocalModeNoPassivationTest.testValuesWithEvictedEntries random failures
> -----------------------------------------------------------------------
>
> Key: ISPN-9002
> URL: https://issues.jboss.org/browse/ISPN-9002
> Project: Infinispan
> Issue Type: Bug
> Components: Test Suite - Core
> Affects Versions: 9.2.0.Final
> Reporter: Dan Berindei
> Assignee: William Burns
> Labels: testsuite_stability
> Fix For: 9.3.0.Beta1
>
> Attachments: LocalModeNoPassivationTest_ISPN-8962_preferavailabilitystrategy_20180327.log.gz
>
>
> {noformat}
> 12:59:16,370 ERROR (testng-Test:[]) [TestSuiteProgress] Test failed: org.infinispan.persistence.LocalModeNoPassivationTest.testValuesWithEvictedEntries
> java.lang.AssertionError: Value: 247 was not found!
> at org.testng.AssertJUnit.fail(AssertJUnit.java:59) ~[testng-6.9.9.jar:?]
> at org.testng.AssertJUnit.assertTrue(AssertJUnit.java:24) ~[testng-6.9.9.jar:?]
> at org.infinispan.persistence.LocalModePassivationTest.testValuesWithEvictedEntries(LocalModePassivationTest.java:203) ~[test-classes/:?]
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 11 months