[ https://issues.jboss.org/browse/ISPN-9915?page=com.atlassian.jira.plugin.... ]
Ryan Emerson updated ISPN-9915:
-------------------------------
Git Pull Request: https://github.com/infinispan/infinispan/pull/6639, https://github.com/infinispan/infinispan/pull/6642 (was: https://github.com/infinispan/infinispan/pull/6639)
> JDBC publish Flowable should explicitly rollback connection
> -----------------------------------------------------------
>
> Key: ISPN-9915
> URL: https://issues.jboss.org/browse/ISPN-9915
> Project: Infinispan
> Issue Type: Bug
> Components: Loaders and Stores
> Affects Versions: 10.0.0.Alpha3, 9.4.6.Final
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
> Priority: Major
> Fix For: 10.0.0.Beta1, 9.4.7.Final
>
>
> The Flowable for the JDBC store publisher sets `autoCommit(false)` in order for pagination to work as expected, however we never explicitly call commit or rollback on the connection, therefore the exact behaviour is determined by the underlying connection pool. Instead we should explicitly call rollback() on the connection after the publisher has finished, because the operation is read only.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
[ https://issues.jboss.org/browse/ISPN-9657?page=com.atlassian.jira.plugin.... ]
Katia Aresti updated ISPN-9657:
-------------------------------
Status: Pull Request Sent (was: Coding In Progress)
> Multimap jar is not OSGi compliant
> ----------------------------------
>
> Key: ISPN-9657
> URL: https://issues.jboss.org/browse/ISPN-9657
> Project: Infinispan
> Issue Type: Bug
> Components: Multimap
> Affects Versions: 9.4.0.Final
> Reporter: Alain Picard
> Assignee: Katia Aresti
> Priority: Major
> Fix For: 10.0.0.Beta1, 10.0.0.Final, 9.4.7.Final
>
>
> Due to issues related to using the embedded jar (see [here|https://developer.jboss.org/message/986042#986042], when switching to individual jars, the multimap jar (infinispan-multimap-9.4.0.Final.jar) doesn't provide a valid OSGi manifest.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
[ https://issues.jboss.org/browse/ISPN-9657?page=com.atlassian.jira.plugin.... ]
Work on ISPN-9657 started by Katia Aresti.
------------------------------------------
> Multimap jar is not OSGi compliant
> ----------------------------------
>
> Key: ISPN-9657
> URL: https://issues.jboss.org/browse/ISPN-9657
> Project: Infinispan
> Issue Type: Bug
> Components: Multimap
> Affects Versions: 9.4.0.Final
> Reporter: Alain Picard
> Assignee: Katia Aresti
> Priority: Major
> Fix For: 10.0.0.Beta1, 10.0.0.Final, 9.4.7.Final
>
>
> Due to issues related to using the embedded jar (see [here|https://developer.jboss.org/message/986042#986042], when switching to individual jars, the multimap jar (infinispan-multimap-9.4.0.Final.jar) doesn't provide a valid OSGi manifest.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
[ https://issues.jboss.org/browse/ISPN-9657?page=com.atlassian.jira.plugin.... ]
Galder Zamarreño updated ISPN-9657:
-----------------------------------
Fix Version/s: 10.0.0.Final
> Multimap jar is not OSGi compliant
> ----------------------------------
>
> Key: ISPN-9657
> URL: https://issues.jboss.org/browse/ISPN-9657
> Project: Infinispan
> Issue Type: Bug
> Components: Multimap
> Affects Versions: 9.4.0.Final
> Reporter: Alain Picard
> Assignee: Katia Aresti
> Priority: Major
> Fix For: 10.0.0.Beta1, 10.0.0.Final, 9.4.7.Final
>
>
> Due to issues related to using the embedded jar (see [here|https://developer.jboss.org/message/986042#986042], when switching to individual jars, the multimap jar (infinispan-multimap-9.4.0.Final.jar) doesn't provide a valid OSGi manifest.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
[ https://issues.jboss.org/browse/ISPN-9657?page=com.atlassian.jira.plugin.... ]
Galder Zamarreño updated ISPN-9657:
-----------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
> Multimap jar is not OSGi compliant
> ----------------------------------
>
> Key: ISPN-9657
> URL: https://issues.jboss.org/browse/ISPN-9657
> Project: Infinispan
> Issue Type: Bug
> Components: Multimap
> Affects Versions: 9.4.0.Final
> Reporter: Alain Picard
> Assignee: Katia Aresti
> Priority: Major
> Fix For: 10.0.0.Beta1, 9.4.7.Final
>
>
> Due to issues related to using the embedded jar (see [here|https://developer.jboss.org/message/986042#986042], when switching to individual jars, the multimap jar (infinispan-multimap-9.4.0.Final.jar) doesn't provide a valid OSGi manifest.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
[ https://issues.jboss.org/browse/ISPN-9916?page=com.atlassian.jira.plugin.... ]
Ryan Emerson updated ISPN-9916:
-------------------------------
Status: Open (was: New)
> JDBC Publish Flowable should explicitly close all ResultSets
> ------------------------------------------------------------
>
> Key: ISPN-9916
> URL: https://issues.jboss.org/browse/ISPN-9916
> Project: Infinispan
> Issue Type: Bug
> Components: Loaders and Stores
> Affects Versions: 10.0.0.Alpha3, 9.4.6.Final
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
> Priority: Major
> Fix For: 10.0.0.Beta1, 9.4.7.Final
>
>
> The Flowable for the JDBC store publisher should explicitly close the created ResultSets by calling `doOnComplete(() -> JdbcUtil.safeClose(rs))` on `function.apply(rs)`
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
[ https://issues.jboss.org/browse/ISPN-9916?page=com.atlassian.jira.plugin.... ]
Ryan Emerson updated ISPN-9916:
-------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/infinispan/infinispan/pull/6639
> JDBC Publish Flowable should explicitly close all ResultSets
> ------------------------------------------------------------
>
> Key: ISPN-9916
> URL: https://issues.jboss.org/browse/ISPN-9916
> Project: Infinispan
> Issue Type: Bug
> Components: Loaders and Stores
> Affects Versions: 10.0.0.Alpha3, 9.4.6.Final
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
> Priority: Major
> Fix For: 10.0.0.Beta1, 9.4.7.Final
>
>
> The Flowable for the JDBC store publisher should explicitly close the created ResultSets by calling `doOnComplete(() -> JdbcUtil.safeClose(rs))` on `function.apply(rs)`
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
[ https://issues.jboss.org/browse/ISPN-9915?page=com.atlassian.jira.plugin.... ]
Ryan Emerson updated ISPN-9915:
-------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/infinispan/infinispan/pull/6639
> JDBC publish Flowable should explicitly rollback connection
> -----------------------------------------------------------
>
> Key: ISPN-9915
> URL: https://issues.jboss.org/browse/ISPN-9915
> Project: Infinispan
> Issue Type: Bug
> Components: Loaders and Stores
> Affects Versions: 10.0.0.Alpha3, 9.4.6.Final
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
> Priority: Major
> Fix For: 10.0.0.Beta1, 9.4.7.Final
>
>
> The Flowable for the JDBC store publisher sets `autoCommit(false)` in order for pagination to work as expected, however we never explicitly call commit or rollback on the connection, therefore the exact behaviour is determined by the underlying connection pool. Instead we should explicitly call rollback() on the connection after the publisher has finished, because the operation is read only.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)