[JBoss JIRA] (ISPN-10745) infinispan-jcache-remote does not support CDI caching annotations
by Dan Berindei (Jira)
[ https://issues.jboss.org/browse/ISPN-10745?page=com.atlassian.jira.plugin... ]
Dan Berindei updated ISPN-10745:
--------------------------------
Status: Open (was: Pull Request Sent)
Git Pull Request: (was: https://github.com/infinispan/infinispan/pull/7466)
> infinispan-jcache-remote does not support CDI caching annotations
> -----------------------------------------------------------------
>
> Key: ISPN-10745
> URL: https://issues.jboss.org/browse/ISPN-10745
> Project: Infinispan
> Issue Type: Bug
> Components: Core
> Affects Versions: 9.4.16.Final, 10.0.0.CR3
> Reporter: Dan Berindei
> Priority: Major
>
> {{infinispan-jcache-remote}} does not have CDI interceptors for the JCache annotations like {{@CacheResult}}, so the annotations are ignored.
> The JCache TCK has tests for the annotations (e.g. {{InterceptionCacheNameOnEachMethodTest}}), but those tests used to pass by accident: a Weld dependency ({{slf4j-api}}) was missing in the {{tck-remote}} maven-failsafe-plugin execution, and {{AbstractInterceptionTest}} was automatically excluding them.
> Weld 2.3.4.Final removed the {{slf4j-api}} dependency and the {{tck-remote}} interception tests started failing after the upgrade, but we did not notice because of ISPN-10379.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months
[JBoss JIRA] (ISPN-10819) GracefulShutdownRestartIT Failure
by Ryan Emerson (Jira)
Ryan Emerson created ISPN-10819:
-----------------------------------
Summary: GracefulShutdownRestartIT Failure
Key: ISPN-10819
URL: https://issues.jboss.org/browse/ISPN-10819
Project: Infinispan
Issue Type: Bug
Components: Server, Test Suite - Server
Reporter: Ryan Emerson
Assignee: Ryan Emerson
Fix For: 10.0.0.Final
The GlobalMarshaller is unable to marshall {{Server.ShutdownRunnable}} as it does not have an externalizer defined. This wasn't an issue when jboss-marshalling was used in the Server as the class was marshalled via Serialization, however now that the default user marshaller is Protostream based this is not possible. The solution is to enable the GlobalMarshaller to be able to marshall the class directly. This can be achieved by defining an Externalizer for the class.
{code:java}_emphasized text_
[0] STDOUT: 19:05:14,244 WARN [org.infinispan.PERSISTENCE] (SINGLE_PORT-ServerIO-7-2) ISPN000559: Cannot marshall 'class org.infinispan.server.Server$ShutdownRunnable': java.lang.IllegalArgumentException: No marshaller registered for Java type org.infinispan.server.Server$ShutdownRunnable
[0] STDOUT: at org.infinispan.protostream.impl.SerializationContextImpl.getMarshallerDelegate(SerializationContextImpl.java:279)
[0] STDOUT: at org.infinispan.protostream.WrappedMessage.writeMessage(WrappedMessage.java:240)
[0] STDOUT: at org.infinispan.protostream.ProtobufUtil.toWrappedStream(ProtobufUtil.java:196)
[0] STDOUT: at org.infinispan.marshall.persistence.impl.PersistenceMarshallerImpl.objectToBuffer(PersistenceMarshallerImpl.java:157)
[0] STDOUT: at org.infinispan.marshall.persistence.impl.PersistenceMarshallerImpl.objectToByteBuffer(PersistenceMarshallerImpl.java:137)
[0] STDOUT: at org.infinispan.marshall.persistence.impl.PersistenceMarshallerImpl.objectToByteBuffer(PersistenceMarshallerImpl.java:145)
[0] STDOUT: at org.infinispan.marshall.core.GlobalMarshaller.writeRawUnknown(GlobalMarshaller.java:638)
[0] STDOUT: at org.infinispan.marshall.core.GlobalMarshaller.writeUnknown(GlobalMarshaller.java:627)
[0] STDOUT: at org.infinispan.marshall.core.GlobalMarshaller.writeUnknown(GlobalMarshaller.java:618)
[0] STDOUT: at org.infinispan.marshall.core.GlobalMarshaller.writeNonNullableObject(GlobalMarshaller.java:384)
[0] STDOUT: at org.infinispan.marshall.core.GlobalMarshaller.writeNullableObject(GlobalMarshaller.java:352)
[0] STDOUT: at org.infinispan.marshall.core.BytesObjectOutput.writeObject(BytesObjectOutput.java:26)
[0] STDOUT: at org.infinispan.manager.impl.ReplicableManagerFunctionCommand.writeTo(ReplicableManagerFunctionCommand.java:54)
[0] STDOUT: at org.infinispan.marshall.exts.ReplicableCommandExternalizer.writeCommandParameters(ReplicableCommandExternalizer.java:70)
[0] STDOUT: at org.infinispan.marshall.exts.ReplicableCommandExternalizer.writeObject(ReplicableCommandExternalizer.java:66)
[0] STDOUT: at org.infinispan.marshall.exts.ReplicableCommandExternalizer.writeObject(ReplicableCommandExternalizer.java:54)
[0] STDOUT: at org.infinispan.marshall.core.GlobalMarshaller.writeInternal(GlobalMarshaller.java:656)
[0] STDOUT: at org.infinispan.marshall.core.GlobalMarshaller.writeNonNullableObject(GlobalMarshaller.java:371)
[0] STDOUT: at org.infinispan.marshall.core.GlobalMarshaller.writeNullableObject(GlobalMarshaller.java:352)
[0] STDOUT: at org.infinispan.marshall.core.GlobalMarshaller.writeObjectOutput(GlobalMarshaller.java:181)
[0] STDOUT: at org.infinispan.marshall.core.GlobalMarshaller.writeObjectOutput(GlobalMarshaller.java:174)
[0] STDOUT: at org.infinispan.marshall.core.GlobalMarshaller.objectToBuffer(GlobalMarshaller.java:302)+underlined text+
{code}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months
[JBoss JIRA] (ISPN-10818) Remote-query 9.4.x backwards compatibility
by Ryan Emerson (Jira)
[ https://issues.jboss.org/browse/ISPN-10818?page=com.atlassian.jira.plugin... ]
Ryan Emerson commented on ISPN-10818:
-------------------------------------
A potential solution is to leverage the HotRod protocol version that is sent with every client request, to determine whether it's necessary for the legacy Ids to be mapped when processing the request and sending a response. If legacy TypeId mapping is required, we can add parameters to the MediaTypes associated with a request which can then be utilised by Transcoders etc that need to unmarshall/marshall request/response bytes.
Lots of discussions about this topic on the original PR https://github.com/infinispan/infinispan/pull/7357.
> Remote-query 9.4.x backwards compatibility
> ------------------------------------------
>
> Key: ISPN-10818
> URL: https://issues.jboss.org/browse/ISPN-10818
> Project: Infinispan
> Issue Type: Bug
> Components: Remote Querying
> Affects Versions: 10.0.0.CR3
> Reporter: Ryan Emerson
> Priority: Major
>
> For performance reasons, ProtoStream changed the TypeId of WrappedMessage to 0, which means that pre 10.x clients using RemoteQuery are no longer compatible. Furthermore, ISPN-10663 updated the TypeId of the remote query messages to conform to the Infinispan TypeId ranges defined in ProtoStreamTypeIds.
> Therefore, for pre 10.x clients, it is neccessary for all remote query requests to have the legacy TypeId mapped to the new TypeId values. https://issues.jboss.org/browse/IPROTO-119 introduced a mechanism for this mapping, however more work is required, as the mapping must occur on a per request/response basis (only if communication is with a legacy client).
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months
[JBoss JIRA] (ISPN-10818) Remote-query 9.4.x backwards compatibility
by Ryan Emerson (Jira)
Ryan Emerson created ISPN-10818:
-----------------------------------
Summary: Remote-query 9.4.x backwards compatibility
Key: ISPN-10818
URL: https://issues.jboss.org/browse/ISPN-10818
Project: Infinispan
Issue Type: Bug
Components: Remote Querying
Affects Versions: 10.0.0.CR3
Reporter: Ryan Emerson
For performance reasons, ProtoStream changed the TypeId of WrappedMessage to 0, which means that pre 10.x clients using RemoteQuery are no longer compatible. Furthermore, ISPN-10663 updated the TypeId of the remote query messages to conform to the Infinispan TypeId ranges defined in ProtoStreamTypeIds.
Therefore, for pre 10.x clients, it is neccessary for all remote query requests to have the legacy TypeId mapped to the new TypeId values. https://issues.jboss.org/browse/IPROTO-119 introduced a mechanism for this mapping, however more work is required, as the mapping must occur on a per request/response basis (only if communication is with a legacy client).
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months
[JBoss JIRA] (ISPN-10778) Change stores to be segmented by default
by Ryan Emerson (Jira)
[ https://issues.jboss.org/browse/ISPN-10778?page=com.atlassian.jira.plugin... ]
Ryan Emerson resolved ISPN-10778.
---------------------------------
Resolution: Done
> Change stores to be segmented by default
> ----------------------------------------
>
> Key: ISPN-10778
> URL: https://issues.jboss.org/browse/ISPN-10778
> Project: Infinispan
> Issue Type: Task
> Components: Core
> Reporter: Will Burns
> Assignee: Will Burns
> Priority: Major
> Fix For: 10.0.0.Final
>
>
> Stores should be segmented whenever possible. We should change the default now that we are on a new major so that stores are segmented by default and a user should explicitly mark it as not segmented.
> The parser should respect the version of the schema though and keep it as non segmented for versions before 10.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months