[JBoss JIRA] (ISPN-8628) Simplify QueryEngine handling of Broadcast vs Fetch queries
by Tristan Tarrant (Jira)
[ https://issues.jboss.org/browse/ISPN-8628?page=com.atlassian.jira.plugin.... ]
Tristan Tarrant updated ISPN-8628:
----------------------------------
Fix Version/s: 9.4.8.Final
(was: 9.4.7.Final)
> Simplify QueryEngine handling of Broadcast vs Fetch queries
> -----------------------------------------------------------
>
> Key: ISPN-8628
> URL: https://issues.jboss.org/browse/ISPN-8628
> Project: Infinispan
> Issue Type: Task
> Reporter: Gustavo Fernandes
> Assignee: Adrian Nistor
> Priority: Minor
> Fix For: 9.4.8.Final
>
>
> [~anistor] commented
> The existence of RemoteQueryDefinition and HsQueryRequest seems to be a symptom of misplaced responsibility. It all starts with QueryDefinition.initialize, which IMO should actually be placed inside QueryEngine, not QueryDefinition. Doing that refactoring will remove the need for RemoteQueryDefinition, which now exists just to differentiate between embedded and remote case, but that differentiation can be done inside the query engine itself. Also, HsQueryRequest is just a data holder that carries the return value of QueryEngine.createHsQuery. If QueryDefinition.initialize is moved to QueryEngine we would also not need this anymore.
> I did not think about it in detail but maybe we would also need to make QueryDefinition mutable for QueryEngine and immutable for external parties. In that case we can extract QueryDefinition as an immutable interface (exposing getters only) and it's implementation class could have package local setters accessible to QueryEngine only.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 1 month
[JBoss JIRA] (ISPN-8643) ClientConnectionPoolingTest.testMaxActiveReached random failures
by Tristan Tarrant (Jira)
[ https://issues.jboss.org/browse/ISPN-8643?page=com.atlassian.jira.plugin.... ]
Tristan Tarrant updated ISPN-8643:
----------------------------------
Fix Version/s: 9.4.8.Final
(was: 9.4.7.Final)
> ClientConnectionPoolingTest.testMaxActiveReached random failures
> ----------------------------------------------------------------
>
> Key: ISPN-8643
> URL: https://issues.jboss.org/browse/ISPN-8643
> Project: Infinispan
> Issue Type: Bug
> Components: Test Suite - Server
> Affects Versions: 9.2.0.Beta2
> Reporter: Dan Berindei
> Priority: Major
> Labels: testsuite_stability
> Fix For: 9.4.8.Final
>
>
> Looks like waiting for 1s for all the connections to be releases is not enough:
> {noformat}
> java.lang.AssertionError:
> at org.infinispan.test.AbstractInfinispanTest.eventually(AbstractInfinispanTest.java:229)
> at org.infinispan.test.AbstractInfinispanTest.eventually(AbstractInfinispanTest.java:211)
> at org.infinispan.test.AbstractInfinispanTest.eventually(AbstractInfinispanTest.java:187)
> at org.infinispan.client.hotrod.ClientConnectionPoolingTest.testMaxActiveReached(ClientConnectionPoolingTest.java:208)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
> http://ci.infinispan.org/job/Infinispan/job/master/336
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 1 month
[JBoss JIRA] (ISPN-8890) TransactionXaAdapter does not implement Geronimo's NamedXaResource
by Tristan Tarrant (Jira)
[ https://issues.jboss.org/browse/ISPN-8890?page=com.atlassian.jira.plugin.... ]
Tristan Tarrant updated ISPN-8890:
----------------------------------
Fix Version/s: 9.4.8.Final
(was: 9.4.7.Final)
> TransactionXaAdapter does not implement Geronimo's NamedXaResource
> ------------------------------------------------------------------
>
> Key: ISPN-8890
> URL: https://issues.jboss.org/browse/ISPN-8890
> Project: Infinispan
> Issue Type: Bug
> Components: Core
> Affects Versions: 9.2.0.CR2
> Reporter: Dan Berindei
> Priority: Major
> Fix For: 9.4.8.Final
>
>
> Geronimo uses its own interface for logging transaction resources, {{NamedXAResource}}. Our {{TransactionXaAdapter}} doesn't implement it, so this error is logged for each transaction in Karaf:
> {noformat}
> 2018-02-28T09:49:05,931 | ERROR | testng-TransactionsSpanningReplicatedCachesTest-9 | Transaction | 68 - org.apache.aries.transaction.manager - 1.3.3 | Please correct the integration and supply a NamedXAResource
> java.lang.IllegalStateException: Cannot log transactions as TransactionXaAdapter{localTransaction=LocalXaTransaction{xid=[Xid:globalId=ffffff96ffffff9561ffffffdb611006f72672e6170616368652e61726965732e7472616e73616374696f6e0000000000000000000000000000,length=64,branchId=1000ffffff84ffffff9561ffffffdb611006170616368652e61726965732e7472616e73616374696f6e0000000000000000000000000000,length=64]} LocalTransaction{remoteLockedNodes=[TransactionsSpanningReplicatedCachesTest-NodeS-28818, TransactionsSpanningReplicatedCachesTest-NodeT-4724], isMarkedForRollback=false, lockedKeys=[], backupKeyLocks=[a], topologyId=5, stateTransferFlag=null} org.infinispan.transaction.xa.LocalXaTransaction@1f} is not a NamedXAResource.
> at org.apache.geronimo.transaction.manager.TransactionImpl$TransactionBranch.getResourceName(TransactionImpl.java:781) ~[?:?]
> at org.apache.geronimo.transaction.log.HOWLLog.prepare(HOWLLog.java:287) ~[?:?]
> at org.apache.geronimo.transaction.manager.TransactionImpl.internalPrepare(TransactionImpl.java:467) ~[?:?]
> at org.apache.geronimo.transaction.manager.TransactionImpl.commit(TransactionImpl.java:312) ~[?:?]
> at org.apache.geronimo.transaction.manager.TransactionManagerImpl.commit(TransactionManagerImpl.java:252) ~[?:?]
> at Proxy325c2276_ef50_4396_9e7d_5deaa002f72c.commit(Unknown Source) ~[?:?]
> at org.infinispan.tx.TransactionsSpanningReplicatedCachesTest.runTest(TransactionsSpanningReplicatedCachesTest.java:260) ~[?:?]
> at org.infinispan.tx.TransactionsSpanningReplicatedCachesTest.testDefaultCacheAndNamedCacheSameNode(TransactionsSpanningReplicatedCachesTest.java:240) ~[?:?]
> at org.infinispan.it.osgi.tx.TransactionsSpanningReplicatedCachesTest.testDefaultCacheAndNamedCacheSameNode(TransactionsSpanningReplicatedCachesTest.java:91) ~[?:?]
> {noformat}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 1 month